Bug#417504: FTBFS with GCC 4.3: missing #includes

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#417504: FTBFS with GCC 4.3: missing #includes

Martin Michlmayr
Package: qsstv
Version: 5.3c-5
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot (20070326-1 or higher)
from unstable.

> Automatic build of qsstv_5.3c-5 on coconut0 by sbuild/ia64 0.49
...
> /usr/share/qt3/include/qpushbutton.h: In member function 'virtual void QPushButton::setIsMenuButton(bool)':
> /usr/share/qt3/include/qpushbutton.h:91: warning: conversion to 'unsigned char:1' from 'int' may alter its value
> repeater.cpp: In member function 'void repeater::restartImageTimer()':
> repeater.cpp:54: error: 'atoi' was not declared in this scope

--- qsstv/repeater.cpp~ 2007-04-02 21:36:17.000000000 +0000
+++ qsstv/repeater.cpp 2007-04-02 21:36:24.000000000 +0000
@@ -5,6 +5,8 @@
 #include "thumbwindow.h"
 #include "configdiag.h"
 
+#include <cstdlib>
+
 bool brepeater;
 bool brepGetPicture;
 

--
Martin Michlmayr
http://www.cyrius.com/


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#417504: marked as done (FTBFS with GCC 4.3: missing #includes)

Debian Bug Tracking System
Your message dated Tue, 03 Apr 2007 09:02:03 +0000
with message-id <[hidden email]>
and subject line Bug#417504: fixed in qsstv 5.3c-7
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)


Package: qsstv
Version: 5.3c-5
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot (20070326-1 or higher)
from unstable.

> Automatic build of qsstv_5.3c-5 on coconut0 by sbuild/ia64 0.49
...
> /usr/share/qt3/include/qpushbutton.h: In member function 'virtual void QPushButton::setIsMenuButton(bool)':
> /usr/share/qt3/include/qpushbutton.h:91: warning: conversion to 'unsigned char:1' from 'int' may alter its value
> repeater.cpp: In member function 'void repeater::restartImageTimer()':
> repeater.cpp:54: error: 'atoi' was not declared in this scope

--- qsstv/repeater.cpp~ 2007-04-02 21:36:17.000000000 +0000
+++ qsstv/repeater.cpp 2007-04-02 21:36:24.000000000 +0000
@@ -5,6 +5,8 @@
 #include "thumbwindow.h"
 #include "configdiag.h"
 
+#include <cstdlib>
+
 bool brepeater;
 bool brepGetPicture;
 

--
Martin Michlmayr
http://www.cyrius.com/


Source: qsstv
Source-Version: 5.3c-7

We believe that the bug you reported is fixed in the latest version of
qsstv, which is due to be installed in the Debian FTP archive:

qsstv_5.3c-7.diff.gz
  to pool/main/q/qsstv/qsstv_5.3c-7.diff.gz
qsstv_5.3c-7.dsc
  to pool/main/q/qsstv/qsstv_5.3c-7.dsc
qsstv_5.3c-7_i386.deb
  to pool/main/q/qsstv/qsstv_5.3c-7_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joop Stakenborg <[hidden email]> (supplier of updated qsstv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 03 Apr 2007 10:38:36 +0200
Source: qsstv
Binary: qsstv
Architecture: source i386
Version: 5.3c-7
Distribution: unstable
Urgency: low
Maintainer: Debian Hamradio Maintainers <[hidden email]>
Changed-By: Joop Stakenborg <[hidden email]>
Description:
 qsstv      - Qt-based slow-scan TV and fax
Closes: 417504
Changes:
 qsstv (5.3c-7) unstable; urgency=low
 .
   * Fix FTBFS with GCC 4.3. Thanks Martin Michlmayr.
     Closes: #417504.
Files:
 7a92d8724b7b10b7e6662f8ead62a7d0 806 hamradio optional qsstv_5.3c-7.dsc
 8afe55f597f6feb1dd48907f5c0f74a0 27125 hamradio optional qsstv_5.3c-7.diff.gz
 79be362f4f43311fc5d2eaed77fa0d7a 637710 hamradio optional qsstv_5.3c-7_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGEhXO/CqtjGLxpX8RAvNrAKCJ25YPqqNRprBLoyse9Qow+ro7vQCgqb3J
/L8VH4PuXf5lVHR2xQWL3HE=
=RP+V
-----END PGP SIGNATURE-----