Bug#506099: iscsitarget: fails to configure without module

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Peter Palfrader
Package: iscsitarget
Version: 0.4.16+svn162-2
Severity: serious

Installing the iscsitarget package fails if a suitable kernel module
is not available at configure time.  This prevents proper installing
when you aren't running the final kernel for instance.

The initscript and maintainerscript shouldn't fail.

test:~# apt-get install iscsitarget
Reading package lists... Done
Building dependency tree      
Reading state information... Done
Suggested packages:
  iscsitarget-source
Recommended packages:
  iscsitarget-module
The following NEW packages will be installed:
  iscsitarget
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0B/60.6kB of archives.
After this operation, 225kB of additional disk space will be used.
Selecting previously deselected package iscsitarget.
(Reading database ... 12108 files and directories currently installed.)
Unpacking iscsitarget (from .../iscsitarget_0.4.16+svn162-2_amd64.deb) ...
Processing triggers for man-db ...
Setting up iscsitarget (0.4.16+svn162-2) ...
Starting iSCSI enterprise target service: FATAL: Module iscsi_trgt not found.
failed - module is missing!
invoke-rc.d: initscript iscsitarget, action "start" failed.
dpkg: error processing iscsitarget (--configure):
 subprocess post-installation script returned error exit status 1
Errors were encountered while processing:
 iscsitarget
E: Sub-process /usr/bin/dpkg returned an error code (1)
test:~#



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Mark Purcell-2
On Tuesday 18 November 2008 22:45:17 Peter Palfrader wrote:
> Installing the iscsitarget package fails if a suitable kernel module
> is not available at configure time.  This prevents proper installing
> when you aren't running the final kernel for instance.

Phillipp, Frederik,

This RC bug against your package is a few weeks old and has not yet had a
comment from you, although Peter Palfrader has proposed a patch.

Are you in a position to investigate this bug/ patch?

Mark



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Frederik Schueler-2
Hi,

IMHO we should just add back the dependency on iscsitarget-module, which is in
lenny thanks to the linux-modules-extra-2.6 package, as the module is
out-of-tree anyway, and must be built from iscsitarget-source for non-debian
packages in order for this package to be of any use at all.

Adding a construct via /etc/default/iscsitarget with ENABLE=no is an option,
but it does only workaround the Debian-specific nuisance of starting every
service by default.

So if no one objects, I will turn the

Recommends: iscsitarget-module

into a Depends: and be done with it.

Best regards
Frederik Schüler

PS: the Recommends is still from before iscsitarget-module was included into
l-m-e-2.6.



On Wednesday 03 December 2008 12:23:03 Mark Purcell wrote:

> On Tuesday 18 November 2008 22:45:17 Peter Palfrader wrote:
> > Installing the iscsitarget package fails if a suitable kernel module
> > is not available at configure time.  This prevents proper installing
> > when you aren't running the final kernel for instance.
>
> Phillipp, Frederik,
>
> This RC bug against your package is a few weeks old and has not yet had a
> comment from you, although Peter Palfrader has proposed a patch.
>
> Are you in a position to investigate this bug/ patch?
>
> Mark
>
>


--
ENOSIG

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Peter Palfrader
On Wed, 03 Dec 2008, Frederik Schüler wrote:

> IMHO we should just add back the dependency on iscsitarget-module

I disagree.  I should not be forced to run a debian kernel, or a kernel
built using debian's kernel stuff.


--
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Frederik Schueler-2
Hi!

On Wednesday 03 December 2008 13:46:40 Peter Palfrader wrote:
> > IMHO we should just add back the dependency on iscsitarget-module
>
> I disagree.  I should not be forced to run a debian kernel, or a kernel
> built using debian's kernel stuff.

iscsitarget is not in vanilla, it is always an external module, thus my
intention.

Best regards
Frederik Schüler

--
ENOSIG

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Peter Palfrader
On Wed, 03 Dec 2008, Frederik Schüler wrote:

> Hi!
>
> On Wednesday 03 December 2008 13:46:40 Peter Palfrader wrote:
> > > IMHO we should just add back the dependency on iscsitarget-module
> >
> > I disagree.  I should not be forced to run a debian kernel, or a kernel
> > built using debian's kernel stuff.
>
> iscsitarget is not in vanilla, it is always an external module, thus my
> intention.

That doesn't mean I have to build the kernel module using debian's
infrastructure however.

--
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Frederik Schueler-2
Hi,

On Wednesday 03 December 2008 15:03:24 Peter Palfrader wrote:
> That doesn't mean I have to build the kernel module using debian's
> infrastructure however.

Indeed, I am preparing a new upload including the patch from this bug.

Best regards
Frederik Schüler

--
ENOSIG

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Mark Purcell-2
On Thursday 04 December 2008 01:09:36 Frederik Schüler wrote:
> Indeed, I am preparing a new upload including the patch from this bug.

Thanks Frederik,

That's great news.

Mark



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Jon Dowland-9
In reply to this post by Peter Palfrader
On Wed, Dec 03, 2008 at 01:46:40PM +0100, Peter Palfrader
wrote:
> On Wed, 03 Dec 2008, Frederik Schüler wrote:
>
> > IMHO we should just add back the dependency on
> > iscsitarget-module
>
> I disagree.  I should not be forced to run a debian
> kernel, or a kernel built using debian's kernel stuff.

With respect, you wouldn't be: you would only be required
to have a debian kernel _installed_.


--
Jon Dowland

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Jon Dowland-9
In reply to this post by Frederik Schueler-2
On Wed, Dec 03, 2008 at 03:09:36PM +0100, Frederik Schüler
wrote:
> On Wednesday 03 December 2008 15:03:24 Peter Palfrader
> wrote:
> > That doesn't mean I have to build the kernel module
> > using debian's infrastructure however.
>
> Indeed, I am preparing a new upload including the patch
> from this bug.

Thank you for applying my patch, but as I stated in the mail
with the patch, there is still some more work to do. With
this patch, a configured and working installation of
iscsitarget will now not be restarted on upgrade (as the
previously non-existent /etc/default/iscsitarget will be
installed with ISCSITARGET_ENABLE=false). This in itself
could be considered RC behaviour.


--
Jon Dowland

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#506099: iscsitarget: fails to configure without module

Peter Palfrader
In reply to this post by Jon Dowland-9
On Thu, 04 Dec 2008, Jon Dowland wrote:

> On Wed, Dec 03, 2008 at 01:46:40PM +0100, Peter Palfrader
> wrote:
> > On Wed, 03 Dec 2008, Frederik Schüler wrote:
> >
> > > IMHO we should just add back the dependency on
> > > iscsitarget-module
> >
> > I disagree.  I should not be forced to run a debian
> > kernel, or a kernel built using debian's kernel stuff.
>
> With respect, you wouldn't be: you would only be required
> to have a debian kernel _installed_.

Which would then force me to install udev, deinstall busybox-static and
other kinds of fun.
--
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]