Bug#680398: unblock: python-qt4/4.9.3-2

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#680398: unblock: python-qt4/4.9.3-2

Scott Kitterman-5
Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock

Please unblock package python-qt4

Fixes RC bug #679819 to allow 4.9.3 (which was uploaded before the freeze, but
stuck in New for some time and has a lot of bug fixes) to migrate.

unblock python-qt4/4.9.3-2



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: http://lists.debian.org/20120705165612.31464.466.reportbug@Scott-Latitude-E6320

Reply | Threaded
Open this post in threaded view
|

Bug#680398: unblock: python-qt4/4.9.3-2

Cyril Brulebois-4
Scott Kitterman <[hidden email]> (05/07/2012):
> Please unblock package python-qt4
>
> Fixes RC bug #679819 to allow 4.9.3 (which was uploaded before the
> freeze, but stuck in New for some time and has a lot of bug fixes) to
> migrate.
>
> unblock python-qt4/4.9.3-2

For the record, there's now -3 due to the RC bug fix for #680837.

I know there are some doc updates, along with updated MetaSIP-generated
comments, but that's still a lot…
  1554 files changed, 10441 insertions(+), 3247 deletions(-)

I guess it would be nice for someone to dive into this to determine how
much really changed (and the amount of code one would need to review if
more regressions are found)…

Mraw,
KiBi.

signature.asc (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#680398: unblock: python-qt4/4.9.3-2

Scott Kitterman-5
On Saturday, July 14, 2012 11:54:30 AM Cyril Brulebois wrote:

> Scott Kitterman <[hidden email]> (05/07/2012):
> > Please unblock package python-qt4
> >
> > Fixes RC bug #679819 to allow 4.9.3 (which was uploaded before the
> > freeze, but stuck in New for some time and has a lot of bug fixes) to
> > migrate.
> >
> > unblock python-qt4/4.9.3-2
>
> For the record, there's now -3 due to the RC bug fix for #680837.
>
> I know there are some doc updates, along with updated MetaSIP-generated
> comments, but that's still a lot…
>   1554 files changed, 10441 insertions(+), 3247 deletions(-)
>
> I guess it would be nice for someone to dive into this to determine how
> much really changed (and the amount of code one would need to review if
> more regressions are found)…
Every file has between two and six lines of change due to both the MetaSIP-
generated comments and the changed copyright year.  After removing those and
the changes in docs/examples the attached diffstat is what's left.  Instead of
1554 files, it's 127 and only 10 of those have more than a 100 LOC change
(total lines changed in the reduced set is 4427).  

A significant fraction of the remaining diff is the addition of IFDEFs
assocaited with support for Qt5 and code for that (which won't affect us since
we aren't building against it).

Is that the sort of thing you were looking for?

Scott K

diffstat.reduced (11K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#680398: marked as done (unblock: python-qt4/4.9.3-2)

Debian Bug Tracking System
In reply to this post by Scott Kitterman-5
Your message dated Sun, 15 Jul 2012 16:36:52 +0200
with message-id <[hidden email]>
and subject line Re: Bug#680398: unblock: python-qt4/4.9.3-2
has caused the Debian Bug report #680398,
regarding unblock: python-qt4/4.9.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
680398: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680398
Debian Bug Tracking System
Contact [hidden email] with problems

Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock

Please unblock package python-qt4

Fixes RC bug #679819 to allow 4.9.3 (which was uploaded before the freeze, but
stuck in New for some time and has a lot of bug fixes) to migrate.

unblock python-qt4/4.9.3-2



Hello Scott,

Scott Kitterman <[hidden email]> (14/07/2012):
> Every file has between two and six lines of change due to both the MetaSIP-
> generated comments and the changed copyright year.

I gathered that part. ;)

> After removing those and the changes in docs/examples the attached diffstat
> is what's left.  Instead of 1554 files, it's 127 and only 10 of those have
> more than a 100 LOC change (total lines changed in the reduced set is 4427).  
>
> A significant fraction of the remaining diff is the addition of IFDEFs
> assocaited with support for Qt5 and code for that (which won't affect us
> since we aren't building against it).
>
> Is that the sort of thing you were looking for?

That definitely helps figuring out what to do with your package, thanks.
I'll go for an unblock after 20 days in unstable. I have first hand
evidence upstream is responsive (weboob ftbfs), but I would still like
the package to spend some more days in unstable, just in case.

age-days 20 python-qt4/4.9.3-3
unblock python-qt4/4.9.3-3

Thanks.

Mraw,
KiBi.

signature.asc (205 bytes) Download Attachment