Bug#719354: ninja-ide: New upstream version 2.3

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#719354: ninja-ide: New upstream version 2.3

Eddy Petrișor
Package: ninja-ide
Version: 2.1.1+ds1-1
Severity: normal

Debian's ninja-ide package is version 2.1.1+ds1-1, but upstream has released
version 2.2 4 months ago, and version 2.3 a month ago.


https://github.com/ninja-ide/ninja-ide/releases


Please package ninja-ide version 2.3 in Debian.



-- System Information:
Debian Release: 7.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.6.0-heidi+ (SMP w/2 CPU cores)
Locale: LANG=ro_RO.utf8, LC_CTYPE=ro_RO.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ninja-ide depends on:
ii  libjs-jquery      1.7.2+dfsg-1
ii  libjs-modernizr   2.6.2+ds1-1
ii  pyflakes          0.5.0-2
ii  python            2.7.3-4
ii  python-pyinotify  0.9.3-1.1
ii  python-qt4        4.9.3-4

ninja-ide recommends no packages.

ninja-ide suggests no packages.

-- no debconf information

--
Regards,
EddyP
=============================================
The universe is not required to be in perfect harmony with human
ambition. - Carl Sagan


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

Eddy Petrișor
Hi,

I packaged for myself the version starting from the official repo; the
distro is still UNRELEASED, and probably some fixes are in order.

The repo is at:
https://github.com/eddyp/ninja-ide

Changes I did:
- added the upstream repo into the packagin repo
- imported the official v2.3.tar.gz while merging v2.3 from upstream
it into the upstream branch, too
- refreshed the patches
- updated debian/install to install addins, too

I haven't tagged my debian/2.3-1 package, but I built it against
wheezy, installed it in my private repo and installed on my machine.
Please use my changes if you find them useful.



--
Regards,
EddyP
=============================================
The universe is not required to be in perfect harmony with human
ambition. - Carl Sagan


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

David Paleino-2
On Mon, 12 Aug 2013 01:09:53 +0300, Eddy Petrișor wrote:

> Hi,

Hey Eddy,

> I packaged for myself the version starting from the official repo; the
> distro is still UNRELEASED, and probably some fixes are in order.
>
> The repo is at:
> https://github.com/eddyp/ninja-ide

Thanks for your work!

> [..]
> Please use my changes if you find them useful.

I'll do, thanks.

However, some more patching was missing. I added the missing bits, and will
upload it to sid ASAP.

Thanks for your report :)
David

--
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

Eddy Petrișor
2013/8/12 David Paleino <[hidden email]>:

> On Mon, 12 Aug 2013 01:09:53 +0300, Eddy Petrișor wrote:
>
>> Hi,
>
> Hey Eddy,
>
>> I packaged for myself the version starting from the official repo; the
>> distro is still UNRELEASED, and probably some fixes are in order.
>>
>> The repo is at:
>> https://github.com/eddyp/ninja-ide
>
> Thanks for your work!

Glad I could be of any use.

>> [..]
>> Please use my changes if you find them useful.
>
> I'll do, thanks.
>
> However, some more patching was missing. I added the missing bits, and will
> upload it to sid ASAP.

I see you uploaded to sid, could you, please, also push the change to
the canonical repo? I would like to backport for myself the official
version.


I also saw that you made some changes in the resources.py, but I not
sure if they aren't redundant. The PRJ_PATH seems to be computed
dinamically and it is /usr/share/ninja-ide by default. I know that in
the build based on my version f8713efd454c0f9f the start page was
displayed properly, which I expect would not happen if PRJ_PATH did
not expand properly.

>
> Thanks for your report :)
> David

My pleasure.

--
Regards,
EddyP
=============================================
The universe is not required to be in perfect harmony with human
ambition. - Carl Sagan


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

David Paleino-2
On Mon, 12 Aug 2013 22:48:43 +0300, Eddy Petrișor wrote:

> 2013/8/12 David Paleino <[hidden email]>:
> [..]
> I see you uploaded to sid, could you, please, also push the change to
> the canonical repo? I would like to backport for myself the official
> version.

Yup, sorry, simply forgot it :)

> I also saw that you made some changes in the resources.py, but I not
> sure if they aren't redundant. The PRJ_PATH seems to be computed
> dinamically and it is /usr/share/ninja-ide by default. I know that in
> the build based on my version f8713efd454c0f9f the start page was
> displayed properly, which I expect would not happen if PRJ_PATH did
> not expand properly.

I guess PRJ_PATH would be /usr/lib/python2.7/dist-packages/ninja_ide/ -- or
kinda. The reason why it works correctly is because setup.py also installs
runtime data files -- syntax highlighting, themes, ... (i.e. addins/)
to /usr/lib/python2.7/dist-packages/ninja_ide/.

Moving them to a more proper /usr/share/ninja-ide needs a patch -- maybe mine
isn't "beautiful" (I should've added a DATA_DIR = ..., and then make other
values depend on that), but it works.

Kindly,
David

--
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

Eddy Petrișor


În data de 13.08.2013 02:40, "David Paleino" <[hidden email]> a scris:
>
> On Mon, 12 Aug 2013 22:48:43 +0300, Eddy Petrișor wrote:
>
> > 2013/8/12 David Paleino <[hidden email]>:
> > [..]
> > I see you uploaded to sid, could you, please, also push the change to
> > the canonical repo? I would like to backport for myself the official
> > version.
>
> Yup, sorry, simply forgot it :)

OK.

> > I also saw that you made some changes in the resources.py, but I not
> > sure if they aren't redundant. The PRJ_PATH seems to be computed
> > dinamically and it is /usr/share/ninja-ide by default. I know that in
> > the build based on my version f8713efd454c0f9f the start page was
> > displayed properly, which I expect would not happen if PRJ_PATH did
> > not expand properly.
>
> I guess PRJ_PATH would be /usr/lib/python2.7/dist-packages/ninja_ide/ -- or
> kinda. The reason why it works correctly is because setup.py also installs
> runtime data files -- syntax highlighting, themes, ... (i.e. addins/)
> to /usr/lib/python2.7/dist-packages/ninja_ide/.
>
> Moving them to a more proper /usr/share/ninja-ide needs a patch -- maybe mine
> isn't "beautiful" (I should've added a DATA_DIR = ..., and then make other
> values depend on that), but it works.

That would be a good idea and I think, if written properly, a variant of the patch could be submitted upstream and the Debian patch would be to only rewrite the DATA_DIR, because the rest would be defined against it.

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

Eddy Petrișor
2013/8/13, Eddy Petrișor <[hidden email]>:
> În data de 13.08.2013 02:40, "David Paleino" <[hidden email]> a scris:
>>
>> On Mon, 12 Aug 2013 22:48:43 +0300, Eddy Petrișor wrote:
>>
>> > 2013/8/12 David Paleino <[hidden email]>:
>> > [..]
>> > I see you uploaded to sid, could you, please, also push the change to
>> > the canonical repo? I would like to backport for myself the official
>> > version.

I backported for myself the version and I hit a serious bug already.


In spite of the obvious seriousness of the issue,I did not report it
officially since I am not running the official version.


Trying to run the ide results in a crash:

0 eddy@heidi ~/usr/src/learnqt/podsoundboard $ ninja-ide podsoundboard.nja
Traceback (most recent call last):
  File "/usr/bin/ninja-ide", line 34, in <module>
    ninja_ide.setup_and_run()
  File "/usr/share/ninja-ide/ninja_ide/__init__.py", line 71, in setup_and_run
    core.run_ninja()
  File "/usr/share/ninja-ide/ninja_ide/core/core.py", line 49, in run_ninja
    ide.start(filenames, projects_path, extra_plugins, linenos)
  File "/usr/share/ninja-ide/ninja_ide/gui/ide.py", line 560, in start
    json_manager.load_syntax()
  File "/usr/share/ninja-ide/ninja_ide/tools/json_manager.py", line
78, in load_syntax
    files = os.listdir(resources.SYNTAX_FILES)
OSError: [Errno 2] No such file or directory:
'/usr/share/ninja-ide/addins/syntax'


The problem is that the addins directory hasn't landed in the proper place:


heidi:/usr/share/ninja-ide/addins# ls
addins
heidi:/usr/share/ninja-ide/addins# ls addins/
lang  qml  syntax  theme

But if the extra addins level is removed, everything works fine:

heidi:/usr/share/ninja-ide/addins# for d in $(ls addins/); do ln -sf
addins/$d ; done
heidi:/usr/share/ninja-ide/addins# ll
total 4
drwxr-xr-x 6 root root 4096 aug 14 00:29 addins
lrwxrwxrwx 1 root root   11 aug 14 00:38 lang -> addins/lang
lrwxrwxrwx 1 root root   10 aug 14 00:38 qml -> addins/qml
lrwxrwxrwx 1 root root   13 aug 14 00:38 syntax -> addins/syntax
lrwxrwxrwx 1 root root   12 aug 14 00:38 theme -> addins/theme


1 eddy@heidi ~/usr/src/learnqt/podsoundboard $ ninja-ide podsoundboard.nja
RefactoringTool: Skipping implicit fixer: buffer
RefactoringTool: Skipping implicit fixer: idioms
RefactoringTool: Skipping implicit fixer: set_literal
RefactoringTool: Skipping implicit fixer: ws_comma
RefactoringTool: Refactored
/home/eddy/usr/src/learnqt/podsoundboard/soundcontainer.py
RefactoringTool: Files that need to be modified:
RefactoringTool: /home/eddy/usr/src/learnqt/podsoundboard/soundcontainer.py


I am also almost sure the dependency on libjs-modernizr is no longer
necessary, since html was replaced with qml. and there are no
references to it in the 2.3 code.



>> I guess PRJ_PATH would be /usr/lib/python2.7/dist-packages/ninja_ide/ --
> or
>> kinda. The reason why it works correctly is because setup.py also
>> installs
>> runtime data files -- syntax highlighting, themes, ... (i.e. addins/)
>> to /usr/lib/python2.7/dist-packages/ninja_ide/.
>>
>> Moving them to a more proper /usr/share/ninja-ide needs a patch -- maybe
> mine
>> isn't "beautiful" (I should've added a DATA_DIR = ..., and then make
>> other
>> values depend on that), but it works.
>
> That would be a good idea and I think, if written properly, a variant of
> the patch could be submitted upstream and the Debian patch would be to only
> rewrite the DATA_DIR, because the rest would be defined against it.

Maybe now it's time for that patch :-)


--
Eddy Petrișor,
http://sceptici.ro


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#719354: Acknowledgement (ninja-ide: New upstream version 2.3)

David Paleino-2
On Wed, 14 Aug 2013 01:03:48 +0300, Eddy Petrișor wrote:

> [..]

Ok, I'm VERY sorry for all the problems caused by the previous upload. :)

I removed the remnants of the old package, made it the cleanest possible, also
moved images under /usr/share/ninja-ide, and fixed d/copyright to include the
forked version of pyflakes.

I also improved the resources.py patch, and it should now work :)

I just uploaded 2.3-2 to sid, any comment is welcome!

Thanks for your help,
David

--
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]