Bug#751493: marked as done (predict: Conflicting declarations of function on_cb_disconnect_clicked to shadow risk of undefined behaviour)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#751493: marked as done (predict: Conflicting declarations of function on_cb_disconnect_clicked to shadow risk of undefined behaviour)

Debian Bug Tracking System
Your message dated Mon, 14 Jan 2019 02:47:23 +0000
with message-id <[hidden email]>
and subject line Bug#919159: Removed package(s) from unstable
has caused the Debian Bug report #751493,
regarding predict: Conflicting declarations of function on_cb_disconnect_clicked to shadow risk of undefined behaviour
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
751493: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751493
Debian Bug Tracking System
Contact [hidden email] with problems

Package: predict
Version: 2.2.3-4
Severity: wishlist
Usertags: goto-cc
Tags: upstream

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
gcc  -g -O2 -Wall   -o gsat main.o support.o interface.o callbacks.o comms.o plugins.o db.o prefs.o -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype   -lm -ldl

error: conflicting function declarations "on_cb_disconnect_clicked"
old definition in module interface file callbacks.h line 28
void (struct _GtkButton *button, void *user_data)
new definition in module comms file comms.c line 51
void (void)
Makefile:365: recipe for target 'gsat' failed
make[3]: *** [gsat] Error 64
make[3]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-predict/predict-2.2.3/clients/gsat-1.1.0/src'
Makefile:376: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1

According to its definition here

http://sources.debian.net/src/predict/2.2.3-4/clients/gsat-1.1.0/src/callbacks.c?hl=144#L143

on_cb_disconnect_clicked requires two arguments. Yet the declaration here

http://sources.debian.net/src/predict/2.2.3-4/clients/gsat-1.1.0/src/comms.c?hl=51#L51

states that the function takes none, and consequently all calls don't pass any.
This would result in buffer underflows, yet it seems the arguments aren't
actually used at present. With the current declaration, however, the compiler
will not be in a position to provide warnings should this change.

Best,
Michael

PS.: I believe this is an upstream issue, but the control file and thus PTS does
not provide any Homepage information.


Version: 2.2.5+dfsg.1-1+rm

Dear submitter,

as the package predict has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/919159

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[hidden email].

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

attachment0 (877 bytes) Download Attachment