Bug#768939: startpar: obsolete conffiles /etc/init/startpar-bridge.conf

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#768939: startpar: obsolete conffiles /etc/init/startpar-bridge.conf

Dmitry Bogatov-3

> /etc/init/startpar-bridge.conf aab4f8aed4d4803ba1f6d97f6b1152da obsolete
>
> Please use the dpkg-maintscript-helper support provided by dh_installdeb
> to remove these obsolete conffiles on upgrade.

Hi! I believe following patch would solve issue. I published it at
https://salsa.debian.org/debian/startpar at branch `bug-768939'.
Opinions?


commit 339bfa8fab86399325bc9f3ba786f76daa360868
Author: Dmitry Bogatov <[hidden email]>
Date:   Mon Nov 26 20:04:26 2018 +0000

    Remove obsolete conffile (Closes: #768939)

diff --git a/debian/changelog b/debian/changelog
index bd0a158..ba05e01 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,7 @@ startpar (0.61-1) UNRELEASED; urgency=medium
 
   * New upstream release
   * Update upstread signing key
+  * Remove obsolete conffile (Closes: #768939)
 
  -- Dmitry Bogatov <[hidden email]>  Sun, 25 Nov 2018 00:00:59 +0000
 
diff --git a/debian/startpar.postinst b/debian/startpar.postinst
new file mode 100644
index 0000000..abf6ca5
--- /dev/null
+++ b/debian/startpar.postinst
@@ -0,0 +1,3 @@
+#!/bin/sh -eu
+#DEBHELPER#
+dpkg-maintscript-helper rm_conffile /etc/init/startpar-bridge.conf 0.61~beta-1~ startpar -- "$@"
diff --git a/debian/startpar.postrm b/debian/startpar.postrm
new file mode 100644
index 0000000..abf6ca5
--- /dev/null
+++ b/debian/startpar.postrm
@@ -0,0 +1,3 @@
+#!/bin/sh -eu
+#DEBHELPER#
+dpkg-maintscript-helper rm_conffile /etc/init/startpar-bridge.conf 0.61~beta-1~ startpar -- "$@"
diff --git a/debian/startpar.preinst b/debian/startpar.preinst
new file mode 100644
index 0000000..abf6ca5
--- /dev/null
+++ b/debian/startpar.preinst
@@ -0,0 +1,3 @@
+#!/bin/sh -eu
+#DEBHELPER#
+dpkg-maintscript-helper rm_conffile /etc/init/startpar-bridge.conf 0.61~beta-1~ startpar -- "$@"

Reply | Threaded
Open this post in threaded view
|

Bug#768939: startpar: obsolete conffiles /etc/init/startpar-bridge.conf

Ivan Shmakov-6
>>>>> Dmitry Bogatov <[hidden email]> writes:

 >> /etc/init/startpar-bridge.conf aab4f8aed4d4803ba1f6d97f6b1152da
 >> obsolete

 >> Please use the dpkg-maintscript-helper support provided by
 >> dh_installdeb to remove these obsolete conffiles on upgrade.

 > I believe following patch would solve issue.  I published it at
 > https://salsa.debian.org/debian/startpar at branch `bug-768939'.
 > Opinions?

[…]

 > +++ b/debian/startpar.postinst
 > @@ -0,0 +1,3 @@
 > +#!/bin/sh -eu
 > +#DEBHELPER#
 > +dpkg-maintscript-helper rm_conffile /etc/init/startpar-bridge.conf 0.61~beta-1~ startpar -- "$@"

[…]

        I’m not going to claim I’m that familiar with Debian packaging
        practices, but wouldn’t .postinst alone be enough?  .postrm
        isn’t going to do anything if .postinst has already removed the
        file, and there seem to be nothing to warrant a .preinst, either.

--
FSF associate member #7257  http://am-1.org/~ivan/

Reply | Threaded
Open this post in threaded view
|

Bug#768939: startpar: obsolete conffiles /etc/init/startpar-bridge.conf

Dmitry Bogatov-3

[2018-11-27 17:33] Ivan Shmakov <[hidden email]>
> I’m not going to claim I’m that familiar with Debian packaging
> practices, but wouldn’t .postinst alone be enough?  .postrm
> isn’t going to do anything if .postinst has already removed the
> file, and there seem to be nothing to warrant a .preinst, either.

Manual page of dpkg-maintscript-helper suggests so:

        Many of those tasks require coordinated actions from several maintainer
        scripts (preinst, postinst, prerm, postrm). To avoid mistakes the  same
        call  simply  needs  to  be  put  in  all  scripts and the program will
        automatically adapt its behaviour based  on  the  environment  variable
        DPKG_MAINTSCRIPT_NAME  and on the maintainer scripts arguments that you
        have to forward after a double hyphen.