Bug#793155: incorrectly follows symlinks (patch provided)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#793155: incorrectly follows symlinks (patch provided)

Yaroslav Halchenko
Package: metapixel
Version: 1.0.2-7.1+b2
Severity: normal
Tags: patch upstream

If original file comes from another directory, symlink would be relative to that directory, not a current one, so mere symlink path would not be sufficient.  With a given patch it would get a full path to the original file

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.17-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages metapixel depends on:
ii  libc6            2.19-18
ii  libgif4          4.1.6-11
ii  libjpeg62-turbo  1:1.4.0-7
ii  libpng12-0       1.2.50-2+b2
ii  zlib1g           1:1.2.8.dfsg-2+b1

metapixel recommends no packages.

metapixel suggests no packages.

-- no debconf information

meta-pixel-prepare-abssymlinkpath.patch (846 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#793155: incorrectly follows symlinks (patch provided)

Chris Vanden Berghe
Thank you for reporting (and the patch). I have fwd'ed the report to the
upstream author.

https://github.com/schani/metapixel/issues/4

---
On Wednesday, July 22, 2015 03:50 AM, Yaroslav Halchenko wrote:

> Package: metapixel
> Version: 1.0.2-7.1+b2
> Severity: normal
> Tags: patch upstream
>
> If original file comes from another directory, symlink would be relative to that directory, not a current one, so mere symlink path would not be sufficient.  With a given patch it would get a full path to the original file
>
> -- System Information:
> Debian Release: stretch/sid
>   APT prefers testing
>   APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 3.17-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
> Versions of packages metapixel depends on:
> ii  libc6            2.19-18
> ii  libgif4          4.1.6-11
> ii  libjpeg62-turbo  1:1.4.0-7
> ii  libpng12-0       1.2.50-2+b2
> ii  zlib1g           1:1.2.8.dfsg-2+b1
>
> metapixel recommends no packages.
>
> metapixel suggests no packages.
>
> -- no debconf information


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Bug#793155: incorrectly follows symlinks (patch provided)

Tobias Frost-3
In reply to this post by Yaroslav Halchenko
Control: tags -1 newcomer

marking as newcomer
(The patch needs to be tested)

Reply | Threaded
Open this post in threaded view
|

Bug#793155: incorrectly follows symlinks (patch provided)

Tobias Frost-3
In reply to this post by Yaroslav Halchenko
Control: tags -1 fixed-upstream

Fixed upstream:
https://github.com/schani/metapixel/commit/72d77c2dade10c9c887bd056d4d9b156029f7f4d#diff-ddcb9fe2bb8ca6f8a04d464450f4223a

(On first glance, the patch is the same as the one on the BTS)