Bug#793863: Add new package f2fs-tools-dev for external development use

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#793863: Add new package f2fs-tools-dev for external development use

殷啟聰 | Kai-Chung Yan
Hi Vincent,

Sorry for the late reply. I have fixed the FTBFS and it's buildable
now. Please check the patch attached or visit
<https://github.com/seamlik/debianpkg-f2fs-tools/compare/master...modify-autotools>.
Here is the changes:

  * FTBFS because I installed the binaries to /usr/sbin(lib) rather
than /sbin(lib). Actually I did it by mistake. :(
  * Merged all library packages into f2fs-libs and f2fs-libs-dev
  * No longer specify version info in soname

Note that using *.install files and dh-exec makes multi-package more
manageable. It seems quite complicated and tedious to use dh_install
in debian/rules for installing multiple packages. dh-exec method is
also documented and recommended by Debian wikis
<https://wiki.debian.org/Multiarch/Implementation>.

Thank you for reviewing the patch, I hope the package can be ready
soon because Android SDK packages needs this.

Regards,
Kai-Chung Yan

f2fs-tools_793863.diff (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#793863: Add new package f2fs-tools-dev for external development use

Vincent Cheng-2
Hi Kai-Chung,

On Thu, Nov 12, 2015 at 6:38 AM, 殷啟聰 <[hidden email]> wrote:

> Hi Vincent,
>
> Sorry for the late reply. I have fixed the FTBFS and it's buildable
> now. Please check the patch attached or visit
> <https://github.com/seamlik/debianpkg-f2fs-tools/compare/master...modify-autotools>.
> Here is the changes:
>
>   * FTBFS because I installed the binaries to /usr/sbin(lib) rather
> than /sbin(lib). Actually I did it by mistake. :(
>   * Merged all library packages into f2fs-libs and f2fs-libs-dev
>   * No longer specify version info in soname
>
> Note that using *.install files and dh-exec makes multi-package more
> manageable. It seems quite complicated and tedious to use dh_install
> in debian/rules for installing multiple packages. dh-exec method is
> also documented and recommended by Debian wikis
> <https://wiki.debian.org/Multiarch/Implementation>.
>
> Thank you for reviewing the patch, I hope the package can be ready
> soon because Android SDK packages needs this.

Sorry for the repeated delays; I'm currently quite busy with school
nowadays, but I'll try to upload an updated f2fs-tools to the archive
sometime this weekend. I took a quick look at your patch and it looks
good, although I'm still not convinced dh-exec actually simplifies
things; aren't the files already placed in the right directories if
you just pass --libdir=/lib/$(DEB_HOST_MULTIARCH)?

Would you be interested in co-maintaining f2fs-tools, by the way
(assuming you already have access to collab-maint, feel free to add
yourself to uploaders)? In addition to your bug, I want to fix #804241
before uploading, and there's also a new upstream release to be
packaged. If you have some spare time on your hands I'd be glad for
any help. :)

Regards,
Vincent