Bug#803744: f2fs-tools: use of f2fs as rootfs is broken

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#803744: f2fs-tools: use of f2fs as rootfs is broken

Sven Geggus-5
Source: f2fs-tools
Severity: normal

Hello,

at least when using System-V Init Debian is currently not able to run from
a f2fs root. The reason is, that fsck.f2fs is unable to check a ro mounted fs.

As this is also the case with xfs there is an easy solution:

1. Rename fsck.f2fs to something else like f2fs_repair or f2fs_check.

2. Copy fsck.xfs script to fsck.f2fs or replace with a slightly modified Version
  (e.g. printing F2FS instead of xfs).

Sven

-- System Information:
Debian Release: 8.1
  APT prefers stable
  APT policy: (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Reply | Threaded
Open this post in threaded view
|

Bug#803744: f2fs-tools: use of f2fs as rootfs is broken

Vincent Cheng-2
Hi Sven,

On Mon, Nov 2, 2015 at 12:38 AM, Sven Geggus
<[hidden email]> wrote:

> Source: f2fs-tools
> Severity: normal
>
> Hello,
>
> at least when using System-V Init Debian is currently not able to run from
> a f2fs root. The reason is, that fsck.f2fs is unable to check a ro mounted fs.
>
> As this is also the case with xfs there is an easy solution:
>
> 1. Rename fsck.f2fs to something else like f2fs_repair or f2fs_check.
>
> 2. Copy fsck.xfs script to fsck.f2fs or replace with a slightly modified Version
>   (e.g. printing F2FS instead of xfs).

I have no problems running Debian with a f2fs root (on a Raspberry Pi,
to be precise).

If this is a question of fsck.f2fs not supporting the same options as
other fsck implementations, IMHO that should be fixed upstream instead
of adding a workaround in Debian with a wrapper script.

Regards,
Vincent

Reply | Threaded
Open this post in threaded view
|

Bug#803744: f2fs-tools: use of f2fs as rootfs is broken

Sven Geggus-5
Vincent Cheng schrieb am Donnerstag, den 19. November um 12:31 Uhr:

> I have no problems running Debian with a f2fs root (on a Raspberry Pi,
> to be precise).

I already had this problem on raspbian wheezy as well and have it now on an
arm based NAS.  However, this might be a sysv-init only problem.  I did not
try to use systemd.

> If this is a question of fsck.f2fs not supporting the same options as
> other fsck implementations, IMHO that should be fixed upstream instead
> of adding a workaround in Debian with a wrapper script.

Its not! Like in xfs it is not possible to check a ro mounted f2fs filesystem.
fsck.f2fs does have the correct options, but is just telling the caller that
checking a mounted filesystem is unsupported with f2fs.

Touching /fastboot will work BTW because it will skip the failing call to
fsck.f2fs.

Sven

--
All bugs added by David S. Miller <[hidden email]>
Linux Kernel boot message from /usr/src/linux/net/8021q/vlan.c

/me is giggls@ircnet, http://sven.gegg.us/ on the Web

Reply | Threaded
Open this post in threaded view
|

Bug#803744: Still not fixed in Raspbian GNU/Linux 9 (stretch)

Alexander Dahl-2
In reply to this post by Sven Geggus-5
Hei hei,

I can confirm that behaviour for Raspbian GNU/Linux 9 (stretch), quote
from syslog:

Jul 20 17:17:04 darcy systemd-fsck[96]: fsck.f2fs: invalid option -- 'y'
Jul 20 17:17:04 darcy systemd-fsck[96]: #011Error: Unknown option ?
Jul 20 17:17:04 darcy systemd-fsck[96]: Usage: fsck.f2fs [options] device
Jul 20 17:17:04 darcy systemd-fsck[96]: [options]:
Jul 20 17:17:04 darcy systemd-fsck[96]:   -a check/fix potential corruption, reported by f2fs
Jul 20 17:17:04 darcy systemd-fsck[96]:   -d debug level [default:0]
Jul 20 17:17:04 darcy systemd-fsck[96]:   -f check/fix entire partition
Jul 20 17:17:04 darcy systemd-fsck[96]:   -p preen mode [default:0 the same as -a [0|1]]
Jul 20 17:17:04 darcy systemd-fsck[96]:   -t show directory tree [-d -1]

If you have any hints on how to solve that, I would happily test it.

Greets
Alex

--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#803744: Info received (Still not fixed in Raspbian GNU/Linux 9 (stretch))

Alexander Dahl-2
In reply to this post by Sven Geggus-5
Hei hei,

meanwhile I found Debian bug report #883026 which addresses the same
underlying problem. I'm not familiar with managing those reports,
maybe someone can set this as duplicate?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883026

Greets
Alex

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#803744: Still not fixed in Raspbian GNU/Linux 9 (stretch)

Theodore Y. Ts'o
In reply to this post by Alexander Dahl-2
On Fri, Jul 20, 2018 at 09:35:53PM +0200, Alexander Dahl wrote:
> Hei hei,
>
> I can confirm that behaviour for Raspbian GNU/Linux 9 (stretch), quote
> from syslog:
>
> Jul 20 17:17:04 darcy systemd-fsck[96]: fsck.f2fs: invalid option -- 'y'
>
> If you have any hints on how to solve that, I would happily test it.
>

f2fs-tools in Debian Stretch is version 1.07 (released July 2016).

This was fixed in f2fs-tools version 1.10, which is in Debian Testing
and Debian Unstable.  f2fs-tools version 1.10 is also available in
Debian Backports, if you want to use it with Debian Stretch.

For information, please see:

        https://backports.debian.org/Instructions/

                                        - Ted