Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

Simon McVittie-7
Source: gsequencer
Version: 0.7.122-1
Severity: serious
Justification: release team consensus

This package build-depends on oss4-dev, which is built by RC-buggy source
package oss4.

I discussed this with some release team members and their opinion is that
oss4 should only be used on non-Linux architectures: on Linux, we should be
using ALSA, either directly or via intermediaries like PulseAudio.
Please restrict the build-dependency to oss4-dev [kfreebsd-any] or possibly
oss4-dev [kfreebsd-any hurd-any], and set the configure options so OSS is
only requested on those architectures, similar to what is done in
vlc (>= 2.2.0~pre3-1).

Regards,
    smcv
    helping the Cambridge BSP

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Reply | Threaded
Open this post in threaded view
|

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

Simon McVittie-7
Control: tags 852985 + patch

On Sat, 28 Jan 2017 at 17:55:43 +0000, Simon McVittie wrote:
> This package build-depends on oss4-dev, which is built by RC-buggy source
> package oss4.

I attach a possible patch.

I don't know how to test gsequencer, so I am not intending to do a
NMU for this bug.

Regards,
    S

0001-Build-depend-on-ALSA-on-Linux-and-on-OSS4-on-non-Lin.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Processed: Re: Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

Debian Bug Tracking System
In reply to this post by Simon McVittie-7
Processing control commands:

> tags 852985 + patch
Bug #852985 [src:gsequencer] gsequencer: please do not build-depend on oss4-dev on Linux
Added tag(s) patch.

--
852985: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852985
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

Joël Krähemann-2
In reply to this post by Simon McVittie-7
Hi

The patch looks fine. There should be no problem as passing this configure flag.
I even used gsequencer on linuxfromscratch.org based system without having OSS4
at all.

Note you can disable it for GNU/Hurd, as well. So JACK is the only output sink.

Bests,
Joël


On Sun, Jan 29, 2017 at 5:18 PM, Simon McVittie <[hidden email]> wrote:

> Control: tags 852985 + patch
>
> On Sat, 28 Jan 2017 at 17:55:43 +0000, Simon McVittie wrote:
>> This package build-depends on oss4-dev, which is built by RC-buggy source
>> package oss4.
>
> I attach a possible patch.
>
> I don't know how to test gsequencer, so I am not intending to do a
> NMU for this bug.
>
> Regards,
>     S

Reply | Threaded
Open this post in threaded view
|

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

Simon McVittie-7
On Tue, 31 Jan 2017 at 02:56:37 +0100, Joël Krähemann wrote:
> The patch looks fine. There should be no problem as passing this
> configure flag.  I even used gsequencer on linuxfromscratch.org based
> system without having OSS4 at all.

I'd be happy to sponsor a maintainer upload with this or a similar change
if you prepare one - I'd prefer to upload something that someone who knows
the software has tested! Or please let me know if you'd like me to prepare
a non-maintainer upload and send it to you for testing.

> Note you can disable it for GNU/Hurd, as well. So JACK is the only
> output sink.

Hurd isn't a release architecture (and never has been, unlike kFreeBSD)
so I don't mind whether it has an OSS4 dependency there - it isn't going
to disrupt the release either way. Do you have any preference for
whether it's [!linux-any] or [kfreebsd-any]?

In NMUs for other packages I've been using [!linux-any] so it's only
a change to previous behaviour on the kernel I know about.

    S

Reply | Threaded
Open this post in threaded view
|

Bug#852985: marked as done (gsequencer: please do not build-depend on oss4-dev on Linux)

Debian Bug Tracking System
In reply to this post by Simon McVittie-7
Your message dated Wed, 01 Feb 2017 10:50:01 +0000
with message-id <[hidden email]>
and subject line Bug#852985: fixed in gsequencer 0.7.122-2
has caused the Debian Bug report #852985,
regarding gsequencer: please do not build-depend on oss4-dev on Linux
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
852985: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852985
Debian Bug Tracking System
Contact [hidden email] with problems

Source: gsequencer
Version: 0.7.122-1
Severity: serious
Justification: release team consensus

This package build-depends on oss4-dev, which is built by RC-buggy source
package oss4.

I discussed this with some release team members and their opinion is that
oss4 should only be used on non-Linux architectures: on Linux, we should be
using ALSA, either directly or via intermediaries like PulseAudio.
Please restrict the build-dependency to oss4-dev [kfreebsd-any] or possibly
oss4-dev [kfreebsd-any hurd-any], and set the configure options so OSS is
only requested on those architectures, similar to what is done in
vlc (>= 2.2.0~pre3-1).

Regards,
    smcv
    helping the Cambridge BSP

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Source: gsequencer
Source-Version: 0.7.122-2

We believe that the bug you reported is fixed in the latest version of
gsequencer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joël Krähemann <[hidden email]> (supplier of updated gsequencer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 01 Feb 2017 11:14:14 +0100
Source: gsequencer
Binary: gsequencer gsequencer-doc libags0 libags-audio0 libags-gui0 libags-dev libags-audio-dev libags-gui-dev libags-doc libags-audio-doc libags-gui-doc
Architecture: source
Version: 0.7.122-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <[hidden email]>
Changed-By: Joël Krähemann <[hidden email]>
Description:
 gsequencer - Advanced Gtk+ Sequencer audio processing engine
 gsequencer-doc - documentation for Advanced Gtk+ Sequencer
 libags-audio-dev - Advanced Gtk+ Sequencer audio processing engine (Development file
 libags-audio-doc - Advanced Gtk+ Sequencer audio processing engine (API documentatio
 libags-audio0 - Advanced Gtk+ Sequencer audio processing library
 libags-dev - Advanced Gtk+ Sequencer core library (Development files)
 libags-doc - Advanced Gtk+ Sequencer core library (API documentation)
 libags-gui-dev - Advanced Gtk+ Sequencer widget library (Development files)
 libags-gui-doc - Advanced Gtk+ Sequencer widget library (API documentation)
 libags-gui0 - Advanced Gtk+ Sequencer widget library
 libags0    - Advanced Gtk+ Sequencer core library
Closes: 852985
Changes:
 gsequencer (0.7.122-2) unstable; urgency=medium
 .
   [ Joël Krähemann ]
   * Disabled ALSA on non-linux, and enabled OSS4 only on kFreeBSD
     (Closes: #852985)
   * Backported patches (from upstream) to fix crasher bugs related to thread
     safety and memory corruption.
Checksums-Sha1:
 392495d4b3614ea062d6383467a12241911f7658 3001 gsequencer_0.7.122-2.dsc
 deb262b2591f020bf509739810f1483905e64be1 26088 gsequencer_0.7.122-2.debian.tar.xz
 784473f514a9e86114b36988a28565a348fa224c 14340 gsequencer_0.7.122-2_amd64.buildinfo
Checksums-Sha256:
 91fb2560337b5c6dabbbad914f1ae7e452da0795982ca4c6adf419582bc9a11a 3001 gsequencer_0.7.122-2.dsc
 14d4594abe05104cc60e0aa228dd87c6b97e3b60fbbf2b55698d5f599dc50668 26088 gsequencer_0.7.122-2.debian.tar.xz
 e89554aad96874232dd6fd3cdbff1d3940747ae93b38eaec58a931e954053327 14340 gsequencer_0.7.122-2_amd64.buildinfo
Files:
 3da31f7d272e7b38619080a0adc45766 3001 sound optional gsequencer_0.7.122-2.dsc
 90dc22641ea2cfeb6eb59f8ce02336aa 26088 sound optional gsequencer_0.7.122-2.debian.tar.xz
 21d07d1c6fffccf71af945443cf6ff10 14340 sound optional gsequencer_0.7.122-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdAXnRVdICXNIABVttlAZxH96NvgFAliRuTsACgkQtlAZxH96
NvimJBAAiBjzZpFur9Lh9/DiyZDVEYm0kg5/AjHdgJ5wT3Sc53F3hTTDfJNXjlEy
KM8EOrK6v4VP7oVv56iS+reC5X+j80YOU9HPRQGzRuYd3phsGhChFn78sWRm9eWe
oC741CACl4xE48U01Xa/mYJHYttfOVJiLtMWPGBA22/A6Mz0s5X0NoJJmySpYIrC
yCJf/zZ9ZDuaPFOsTBTOwA1bEkxaTj1Af7otYuP0zLuKlkwvOMtmlqpuIa9xmqy6
fOwk3z601Xx8tj82mbbMyCcmIEanIS1cqYessI5lfkT8fvkSUGRZVlH9M3zMUHEb
QGZh7IIj+CebI2Mt0ehtDWArGG4zZRWOaEykrKf6nYpJHgC5gybWxPTeF7gmtHn1
sedQuKa33pWaKWIndqUO/iZ0ilNSkT+Ginnb68+/XzxJWMJyBtbYW7/Q36jWqauf
NECowmIIWKH9oQ00GFo9Qi+AFF5bvig87t5Cx2cUwoG27aNbIVIvMe4Jmq7/Grca
6rrV/BwhHfKMwAV5dhBqlCW8rz5Fcw3V5vIpEiSZ9E84gOWdf/K8iHl5s2WZE+69
mH0MMrQRo3Ij92/Kc4vCje7y/IurMMGuo9ELvLSJl78frJlPdSVPSDKLyyei7ywt
sIZvz594FigMm6x9/dyJhdJsZgFY7pcgCP0l7LMGk/jnDSrTkhc=
=bS2s
-----END PGP SIGNATURE-----