Bug#871727: grinder: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#871727: grinder: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

Dominic Hargreaves-2
Source: grinder
Version: 0.5.4-1
Severity: normal
User: [hidden email]
Usertags: debhelper-use-unsafe-inc-removal

This package FTBFS when debhelper is changed to not export
PERL_USE_UNSAFE_INC to the build environment. This export was added in
2016 at the same time that '.' was removed from INC by default, to
avoid breakage, but was a temporary change.

As well as allowing us to (eventually) remove this export from debhelper,
fixing this bug in your package will also help upstream, since this
change has been made in perl 5.26 upstream.

Additionally, it's possible that the problem may also exist at runtime
for your package (though from experience this is less likely).

Note that the rebuild testing was against a locally-modified version
of debhelper, but you can get the same effect by setting debhelper
compat level 11 in your package, which also removes the same
export.

For information about how to fix this class of issues, please refer
to the upstream release notes (in particular, 'Script authors' and
'Module Authors'):

http://perldoc.perl.org/perldelta.html#Removal-of-the-current-directory-(%22.%22)-from-%40INC

The relevant build failure logs are below.

not ok 4 - use t::TestUtils;
#   Failed test 'use t::TestUtils;'
#   at t/00-load.t line 12.
#     Tried to use 't::TestUtils'.
#     Error:  Can't locate t/TestUtils.pm in @INC (you may need to install the t::TestUtils module) (@INC contains: inc blib/lib blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/00-load.t line 12.
# BEGIN failed--compilation aborted at t/00-load.t line 12.
# Testing Grinder 0.5.4, Perl 5.026000, /usr/bin/perl
1..4

Please feel feel free to get in touch with the Debian Perl team at              [hidden email] if you need any more information or                assistance to fix this issue.              

Cheers,
Dominic.

Reply | Threaded
Open this post in threaded view
|

Bug#871727: grinder: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

Andreas Tille-5
Control: tags -1 help

I'm hereby following the kind hint below to get in touch with the Debian
Perl team. :-)

Thanks for any help

      Andreas.

On Thu, Aug 10, 2017 at 06:33:37PM -0400, Dominic Hargreaves wrote:

> Source: grinder
> Version: 0.5.4-1
> Severity: normal
> User: [hidden email]
> Usertags: debhelper-use-unsafe-inc-removal
>
> This package FTBFS when debhelper is changed to not export
> PERL_USE_UNSAFE_INC to the build environment. This export was added in
> 2016 at the same time that '.' was removed from INC by default, to
> avoid breakage, but was a temporary change.
>
> As well as allowing us to (eventually) remove this export from debhelper,
> fixing this bug in your package will also help upstream, since this
> change has been made in perl 5.26 upstream.
>
> Additionally, it's possible that the problem may also exist at runtime
> for your package (though from experience this is less likely).
>
> Note that the rebuild testing was against a locally-modified version
> of debhelper, but you can get the same effect by setting debhelper
> compat level 11 in your package, which also removes the same
> export.
>
> For information about how to fix this class of issues, please refer
> to the upstream release notes (in particular, 'Script authors' and
> 'Module Authors'):
>
> http://perldoc.perl.org/perldelta.html#Removal-of-the-current-directory-(%22.%22)-from-%40INC
>
> The relevant build failure logs are below.
>
> not ok 4 - use t::TestUtils;
> #   Failed test 'use t::TestUtils;'
> #   at t/00-load.t line 12.
> #     Tried to use 't::TestUtils'.
> #     Error:  Can't locate t/TestUtils.pm in @INC (you may need to install the t::TestUtils module) (@INC contains: inc blib/lib blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at t/00-load.t line 12.
> # BEGIN failed--compilation aborted at t/00-load.t line 12.
> # Testing Grinder 0.5.4, Perl 5.026000, /usr/bin/perl
> 1..4
>
> Please feel feel free to get in touch with the Debian Perl team at              [hidden email] if you need any more information or                assistance to fix this issue.              
>
> Cheers,
> Dominic.
>
> _______________________________________________
> Debian-med-packaging mailing list
> [hidden email]
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
>

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#871727: grinder: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

gregor herrmann-3
On Wed, 13 Dec 2017 08:50:26 +0100, Andreas Tille wrote:

> I'm hereby following the kind hint below to get in touch with the Debian
> Perl team. :-)

I just pushed a fix (and some other minor improvements) to the
package's git repo.
 

Cheers,
gregor

--
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Rolling Stones: She's A Rainbow

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#871727: grinder: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

Andreas Tille-5
Hi Gregor,

On Wed, Dec 13, 2017 at 06:13:42PM +0100, gregor herrmann wrote:
>
> I just pushed a fix (and some other minor improvements) to the
> package's git repo.

Cool!  Since we have currently the advent calendar bug fixing party I
wanted to keep the bug statistics right and uploaded on behalf of you.
;-)

Thanks a lot

       Andreas.

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#871727: grinder: FTBFS when debhelper does not export PERL_USE_UNSAFE_INC

gregor herrmann-3
On Wed, 13 Dec 2017 18:54:13 +0100, Andreas Tille wrote:

> > I just pushed a fix (and some other minor improvements) to the
> > package's git repo.
> Cool!  Since we have currently the advent calendar bug fixing party I
> wanted to keep the bug statistics right and uploaded on behalf of you.
> ;-)

Thanks, happy to help opening windows (doors?) in advent calendars :)


Cheers,
gregor

--
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Simply Red: Holding Back The Years

signature.asc (981 bytes) Download Attachment