Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325

Kamal Wickramanayake
Package: linux-image-4.9.0-3-marvell
Version: 4.9.30-2+deb9u5

When the kirkwood-t5325.dtb included in the package is used on HP T5325,
the poweroff command fails to power off the device (indicated by the
front blue light not turning off). It does however brings the device to
near power off ( I have seen a kernel panic at the end that can be seen
if a hardware serial connection is used). Also, with the same dtb, sound
device does not get detected. dmesg output contains the following:

[   10.861482] OF: /sound/simple-audio-card,cpu: arguments longer than
property
[   10.861492] asoc-simple-card sound: parse error -22
[   10.861508] asoc-simple-card: probe of sound failed with error -22

Fix:

Both problems could be corrected by fixing the dtb. "bodhi" at
https://forum.doozan.com possibly with the help of other forum members
had fixed and tested the corrections. Thanks go to him and those who
supported him!

If ever needed, package "bodhi" maintains can be found at
https://forum.doozan.com/read.php?2,12096 and the download contains a
patch file showing his modifications.

I myself tested the changes needed to fix the poweroff problem and the
sound device detection issue by getting the upstream kernel source,
changing two lines and compiling the kirkwood-t5325.dts. Please find the
attached working dtb and dts. The two fixes needed are as follows:

--- linux-master/arch/arm/boot/dts/kirkwood-t5325.dts    2017-10-05
01:16:05.000000000 +0100
+++ linux-master-fixed/arch/arm/boot/dts/kirkwood-t5325.dts   
2017-10-06 13:59:19.834377641 +0100
@@ -174,7 +174,7 @@
         compatible = "gpio-poweroff";
         pinctrl-0 = <&pmx_power_off>;
         pinctrl-names = "default";
-        gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+        gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>;
     };
 
     sound {
@@ -195,7 +195,7 @@
         simple-audio-card,mclk-fs = <256>;
 
         simple-audio-card,cpu {
-            sound-dai = <&audio>;
+            sound-dai = <&audio 0>;
         };
 
         simple-audio-card,codec {

I haven't submitted the changes to upstream. Appreciate if you release
the package with a corrected kirkwood-t5325.dtb.

Kamal

kirkwood-t5325.dtb (15K) Download Attachment
kirkwood-t5325.dts (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#877869: Console output showing the poweroff issue

Kamal Wickramanayake
I managed to get the output via a serial connection to show the issue
related to the poweroff command.

Package: linux-image-4.9.0-4-marvell
Version: 4.9.51-1

With the dtd file included in the package (Kernel panic, device does not
turn off):

root@debian:~# poweroff
[   56.473637] systemd-shutdow: 34 output lines suppressed due to
ratelimiting
[   60.334374] systemd-shutdown[1]: Sending SIGTERM to remaining
processes...
[   60.368378] systemd-journald[208]: Received SIGTERM from PID 1
(systemd-shutdow).
[   60.395961] systemd-shutdown[1]: Sending SIGKILL to remaining
processes...
[   60.429263] systemd-shutdown[1]: Unmounting file systems.
[   60.448756] systemd-shutdown[1]: Remounting '/' read-only with
options 'errors=remount-ro,data=ordered'.
[   61.125270] EXT4-fs (sdb2): re-mounted. Opts:
errors=remount-ro,data=ordered
[   61.153210] systemd-shutdown[1]: Remounting '/' read-only with
options 'errors=remount-ro,data=ordered'.
[   61.191019] EXT4-fs (sdb2): re-mounted. Opts:
errors=remount-ro,data=ordered
[   61.212739] systemd-shutdown[1]: All filesystems unmounted.
[   61.233125] systemd-shutdown[1]: Deactivating swaps.
[   61.252864] systemd-shutdown[1]: All swaps deactivated.
[   61.272698] systemd-shutdown[1]: Detaching loop devices.
[   61.302171] systemd-shutdown[1]: All loop devices detached.
[   61.333450] sd 0:0:0:0: [sda] Stopping disk
[   61.354880] reboot: Power down
[   64.551110] ------------[ cut here ]------------
[   64.570412] WARNING: CPU: 0 PID: 1 at
/build/linux-BErZ7F/linux-4.9.51/drivers/power/reset/gpio-poweroff.c:45
SyS_reboot+0x15c/0x204
[   64.613235] Modules linked in: evdev snd_soc_simple_card
snd_soc_simple_card_utils snd_soc_kirkwood snd_soc_alc5623 sg
mv643xx_eth mvmdio of_mdio fixed_phy libphy snd_soc_core marvell_cesa
snd_pcm snd_timer des_generic snd soundcore orion_wdt m25p80 spi_nor
gpio_keys ip_tables x_tables ipv6 autofs4 ext4 crc16 jbd2 fscrypto ecb
mbcache btrfs crc32c_generic xor zlib_deflate uas raid6_pq usb_storage
loop squashfs overlay fbcon bitblit fbcon_rotate fbcon_ccw fbcon_ud
fbcon_cw softcursor font tileblit sd_mod ehci_orion sata_mv ehci_hcd
libata scsi_mod usbcore usb_common xgifb(C) cfbfillrect cfbimgblt
cfbcopyarea fb
[   64.795429] CPU: 0 PID: 1 Comm: systemd-shutdow Tainted: G        
C      4.9.0-4-marvell #1 Debian 4.9.51-1
[   64.845458] Hardware name: Marvell Kirkwood (Flattened Device Tree)
[   64.871953] [<c00160e0>] (unwind_backtrace) from [<c0013080>]
(show_stack+0x18/0x1c)
[   64.900010] [<c0013080>] (show_stack) from [<c0021858>]
(__warn+0xe8/0x104)
[   64.927431] [<c0021858>] (__warn) from [<c0021930>]
(warn_slowpath_null+0x24/0x2c)
[   64.955755] [<c0021930>] (warn_slowpath_null) from [<c003e004>]
(SyS_reboot+0x15c/0x204)
[   64.984897] [<c003e004>] (SyS_reboot) from [<c000f560>]
(ret_fast_syscall+0x0/0x38)
[   65.013817] ---[ end trace fe55aa9832549b2b ]---
[   65.043038] systemd-shutdow: 3 output lines suppressed due to
ratelimiting
[   65.071331] Kernel panic - not syncing: Attempted to kill init!
exitcode=0x00000000
[   65.071331]
[   65.122779] CPU: 0 PID: 1 Comm: systemd-shutdow Tainted: G       
WC      4.9.0-4-marvell #1 Debian 4.9.51-1
[   65.175519] Hardware name: Marvell Kirkwood (Flattened Device Tree)
[   65.203220] [<c00160e0>] (unwind_backtrace) from [<c0013080>]
(show_stack+0x18/0x1c)
[   65.232564] [<c0013080>] (show_stack) from [<c00d26d0>]
(panic+0xb8/0x254)
[   65.260791] [<c00d26d0>] (panic) from [<c00233d8>] (do_exit+0x46c/0x8a0)
[   65.288556] [<c00233d8>] (do_exit) from [<c003e000>]
(SyS_reboot+0x158/0x204)
[   65.316675] [<c003e000>] (SyS_reboot) from [<c000f560>]
(ret_fast_syscall+0x0/0x38)
[   65.345348] ---[ end Kernel panic - not syncing: Attempted to kill
init! exitcode=0x00000000
[   65.345348]


With the corrected dtd (No kernel panic, device turns off correctly):

root@debian:~# poweroff
[  147.377304] systemd-shutdow: 25 output lines suppressed due to
ratelimiting
[  157.005000] systemd-shutdown[1]: Sending SIGTERM to remaining
processes...
[  157.038899] systemd-journald[203]: Received SIGTERM from PID 1
(systemd-shutdow).
[  157.065973] systemd-shutdown[1]: Sending SIGKILL to remaining
processes...
[  157.099147] systemd-shutdown[1]: Unmounting file systems.
[  157.118323] systemd-shutdown[1]: Remounting '/' read-only with
options 'errors=remount-ro,data=ordered'.
[  157.169701] EXT4-fs (sdb2): re-mounted. Opts:
errors=remount-ro,data=ordered
[  157.197557] systemd-shutdown[1]: Remounting '/' read-only with
options 'errors=remount-ro,data=ordered'.
[  157.235876] EXT4-fs (sdb2): re-mounted. Opts:
errors=remount-ro,data=ordered
[  157.258109] systemd-shutdown[1]: All filesystems unmounted.
[  157.279087] systemd-shutdown[1]: Deactivating swaps.
[  157.299515] systemd-shutdown[1]: All swaps deactivated.
[  157.319976] systemd-shutdown[1]: Detaching loop devices.
[  157.349948] systemd-shutdown[1]: All loop devices detached.
[  157.381582] sd 0:0:0:0: [sda] Stopping disk
[  157.403176] reboot: Power down

Reply | Threaded
Open this post in threaded view
|

Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325

Martin Michlmayr
In reply to this post by Kamal Wickramanayake
* Kamal Wickramanayake <[hidden email]> [2017-10-06 14:13]:
> I haven't submitted the changes to upstream. Appreciate if you release
> the package with a corrected kirkwood-t5325.dtb.

Can you please submit or get "bodhi" (or whoever wrote the patch) to
submit the patches upstream.  This is how it would flow into the
Debian kernel.

MAINTAINERS in the kernel source lists the maintainers for
ARM/Marvell Kirkwood

--
Martin Michlmayr
http://www.cyrius.com/

Reply | Threaded
Open this post in threaded view
|

Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325

Martin Michlmayr
* Martin Michlmayr <[hidden email]> [2018-03-04 19:51]:

> * Kamal Wickramanayake <[hidden email]> [2017-10-06 14:13]:
> > I haven't submitted the changes to upstream. Appreciate if you release
> > the package with a corrected kirkwood-t5325.dtb.
>
> Can you please submit or get "bodhi" (or whoever wrote the patch) to
> submit the patches upstream.  This is how it would flow into the
> Debian kernel.
>
> MAINTAINERS in the kernel source lists the maintainers for
> ARM/Marvell Kirkwood

Kamal, did you submit this upstream?

--
Martin Michlmayr
https://www.cyrius.com/

Reply | Threaded
Open this post in threaded view
|

Bug#877869: kirkwood-t5325.dts fixes for poweroff and sound device detection issues on HP T5325

Martin Michlmayr
* Martin Michlmayr <[hidden email]> [2018-09-10 14:28]:
> > MAINTAINERS in the kernel source lists the maintainers for
> > ARM/Marvell Kirkwood
>
> Kamal, did you submit this upstream?

Kamal?

--
Martin Michlmayr
https://www.cyrius.com/