Bug#880393: nmuing cyrus-sasl2

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#880393: nmuing cyrus-sasl2

Helmut Grohne
Control: tags 792851 + pending
Control: tags 880393 + pending patch

Dear cyrus-sasl2 maintainers,

I have prepared a NMU fixing the following bugs:

 * #792851: FTCBFS

   This one already had a patch since ages.

 * #880393: libsasl2-modules-gssapi-heimdal linked against mit krb5

   Actually, libgssapiv2.so is built against heimdal correctly. It just
   happens that the dh_auto_install overwrites the heimdal version with
   the mit version. Putting the relevant dh_install between the two
   dh_auto_install fixes the issue.

You can find a .debdiff attached. I'll be uploading it to delayed/10
later today.  Please let me know if I should delay it any longer.

Helmut

cyrus-sasl2_2.1.27~101-g0780600+dfsg-3.2.debdiff (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Processed: nmuing cyrus-sasl2

Debian Bug Tracking System
Processing control commands:

> tags 792851 + pending
Bug #792851 [src:cyrus-sasl2] FTCBFS: confuses build arch and host arch compiler
Ignoring request to alter tags of bug #792851 to the same tags previously set
> tags 880393 + pending patch
Bug #880393 [libsasl2-modules-gssapi-heimdal] libsasl2-modules-gssapi-heimdal seems built against MIT
Ignoring request to alter tags of bug #880393 to the same tags previously set

--
792851: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792851
880393: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880393
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#880393: nmuing cyrus-sasl2

Richard Landster
In reply to this post by Helmut Grohne
On Sat, 29 Sep 2018 12:23:05 +0200 Helmut Grohne <[hidden email]> wrote:

> Control: tags 792851 + pending
> Control: tags 880393 + pending patch
>
> Dear cyrus-sasl2 maintainers,
>
> I have prepared a NMU fixing the following bugs:
>
>  * #792851: FTCBFS
>
>    This one already had a patch since ages.
>
>  * #880393: libsasl2-modules-gssapi-heimdal linked against mit krb5
>
>    Actually, libgssapiv2.so is built against heimdal correctly. It just
>    happens that the dh_auto_install overwrites the heimdal version with
>    the mit version. Putting the relevant dh_install between the two
>    dh_auto_install fixes the issue.
>
> You can find a .debdiff attached. I'll be uploading it to delayed/10
> later today.  Please let me know if I should delay it any longer.
>
> Helmut

This problem is causing us serious heartburn. Is there a way to get the
corrected stretch .deb file so we can move ahead with our upgrade to
stretch?

Adam

Reply | Threaded
Open this post in threaded view
|

Bug#880393: nmuing cyrus-sasl2

Ondřej Surý-4
In reply to this post by Helmut Grohne
Hi all,

I spent a half-day hacking cyrus-sasl2 and I uploaded 2.1.27 to experimental. I would appreciate if more people can test the package (I won’t have time until tomorrow or next week). I didn’t even had a chance to test it myself, so even the basic it installs and nothing breaks horribly would help.

Ondrej
--
Ondřej Surý <[hidden email]>

> On 21 Jan 2019, at 03:17, Ryan Tandy <[hidden email]> wrote:
>
> Hello,
>
> I extracted Helmut's changes for this issue from the debdiff he posted in an earlier message, and proposed a merge request on salsa.
>
> https://salsa.debian.org/debian/cyrus-sasl2/merge_requests/3
>
> as a git-format-patch(1) patch:
>
> https://salsa.debian.org/debian/cyrus-sasl2/merge_requests/3.patch
>
> I have built it and verified that the Depends line and library dependencies are corrected, and that it is installable. I have not actually tested the module's functionality.
>
> I agree with Helmut that this looks suitable for a stretch update. I would be willing to drive that process if the maintainers agree but lack time.

Reply | Threaded
Open this post in threaded view
|

Bug#880393: testing cyrus-sasl2 2.1.27+dfsg-1~exp1 (was: Re: nmuing cyrus-sasl2)

Ryan Tandy-4
Hello Ondřej,

On Mon, Jan 21, 2019 at 05:54:39PM +0100, OndÅ?ej Surý wrote:
>I spent a half-day hacking cyrus-sasl2 and I uploaded 2.1.27 to
>experimental. I would appreciate if more people can test the package (I
>won’t have time until tomorrow or next week). I didn’t even had a
>chance to test it myself, so even the basic it installs and nothing
>breaks horribly would help.

Thank you for spending some time working on the package! I have spent
some time looking at it this evening.

I noticed in debian/control that the Build-Depends lines for
libpod-pom-view-restructured-perl and python3-sphinx are indented with
mixed spaces and tabs.

I confirm that these bugs are fixed:
#880393 (MIT modules installed in heimdal pkg)
#919639 (man pages were empty -- please close this one in changelog)

These bugs still exist:
#917140 (changes from old NMUs silently dropped)
#917129 (unnecessary GSSAPI linking breaks slapd-smbk5pwd)

I already opened merge requests on salsa for these last two and am
rebasing them now; would you mind taking a look? #917129 in particular
would be great to have in buster as slapd-smbk5pwd is currently unusable
with heimdal.

I tested the following use cases:

* testsaslauthd with saslauthd using sasldb backend
* testsaslauthd with saslauthd using pam backend
* testsaslauthd with saslauthd using ldap backend
* testsaslauthd with saslauthd using kerberos5 backend
* EXTERNAL authentication to slapd
* GSSAPI authentication to slapd (heimdal module)
* GSSAPI authentication to slapd (MIT module)
* DIGEST-MD5 authentication to slapd (password stored in slapd)
* PLAIN authentication to slapd (password stored in slapd)
* PLAIN authentication to slapd with pass-through to saslauthd
* LOGIN authentication to slapd with pass-through to saslauthd

and all of those are working fine. I have not looked at the sql or otp
modules.

I also checked some man pages and the html docs (-doc package) briefly
and everything looked ok.

Thank you for working on cyrus-sasl2, and please consider adding the
patch for #917129 if you can. :)

cheers,
Ryan

Reply | Threaded
Open this post in threaded view
|

Bug#880393: testing cyrus-sasl2 2.1.27+dfsg-1~exp1 (was: Re: nmuing cyrus-sasl2)

Ondřej Surý-4
Ryan,

thank you for testing the package.  I merged your two MRs and I am building the package
for unstable right now, and I will be uploading it there shortly.

Thank you for your work on the package, I do appreciate the work you spent on this.

Ondrej
--
Ondřej Surý
[hidden email]



> On 22 Jan 2019, at 08:38, Ryan Tandy <[hidden email]> wrote:
>
> Hello Ondřej,
>
> On Mon, Jan 21, 2019 at 05:54:39PM +0100, OndÅ?ej Surý wrote:
>> I spent a half-day hacking cyrus-sasl2 and I uploaded 2.1.27 to experimental. I would appreciate if more people can test the package (I won’t have time until tomorrow or next week). I didn’t even had a chance to test it myself, so even the basic it installs and nothing breaks horribly would help.
>
> Thank you for spending some time working on the package! I have spent some time looking at it this evening.
>
> I noticed in debian/control that the Build-Depends lines for libpod-pom-view-restructured-perl and python3-sphinx are indented with mixed spaces and tabs.
>
> I confirm that these bugs are fixed:
> #880393 (MIT modules installed in heimdal pkg)
> #919639 (man pages were empty -- please close this one in changelog)
>
> These bugs still exist:
> #917140 (changes from old NMUs silently dropped)
> #917129 (unnecessary GSSAPI linking breaks slapd-smbk5pwd)
>
> I already opened merge requests on salsa for these last two and am rebasing them now; would you mind taking a look? #917129 in particular would be great to have in buster as slapd-smbk5pwd is currently unusable with heimdal.
>
> I tested the following use cases:
>
> * testsaslauthd with saslauthd using sasldb backend
> * testsaslauthd with saslauthd using pam backend
> * testsaslauthd with saslauthd using ldap backend
> * testsaslauthd with saslauthd using kerberos5 backend
> * EXTERNAL authentication to slapd
> * GSSAPI authentication to slapd (heimdal module)
> * GSSAPI authentication to slapd (MIT module)
> * DIGEST-MD5 authentication to slapd (password stored in slapd)
> * PLAIN authentication to slapd (password stored in slapd)
> * PLAIN authentication to slapd with pass-through to saslauthd
> * LOGIN authentication to slapd with pass-through to saslauthd
>
> and all of those are working fine. I have not looked at the sql or otp modules.
>
> I also checked some man pages and the html docs (-doc package) briefly and everything looked ok.
>
> Thank you for working on cyrus-sasl2, and please consider adding the patch for #917129 if you can. :)
>
> cheers,
> Ryan
>