Bug#884921: wrong version, misses debian revision

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#884921: wrong version, misses debian revision

Rene Engelhard
Package: hunspell-en-us,hunspell-en-ca,hunspell-en-au
Version: 1:2017.08.24
Severity: important
Tags: patch

Hi Don,

hunspell-en-us | 1:2017.08.24      | testing            | all
hunspell-en-us | 1:2017.08.24      | unstable           | all

looks very wrong compares to

wamerican  | 2017.08.24-1  | testing            | all
wamerican  | 2017.08.24-1  | unstable           | all

out of the same source.

Yes, I know it was my patch (mea culpa), but the gencontrol call is simply
wrong and will break if any time one needed a update to the 2017.08.24
version...

No idea why I used DEB_VERSION_UPSTREAM (maybe I thought we need
to special-case more things), but of course DEB_VERSION would be right:

diff -Nru scowl-2017.08.24/debian/rules scowl-2017.08.24/debian/rules
--- scowl-2017.08.24/debian/rules       2017-10-20 21:09:03.000000000 +0200
+++ scowl-2017.08.24/debian/rules       2017-12-21 11:58:19.000000000 +0100
@@ -135,7 +135,7 @@

 override_dh_gencontrol:
        dh_gencontrol -Nhunspell-en-us -Nhunspell-en-au -Nhunspell-en-ca
-       dh_gencontrol -phunspell-en-us -phunspell-en-au -phunspell-en-ca -- -v1:$(DEB_VERSION_UPSTREAM)
+       dh_gencontrol -phunspell-en-us -phunspell-en-au -phunspell-en-ca -- -v1:$(DEB_VERSION)


 WORDLIST=$(shell echo $(*)|sed -re 's/^w([a-z]*)(-*[a-z]*)/\1-english\2/')

Regards,

Rene

Reply | Threaded
Open this post in threaded view
|

Bug#884921: wrong version, misses debian revision

Don Armstrong-2
Control: reassign -1 src:scowl
Control: severity -1 normal

On Thu, 21 Dec 2017, Rene Engelhard wrote:

> hunspell-en-us | 1:2017.08.24      | testing            | all
> hunspell-en-us | 1:2017.08.24      | unstable           | all
>
> looks very wrong compares to
>
> wamerican  | 2017.08.24-1  | testing            | all
> wamerican  | 2017.08.24-1  | unstable           | all
>
> out of the same source.
>
> Yes, I know it was my patch (mea culpa), but the gencontrol call is
> simply wrong and will break if any time one needed a update to the
> 2017.08.24 version...
>
> No idea why I used DEB_VERSION_UPSTREAM (maybe I thought we need
> to special-case more things), but of course DEB_VERSION would be right:

Yeah, makes sense. I've dropped this patch in now. It's not really a big
deal because 2017.08.24 << 2017.08.24-1, but we'll need it before the
next scowl update.


--
Don Armstrong                      https://www.donarmstrong.com

Have you ever noticed: the most vocal superpatriots are the old men
who send young men out to die.
 -- Harlan Ellison "Basilisk" (_Deathbird Stories_ p73)