Bug#888743: marked as done (pidofproc returns PIDs in foreign chroots and containers)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#888743: marked as done (pidofproc returns PIDs in foreign chroots and containers)

Debian Bug Tracking System
Your message dated Sun, 24 Mar 2019 14:53:27 +0000
with message-id <[hidden email]>
and subject line Bug#888743: fixed in lsb 10.2019032400
has caused the Debian Bug report #888743,
regarding pidofproc returns PIDs in foreign chroots and containers
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
888743: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888743
Debian Bug Tracking System
Contact [hidden email] with problems

Package: lsb-base
Version: 9.20161125

Apparently pidofproc returns the PIDs of programs running
in a chroot or in a container, if there is no local PID file.
This is a *huge* problem for me, because either the init
scripts on the host fail to restart services, or they affect
services running in a container/chroot.

Sample session:

root@mydb01a:~# . /lib/lsb/init-functions
root@mydb01a:~# pidofproc /usr/sbin/smtpd
26623
root@mydb01a:~# ps -ef | grep smtp[d]
root      1689  1541  0 Jan17 ?        00:00:00 /usr/sbin/smtpd
uml-net   1690  1689  0 Jan17 ?        00:00:00 smtpd: klondike
uml-net   1691  1689  0 Jan17 ?        00:00:00 smtpd: control
uml-net   1692  1689  0 Jan17 ?        00:00:00 smtpd: lookup
uml-net   1693  1689  0 Jan17 ?        00:00:00 smtpd: pony express
lxc-dns+  1694  1689  0 Jan17 ?        00:00:00 smtpd: queue
uml-net   1695  1689  0 Jan17 ?        00:00:00 smtpd: scheduler
root      4193  4032  0 Jan10 ?        00:00:00 /usr/sbin/smtpd
lxc-dns+  4194  4193  0 Jan10 ?        00:00:00 smtpd: klondike
lxc-dns+  4195  4193  0 Jan10 ?        00:00:00 smtpd: control
lxc-dns+  4196  4193  0 Jan10 ?        00:00:00 smtpd: lookup
lxc-dns+  4197  4193  0 Jan10 ?        00:00:00 smtpd: pony express
zabbix    4198  4193  0 Jan10 ?        00:00:00 smtpd: queue
lxc-dns+  4199  4193  0 Jan10 ?        00:00:00 smtpd: scheduler
root     26623     1  0 14:06 ?        00:00:00 /usr/sbin/smtpd
opensmt+ 26625 26623  0 14:06 ?        00:00:00 smtpd: klondike
opensmt+ 26626 26623  0 14:06 ?        00:00:00 smtpd: control
opensmt+ 26627 26623  0 14:06 ?        00:00:00 smtpd: lookup
opensmt+ 26628 26623  0 14:06 ?        00:00:00 smtpd: pony express
opensmt+ 26629 26623  0 14:06 ?        00:00:00 smtpd: queue
opensmt+ 26630 26623  0 14:06 ?        00:00:00 smtpd: scheduler


Please note the smtpds running in 2 LXC containers. If I kill
the local smtpd, then pidofproc finds the foreign smtpds:

root@mydb01a:~# kill 26623
root@mydb01a:~# pidofproc /usr/sbin/smtpd
4199 4198 4197 4196 4195 4194 4193 1695 1694 1693 1692 1691 1690 1689
root@mydb01a:~# echo $?
0


If pidofproc would use "pidof -c" internally, then it should work as
expected:

root@mydb01a:~# /bin/pidof -o %PPID -x /usr/sbin/smtpd
4199 4198 4197 4196 4195 4194 4193 1695 1694 1693 1692 1691 1690 1689
root@mydb01a:~# /bin/pidof -c -o %PPID -x /usr/sbin/smtpd
root@mydb01a:~# echo $?
1


lsb-base version 9.20170808 has the same problem. I would highly
appreciate a fix for stretch and sid.


Regards
Harri

Source: lsb
Source-Version: 10.2019032400

We believe that the bug you reported is fixed in the latest version of
lsb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <[hidden email]> (supplier of updated lsb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 24 Mar 2019 14:28:26 +0100
Source: lsb
Architecture: source
Version: 10.2019032400
Distribution: experimental
Urgency: medium
Maintainer: Debian LSB Team <[hidden email]>
Changed-By: Didier Raboud <[hidden email]>
Closes: 888743
Changes:
 lsb (10.2019032400) experimental; urgency=medium
 .
   [ Harald Dunkel ]
   * pidofproc: use "pidof -c" to avoid pidofproc results from containers or chroots
     (Closes: #888743)
Checksums-Sha1:
 1909e03c94cfe9355486f53b70c40ceb91517df0 1695 lsb_10.2019032400.dsc
 2d75f80411cb37d726231323781df5b09af977fd 42212 lsb_10.2019032400.tar.xz
Checksums-Sha256:
 6c85585c422cbbfd801f17700452cc2418f40f44f633ae97cee074d4e2d5f3ac 1695 lsb_10.2019032400.dsc
 53c71f79c72eb82224c19658626ed20872d4c2d44de5cda2dbea57a070a89275 42212 lsb_10.2019032400.tar.xz
Files:
 6235df5b4edf8860d100a44fbd31d904 1695 misc extra lsb_10.2019032400.dsc
 2399a19d75e522583f73e51283aff338 42212 misc extra lsb_10.2019032400.tar.xz

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEe+WPIRpjNw1/GSB7i8+nHsoWNFUFAlyXh50ACgkQi8+nHsoW
NFVjoQv/XIwZsnAWjcsy/TJaaOjMq7TM7o8MSPk663xVIfuNhcRf2Dumr0XVvXLt
uOMxlcGS6EaWJL8M7EgqvBciKab4ElpWzy0d4cF/KipeKWUn1R6a8o30Dznhi+tT
PRl+O4UiUuZs+oKVzPyQfGQvALGzvHlGsKVIclHo0pYPaxJSPRmqFaIMmxxRRcQ7
PtikA+mtX/qrWp8UG5UO8MbVHQe8Q9iaHGe6YKulgyms7MsuTvCZXmxoy8DT1lcv
Oxm8o5Jr79gETaJPmiBMHC4A32eZMt8rKjqYmzusCJiKZXo4jvd6QM3lVAomfUHt
VcgwSWrOwwA+y9eEWYCgULK+dWj6ko1nCgjN9RsV/VVIaEP46WHs38df2PD0mFcm
CX8dHtrI7gdAJ0Q5zWkovgOLatvQTN2IlE5CxdArZCBsUnkA4AkLn4vFVFyKg3/T
TZWERmj/Vd8722DAIdKgVY+At4X6Ms2wn+eqC9IDN3plKUIAhykYCWCUBsZ/Amlz
Zo/XsZun
=o+sa
-----END PGP SIGNATURE-----