Bug#889509: Fix CMake module installation, prepare for DNF support

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#889509: Fix CMake module installation, prepare for DNF support

Mihai Moldovan
Package: libsolv
Version: 0.6.30-1

This patch:
  - fixes how libsolv installs its FindLibSolv.cmake files, which has been
    broken before - no, this is not a version file!
  - fixes various meta errors (dependencies, typo in patch file name that is
    supposed to fix typos, symbols file cleanup, ...)
  - enables some optional features previously disabled and
  - patches libsolv's RPMDB handling to be compatible with the patched rpm
    package version that uses ~/.rpmdb instead of the system-level /var/lib/rpm
    dbpath.

I will probably have to push the latter patch upstream as well.

This patch also opens the way for DNF on Debian.



Mihai

libsolv.debdiff.patch (45K) Download Attachment
signature.asc (915 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#889509: Fix CMake module installation, prepare for DNF support

Mike Gabriel-4
Hi Mihai,

oh well...

On  So 04 Feb 2018 00:14:32 CET, Mihai Moldovan wrote:

> Package: libsolv
> Version: 0.6.30-1
>
> This patch:
>   - fixes how libsolv installs its FindLibSolv.cmake files, which has been
>     broken before - no, this is not a version file!
>   - fixes various meta errors (dependencies, typo in patch file name that is
>     supposed to fix typos, symbols file cleanup, ...)
>   - enables some optional features previously disabled and
>   - patches libsolv's RPMDB handling to be compatible with the patched rpm
>     package version that uses ~/.rpmdb instead of the system-level  
> /var/lib/rpm
>     dbpath.
>
> I will probably have to push the latter patch upstream as well.
>
> This patch also opens the way for DNF on Debian.
I just uploaded 0.6.34-1 and only after that looked into open bugs on  
Debian BTS. And then I remembered.

With the greatest embarrased... may I ask you to rebase your .debdiff?  
Have your changes been upstream meanwhile?

Thanks+Greets,
Mike


--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: [hidden email], http://das-netzwerkteam.de


attachment0 (868 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#889509: rebase

Jo Shields-2
In reply to this post by Mihai Moldovan
I gave rebasing Mihai's patch a shot. Seems to build, no word on
functionality yet.


0001-Rebase-changes-for-DNF-support-Closes-889509.patch (28K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#889509: Fix CMake module installation, prepare for DNF support

Mihai Moldovan
> With the greatest embarrased... may I ask you to rebase your .debdiff?

Rebased everything and bumped up to 0.6.36, which also fixes the 3 CVE's
attached to this package. Will upload a new debdiff soon, need to build these
packages for sid and test them for a bit, including the updated dnf stuff.
Shouldn't take too long.


> Have your changes been upstream meanwhile?

I've reworked my own patchset, since the previous solution was weird. It should
be a lot cleaner now and not touching the whole pool content, but only RPM stuff.

I also decided not to even try to upstream it, because upstream would almost
certainly reject it anyway. It's a workaround for Debian breaking librpm/rpm, so
Debian is responsible for keeping the patch.

With a bit of luck, we will very soon be able to drop those patches completely
though, as I'm trying to get Debian to not apply the patch that breaks rpm in
the first place... see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794495

(Un-?)fortunately the rpm package is up for grabs since the current maintainer
is not interested in maintaining/using it any longer.

I'm very much interesting in having a working and if possible up-to-date rpm
package within Debian as user, but I'm not a DD and I *know* that I won't have
the time for proper maintenance.



Mihai


signature.asc (916 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#889509: Fix CMake module installation, prepare for DNF support

Mihai Moldovan
* On 9/6/19 4:43 AM, Mihai Moldovan wrote:
> Rebased everything and bumped up to 0.6.36, which also fixes the 3 CVE's
> attached to this package. Will upload a new debdiff soon, need to build these
> packages for sid and test them for a bit, including the updated dnf stuff.
> Shouldn't take too long.

Longer than actually expected, but finally here it is.


Note that I've marked the bump NMU, mainly to make lintian happy or such. In any
case, when applying the debdiff, please change the version number to 0.6.36-1
and remove the NMU changelog entry. Be sure to close the CVE bug entry, though.

Built and tested on Debian unstable amd64.



Mihai

libsolv_0.6.36-0.1.debdiff (112K) Download Attachment
signature.asc (916 bytes) Download Attachment