Bug#890660: too many false positives for debian-rules-is-dh_make-template

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#890660: too many false positives for debian-rules-is-dh_make-template

Evgeni Golov-2
Package: lintian
Version: 2.5.75
Severity: normal

Ohai,

I think the check for debian-rules-is-dh_make-template instroduced in
d0fec9183b5977fa8f5e0a779631bb140ee3415d is too broad.
Just because d/rules has '# See debhelper(7) (uncomment to enable)' as
the second line, does not mean the author did not modify it.

Actually, looking at the current dh_make template [1], I see no reason
why this should not be used verbatim in most packages that require no
special handling.

lintian.d.o currently lists 328 packages where this tag is applied [2],
at least for tlp [3] and acpi-call [4] (which I sponsor), I know that
d/rules is modified. Same applies to my own tuned [5] and tp-smapi [6].

Thanks for taking care of lintian and Debian
Evgeni

[1] https://anonscm.debian.org/cgit/collab-maint/dh-make.git/tree/lib/debian/rules
[2] https://lintian.debian.org/tags/debian-rules-is-dh_make-template.html
[3] https://anonscm.debian.org/cgit/collab-maint/tlp.git/tree/debian/rules
[4] https://github.com/MoonSweep/acpi-call/blob/master/debian/rules
[5] https://anonscm.debian.org/cgit/collab-maint/tuned.git/tree/debian/rules
[6] https://anonscm.debian.org/git/users/evgeni/tp-smapi.git/tree/debian/rules

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: SELinux: enabled - Mode: Permissive - Policy name: default

Versions of packages lintian depends on:
ii  binutils                          2.30-5
ii  bzip2                             1.0.6-8.1
ii  diffstat                          1.61-1+b1
ii  dpkg                              1.19.0.5
ii  file                              1:5.32-2
ii  gettext                           0.19.8.1-4
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.33
ii  libarchive-zip-perl               1.60-1
ii  libclass-accessor-perl            0.51-1
ii  libclone-perl                     0.39-1
ii  libdpkg-perl                      1.19.0.5
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libipc-run-perl                   0.96-1
ii  liblist-moreutils-perl            0.416-1+b3
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.1-4+b1
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  liburi-perl                       1.73-1
ii  libxml-simple-perl                2.24-1
ii  libyaml-libyaml-perl              0.69+repack-1
ii  man-db                            2.8.1-1
ii  patchutils                        0.3.4-2
ii  perl                              5.26.1-4+b1
ii  t1utils                           1.41-2
ii  xz-utils                          5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
ii  binutils-multiarch     2.30-5
ii  dpkg-dev               1.19.0.5
ii  libhtml-parser-perl    3.72-3+b2
ii  libtext-template-perl  1.47-1

-- no debconf information

Reply | Threaded
Open this post in threaded view
|

Bug#890660: too many false positives for debian-rules-is-dh_make-template

Chris Lamb -2
tags 890660 + pending
thanks

Thanks Evgeni! Fixed in Git, pending upload:

  https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=81060242e253c42321209e8ff4b12d0c2091786e


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] / chris-lamb.co.uk
       `-