Bug#908294: marked as done (hamlib: FTBFS (Syntax error: "then" unexpected))

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#908294: marked as done (hamlib: FTBFS (Syntax error: "then" unexpected))

Debian Bug Tracking System
Your message dated Fri, 21 Sep 2018 10:19:42 +0000
with message-id <[hidden email]>
and subject line Bug#908294: fixed in hamlib 3.2-3
has caused the Debian Bug report #908294,
regarding hamlib: FTBFS (Syntax error: "then" unexpected)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
908294: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908294
Debian Bug Tracking System
Contact [hidden email] with problems

Package: src:hamlib
Version: 3.2-2
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster using dpkg-buildpackage -A
but it failed:

--------------------------------------------------------------------------------
[...]

   debian/rules override_dh_auto_install-indep
make[1]: Entering directory '/<<PKGBUILDDIR>>'
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
py3versions: no X-Python3-Version in control file, using supported versions
mkdir -p /<<PKGBUILDDIR>>/debian/tmp/usr/share/doc/hamlib
cp -r /<<PKGBUILDDIR>>/build-indep/doc/html \
        /<<PKGBUILDDIR>>/debian/tmp/usr/share/doc/hamlib/
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
py3versions: no X-Python3-Version in control file, using supported versions
dh_install
lts=/<<PKGBUILDDIR>>/debian/lua-hamlib2/usr/share/doc/lua-hamlib2/luatest.lua \
    if [ -f "$lts" ]; then \
            rm -f $lts; \
    fi
/bin/sh: 2: Syntax error: "then" unexpected
make[1]: *** [debian/rules:105: override_dh_install] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:18: binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

Looking at the code:

override_dh_install:
        dh_install
        lts=$(CURDIR)/debian/lua-hamlib2/usr/share/doc/lua-hamlib2/luatest.lua \
            if [ -f "$$lts" ]; then \
                    rm -f $$lts; \
            fi

it seems there is a missing ";" at the end of lts= line.

However, if you want to remove a file unconditionally no matter what, I wonder
why don't you do this instead:

--- a/debian/rules
+++ b/debian/rules
@@ -102,10 +102,7 @@ override_dh_auto_install-indep:
 
 override_dh_install:
  dh_install
- lts=$(CURDIR)/debian/lua-hamlib2/usr/share/doc/lua-hamlib2/luatest.lua \
-    if [ -f "$$lts" ]; then \
-    rm -f $$lts; \
-    fi
+ rm -f debian/lua-hamlib2/usr/share/doc/lua-hamlib2/luatest.lua
 
 override_dh_auto_clean:
  dh_auto_clean


Or maybe it would be even better to use "dh_install -Xexcluded_file" in a single line.

Thanks.

Source: hamlib
Source-Version: 3.2-3

We believe that the bug you reported is fixed in the latest version of
hamlib, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Enrico Rossi <[hidden email]> (supplier of updated hamlib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 08 Sep 2018 14:35:53 +0200
Source: hamlib
Binary: libhamlib2 libhamlib2++c2 libhamlib-dev libhamlib++-dev libhamlib2-perl libhamlib2-tcl python-libhamlib2 python3-libhamlib2 libhamlib-utils libhamlib-doc lua-hamlib2
Architecture: source
Version: 3.2-3
Distribution: unstable
Urgency: low
Maintainer: Debian Hamradio Maintainers <[hidden email]>
Changed-By: Enrico Rossi <[hidden email]>
Description:
 libhamlib++-dev - Development C++ library to control radio transceivers and receive
 libhamlib-dev - Development library to control radio transceivers and receivers
 libhamlib-doc - Documentation for the hamlib radio control library
 libhamlib-utils - Utilities to support the hamlib radio control library
 libhamlib2 - Run-time library to control radio transceivers and receivers
 libhamlib2++c2 - Run-time C++ library to control radio transceivers and receivers
 libhamlib2-perl - Run-time perl library to control radio transceivers and receivers
 libhamlib2-tcl - Run-time Tcl library to control radio transceivers and receivers
 lua-hamlib2 - Run-time Lua library to control radio transceivers and receivers
 python-libhamlib2 - Run-time Python library to control radio transceivers and receive
 python3-libhamlib2 - Run-time Python3 library to control radio transceivers and receiv
Closes: 908294
Changes:
 hamlib (3.2-3) unstable; urgency=low
 .
   * Bump debian/watch file to version 4.
   * Fix FTBFS uncatched syntax error. (Closes: #908294)
Checksums-Sha1:
 fb92d017fa5c0d54a6253d2cc606d85dcb5a60dc 2562 hamlib_3.2-3.dsc
 0cd61623b6b6a52f1801e5730b0dcdd8c4b95e71 16400 hamlib_3.2-3.debian.tar.xz
 ddba5c1b838e9b70ce1bfb0163a2f8455a76ec2d 8981 hamlib_3.2-3_source.buildinfo
Checksums-Sha256:
 58615bdef19fee33c3267296053b10a66de31ed71f7dc838aafa8e52aef20e4a 2562 hamlib_3.2-3.dsc
 b5fe0f54588a151d07690445697c2f2202d397651e929afa7b9684f94c5b5984 16400 hamlib_3.2-3.debian.tar.xz
 54bb664d87f0ca37252259ad648a29f6154897d311ba0a748b8410c4a4821bea 8981 hamlib_3.2-3_source.buildinfo
Files:
 898ae3427432836d501282b2ed0da420 2562 hamradio optional hamlib_3.2-3.dsc
 a3cbc1c66e01a39b6d5253a0fa659749 16400 hamradio optional hamlib_3.2-3.debian.tar.xz
 3c87e211116a3401b88d2c957deee948 8981 hamradio optional hamlib_3.2-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEENwlPTy1bRd2msd6zfc9sMzd2V4EFAlukvqYACgkQfc9sMzd2
V4FcRwf/cbcMQERlZA57nUl12rGiU+ZlG4hlir3JtnT4LI5/cM7oLoTZmF+TL1y9
H6Ub3XUsZeV1mBZVch5QOF0WWWK/m5uMFNy3s7rxFwBWrdGZ9+bjOT9PXfogvevr
5pnkt4y8b7loKKgXxo0VpNIpXvkuWDEyh+7kulwjgWwGgUOQ4sjTKwUItUoRwxjc
1MNoD41YU37Pyvvk3Izw00gxM0I3uHNbNCodcXM+cajgfZzxpgsxsetbkQPlQvPP
O1fAPkSrJamoFKEbBHxnufxwfkyCHLEsuout825I0d288la/K0vdHdugo6YUxQ3p
rhoEPbfeNgDeLayywaAQvk1cBpM9xg==
=7xnm
-----END PGP SIGNATURE-----