Bug#909561: simple-cdd: configuration file can't rely on $simple_cdd_dir and other variables

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#909561: simple-cdd: configuration file can't rely on $simple_cdd_dir and other variables

Raphael Hertzog-3
Package: simple-cdd
Version: 0.6.6
Severity: important

I'm putting this as important because it's a regression compared to
before the python rewrite and because the sample configuration files shipped
in the package make you believe that you can rely on this variable.

I'm referring to those lines for example in
/usr/share/doc/simple-cdd/examples/simple-cdd.conf.detailed.gz:

    #debian_cd_dir=$simple_cdd_dir/debian-cd
    #simple_cdd_temp="$simple_cdd_dir/tmp/"
    # export SPLASHPNG="$simple_cdd_dir/yourimage.png"
    #hd_img="$simple_cdd_dir/qemu-test.hd.img"

I just checked by putting "env >/tmp/foo" in the configuration file that I
passed to the --conf parameter and I confirm that "simple_cdd_dir" is not
set in the environment.

You can decide to set it or not, I don't really care but it should be either
documented and supported, or unsupported and with no misleading references
to it in the configuration file.

Cheers,

-- System Information:
Debian Release: buster/sid
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages simple-cdd depends on:
ii  dctrl-tools         2.24-2+b1
ii  debian-cd           3.1.21
ii  lsb-release         9.20170808
ii  python3             3.6.6-1
ii  python3-simple-cdd  0.6.6
ii  reprepro            5.2.0-1
ii  rsync               3.1.2-2.2
ii  wget                1.19.5-2

Versions of packages simple-cdd recommends:
ii  dose-distcheck  5.0.1-11+b1

Versions of packages simple-cdd suggests:
ii  qemu-kvm  1:2.12+dfsg-3

-- no debconf information

Reply | Threaded
Open this post in threaded view
|

Bug#909561: simple-cdd: configuration file can't rely on $simple_cdd_dir and other variables

Vagrant Cascadian-4
Control: found 909561 0.6.5
Control: tags 909561 +help +confirmed

On 2018-09-25, Raphaël Hertzog wrote:

> I'm putting this as important because it's a regression compared to
> before the python rewrite and because the sample configuration files shipped
> in the package make you believe that you can rely on this variable.
>
> I'm referring to those lines for example in
> /usr/share/doc/simple-cdd/examples/simple-cdd.conf.detailed.gz:
>
>     #debian_cd_dir=$simple_cdd_dir/debian-cd
>     #simple_cdd_temp="$simple_cdd_dir/tmp/"
>     # export SPLASHPNG="$simple_cdd_dir/yourimage.png"
>     #hd_img="$simple_cdd_dir/qemu-test.hd.img"
>
> I just checked by putting "env >/tmp/foo" in the configuration file that I
> passed to the --conf parameter and I confirm that "simple_cdd_dir" is not
> set in the environment.

> You can decide to set it or not, I don't really care but it should be either
> documented and supported, or unsupported and with no misleading references
> to it in the configuration file.

I think this extends to setting any variables within variables any of
simple-cdd's configuration files.

I definitely consider it a bug.


live well,
  vagrant

signature.asc (233 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#909561: simple-cdd: configuration file can't rely on $simple_cdd_dir and other variables

Vagrant Cascadian-4
Control: clone 909561 -1
Control: retitle -1 simple-cdd: support variables in configuration files
Control: tags 909561 pending

On 2019-05-29, Vagrant Cascadian wrote:

> On 2018-09-25, Raphaël Hertzog wrote:
>> I'm putting this as important because it's a regression compared to
>> before the python rewrite and because the sample configuration files shipped
>> in the package make you believe that you can rely on this variable.
>>
>> I'm referring to those lines for example in
>> /usr/share/doc/simple-cdd/examples/simple-cdd.conf.detailed.gz:
>>
>>     #debian_cd_dir=$simple_cdd_dir/debian-cd
>>     #simple_cdd_temp="$simple_cdd_dir/tmp/"
>>     # export SPLASHPNG="$simple_cdd_dir/yourimage.png"
>>     #hd_img="$simple_cdd_dir/qemu-test.hd.img"
>>
>> I just checked by putting "env >/tmp/foo" in the configuration file that I
>> passed to the --conf parameter and I confirm that "simple_cdd_dir" is not
>> set in the environment.
>
>> You can decide to set it or not, I don't really care but it should be either
>> documented and supported, or unsupported and with no misleading references
>> to it in the configuration file.
I've added a commit upstream which removes references to variables in
the example configuration files and profiles, since the fix may take
longer.


> I think this extends to setting any variables within variables any of
> simple-cdd's configuration files.
>
> I definitely consider it a bug.

Cloning this bug to track fixing the actual issue.


live well,
  vagrant

signature.asc (233 bytes) Download Attachment