Bug#915718: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#915718: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

Sven Geuer
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "arno-iptables-firewall"

 * Package name    : arno-iptables-firewall
   Version         : 2.0.3-1
   Upstream Author : Arno van Amersfoort and Lonnie Abelbeck
 * URL             : http://rocky.eld.leidenuniv.nl/
 * License         : GPL-2+
   Section         : net

It builds those binary packages:

 arno-iptables-firewall - single- and multi-homed firewall script with
DSL/ADSL support

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/arno-iptables-firewall


Alternatively, one can download the package with dget using this
command:

  dget -x
https://mentors.debian.net/debian/pool/main/a/arno-iptables-firewall/arno-iptables-firewall_2.0.3-1.dsc

More information about arno-iptables-firewall can be obtained from
http://rocky.eld.leidenuniv.nl/html/.

Changes since the last upload:

  * New upstream release.
    (Closes: #824684, #862856, #886991, #898770, #913089)
  * New maintainer.
    (Closes: #886951)
  * Update Standards-Version to 4.2.1; no changes necessary.
  * Update debhelper compatibility level to 11.
  * Clean up Depends.
  * Update debian/copyright.
  * Update debian/watch.
  * Make use of dh_installlogrotate and simulate non-existing
    dh_installrsyslog
    - Move logrotate.d.conf to arno-iptables-firewall.logrotate
    - Move rsyslog.d.conf to arno-iptables-firewall.rsyslog
    - Update debian/rules
  * Switch from System-V style init scripts to systemd
    - Suppress installation of /etc/init.d/arno-iptables-firewall
    - Introduce debian/prerm
    - Update debian/postrm to not use invoke-rc.d or update-rc.d.
    - Update debian/preinst to remove System-V style init script links.
    - Update debian/postinst to use deb-systemd-invoke instead
      of invoke-rc.d or update-rc.d.
    - Update debian/arno-iptables-firewall.logrotate to use systemctl
      instead of invoke-rc.d.
    - Update debian/template and debian/po/* to propose a call to
      systemctl instead of invoke-rc.d.
    - Update debian/rules
  * Bugfix: Convert debian/po/fr.po and sv.po from latin1 to utf8

Regards,
 Sven Geuer

Reply | Threaded
Open this post in threaded view
|

Bug#915718: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

Adam Borowski-3
On Thu, Dec 06, 2018 at 12:41:55PM +0100, Sven Geuer wrote:
>  * Package name    : arno-iptables-firewall
>    Version         : 2.0.3-1

> Changes since the last upload:
>
>   * New upstream release.
>     (Closes: #824684, #862856, #886991, #898770, #913089)
>   * New maintainer.
>     (Closes: #886951)
>   * Update Standards-Version to 4.2.1; no changes necessary.
>   * Update debhelper compatibility level to 11.
>   * Clean up Depends.
>   * Update debian/copyright.
>   * Update debian/watch.
>   * Make use of dh_installlogrotate and simulate non-existing
>     dh_installrsyslog
>     - Move logrotate.d.conf to arno-iptables-firewall.logrotate
>     - Move rsyslog.d.conf to arno-iptables-firewall.rsyslog
>     - Update debian/rules

>   * Switch from System-V style init scripts to systemd

No, this is no good.  You can _add_ integration for a specific additional
rc system if you have a good reason (this is usually merely doubling the
effort) but the Policy is clear:

# However, any package integrating with other init systems must also be
# backwards-compatible with sysvinit by providing a SysV-style init script
# with the same name as and equivalent functionality to any init-specific
# job, as this is the only start-up configuration method guaranteed to be
# supported by all init implementations.

An init script works with systemd, sysvinit, openrc, runit, etc.

>     - Suppress installation of /etc/init.d/arno-iptables-firewall
>     - Introduce debian/prerm
>     - Update debian/postrm to not use invoke-rc.d or update-rc.d.
>     - Update debian/preinst to remove System-V style init script links.
>     - Update debian/postinst to use deb-systemd-invoke instead
>       of invoke-rc.d or update-rc.d.
>     - Update debian/arno-iptables-firewall.logrotate to use systemctl
>       instead of invoke-rc.d.
>     - Update debian/template and debian/po/* to propose a call to
>       systemctl instead of invoke-rc.d.
>     - Update debian/rules
>   * Bugfix: Convert debian/po/fr.po and sv.po from latin1 to utf8


Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Ivan was a worldly man: born in St. Petersburg, raised in
⢿⡄⠘⠷⠚⠋⠀ Petrograd, lived most of his life in Leningrad, then returned
⠈⠳⣄⠀⠀⠀⠀ to the city of his birth to die.

Reply | Threaded
Open this post in threaded view
|

Bug#915718: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

Marcos Fouces-2
In reply to this post by Sven Geuer
Hello Sven

As Adam stated, you should reconsider this change. I cannot see any
reason no to be backward compatible with sysvinit.

There is also some Lintian informative and pedantic tags that are
triggered. I found most of them reasonable, so it should also a good
idea to address them.

BTW: this is a security tool that would fit perfectly on the
pkg-security tools team. Please consider joining us [0]if you are
interested in maintain this package within a team.

[0] https://wiki.debian.org/Teams/pkg-security

Greetings,

Marcos.

Reply | Threaded
Open this post in threaded view
|

Bug#915718: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

Sven Geuer
Hi Adam and Marcos,

thank you for your input. I will upload a package with re-integrated
sysvinit support soon.

@Marcos: I wonder why Lintian on mentors.debian.net complains about
several issues while the lintian check included in debuild stays calm.
Any clue about this?

Cheers,
Sven

Reply | Threaded
Open this post in threaded view
|

Bug#915718: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

Sven Geuer
Dear mentors,

I uploaded a revised version for my package "arno-iptables-firewall"
and I am looking for a sponsor

 * Package name    : arno-iptables-firewall
   Version         : 2.0.3-1
   Upstream Author : Arno van Amersfoort and Lonnie Abelbeck
 * URL             : http://rocky.eld.leidenuniv.nl/
 * License         : GPL-2+
   Section         : net

It builds those binary packages:

 arno-iptables-firewall - single- and multi-homed firewall script with
DSL/ADSL support

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/arno-iptables-firewall


Alternatively, one can download the package with dget using this
command:

  dget -x
https://mentors.debian.net/debian/pool/main/a/arno-iptables-firewall/arno-iptables-firewall_2.0.3-1.dsc

More information about arno-iptables-firewall can be obtained from
http://rocky.eld.leidenuniv.nl/html/.

Changes since the last upload:

  * New upstream release.
    (Closes: #824684, #862856, #886991, #898770, #913089)
  * New maintainer.
    (Closes: #886951)
  * Update Standards-Version to 4.2.1; no changes necessary.
  * Update debhelper compatibility level to 11.
  * Clean up Depends.
  * Update debian/copyright.
  * Update debian/watch.
  * Make use of dh_installlogrotate and simulate non-existing
    dh_installrsyslog
    - Move logrotate.d.conf to arno-iptables-firewall.logrotate
    - Move rsyslog.d.conf to arno-iptables-firewall.rsyslog
    - Update debian/rules
  * Add support for systemd as alternate init system in addition to
sysvinit.
    - Refactor preinst, postinst, prerm, postrm.
  * Patch documentation and security related directives into systemd
unit file.
  * Add lintian-override due to missing uplink pgp signature.
  * Add debian/upstream/metadata.
  * Update debian/templates to provide a valid default configuration.
  * Add debian/tests/* for autopkgtest.
  * Convert debian/po/fr.po and sv.po from latin1 to utf8.

Regards,
 Sven Geuer