Bug#916705: Please patch DHT

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Juliusz Chroboczek-4
Package: transmission-gtk
Version: 2.94-1
Severity: wishlist

Hi,

I've just released libdht version 0.26, which fixes a rather unpleasant
bug.  I've filed a bug upstream:

  https://github.com/transmission/transmission/issues/782

Since upstream hasn't done a release in a long time, I'm attaching the bug
fix, in case you wish to patch the Debian package.

diff --git a/dht.c b/dht.c
index c752d13..b3709f9 100644
--- a/dht.c
+++ b/dht.c
@@ -2713,7 +2713,7 @@ send_closest_nodes(const struct sockaddr *sa, int salen,
     int numnodes = 0, numnodes6 = 0;
     struct bucket *b;
 
-    if(want < 0)
+    if(want <= 0)
         want = sa->sa_family == AF_INET ? WANT4 : WANT6;
 
     if((want & WANT4)) {

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Sandro Tosi-4
in light of https://github.com/transmission/transmission/issues/782#issuecomment-450852432
should https://salsa.debian.org/debian/transmission/blob/master/debian/patches/patch-vendored-libdht.patch
be reverted?

On Mon, Dec 17, 2018 at 12:45 PM Juliusz Chroboczek <[hidden email]> wrote:

>
> Package: transmission-gtk
> Version: 2.94-1
> Severity: wishlist
>
> Hi,
>
> I've just released libdht version 0.26, which fixes a rather unpleasant
> bug.  I've filed a bug upstream:
>
>   https://github.com/transmission/transmission/issues/782
>
> Since upstream hasn't done a release in a long time, I'm attaching the bug
> fix, in case you wish to patch the Debian package.
>
> diff --git a/dht.c b/dht.c
> index c752d13..b3709f9 100644
> --- a/dht.c
> +++ b/dht.c
> @@ -2713,7 +2713,7 @@ send_closest_nodes(const struct sockaddr *sa, int salen,
>      int numnodes = 0, numnodes6 = 0;
>      struct bucket *b;
>
> -    if(want < 0)
> +    if(want <= 0)
>          want = sa->sa_family == AF_INET ? WANT4 : WANT6;
>
>      if((want & WANT4)) {



--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Juliusz Chroboczek-4
> in light of https://github.com/transmission/transmission/issues/782#issuecomment-450852432
> should https://salsa.debian.org/debian/transmission/blob/master/debian/patches/patch-vendored-libdht.patch
> be reverted?

dht-0.25 doesn't have the bug.  The patch is harmless, but it doesn't
achieve anything useful.

Sorry again for the confusion.

-- Juliusz

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Sandro Tosi-4
Debian (i think) ships dht
https://salsa.debian.org/debian/transmission/blob/master/third-party/dht/CHANGES
- what should we do here?

On Wed, Jan 2, 2019 at 12:04 PM Juliusz Chroboczek <[hidden email]> wrote:

>
> > in light of https://github.com/transmission/transmission/issues/782#issuecomment-450852432
> > should https://salsa.debian.org/debian/transmission/blob/master/debian/patches/patch-vendored-libdht.patch
> > be reverted?
>
> dht-0.25 doesn't have the bug.  The patch is harmless, but it doesn't
> achieve anything useful.
>
> Sorry again for the confusion.
>
> -- Juliusz
>


--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Juliusz Chroboczek-4
> Debian (i think) ships dht
> https://salsa.debian.org/debian/transmission/blob/master/third-party/dht/CHANGES
> - what should we do here?

Debian's 2.94-1+b2 appears to be shipping 0.22, which is a rather old version.
There's no need to apply this patch to that version.

-- Juliusz

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Sandro Tosi-4
point it, it's already been applied - should i remove it or not?

On Wed, Jan 2, 2019 at 3:18 PM Juliusz Chroboczek <[hidden email]> wrote:
>
> > Debian (i think) ships dht
> > https://salsa.debian.org/debian/transmission/blob/master/third-party/dht/CHANGES
> > - what should we do here?
>
> Debian's 2.94-1+b2 appears to be shipping 0.22, which is a rather old version.
> There's no need to apply this patch to that version.
>
> -- Juliusz



--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Juliusz Chroboczek-4
> point it, it's already been applied - should i remove it or not?

It doesn't hurt, so if you'd rather not bother with a new upload, feel
free to leave it as it is.

Sorry again for the confusion,

-- Juliusz

Reply | Threaded
Open this post in threaded view
|

Bug#916705: Please patch DHT

Sandro Tosi-4
it's no problem, i'll just leave it then -- thanks!

On Wed, Jan 2, 2019 at 4:09 PM Juliusz Chroboczek <[hidden email]> wrote:
>
> > point it, it's already been applied - should i remove it or not?
>
> It doesn't hurt, so if you'd rather not bother with a new upload, feel
> free to leave it as it is.
>
> Sorry again for the confusion,
>
> -- Juliusz



--
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi