Bug#917120: lintian: Lintianrc should contain valid configuration

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#917120: lintian: Lintianrc should contain valid configuration

Salvo Tomaselli-3
Package: lintian
Version: 2.5.117
Severity: wishlist

Dear Maintainer,

According to the comments at the beginning of the file, /etc/lintianrc uses
shell syntax (it gets sourced I presume).

However all the later commented example options do not use said valid syntax.

It would be better if people could just uncomment, rather than needing to fix
the syntax as well.

Best

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.16 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                       2.31.1-11
ii  bzip2                          1.0.6-9
ii  diffstat                       1.62-1
ii  dpkg                           1.19.2
ii  dpkg-dev                       1.19.2
ii  file                           1:5.34-2
ii  gettext                        0.19.8.1-9
ii  gpg                            2.2.12-1
ii  intltool-debian                0.35.0+20060710.4
ii  libapt-pkg-perl                0.1.34+b1
ii  libarchive-zip-perl            1.64-1
ii  libcgi-pm-perl                 4.40-1
ii  libclass-accessor-perl         0.51-1
ii  libclone-perl                  0.41-1+b1
pn  libdigest-sha-perl             <none>
ii  libdpkg-perl                   1.19.2
ii  libemail-valid-perl            1.202-1
ii  libfile-basedir-perl           0.08-1
ii  libipc-run-perl                20180523.0-1
ii  liblist-moreutils-perl         0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libtext-levenshtein-perl       0.13-1
ii  libtimedate-perl               2.3000-2
ii  liburi-perl                    1.74-1
ii  libxml-simple-perl             2.25-1
ii  libyaml-libyaml-perl           0.75+repack-1
ii  man-db                         2.8.4-3
ii  patchutils                     0.3.4-2
ii  perl                           5.28.1-3
ii  t1utils                        1.41-2
ii  xz-utils                       5.2.2-1.3

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  <none>

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libhtml-parser-perl    3.72-3+b3
pn  libtext-template-perl  <none>

-- no debconf information

Reply | Threaded
Open this post in threaded view
|

Bug#917120: lintian: Lintianrc should contain valid configuration

Chris Lamb -2
tags 917120 + moreinfo
thanks

Hi Salvo,

> According to the comments at the beginning of the file, /etc/lintianrc uses
> shell syntax (it gets sourced I presume).

Hm? It's not shell, it's parsed with:

  https://salsa.debian.org/lintian/lintian/blob/master/commands/lintian.pm#L1240

> It would be better if people could just uncomment, rather than needing to fix
> the syntax as well.

What error message(s) are you seeing, specifically?


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] / chris-lamb.co.uk
       `-

Reply | Threaded
Open this post in threaded view
|

Bug#917120: lintian: Lintianrc should contain valid configuration

Salvo Tomaselli-3
No error message, just that the comment at the top of the file states
that var assignments should have no spaces, and then all the example
assignments have spaces.

Unless I am misinterpreting the meaning of the comment, but the
example syntax there has no spaces.

Il giorno dom 23 dic 2018 alle ore 00:24 Chris Lamb <[hidden email]>
ha scritto:

>
> tags 917120 + moreinfo
> thanks
>
> Hi Salvo,
>
> > According to the comments at the beginning of the file, /etc/lintianrc uses
> > shell syntax (it gets sourced I presume).
>
> Hm? It's not shell, it's parsed with:
>
>   https://salsa.debian.org/lintian/lintian/blob/master/commands/lintian.pm#L1240
>
> > It would be better if people could just uncomment, rather than needing to fix
> > the syntax as well.
>
> What error message(s) are you seeing, specifically?
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      [hidden email] / chris-lamb.co.uk
>        `-



--
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
                -- Galileo Galilei

http://ltworf.github.io/ltworf/

Reply | Threaded
Open this post in threaded view
|

Bug#917120: lintian: Lintianrc should contain valid configuration

Chris Lamb -2
Hi Salvo,

> No error message, just that the comment at the top of the file states
> that var assignments should have no spaces, and then all the example
> assignments have spaces.

I don't see any reference to spaces being illegal in this file. Please
could you copy-paste what you are seeing? I'm struggling to see what
the bug is here and we appear to be making a number of unnecessary
round-trips. :)


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] / chris-lamb.co.uk
       `-

Reply | Threaded
Open this post in threaded view
|

Bug#917120: lintian: Lintianrc should contain valid configuration

Salvo Tomaselli-3
# Also note, that this file uses a special syntax:
# Empty lines are allowed, comments are introduced by a hash sign (#).
# All other lines must have the format
#    VAR=text
# or
#    VAR="text"
# It is allowed to use `~' and `$HOME' in the variables, but not other
# shell/environment variables.

# Enable info tags by default (--display info)
#display-info = yes

# Limit the number of parallel unpacking jobs to X (--jobs)
#jobs = 8

# Enable pedantic tags by default (--pedantic)
#pedantic = yes


In the example syntax, spaces do not seem to be allowed.

Il giorno dom 23 dic 2018 alle ore 01:00 Chris Lamb <[hidden email]>
ha scritto:

>
> Hi Salvo,
>
> > No error message, just that the comment at the top of the file states
> > that var assignments should have no spaces, and then all the example
> > assignments have spaces.
>
> I don't see any reference to spaces being illegal in this file. Please
> could you copy-paste what you are seeing? I'm struggling to see what
> the bug is here and we appear to be making a number of unnecessary
> round-trips. :)
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      [hidden email] / chris-lamb.co.uk
>        `-



--
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
                -- Galileo Galilei

http://ltworf.github.io/ltworf/

Reply | Threaded
Open this post in threaded view
|

Bug#917120: lintian: Lintianrc should contain valid configuration

Chris Lamb -2
retitle 917120 lintian: misleading line format description in lintianrc
thanks

Salvo,

> # Also note, that this file uses a special syntax:
> # Empty lines are allowed, comments are introduced by a hash sign (#).
> # All other lines must have the format
> #    VAR=text
> # or
> #    VAR="text"

I don't read this as forbidding spaces myself, but I would concede
that it could be ambiguous so very happy to update the comment.

For the avoidance of doubt, I was asking you to copy-paste exactly
what you were seeing and reading (text, errors, etc.) just in case we
had different file contents. When filing bugs, please do try and a) be
as explicit as possible and b) avoid making assumptions about what the
problem is (your bug title is misleading; the commented-out syntax is
perfectly valid).

We could have saved a number of round-trips at the very least. :)


Best wishes,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] / chris-lamb.co.uk
       `-