Bug#919356: dwarves-dfsg: Copyright/licensing is unclear

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#919356: dwarves-dfsg: Copyright/licensing is unclear

Domenico Andreoli-3
Package: dwarves-dfsg
Severity: grave

This file is without license info:

 - hash.h

These are also without copyright info:

 - btf_encoder.c
 - btf_encoder.h
 - ctf.h
 - libbtf.c
 - libbtf.h
 - libctf.c
 - libctf.h

Though the detailed analysis is not yet complete, it's clear that the
copyright/licensing situation does not satisfy DFSG.

--
3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Arnaldo Carvalho de Melo
Em Fri, Jan 18, 2019 at 06:30:38PM +0100, Domenico Andreoli escreveu:

> From: Domenico Andreoli <[hidden email]>
>
> Hi Arnaldo,
>
>   I noticed that some files of pahole come without licensing and
> copyright information, this makes Debian struggle with the redistribution
> and, unfortunately, puts the inclusion of pahole into coming release
> at risk.
>
> For your convenience, I attached a patch that adds the info where
> missing and also adopts the SPDX notation.

Thanks, I've added the fb team involved in recent changes to this
package so that they are aware of it and can voice any concern, folks
anything to say about this? Is everything okay?

I'm tentatively adding this to my repo, hope to tag 1.13 soon.

- Arnaldo
 

> I presumed to match your intentions in fact copyright/licensing but
> please comment back so that I can adapt and hopefully converge quickly.
>
> Kind regards,
> Domenico
>
> Signed-off-by: Domenico Andreoli <[hidden email]>
> ---
>  btf_encoder.c        |  6 ++++++
>  btf_encoder.h        |  5 +++++
>  codiff.c             |  6 ++----
>  ctf.h                |  5 +++++
>  ctf_encoder.c        |  6 ++----
>  ctf_encoder.h        |  6 ++----
>  ctracer.c            |  6 ++----
>  dtagnames.c          |  6 ++----
>  dutil.c              |  6 ++----
>  dutil.h              |  6 ++----
>  dwarf_loader.c       |  6 ++----
>  dwarves.c            |  6 ++----
>  dwarves.h            |  6 ++----
>  dwarves_emit.c       |  6 ++----
>  dwarves_emit.h       |  6 ++----
>  dwarves_fprintf.c    |  6 ++----
>  dwarves_reorganize.c |  6 ++----
>  dwarves_reorganize.h |  6 ++----
>  elf_symtab.c         |  6 ++----
>  elf_symtab.h         |  6 ++----
>  elfcreator.c         |  6 ++----
>  elfcreator.h         |  6 ++----
>  gobuffer.c           |  6 ++----
>  gobuffer.h           |  6 ++----
>  libbtf.c             |  6 ++++++
>  libbtf.h             |  6 ++++++
>  libctf.c             |  6 ++++++
>  libctf.h             |  6 ++++++
>  list.h               |  6 ++----
>  pahole.c             |  6 ++----
>  pdwtags.c            |  6 ++----
>  pfunct.c             |  6 ++----
>  pglobal.c            |  5 +----
>  prefcnt.c            |  6 ++----
>  rbtree.c             | 16 ++--------------
>  rbtree.h             | 16 ++--------------
>  scncopy.c            |  6 ++----
>  strings.c            |  6 ++----
>  strings.h            |  6 ++----
>  syscse.c             |  6 ++----
>  40 files changed, 105 insertions(+), 152 deletions(-)
>
> diff --git a/btf_encoder.c b/btf_encoder.c
> index bfdab27..854434c 100644
> --- a/btf_encoder.c
> +++ b/btf_encoder.c
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #include "dwarves.h"
>  #include "libbtf.h"
>  #include "btf.h"
> diff --git a/btf_encoder.h b/btf_encoder.h
> index a9d622f..62409f8 100644
> --- a/btf_encoder.h
> +++ b/btf_encoder.h
> @@ -1,5 +1,10 @@
>  #ifndef _BTF_ENCODER_H_
>  #define _BTF_ENCODER_H_ 1
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
>  
>  struct cu;
>  
> diff --git a/codiff.c b/codiff.c
> index a3bee05..8bbc32a 100644
> --- a/codiff.c
> +++ b/codiff.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/ctf.h b/ctf.h
> index 6233f6f..25b7989 100644
> --- a/ctf.h
> +++ b/ctf.h
> @@ -1,5 +1,10 @@
>  #ifndef _CTF_H
>  #define _CTF_H
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
>  
>  #include <stdint.h>
>  
> diff --git a/ctf_encoder.c b/ctf_encoder.c
> index ab70254..8f1c0be 100644
> --- a/ctf_encoder.c
> +++ b/ctf_encoder.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include "dwarves.h"
> diff --git a/ctf_encoder.h b/ctf_encoder.h
> index 91c43d9..16e76e2 100644
> --- a/ctf_encoder.h
> +++ b/ctf_encoder.h
> @@ -1,12 +1,10 @@
>  #ifndef _CTF_ENCODER_H_
>  #define _CTF_ENCODER_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  struct cu;
> diff --git a/ctracer.c b/ctracer.c
> index 710bdab..e4bd5e0 100644
> --- a/ctracer.c
> +++ b/ctracer.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/dtagnames.c b/dtagnames.c
> index 16b9987..0ffcbf7 100644
> --- a/dtagnames.c
> +++ b/dtagnames.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <stdio.h>
> diff --git a/dutil.c b/dutil.c
> index 791866f..51bed2d 100644
> --- a/dutil.c
> +++ b/dutil.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  
> diff --git a/dutil.h b/dutil.h
> index 0401b3e..7404d6b 100644
> --- a/dutil.h
> +++ b/dutil.h
> @@ -1,12 +1,10 @@
>  #ifndef _DUTIL_H_
>  #define _DUTIL_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>   * Copyright (C) 2007..2009 Arnaldo Carvalho de Melo <[hidden email]>
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> - *
>   * Some functions came from the Linux Kernel sources, copyrighted by a
>   * cast of dozens, please see the Linux Kernel git history for details.
>   */
> diff --git a/dwarf_loader.c b/dwarf_loader.c
> index 2cc0911..47eeb70 100644
> --- a/dwarf_loader.c
> +++ b/dwarf_loader.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include <assert.h>
> diff --git a/dwarves.c b/dwarves.c
> index cef0681..3b966f3 100644
> --- a/dwarves.c
> +++ b/dwarves.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Red Hat Inc.
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <assert.h>
> diff --git a/dwarves.h b/dwarves.h
> index 52a68db..212ebea 100644
> --- a/dwarves.h
> +++ b/dwarves.h
> @@ -1,12 +1,10 @@
>  #ifndef _DWARVES_H_
>  #define _DWARVES_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006..2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  
> diff --git a/dwarves_emit.c b/dwarves_emit.c
> index ad0e163..062cdea 100644
> --- a/dwarves_emit.c
> +++ b/dwarves_emit.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Red Hat Inc.
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <string.h>
> diff --git a/dwarves_emit.h b/dwarves_emit.h
> index 1aa485b..5d8c7ab 100644
> --- a/dwarves_emit.h
> +++ b/dwarves_emit.h
> @@ -1,13 +1,11 @@
>  #ifndef _DWARVES_EMIT_H_
>  #define _DWARVES_EMIT_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <stdio.h>
> diff --git a/dwarves_fprintf.c b/dwarves_fprintf.c
> index 2164c9e..09626d0 100644
> --- a/dwarves_fprintf.c
> +++ b/dwarves_fprintf.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007..2009 Red Hat Inc.
>    Copyright (C) 2007..2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <dwarf.h>
> diff --git a/dwarves_reorganize.c b/dwarves_reorganize.c
> index 6f59a76..1fb08d5 100644
> --- a/dwarves_reorganize.c
> +++ b/dwarves_reorganize.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Red Hat Inc.
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include "list.h"
> diff --git a/dwarves_reorganize.h b/dwarves_reorganize.h
> index 97cfc5a..5fccf6d 100644
> --- a/dwarves_reorganize.h
> +++ b/dwarves_reorganize.h
> @@ -1,13 +1,11 @@
>  #ifndef _DWARVES_REORGANIZE_H_
>  #define _DWARVES_REORGANIZE_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  
> diff --git a/elf_symtab.c b/elf_symtab.c
> index d70d1bc..741990e 100644
> --- a/elf_symtab.c
> +++ b/elf_symtab.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <malloc.h>
> diff --git a/elf_symtab.h b/elf_symtab.h
> index 70bcfd5..359add6 100644
> --- a/elf_symtab.h
> +++ b/elf_symtab.h
> @@ -1,12 +1,10 @@
>  #ifndef _ELF_SYMTAB_H_
>  #define _ELF_SYMTAB_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <stdbool.h>
> diff --git a/elfcreator.c b/elfcreator.c
> index c284b52..baea6e8 100644
> --- a/elfcreator.c
> +++ b/elfcreator.c
> @@ -1,9 +1,7 @@
>  /*
> - * Copyright 2009 Red Hat, Inc.
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> + * Copyright 2009 Red Hat, Inc.
>   *
>   * Author: Peter Jones <[hidden email]>
>   */
> diff --git a/elfcreator.h b/elfcreator.h
> index 7de1a98..a071de5 100644
> --- a/elfcreator.h
> +++ b/elfcreator.h
> @@ -1,9 +1,7 @@
>  /*
> - * Copyright 2009 Red Hat, Inc.
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> + * Copyright 2009 Red Hat, Inc.
>   *
>   * Author: Peter Jones <[hidden email]>
>   */
> diff --git a/gobuffer.c b/gobuffer.c
> index ef4718d..f8d2066 100644
> --- a/gobuffer.c
> +++ b/gobuffer.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  
>    Grow only buffer, add entries but never delete
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include "gobuffer.h"
> diff --git a/gobuffer.h b/gobuffer.h
> index 41f0c9d..a12c5c8 100644
> --- a/gobuffer.h
> +++ b/gobuffer.h
> @@ -1,11 +1,9 @@
>  #ifndef _GOBUFFER_H_
>  #define _GOBUFFER_H_ 1
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  struct gobuffer {
> diff --git a/libbtf.c b/libbtf.c
> index 3f49c0f..f075988 100644
> --- a/libbtf.c
> +++ b/libbtf.c
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #include <fcntl.h>
>  #include <gelf.h>
>  #include <limits.h>
> diff --git a/libbtf.h b/libbtf.h
> index 02156fd..fee05e3 100644
> --- a/libbtf.h
> +++ b/libbtf.h
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #ifndef _LIBBTF_H
>  #define _LIBBTF_H
>  
> diff --git a/libctf.c b/libctf.c
> index 33e2b67..e9fc609 100644
> --- a/libctf.c
> +++ b/libctf.c
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #include <fcntl.h>
>  #include <gelf.h>
>  #include <limits.h>
> diff --git a/libctf.h b/libctf.h
> index edb2104..6ebc191 100644
> --- a/libctf.h
> +++ b/libctf.h
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #ifndef _LIBCTF_H
>  #define _LIBCTF_H
>  
> diff --git a/list.h b/list.h
> index e2548e8..6072919 100644
> --- a/list.h
> +++ b/list.h
> @@ -1,11 +1,9 @@
>  #ifndef _LINUX_LIST_H
>  #define _LINUX_LIST_H
>  /*
> -  Copyright (C) Cast of dozens, comes from the Linux kernel
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) Cast of dozens, comes from the Linux kernel
>  */
>  
>  #include <stddef.h>
> diff --git a/pahole.c b/pahole.c
> index 55803c3..4f99a85 100644
> --- a/pahole.c
> +++ b/pahole.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007-2008 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/pdwtags.c b/pdwtags.c
> index c1c6688..1d300e6 100644
> --- a/pdwtags.c
> +++ b/pdwtags.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2007-2016 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2007-2016 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include <argp.h>
> diff --git a/pfunct.c b/pfunct.c
> index 97c31f0..bb57507 100644
> --- a/pfunct.c
> +++ b/pfunct.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/pglobal.c b/pglobal.c
> index f7ca54d..1f6cdad 100644
> --- a/pglobal.c
> +++ b/pglobal.c
> @@ -1,10 +1,7 @@
>  /*
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
>   * Copyright (C) 2007 Davi E. M. Arnaut <[hidden email]>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as published
> - * by the Free Software Foundation.
>   */
>  
>  #include <argp.h>
> diff --git a/prefcnt.c b/prefcnt.c
> index 412e999..8b24db2 100644
> --- a/prefcnt.c
> +++ b/prefcnt.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <assert.h>
> diff --git a/rbtree.c b/rbtree.c
> index 2189f88..b8b907d 100644
> --- a/rbtree.c
> +++ b/rbtree.c
> @@ -1,22 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-or-later
> +
>    Red Black Trees
>    (C) 1999  Andrea Arcangeli <[hidden email]>
>    (C) 2002  David Woodhouse <[hidden email]>
>  
> -  This program is free software; you can redistribute it and/or modify
> -  it under the terms of the GNU General Public License as published by
> -  the Free Software Foundation; either version 2 of the License, or
> -  (at your option) any later version.
> -
> -  This program is distributed in the hope that it will be useful,
> -  but WITHOUT ANY WARRANTY; without even the implied warranty of
> -  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -  GNU General Public License for more details.
> -
> -  You should have received a copy of the GNU General Public License
> -  along with this program; if not, write to the Free Software
> -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> -
>    linux/lib/rbtree.c
>  */
>  
> diff --git a/rbtree.h b/rbtree.h
> index c9ab87a..3eb99f9 100644
> --- a/rbtree.h
> +++ b/rbtree.h
> @@ -1,21 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-or-later
> +
>    Red Black Trees
>    (C) 1999  Andrea Arcangeli <[hidden email]>
>  
> -  This program is free software; you can redistribute it and/or modify
> -  it under the terms of the GNU General Public License as published by
> -  the Free Software Foundation; either version 2 of the License, or
> -  (at your option) any later version.
> -
> -  This program is distributed in the hope that it will be useful,
> -  but WITHOUT ANY WARRANTY; without even the implied warranty of
> -  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -  GNU General Public License for more details.
> -
> -  You should have received a copy of the GNU General Public License
> -  along with this program; if not, write to the Free Software
> -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> -
>    linux/include/linux/rbtree.h
>  
>    To use rbtrees you'll have to implement your own insert and search cores.
> diff --git a/scncopy.c b/scncopy.c
> index 9acc16d..539186f 100644
> --- a/scncopy.c
> +++ b/scncopy.c
> @@ -1,9 +1,7 @@
>  /*
> - * Copyright 2009 Red Hat, Inc.
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> + * Copyright 2009 Red Hat, Inc.
>   *
>   * Author: Peter Jones <[hidden email]>
>   */
> diff --git a/strings.c b/strings.c
> index a0f188a..ddb2b1b 100644
> --- a/strings.c
> +++ b/strings.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include "strings.h"
> diff --git a/strings.h b/strings.h
> index 127f651..01f50ef 100644
> --- a/strings.h
> +++ b/strings.h
> @@ -1,11 +1,9 @@
>  #ifndef _STRINGS_H_
>  #define _STRINGS_H_ 1
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include "gobuffer.h"
> diff --git a/syscse.c b/syscse.c
> index edd8ee7..1d5d905 100644
> --- a/syscse.c
> +++ b/syscse.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2007-2016 Arnaldo Carvalho de Melo <[hidden email]>
>  
>    System call sign extender
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>

> From: Domenico Andreoli <[hidden email]>
> Date: Tue, 15 Jan 2019 18:28:24 +0100
> Subject: Adopt SPDX-License-Identifier
>
> ---
>  btf_encoder.c        |  6 ++++++
>  btf_encoder.h        |  5 +++++
>  codiff.c             |  6 ++----
>  ctf.h                |  5 +++++
>  ctf_encoder.c        |  6 ++----
>  ctf_encoder.h        |  6 ++----
>  ctracer.c            |  6 ++----
>  dtagnames.c          |  6 ++----
>  dutil.c              |  6 ++----
>  dutil.h              |  6 ++----
>  dwarf_loader.c       |  6 ++----
>  dwarves.c            |  6 ++----
>  dwarves.h            |  6 ++----
>  dwarves_emit.c       |  6 ++----
>  dwarves_emit.h       |  6 ++----
>  dwarves_fprintf.c    |  6 ++----
>  dwarves_reorganize.c |  6 ++----
>  dwarves_reorganize.h |  6 ++----
>  elf_symtab.c         |  6 ++----
>  elf_symtab.h         |  6 ++----
>  elfcreator.c         |  6 ++----
>  elfcreator.h         |  6 ++----
>  gobuffer.c           |  6 ++----
>  gobuffer.h           |  6 ++----
>  libbtf.c             |  6 ++++++
>  libbtf.h             |  6 ++++++
>  libctf.c             |  6 ++++++
>  libctf.h             |  6 ++++++
>  list.h               |  6 ++----
>  pahole.c             |  6 ++----
>  pdwtags.c            |  6 ++----
>  pfunct.c             |  6 ++----
>  pglobal.c            |  5 +----
>  prefcnt.c            |  6 ++----
>  rbtree.c             | 16 ++--------------
>  rbtree.h             | 16 ++--------------
>  scncopy.c            |  6 ++----
>  strings.c            |  6 ++----
>  strings.h            |  6 ++----
>  syscse.c             |  6 ++----
>  40 files changed, 105 insertions(+), 152 deletions(-)
>
> diff --git a/btf_encoder.c b/btf_encoder.c
> index bfdab27..854434c 100644
> --- a/btf_encoder.c
> +++ b/btf_encoder.c
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #include "dwarves.h"
>  #include "libbtf.h"
>  #include "btf.h"
> diff --git a/btf_encoder.h b/btf_encoder.h
> index a9d622f..62409f8 100644
> --- a/btf_encoder.h
> +++ b/btf_encoder.h
> @@ -1,5 +1,10 @@
>  #ifndef _BTF_ENCODER_H_
>  #define _BTF_ENCODER_H_ 1
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
>  
>  struct cu;
>  
> diff --git a/codiff.c b/codiff.c
> index a3bee05..8bbc32a 100644
> --- a/codiff.c
> +++ b/codiff.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/ctf.h b/ctf.h
> index 6233f6f..25b7989 100644
> --- a/ctf.h
> +++ b/ctf.h
> @@ -1,5 +1,10 @@
>  #ifndef _CTF_H
>  #define _CTF_H
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
>  
>  #include <stdint.h>
>  
> diff --git a/ctf_encoder.c b/ctf_encoder.c
> index ab70254..8f1c0be 100644
> --- a/ctf_encoder.c
> +++ b/ctf_encoder.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include "dwarves.h"
> diff --git a/ctf_encoder.h b/ctf_encoder.h
> index 91c43d9..16e76e2 100644
> --- a/ctf_encoder.h
> +++ b/ctf_encoder.h
> @@ -1,12 +1,10 @@
>  #ifndef _CTF_ENCODER_H_
>  #define _CTF_ENCODER_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  struct cu;
> diff --git a/ctracer.c b/ctracer.c
> index 710bdab..e4bd5e0 100644
> --- a/ctracer.c
> +++ b/ctracer.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/dtagnames.c b/dtagnames.c
> index 16b9987..0ffcbf7 100644
> --- a/dtagnames.c
> +++ b/dtagnames.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <stdio.h>
> diff --git a/dutil.c b/dutil.c
> index 791866f..51bed2d 100644
> --- a/dutil.c
> +++ b/dutil.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  
> diff --git a/dutil.h b/dutil.h
> index 0401b3e..7404d6b 100644
> --- a/dutil.h
> +++ b/dutil.h
> @@ -1,12 +1,10 @@
>  #ifndef _DUTIL_H_
>  #define _DUTIL_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>   * Copyright (C) 2007..2009 Arnaldo Carvalho de Melo <[hidden email]>
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> - *
>   * Some functions came from the Linux Kernel sources, copyrighted by a
>   * cast of dozens, please see the Linux Kernel git history for details.
>   */
> diff --git a/dwarf_loader.c b/dwarf_loader.c
> index 2cc0911..47eeb70 100644
> --- a/dwarf_loader.c
> +++ b/dwarf_loader.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include <assert.h>
> diff --git a/dwarves.c b/dwarves.c
> index cef0681..3b966f3 100644
> --- a/dwarves.c
> +++ b/dwarves.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Red Hat Inc.
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <assert.h>
> diff --git a/dwarves.h b/dwarves.h
> index 52a68db..212ebea 100644
> --- a/dwarves.h
> +++ b/dwarves.h
> @@ -1,12 +1,10 @@
>  #ifndef _DWARVES_H_
>  #define _DWARVES_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006..2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  
> diff --git a/dwarves_emit.c b/dwarves_emit.c
> index ad0e163..062cdea 100644
> --- a/dwarves_emit.c
> +++ b/dwarves_emit.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Red Hat Inc.
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <string.h>
> diff --git a/dwarves_emit.h b/dwarves_emit.h
> index 1aa485b..5d8c7ab 100644
> --- a/dwarves_emit.h
> +++ b/dwarves_emit.h
> @@ -1,13 +1,11 @@
>  #ifndef _DWARVES_EMIT_H_
>  #define _DWARVES_EMIT_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <stdio.h>
> diff --git a/dwarves_fprintf.c b/dwarves_fprintf.c
> index 2164c9e..09626d0 100644
> --- a/dwarves_fprintf.c
> +++ b/dwarves_fprintf.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007..2009 Red Hat Inc.
>    Copyright (C) 2007..2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <dwarf.h>
> diff --git a/dwarves_reorganize.c b/dwarves_reorganize.c
> index 6f59a76..1fb08d5 100644
> --- a/dwarves_reorganize.c
> +++ b/dwarves_reorganize.c
> @@ -1,12 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Red Hat Inc.
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include "list.h"
> diff --git a/dwarves_reorganize.h b/dwarves_reorganize.h
> index 97cfc5a..5fccf6d 100644
> --- a/dwarves_reorganize.h
> +++ b/dwarves_reorganize.h
> @@ -1,13 +1,11 @@
>  #ifndef _DWARVES_REORGANIZE_H_
>  #define _DWARVES_REORGANIZE_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  
> diff --git a/elf_symtab.c b/elf_symtab.c
> index d70d1bc..741990e 100644
> --- a/elf_symtab.c
> +++ b/elf_symtab.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <malloc.h>
> diff --git a/elf_symtab.h b/elf_symtab.h
> index 70bcfd5..359add6 100644
> --- a/elf_symtab.h
> +++ b/elf_symtab.h
> @@ -1,12 +1,10 @@
>  #ifndef _ELF_SYMTAB_H_
>  #define _ELF_SYMTAB_H_ 1
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2009 Red Hat Inc.
>    Copyright (C) 2009 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <stdbool.h>
> diff --git a/elfcreator.c b/elfcreator.c
> index c284b52..baea6e8 100644
> --- a/elfcreator.c
> +++ b/elfcreator.c
> @@ -1,9 +1,7 @@
>  /*
> - * Copyright 2009 Red Hat, Inc.
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> + * Copyright 2009 Red Hat, Inc.
>   *
>   * Author: Peter Jones <[hidden email]>
>   */
> diff --git a/elfcreator.h b/elfcreator.h
> index 7de1a98..a071de5 100644
> --- a/elfcreator.h
> +++ b/elfcreator.h
> @@ -1,9 +1,7 @@
>  /*
> - * Copyright 2009 Red Hat, Inc.
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> + * Copyright 2009 Red Hat, Inc.
>   *
>   * Author: Peter Jones <[hidden email]>
>   */
> diff --git a/gobuffer.c b/gobuffer.c
> index ef4718d..f8d2066 100644
> --- a/gobuffer.c
> +++ b/gobuffer.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  
>    Grow only buffer, add entries but never delete
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include "gobuffer.h"
> diff --git a/gobuffer.h b/gobuffer.h
> index 41f0c9d..a12c5c8 100644
> --- a/gobuffer.h
> +++ b/gobuffer.h
> @@ -1,11 +1,9 @@
>  #ifndef _GOBUFFER_H_
>  #define _GOBUFFER_H_ 1
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  struct gobuffer {
> diff --git a/libbtf.c b/libbtf.c
> index 3f49c0f..f075988 100644
> --- a/libbtf.c
> +++ b/libbtf.c
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #include <fcntl.h>
>  #include <gelf.h>
>  #include <limits.h>
> diff --git a/libbtf.h b/libbtf.h
> index 02156fd..fee05e3 100644
> --- a/libbtf.h
> +++ b/libbtf.h
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #ifndef _LIBBTF_H
>  #define _LIBBTF_H
>  
> diff --git a/libctf.c b/libctf.c
> index 33e2b67..e9fc609 100644
> --- a/libctf.c
> +++ b/libctf.c
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #include <fcntl.h>
>  #include <gelf.h>
>  #include <limits.h>
> diff --git a/libctf.h b/libctf.h
> index edb2104..6ebc191 100644
> --- a/libctf.h
> +++ b/libctf.h
> @@ -1,3 +1,9 @@
> +/*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
> +  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> + */
> +
>  #ifndef _LIBCTF_H
>  #define _LIBCTF_H
>  
> diff --git a/list.h b/list.h
> index e2548e8..6072919 100644
> --- a/list.h
> +++ b/list.h
> @@ -1,11 +1,9 @@
>  #ifndef _LINUX_LIST_H
>  #define _LINUX_LIST_H
>  /*
> -  Copyright (C) Cast of dozens, comes from the Linux kernel
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) Cast of dozens, comes from the Linux kernel
>  */
>  
>  #include <stddef.h>
> diff --git a/pahole.c b/pahole.c
> index 55803c3..4f99a85 100644
> --- a/pahole.c
> +++ b/pahole.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007-2008 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/pdwtags.c b/pdwtags.c
> index c1c6688..1d300e6 100644
> --- a/pdwtags.c
> +++ b/pdwtags.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2007-2016 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2007-2016 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include <argp.h>
> diff --git a/pfunct.c b/pfunct.c
> index 97c31f0..bb57507 100644
> --- a/pfunct.c
> +++ b/pfunct.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
>    Copyright (C) 2007 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>
> diff --git a/pglobal.c b/pglobal.c
> index f7ca54d..1f6cdad 100644
> --- a/pglobal.c
> +++ b/pglobal.c
> @@ -1,10 +1,7 @@
>  /*
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
>   * Copyright (C) 2007 Davi E. M. Arnaut <[hidden email]>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as published
> - * by the Free Software Foundation.
>   */
>  
>  #include <argp.h>
> diff --git a/prefcnt.c b/prefcnt.c
> index 412e999..8b24db2 100644
> --- a/prefcnt.c
> +++ b/prefcnt.c
> @@ -1,10 +1,8 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2006 Mandriva Conectiva S.A.
>    Copyright (C) 2006 Arnaldo Carvalho de Melo <[hidden email]>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <assert.h>
> diff --git a/rbtree.c b/rbtree.c
> index 2189f88..b8b907d 100644
> --- a/rbtree.c
> +++ b/rbtree.c
> @@ -1,22 +1,10 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-or-later
> +
>    Red Black Trees
>    (C) 1999  Andrea Arcangeli <[hidden email]>
>    (C) 2002  David Woodhouse <[hidden email]>
>  
> -  This program is free software; you can redistribute it and/or modify
> -  it under the terms of the GNU General Public License as published by
> -  the Free Software Foundation; either version 2 of the License, or
> -  (at your option) any later version.
> -
> -  This program is distributed in the hope that it will be useful,
> -  but WITHOUT ANY WARRANTY; without even the implied warranty of
> -  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -  GNU General Public License for more details.
> -
> -  You should have received a copy of the GNU General Public License
> -  along with this program; if not, write to the Free Software
> -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> -
>    linux/lib/rbtree.c
>  */
>  
> diff --git a/rbtree.h b/rbtree.h
> index c9ab87a..3eb99f9 100644
> --- a/rbtree.h
> +++ b/rbtree.h
> @@ -1,21 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-or-later
> +
>    Red Black Trees
>    (C) 1999  Andrea Arcangeli <[hidden email]>
>  
> -  This program is free software; you can redistribute it and/or modify
> -  it under the terms of the GNU General Public License as published by
> -  the Free Software Foundation; either version 2 of the License, or
> -  (at your option) any later version.
> -
> -  This program is distributed in the hope that it will be useful,
> -  but WITHOUT ANY WARRANTY; without even the implied warranty of
> -  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -  GNU General Public License for more details.
> -
> -  You should have received a copy of the GNU General Public License
> -  along with this program; if not, write to the Free Software
> -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> -
>    linux/include/linux/rbtree.h
>  
>    To use rbtrees you'll have to implement your own insert and search cores.
> diff --git a/scncopy.c b/scncopy.c
> index 9acc16d..539186f 100644
> --- a/scncopy.c
> +++ b/scncopy.c
> @@ -1,9 +1,7 @@
>  /*
> - * Copyright 2009 Red Hat, Inc.
> + * SPDX-License-Identifier: GPL-2.0-only
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> + * Copyright 2009 Red Hat, Inc.
>   *
>   * Author: Peter Jones <[hidden email]>
>   */
> diff --git a/strings.c b/strings.c
> index a0f188a..ddb2b1b 100644
> --- a/strings.c
> +++ b/strings.c
> @@ -1,9 +1,7 @@
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include "strings.h"
> diff --git a/strings.h b/strings.h
> index 127f651..01f50ef 100644
> --- a/strings.h
> +++ b/strings.h
> @@ -1,11 +1,9 @@
>  #ifndef _STRINGS_H_
>  #define _STRINGS_H_ 1
>  /*
> -  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
> +  SPDX-License-Identifier: GPL-2.0-only
>  
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> +  Copyright (C) 2008 Arnaldo Carvalho de Melo <[hidden email]>
>  */
>  
>  #include "gobuffer.h"
> diff --git a/syscse.c b/syscse.c
> index edd8ee7..1d5d905 100644
> --- a/syscse.c
> +++ b/syscse.c
> @@ -1,11 +1,9 @@
>  /*
> +  SPDX-License-Identifier: GPL-2.0-only
> +
>    Copyright (C) 2007-2016 Arnaldo Carvalho de Melo <[hidden email]>
>  
>    System call sign extender
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
>  */
>  
>  #include <argp.h>

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Arnaldo Carvalho de Melo-2
In reply to this post by Domenico Andreoli-3
Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:

> On Fri, Jan 18, 2019 at 03:45:03PM -0200, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jan 18, 2019 at 06:30:38PM +0100, Domenico Andreoli escreveu:
> > > From: Domenico Andreoli <[hidden email]>
> > >
> > > Hi Arnaldo,
> > >
> > >   I noticed that some files of pahole come without licensing and
> > > copyright information, this makes Debian struggle with the redistribution
> > > and, unfortunately, puts the inclusion of pahole into coming release
> > > at risk.
> > >
> > > For your convenience, I attached a patch that adds the info where
> > > missing and also adopts the SPDX notation.
> >
> > Thanks, I've added the fb team involved in recent changes to this
> > package so that they are aware of it and can voice any concern, folks
> > anything to say about this? Is everything okay?
> No concern on adding the SPDX notation.
> I would like to add my employer to a few btf files:
>
> + Copyright (c) 2018 Facebook

Sure, I'll add a patch, authored by you, with a signed-off-by you, etc,
CC the group and signed by me as well, just like the kernel process. On
top of Domenico's patch.

Thanks a lot!

- Arnaldo
 
> > >  btf_encoder.c        |  6 ++++++
> > >  btf_encoder.h        |  5 +++++
> > >  libbtf.c             |  6 ++++++
> > >  libbtf.h             |  6 ++++++
> > >  libctf.c             |  6 ++++++
>
> Thanks!
> Martin

--

- Arnaldo

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Arnaldo Carvalho de Melo-2
In reply to this post by Domenico Andreoli-3
Em Fri, Jan 18, 2019 at 03:33:25PM -0300, Arnaldo Carvalho de Melo escreveu:

> Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:
> > On Fri, Jan 18, 2019 at 03:45:03PM -0200, Arnaldo Carvalho de Melo wrote:
> > > Em Fri, Jan 18, 2019 at 06:30:38PM +0100, Domenico Andreoli escreveu:
> > > > From: Domenico Andreoli <[hidden email]>
> > > >
> > > > Hi Arnaldo,
> > > >
> > > >   I noticed that some files of pahole come without licensing and
> > > > copyright information, this makes Debian struggle with the redistribution
> > > > and, unfortunately, puts the inclusion of pahole into coming release
> > > > at risk.
> > > >
> > > > For your convenience, I attached a patch that adds the info where
> > > > missing and also adopts the SPDX notation.
> > >
> > > Thanks, I've added the fb team involved in recent changes to this
>
> Hey, is that I problem for me to take your GPG signature as an indicator
> I can add a:
>
> Signed-off-by: Domenico Andreoli <[hidden email]>

Or better:

Signed-off-by: Domenico Andreoli <[hidden email]>


since that is the one you used in the From: line, ok?
 

> ?
>
> > > package so that they are aware of it and can voice any concern, folks
> > > anything to say about this? Is everything okay?
> > No concern on adding the SPDX notation.
> > I would like to add my employer to a few btf files:
> >
> > + Copyright (c) 2018 Facebook
> >
> > > >  btf_encoder.c        |  6 ++++++
> > > >  btf_encoder.h        |  5 +++++
> > > >  libbtf.c             |  6 ++++++
> > > >  libbtf.h             |  6 ++++++
> > > >  libctf.c             |  6 ++++++
> >
> > Thanks!
> > Martin
>
> --
>
> - Arnaldo

--

- Arnaldo

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Arnaldo Carvalho de Melo-2
In reply to this post by Domenico Andreoli-3
Em Fri, Jan 18, 2019 at 03:41:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 18, 2019 at 03:28:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:
> > > No concern on adding the SPDX notation.
> > > I would like to add my employer to a few btf files:

> > > + Copyright (c) 2018 Facebook

> > Sure, I'll add a patch, authored by you, with a signed-off-by you, etc,
> > CC the group and signed by me as well, just like the kernel process. On
> > top of Domenico's patch.
>
> Now I noticed that the patch adds Copyright entries as well, so I'm
> fixing it up, as libbtf.[ch] I haven't authored, and btf_encoder.[ch]
> where authored by Facebook engineers based on ctf_encoder.[ch] that I'm
> the author, so I'm just fixing these things up in Martin's follow up
> patch.

End result, ok?

commit 1610b9b4327d14589800606fc4d31229eb8f1daf
Author: Martin Lau <[hidden email]>
Date:   Fri Jan 18 15:42:37 2019 -0300

    Fixup copyright notices for BTF files authored by Facebook engineers
   
    Cc: Andrii Nakryiko <[hidden email]>
    Cc: Domenico Andreoli <[hidden email]>
    Cc: Yonghong Song <[hidden email]>
    Signed-off-by: Martin Lau <[hidden email]>
    Signed-off-by: Arnaldo Carvalho de Melo <[hidden email]>

diff --git a/btf_encoder.c b/btf_encoder.c
index 613e7e9a6d43..7aed9b454c1f 100644
--- a/btf_encoder.c
+++ b/btf_encoder.c
@@ -1,7 +1,12 @@
 /*
   SPDX-License-Identifier: GPL-2.0-only
 
-  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
+  Copyright (C) 2019 Facebook
+
+  Derived from ctf_encoder.c, which is:
+
+  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
+  Copyright (C) Red Hat Inc
  */
 
 #include "dwarves.h"
diff --git a/btf_encoder.h b/btf_encoder.h
index daf5d372986a..80237bb4ca61 100644
--- a/btf_encoder.h
+++ b/btf_encoder.h
@@ -3,7 +3,10 @@
 /*
   SPDX-License-Identifier: GPL-2.0-only
 
-  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
+  Copyright (C) 2019 Facebook
+
+  Derived from ctf_encoder.h, which is:
+  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
  */
 
 struct cu;
diff --git a/libbtf.c b/libbtf.c
index 64437f3bd2d9..c6ece9d84de5 100644
--- a/libbtf.c
+++ b/libbtf.c
@@ -1,7 +1,7 @@
 /*
   SPDX-License-Identifier: GPL-2.0-only
 
-  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
+  Copyright (C) 2019 Facebook
  */
 
 #include <fcntl.h>
diff --git a/libbtf.h b/libbtf.h
index ef1c49804a20..780f3ec888d7 100644
--- a/libbtf.h
+++ b/libbtf.h
@@ -1,7 +1,7 @@
 /*
   SPDX-License-Identifier: GPL-2.0-only
 
-  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
+  Copyright (C) 2019 Facebook
  */
 
 #ifndef _LIBBTF_H

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Martin Lau
On Fri, Jan 18, 2019 at 03:44:27PM -0300, Arnaldo Carvalho de Melo wrote:

> Em Fri, Jan 18, 2019 at 03:41:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Jan 18, 2019 at 03:28:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:
> > > > No concern on adding the SPDX notation.
> > > > I would like to add my employer to a few btf files:
>
> > > > + Copyright (c) 2018 Facebook
>
> > > Sure, I'll add a patch, authored by you, with a signed-off-by you, etc,
> > > CC the group and signed by me as well, just like the kernel process. On
> > > top of Domenico's patch.
> >
> > Now I noticed that the patch adds Copyright entries as well, so I'm
> > fixing it up, as libbtf.[ch] I haven't authored, and btf_encoder.[ch]
> > where authored by Facebook engineers based on ctf_encoder.[ch] that I'm
> > the author, so I'm just fixing these things up in Martin's follow up
> > patch.
>
> End result, ok?
Perfect!


>
> commit 1610b9b4327d14589800606fc4d31229eb8f1daf
> Author: Martin Lau <[hidden email]>
> Date:   Fri Jan 18 15:42:37 2019 -0300
>
>     Fixup copyright notices for BTF files authored by Facebook engineers
>    
>     Cc: Andrii Nakryiko <[hidden email]>
>     Cc: Domenico Andreoli <[hidden email]>
>     Cc: Yonghong Song <[hidden email]>
>     Signed-off-by: Martin Lau <[hidden email]>
>     Signed-off-by: Arnaldo Carvalho de Melo <[hidden email]>
>
> diff --git a/btf_encoder.c b/btf_encoder.c
> index 613e7e9a6d43..7aed9b454c1f 100644
> --- a/btf_encoder.c
> +++ b/btf_encoder.c
> @@ -1,7 +1,12 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
> +
> +  Derived from ctf_encoder.c, which is:
> +
> +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) Red Hat Inc
>   */
>  
>  #include "dwarves.h"
> diff --git a/btf_encoder.h b/btf_encoder.h
> index daf5d372986a..80237bb4ca61 100644
> --- a/btf_encoder.h
> +++ b/btf_encoder.h
> @@ -3,7 +3,10 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
> +
> +  Derived from ctf_encoder.h, which is:
> +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
>   */
>  
>  struct cu;
> diff --git a/libbtf.c b/libbtf.c
> index 64437f3bd2d9..c6ece9d84de5 100644
> --- a/libbtf.c
> +++ b/libbtf.c
> @@ -1,7 +1,7 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
>   */
>  
>  #include <fcntl.h>
> diff --git a/libbtf.h b/libbtf.h
> index ef1c49804a20..780f3ec888d7 100644
> --- a/libbtf.h
> +++ b/libbtf.h
> @@ -1,7 +1,7 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
>   */
>  
>  #ifndef _LIBBTF_H

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Domenico Andreoli-3
In reply to this post by Arnaldo Carvalho de Melo-2
On Fri, Jan 18, 2019 at 03:44:27PM -0300, Arnaldo Carvalho de Melo wrote:

> Em Fri, Jan 18, 2019 at 03:41:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Jan 18, 2019 at 03:28:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:
> > > > No concern on adding the SPDX notation.
> > > > I would like to add my employer to a few btf files:
>
> > > > + Copyright (c) 2018 Facebook
>
> > > Sure, I'll add a patch, authored by you, with a signed-off-by you, etc,
> > > CC the group and signed by me as well, just like the kernel process. On
> > > top of Domenico's patch.
> >
> > Now I noticed that the patch adds Copyright entries as well, so I'm
> > fixing it up, as libbtf.[ch] I haven't authored, and btf_encoder.[ch]
> > where authored by Facebook engineers based on ctf_encoder.[ch] that I'm
> > the author, so I'm just fixing these things up in Martin's follow up
> > patch.
>
> End result, ok?

yes, thanks!

>
> commit 1610b9b4327d14589800606fc4d31229eb8f1daf
> Author: Martin Lau <[hidden email]>
> Date:   Fri Jan 18 15:42:37 2019 -0300
>
>     Fixup copyright notices for BTF files authored by Facebook engineers
>    
>     Cc: Andrii Nakryiko <[hidden email]>
>     Cc: Domenico Andreoli <[hidden email]>
>     Cc: Yonghong Song <[hidden email]>
>     Signed-off-by: Martin Lau <[hidden email]>
>     Signed-off-by: Arnaldo Carvalho de Melo <[hidden email]>

could please add also mine?

Signed-off-by: Domenico Andreoli <[hidden email]>

>
> diff --git a/btf_encoder.c b/btf_encoder.c
> index 613e7e9a6d43..7aed9b454c1f 100644
> --- a/btf_encoder.c
> +++ b/btf_encoder.c
> @@ -1,7 +1,12 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
> +
> +  Derived from ctf_encoder.c, which is:
> +
> +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) Red Hat Inc
>   */
>  
>  #include "dwarves.h"
> diff --git a/btf_encoder.h b/btf_encoder.h
> index daf5d372986a..80237bb4ca61 100644
> --- a/btf_encoder.h
> +++ b/btf_encoder.h
> @@ -3,7 +3,10 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
> +
> +  Derived from ctf_encoder.h, which is:
> +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
>   */
>  
>  struct cu;
> diff --git a/libbtf.c b/libbtf.c
> index 64437f3bd2d9..c6ece9d84de5 100644
> --- a/libbtf.c
> +++ b/libbtf.c
> @@ -1,7 +1,7 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
>   */
>  
>  #include <fcntl.h>
> diff --git a/libbtf.h b/libbtf.h
> index ef1c49804a20..780f3ec888d7 100644
> --- a/libbtf.h
> +++ b/libbtf.h
> @@ -1,7 +1,7 @@
>  /*
>    SPDX-License-Identifier: GPL-2.0-only
>  
> -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> +  Copyright (C) 2019 Facebook
>   */
>  
>  #ifndef _LIBBTF_H

--
3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Domenico Andreoli
In reply to this post by Arnaldo Carvalho de Melo
On Fri, Jan 18, 2019 at 03:45:03PM -0200, Arnaldo Carvalho de Melo wrote:

> Em Fri, Jan 18, 2019 at 06:30:38PM +0100, Domenico Andreoli escreveu:
> > From: Domenico Andreoli <[hidden email]>
> >
> > Hi Arnaldo,
> >
> >   I noticed that some files of pahole come without licensing and
> > copyright information, this makes Debian struggle with the redistribution
> > and, unfortunately, puts the inclusion of pahole into coming release
> > at risk.
> >
> > For your convenience, I attached a patch that adds the info where
> > missing and also adopts the SPDX notation.
>
> Thanks, I've added the fb team involved in recent changes to this
> package so that they are aware of it and can voice any concern, folks
> anything to say about this? Is everything okay?
>
> I'm tentatively adding this to my repo, hope to tag 1.13 soon.
Excellent!

Would be also nice to have the COPYING file to cover every other file
without explicit copyright.

Regards,
Domenico

--
3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Arnaldo Carvalho de Melo-2
In reply to this post by Martin Lau
Em Fri, Jan 18, 2019 at 06:54:41PM +0000, Martin Lau escreveu:

> On Fri, Jan 18, 2019 at 03:44:27PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jan 18, 2019 at 03:41:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Jan 18, 2019 at 03:28:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:
> > > > > No concern on adding the SPDX notation.
> > > > > I would like to add my employer to a few btf files:
> >
> > > > > + Copyright (c) 2018 Facebook
> >
> > > > Sure, I'll add a patch, authored by you, with a signed-off-by you, etc,
> > > > CC the group and signed by me as well, just like the kernel process. On
> > > > top of Domenico's patch.
> > >
> > > Now I noticed that the patch adds Copyright entries as well, so I'm
> > > fixing it up, as libbtf.[ch] I haven't authored, and btf_encoder.[ch]
> > > where authored by Facebook engineers based on ctf_encoder.[ch] that I'm
> > > the author, so I'm just fixing these things up in Martin's follow up
> > > patch.
> >
> > End result, ok?
> Perfect!

:-)
 

>
> >
> > commit 1610b9b4327d14589800606fc4d31229eb8f1daf
> > Author: Martin Lau <[hidden email]>
> > Date:   Fri Jan 18 15:42:37 2019 -0300
> >
> >     Fixup copyright notices for BTF files authored by Facebook engineers
> >    
> >     Cc: Andrii Nakryiko <[hidden email]>
> >     Cc: Domenico Andreoli <[hidden email]>
> >     Cc: Yonghong Song <[hidden email]>
> >     Signed-off-by: Martin Lau <[hidden email]>
> >     Signed-off-by: Arnaldo Carvalho de Melo <[hidden email]>
> >
> > diff --git a/btf_encoder.c b/btf_encoder.c
> > index 613e7e9a6d43..7aed9b454c1f 100644
> > --- a/btf_encoder.c
> > +++ b/btf_encoder.c
> > @@ -1,7 +1,12 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> > +
> > +  Derived from ctf_encoder.c, which is:
> > +
> > +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) Red Hat Inc
> >   */
> >  
> >  #include "dwarves.h"
> > diff --git a/btf_encoder.h b/btf_encoder.h
> > index daf5d372986a..80237bb4ca61 100644
> > --- a/btf_encoder.h
> > +++ b/btf_encoder.h
> > @@ -3,7 +3,10 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> > +
> > +  Derived from ctf_encoder.h, which is:
> > +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
> >   */
> >  
> >  struct cu;
> > diff --git a/libbtf.c b/libbtf.c
> > index 64437f3bd2d9..c6ece9d84de5 100644
> > --- a/libbtf.c
> > +++ b/libbtf.c
> > @@ -1,7 +1,7 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> >   */
> >  
> >  #include <fcntl.h>
> > diff --git a/libbtf.h b/libbtf.h
> > index ef1c49804a20..780f3ec888d7 100644
> > --- a/libbtf.h
> > +++ b/libbtf.h
> > @@ -1,7 +1,7 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> >   */
> >  
> >  #ifndef _LIBBTF_H

--

- Arnaldo

Reply | Threaded
Open this post in threaded view
|

Bug#919356: [PATCH] Add missing licensing info

Arnaldo Carvalho de Melo-2
In reply to this post by Domenico Andreoli-3
Em Fri, Jan 18, 2019 at 08:02:40PM +0100, Domenico Andreoli escreveu:

> On Fri, Jan 18, 2019 at 03:44:27PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jan 18, 2019 at 03:41:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Jan 18, 2019 at 03:28:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Em Fri, Jan 18, 2019 at 06:24:52PM +0000, Martin Lau escreveu:
> > > > > No concern on adding the SPDX notation.
> > > > > I would like to add my employer to a few btf files:
> >
> > > > > + Copyright (c) 2018 Facebook
> >
> > > > Sure, I'll add a patch, authored by you, with a signed-off-by you, etc,
> > > > CC the group and signed by me as well, just like the kernel process. On
> > > > top of Domenico's patch.
> > >
> > > Now I noticed that the patch adds Copyright entries as well, so I'm
> > > fixing it up, as libbtf.[ch] I haven't authored, and btf_encoder.[ch]
> > > where authored by Facebook engineers based on ctf_encoder.[ch] that I'm
> > > the author, so I'm just fixing these things up in Martin's follow up
> > > patch.
> >
> > End result, ok?
>
> yes, thanks!
>
> >
> > commit 1610b9b4327d14589800606fc4d31229eb8f1daf
> > Author: Martin Lau <[hidden email]>
> > Date:   Fri Jan 18 15:42:37 2019 -0300
> >
> >     Fixup copyright notices for BTF files authored by Facebook engineers
> >    
> >     Cc: Andrii Nakryiko <[hidden email]>
> >     Cc: Domenico Andreoli <[hidden email]>
> >     Cc: Yonghong Song <[hidden email]>
> >     Signed-off-by: Martin Lau <[hidden email]>
> >     Signed-off-by: Arnaldo Carvalho de Melo <[hidden email]>
>
> could please add also mine?
>
> Signed-off-by: Domenico Andreoli <[hidden email]>

Sure!
 

> >
> > diff --git a/btf_encoder.c b/btf_encoder.c
> > index 613e7e9a6d43..7aed9b454c1f 100644
> > --- a/btf_encoder.c
> > +++ b/btf_encoder.c
> > @@ -1,7 +1,12 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> > +
> > +  Derived from ctf_encoder.c, which is:
> > +
> > +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) Red Hat Inc
> >   */
> >  
> >  #include "dwarves.h"
> > diff --git a/btf_encoder.h b/btf_encoder.h
> > index daf5d372986a..80237bb4ca61 100644
> > --- a/btf_encoder.h
> > +++ b/btf_encoder.h
> > @@ -3,7 +3,10 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> > +
> > +  Derived from ctf_encoder.h, which is:
> > +  Copyright (C) Arnaldo Carvalho de Melo <[hidden email]>
> >   */
> >  
> >  struct cu;
> > diff --git a/libbtf.c b/libbtf.c
> > index 64437f3bd2d9..c6ece9d84de5 100644
> > --- a/libbtf.c
> > +++ b/libbtf.c
> > @@ -1,7 +1,7 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> >   */
> >  
> >  #include <fcntl.h>
> > diff --git a/libbtf.h b/libbtf.h
> > index ef1c49804a20..780f3ec888d7 100644
> > --- a/libbtf.h
> > +++ b/libbtf.h
> > @@ -1,7 +1,7 @@
> >  /*
> >    SPDX-License-Identifier: GPL-2.0-only
> >  
> > -  Copyright (C) 2019 Arnaldo Carvalho de Melo <[hidden email]>
> > +  Copyright (C) 2019 Facebook
> >   */
> >  
> >  #ifndef _LIBBTF_H
>
> --
> 3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

--

- Arnaldo

Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Kristian Fiskerstrand-2
In reply to this post by Domenico Andreoli-3
On 1/23/19 9:50 AM, Domenico Andreoli wrote:

> Ben Finney <[hidden email]> writes:
>> Domenico Andreoli <[hidden email]> writes:
>>
>>>   the situation of dwarves-dfsg improved a lot over the weekend
>>
>> That's good to hear. What is the event you're referring to? Can you give
>> a URL to something that describes this change?
>
> Upstream (in CC) reacted to my request of clarification and patches
> have been applied upstream and on Salsa. See bug 919356 [0] (please
> keep in CC).
>
>>> the only knot left is now the license of hash.h
>>>
>>> This file is also present in the kernel [0] with an updated copyright
>>> but still without license.
>>
>> The file you show (in the Linux code base) seems likely to have an
>> equivalent implementation under a different license, from some other
>> code base.
>
> This will require research and work unlikely to be done before Buster
> release. Are we going to drop this package for now?
>
>>> I received a private email from somebody in the kernel community who
>>> already tried to contact Nadia in the past but did not get any reply.
>>
>> Thank you also for contacting the Linux developers forum to ask
>> <URL:https://www.mail-archive.com/linux-kernel@.../msg1900588.html>.
>
> (also in CC now)
>
>>> I think that pushing it to non-free is formally the right thing but I
>>> actually feel it's not the right thing.
>>
>> To know that work (that file) is free software, we need a clear grant of
>> some specific license, for that work.
>>
>> If the work is not free, it would be incorrect to have the work in Debian.
>
> Is it possible that for the kernel it is instead correct because it is,
> as whole, covered by its COPYING?
>
>> Alternatives, for complying with the Debian Free Software Guidelines with
>> this package, include:
>>
>> * Find a credible grant of license under some GPL-compatible free
>>   license to that exact file. Document that explicit grant in the Debian
>>   package. This demonstrates the work is DFSG-free.
>>
>> * Convince ‘dwarves-dfsg’ upstream to replace that file with a different
>>   implementation (I don't know whether such an implementation exists)
>>   under a license compatible with the same version of GNU GPL. Document
>>   that explicit grant in the Debian package. This demonstrates the
>>   modified work is DFSG-free.
>
> Arnaldo, what priority would you give to this task?
>
>>
>> * Replace that file in Debian only, with a different implementation as
>>   above. Document that explicit grant in the Debian package. This
>>   demonstrates the modified Debian package is DFSG-free.
>>
>> * Move the work to the ‘non-free’ area.
>>
>> * Remove the work altogether.
>>
>> Those are in descending order of (my recommended) preference.
>
> Thanks,
> Domenico
>
> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919356
>
It was [pointed out] by one of our license group that [hash.h]  is the
same that has a GPL-2+ in [fio] which has a signed-off-by.

References:
[pointed out]
https://bugs.gentoo.org/677586#c1

[hash.h]
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/fio.git/commit/hash.h?id=bdc7211e190482f0c17c109a0d90834a6611be1c

[fio]
https://metadata.ftp-master.debian.org/changelogs/main/f/fio/fio_3.12-2_copyright



--
Kristian Fiskerstrand
OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Domenico Andreoli-3
On Mon, Feb 11, 2019 at 12:08:32AM +0100, Kristian Fiskerstrand wrote:
> On 1/23/19 9:50 AM, Domenico Andreoli wrote:
> > Ben Finney <[hidden email]> writes:
> >> Domenico Andreoli <[hidden email]> writes:

[...]

> >>> the only knot left is now the license of hash.h
> >>>
> >>> This file is also present in the kernel [0] with an updated copyright
> >>> but still without license.

[...]

> >> To know that work (that file) is free software, we need a clear grant of
> >> some specific license, for that work.
> >>
> >> If the work is not free, it would be incorrect to have the work in Debian.
> >
> > Is it possible that for the kernel it is instead correct because it is,
> > as whole, covered by its COPYING?
> >
> >> Alternatives, for complying with the Debian Free Software Guidelines with
> >> this package, include:
> >>
> >> * Find a credible grant of license under some GPL-compatible free
> >>   license to that exact file. Document that explicit grant in the Debian
> >>   package. This demonstrates the work is DFSG-free.
> >>
> >> * Convince ???dwarves-dfsg??? upstream to replace that file with a different
> >>   implementation (I don't know whether such an implementation exists)
> >>   under a license compatible with the same version of GNU GPL. Document
> >>   that explicit grant in the Debian package. This demonstrates the
> >>   modified work is DFSG-free.
> >>
> >> * Replace that file in Debian only, with a different implementation as
> >>   above. Document that explicit grant in the Debian package. This
> >>   demonstrates the modified Debian package is DFSG-free.
> >>
> >> * Move the work to the ???non-free??? area.
> >>
> >> * Remove the work altogether.
> >>
> >> Those are in descending order of (my recommended) preference.
[...]

> It was [pointed out] by one of our license group that [hash.h]  is the
> same that has a GPL-2+ in [fio] which has a signed-off-by.
>
> References:
> [pointed out]
> https://bugs.gentoo.org/677586#c1
>
> [hash.h]
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/fio.git/commit/hash.h?id=bdc7211e190482f0c17c109a0d90834a6611be1c

Yes, the Signed-off-by is from Jens Axboe (in CC) but he's not the
original author, I guess he just copied the file as Arnaldo did. The
file he committed has not any reference to the license.

> [fio]
> https://metadata.ftp-master.debian.org/changelogs/main/f/fio/fio_3.12-2_copyright

I'm afraid that this entry in wrong. I'll seek confirmation with Martin Steigerwald.

Regards,
Domenico

--
3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

signature.asc (321 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Martin Steigerwald-5
Adding in [hidden email], as I am not sure whether the oracle.com address
from Jens is actually valid / up to date.

Domenico Andreoli - 11.02.19, 08:22:
> On Mon, Feb 11, 2019 at 12:08:32AM +0100, Kristian Fiskerstrand wrote:
> >
Mit freundlichen Grüßen / With kind regards
Martin Steigerwald • 
Proact Deutschland GmbH
Trainer
Telefon: <a href="tel:+49%20911%2030999%200" target="_blank" id="LPlnk689713" style="text-decoration:none;color:#7D7D7D;">+49 911 30999 0 • 
Fax: <a href="tel:" target="_blank" id="LPlnk689713" style="text-decoration:none;color:#7D7D7D;">+49 911 30999 99
Südwestpark 43 • 
90449 Nürnberg • 
Germany
[hidden email] • 
www.proact.de
 
Amtsgericht Nürnberg
 • 
HRB 18320
Geschäftsführer: 
Oliver Kügow • 
Richard Müller • 
Jakob Høholdt
 • 
Peter Mikael Javestad
 
– Delivering Business Agility –
 
On 1/23/19 9:50 AM, Domenico Andreoli wrote:

> > > Ben Finney <[hidden email]> writes:
> > >> Domenico Andreoli <[hidden email]> writes:
> [...]
>
> > >>> the only knot left is now the license of hash.h
> > >>>
> > >>> This file is also present in the kernel [0] with an updated copyright
> > >>> but still without license.
>
> [...]
>
> > >> To know that work (that file) is free software, we need a clear grant
> > >> of
> > >> some specific license, for that work.
> > >>
> > >> If the work is not free, it would be incorrect to have the work in
> > >> Debian.
> > >
> > > Is it possible that for the kernel it is instead correct because it is,
> > > as whole, covered by its COPYING?
> > >
> > >> Alternatives, for complying with the Debian Free Software Guidelines
> > >> with
> > >> this package, include:
> > >>
> > >> * Find a credible grant of license under some GPL-compatible free
> > >>
> > >> license to that exact file. Document that explicit grant in the
> > >> Debian
> > >> package. This demonstrates the work is DFSG-free.
> > >>
> > >> * Convince ???dwarves-dfsg??? upstream to replace that file with a
> > >> different> >>
> > >> implementation (I don't know whether such an implementation exists)
> > >> under a license compatible with the same version of GNU GPL. Document
> > >> that explicit grant in the Debian package. This demonstrates the
> > >> modified work is DFSG-free.
> > >>
> > >> * Replace that file in Debian only, with a different implementation as
> > >>
> > >> above. Document that explicit grant in the Debian package. This
> > >> demonstrates the modified Debian package is DFSG-free.
> > >>
> > >> * Move the work to the ???non-free??? area.
> > >>
> > >> * Remove the work altogether.
> > >>
> > >> Those are in descending order of (my recommended) preference.
>
> [...]
>
> > It was [pointed out] by one of our license group that [hash.h] is the
> > same that has a GPL-2+ in [fio] which has a signed-off-by.
> >
> > References:
> > [pointed out]
> > https://bugs.gentoo.org/677586#c1
> >
> > [hash.h]
> > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/fio.git/commit/hash.
> > h?id=bdc7211e190482f0c17c109a0d90834a6611be1c
> Yes, the Signed-off-by is from Jens Axboe (in CC) but he's not the
> original author, I guess he just copied the file as Arnaldo did. The
> file he committed has not any reference to the license.
>
> > [fio]
> > https://metadata.ftp-master.debian.org/changelogs/main/f/fio/fio_3.12-2_co
> > pyright
> I'm afraid that this entry in wrong. I'll seek confirmation with Martin
> Steigerwald.

Which entry to you refer to? I assume the one about hash.h.

Well the file has in its header:

/* Fast hashing routine for a long.
(C) 2002 William Lee Irwin III, IBM */

/*
* Knuth recommends primes in approximately golden ratio to the maximum
* integer representable by a machine word for multiplicative hashing.
* Chuck Lever verified the effectiveness of this technique:
* http://www.citi.umich.edu/techreports/reports/citi-tr-00-1.pdf
*
* These primes are chosen to be bit-sparse, that is operations on
* them can use shifts and additions instead of multiplications for
* machines where multiplications are slow.
*/

It has been quite a while ago. I bet back then I did not regard this as
license information since it does not specify a license. Thus I assumed it to
be GPL-2 as the other files which have no license boiler plate. I.e.: Check file
is it has different license, if not, then assume it has license as specified in
COPYING.

Not specifying a license can however also mean in this context that it has no
license as the file contains copyright information from another author.

Of course I can update copyright file in case my conclusion from a long time
ago was wrong.

Jens?

Thanks,
--
Martin Steigerwald • Proact Deutschland GmbH
Trainer

Telefon: +49 911 30999 55 • Fax: +49 911 30999 99
Südwestpark 43 • 90449 Nürnberg • Germany
[hidden email] • www.proact.de

Amtsgericht Nürnberg • HRB 18320
Geschäftsführer: Oliver Kügow • Richard Müller • Jakob Høholdt • Peter Mikael
Javestad


Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Jens Axboe-4
On 2/11/19 3:50 AM, Martin Steigerwald wrote:

> Adding in [hidden email], as I am not sure whether the oracle.com address
> from Jens is actually valid / up to date.
>
> Domenico Andreoli - 11.02.19, 08:22:
>> On Mon, Feb 11, 2019 at 12:08:32AM +0100, Kristian Fiskerstrand wrote:
>> >
> Mit freundlichen Grüßen / With kind regards​
>
> Martin Steigerwald  • 
> Proact Deutschland GmbH
>
> Trainer
>
> Telefon: *+49 911 30999 0* <tel:+49%20911%2030999%200>  • 
> Fax: *+49 911 30999 99* <tel:>
>
> Südwestpark 43  • 
> 90449  Nürnberg  • 
> Germany
>
> *[hidden email]* <mailto:[hidden email]>  • 
> *www.proact.de* <https://www.proact.de/>
>
>  
> Amtsgericht Nürnberg
>  • 
> HRB 18320
>
> Geschäftsführer: 
> Oliver Kügow  • 
> Richard Müller  • 
> Jakob Høholdt
>  • 
> Peter Mikael Javestad
>
>  
> – Delivering Business Agility –
>
>  
>
> On 1/23/19 9:50 AM, Domenico Andreoli wrote:
>> > > Ben Finney <[hidden email]> writes:
>> > >> Domenico Andreoli <[hidden email]> writes:
>> [...]
>>
>> > >>> the only knot left is now the license of hash.h
>> > >>>
>> > >>> This file is also present in the kernel [0] with an updated copyright
>> > >>> but still without license.
>>
>> [...]
>>
>> > >> To know that work (that file) is free software, we need a clear grant
>> > >> of
>> > >> some specific license, for that work.
>> > >>
>> > >> If the work is not free, it would be incorrect to have the work in
>> > >> Debian.
>> > >
>> > > Is it possible that for the kernel it is instead correct because it is,
>> > > as whole, covered by its COPYING?
>> > >
>> > >> Alternatives, for complying with the Debian Free Software Guidelines
>> > >> with
>> > >> this package, include:
>> > >>
>> > >> * Find a credible grant of license under some GPL-compatible free
>> > >>
>> > >> license to that exact file. Document that explicit grant in the
>> > >> Debian
>> > >> package. This demonstrates the work is DFSG-free.
>> > >>
>> > >> * Convince ???dwarves-dfsg??? upstream to replace that file with a
>> > >> different> >>
>> > >> implementation (I don't know whether such an implementation exists)
>> > >> under a license compatible with the same version of GNU GPL. Document
>> > >> that explicit grant in the Debian package. This demonstrates the
>> > >> modified work is DFSG-free.
>> > >>
>> > >> * Replace that file in Debian only, with a different implementation as
>> > >>
>> > >> above. Document that explicit grant in the Debian package. This
>> > >> demonstrates the modified Debian package is DFSG-free.
>> > >>
>> > >> * Move the work to the ???non-free??? area.
>> > >>
>> > >> * Remove the work altogether.
>> > >>
>> > >> Those are in descending order of (my recommended) preference.
>>
>> [...]
>>
>> > It was [pointed out] by one of our license group that [hash.h] is the
>> > same that has a GPL-2+ in [fio] which has a signed-off-by.
>> >
>> > References:
>> > [pointed out]
>> > https://bugs.gentoo.org/677586#c1
>> >
>> > [hash.h]
>> > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/fio.git/commit/hash.
>> > h?id=bdc7211e190482f0c17c109a0d90834a6611be1c
>> Yes, the Signed-off-by is from Jens Axboe (in CC) but he's not the
>> original author, I guess he just copied the file as Arnaldo did. The
>> file he committed has not any reference to the license.
>>
>> > [fio]
>> > https://metadata.ftp-master.debian.org/changelogs/main/f/fio/fio_3.12-2_co
>> > pyright
>> I'm afraid that this entry in wrong. I'll seek confirmation with Martin
>> Steigerwald.
>
> Which entry to you refer to? I assume the one about hash.h.
>
> Well the file has in its header:
>
> /* Fast hashing routine for a long.
> (C) 2002 William Lee Irwin III, IBM */
>
> /*
> * Knuth recommends primes in approximately golden ratio to the maximum
> * integer representable by a machine word for multiplicative hashing.
> * Chuck Lever verified the effectiveness of this technique:
> * http://www.citi.umich.edu/techreports/reports/citi-tr-00-1.pdf
> *
> * These primes are chosen to be bit-sparse, that is operations on
> * them can use shifts and additions instead of multiplications for
> * machines where multiplications are slow.
> */
>
> It has been quite a while ago. I bet back then I did not regard this as
> license information since it does not specify a license. Thus I assumed it to
> be GPL-2 as the other files which have no license boiler plate. I.e.: Check file
> is it has different license, if not, then assume it has license as specified in
> COPYING.
>
> Not specifying a license can however also mean in this context that it has no
> license as the file contains copyright information from another author.
>
> Of course I can update copyright file in case my conclusion from a long time
> ago was wrong.
>
> Jens?

Right, if nothing else is noted, it's GPL v2.

--
Jens Axboe

Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Ben Finney-3
In reply to this post by Martin Steigerwald-5
Martin Steigerwald <[hidden email]> writes:

> Well the file has in its header:
>
> /* Fast hashing routine for a long.
>    (C) 2002 William Lee Irwin III, IBM */
>
> /*
>  * Knuth recommends primes in approximately golden ratio to the maximum
>  * integer representable by a machine word for multiplicative hashing.
>  * Chuck Lever verified the effectiveness of this technique:
>  * http://www.citi.umich.edu/techreports/reports/citi-tr-00-1.pdf
>  *
>  * These primes are chosen to be bit-sparse, that is operations on
>  * them can use shifts and additions instead of multiplications for
>  * machines where multiplications are slow.
>  */
>
> It has been quite a while ago. I bet back then I did not regard this
> as license information since it does not specify a license. Thus I
> assumed it to be GPL-2 as the other files which have no license boiler
> plate. I.e.: Check file is it has different license, if not, then
> assume it has license as specified in COPYING.
>
> Not specifying a license can however also mean in this context that it
> has no license as the file contains copyright information from another
> author.

If a work (even one file) “has no license”, that means no special
permissions are granted and normal copyright applies: All rights
reserved, i.e. not redistributable. So, no license is grounds to
consider a work non-free and non-redistributable.

If, on the other hand, the file is to be free software, there would need
to be a clear grant of some free software license to that work.

Given the confusion over this file, I would consider it a significant
risk to just assume we have GPLv2 permissions without being told that
explicitly by the copyright holder. Rather, the reason we are seeking a
clearly-granted free license for this one file, is because we are trying
to replace a probably non-free file with the same code in it.

It seems we need to keep looking, and in the meantime assume we have no
free license in this file.

--
 \      “If the desire to kill and the opportunity to kill came always |
  `\      together, who would escape hanging?” —Mark Twain, _Following |
_o__)                                                     the Equator_ |
Ben Finney <[hidden email]>

Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Martin Steigerwald
In reply to this post by Domenico Andreoli-3
Jens Axboe - 12.02.19, 17:16:

> On 2/11/19 11:27 PM, Ben Finney wrote:
> > Martin Steigerwald <[hidden email]> writes:
> >> Well the file has in its header:
> >>
> >> /* Fast hashing routine for a long.
> >>
> >>    (C) 2002 William Lee Irwin III, IBM */
> >>
> >> /*
> >>
> >>  * Knuth recommends primes in approximately golden ratio to the
> >>  maximum * integer representable by a machine word for
> >>  multiplicative hashing. * Chuck Lever verified the effectiveness
> >>  of this technique:
> >>  * http://www.citi.umich.edu/techreports/reports/citi-tr-00-1.pdf
> >>  *
> >>  * These primes are chosen to be bit-sparse, that is operations on
> >>  * them can use shifts and additions instead of multiplications for
> >>  * machines where multiplications are slow.
> >>  */
> >>
> >> It has been quite a while ago. I bet back then I did not regard
> >> this
> >> as license information since it does not specify a license. Thus I
> >> assumed it to be GPL-2 as the other files which have no license
> >> boiler plate. I.e.: Check file is it has different license, if
> >> not, then assume it has license as specified in COPYING.
> >>
> >> Not specifying a license can however also mean in this context that
> >> it has no license as the file contains copyright information from
> >> another author.
> >
> > If a work (even one file) “has no license”, that means no special
> > permissions are granted and normal copyright applies: All rights
> > reserved, i.e. not redistributable. So, no license is grounds to
> > consider a work non-free and non-redistributable.
> >
> > If, on the other hand, the file is to be free software, there would
> > need to be a clear grant of some free software license to that
> > work.
> >
> > Given the confusion over this file, I would consider it a
> > significant
> > risk to just assume we have GPLv2 permissions without being told
> > that
> > explicitly by the copyright holder. Rather, the reason we are
> > seeking a clearly-granted free license for this one file, is
> > because we are trying to replace a probably non-free file with the
> > same code in it.
> >
> > It seems we need to keep looking, and in the meantime assume we have
> > no free license in this file.
>
> FWIW, fio.c includes the following mention:
>
>  * The license below covers all files distributed with fio unless
> otherwise * noted in the file itself.
>
> followed by the GPL v2 license. I'll go through and add SPDX headers
> to everything to avoid wasting anymore time on this nonsense.

Thank you, Jens, for settling this. I did not remember that one. It may
very well be that I have seen this note as I initially packaged fio as my
first package for Debian about 10 years ago.

I forwarded your mail and the one from Domenico with the SPDX patch to
Debian bug

#922112 fio: hash.h is not DFSG compliant
https://bugs.debian.org/922112

which I closed before as you told already that hash.c is GPL-2.

Thanks,
--
Martin

Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Martin Steigerwald
In reply to this post by Ben Finney-3
On 2/11/19 11:27 PM, Ben Finney wrote:
> Martin Steigerwald <[hidden email]> writes:
>
>> Well the file has in its header:
>>
>> /* Fast hashing routine for a long.
>>    (C) 2002 William Lee Irwin III, IBM */
>>
>> /*
>>  * Knuth recommends primes in approximately golden ratio to the
maximum
>>  * integer representable by a machine word for multiplicative
hashing.

>>  * Chuck Lever verified the effectiveness of this technique:
>>  * http://www.citi.umich.edu/techreports/reports/citi-tr-00-1.pdf
>>  *
>>  * These primes are chosen to be bit-sparse, that is operations on
>>  * them can use shifts and additions instead of multiplications for
>>  * machines where multiplications are slow.
>>  */
>>
>> It has been quite a while ago. I bet back then I did not regard this
>> as license information since it does not specify a license. Thus I
>> assumed it to be GPL-2 as the other files which have no license boiler
>> plate. I.e.: Check file is it has different license, if not, then
>> assume it has license as specified in COPYING.
>>
>> Not specifying a license can however also mean in this context that
it
>> has no license as the file contains copyright information from another
>> author.
>
> If a work (even one file) “has no license”, that means no special
> permissions are granted and normal copyright applies: All rights
> reserved, i.e. not redistributable. So, no license is grounds to
> consider a work non-free and non-redistributable.
>
> If, on the other hand, the file is to be free software, there would
need
> to be a clear grant of some free software license to that work.
>
> Given the confusion over this file, I would consider it a significant
> risk to just assume we have GPLv2 permissions without being told that
> explicitly by the copyright holder. Rather, the reason we are seeking
a
> clearly-granted free license for this one file, is because we are
trying
> to replace a probably non-free file with the same code in it.
>
> It seems we need to keep looking, and in the meantime assume we have
no
> free license in this file.

FWIW, fio.c includes the following mention:

 * The license below covers all files distributed with fio unless
otherwise
 * noted in the file itself.

followed by the GPL v2 license. I'll go through and add SPDX headers to
everything to avoid wasting anymore time on this nonsense.
 
--
Jens Axboe

Reply | Threaded
Open this post in threaded view
|

Bug#919356: Licensing of include/linux/hash.h

Ben Finney-3
In reply to this post by Domenico Andreoli-3
Jens Axboe <[hidden email]> writes:

> On 2/11/19 11:27 PM, Ben Finney wrote:
> > If, on the other hand, the file is to be free software, there would need
> > to be a clear grant of some free software license to that work.
>
> FWIW, fio.c includes the following mention:
>
>  * The license below covers all files distributed with fio unless otherwise
>  * noted in the file itself.
>
> followed by the GPL v2 license.

Great! That does appear to be a positive assertion from the copyright
holder, that we have a grant to use that work under GPLv2.

That written grant of license can be used in the Debian package to
demonstrate our license to the work.

> I'll go through and add SPDX headers to everything to avoid wasting
> anymore time on this nonsense.

Not necessary from my point of view for this specific case, because we
have the clear explicit grant of license. Don't let me stop you from
doing the good work of documenting more clearly :-)

--
 \       “Come on Milhouse, there’s no such thing as a soul! It’s just |
  `\      something they made up to scare kids, like the Boogie Man or |
_o__)                          Michael Jackson.” —Bart, _The Simpsons_ |
Ben Finney

Reply | Threaded
Open this post in threaded view
|

Bug#919356: marked as done (dwarves-dfsg: Copyright/licensing is unclear)

Debian Bug Tracking System
In reply to this post by Domenico Andreoli-3
Your message dated Wed, 27 Feb 2019 20:42:48 +0000
with message-id <[hidden email]>
and subject line Bug#919356: fixed in dwarves-dfsg 1.12-2
has caused the Debian Bug report #919356,
regarding dwarves-dfsg: Copyright/licensing is unclear
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
919356: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919356
Debian Bug Tracking System
Contact [hidden email] with problems

Package: dwarves-dfsg
Severity: grave

This file is without license info:

 - hash.h

These are also without copyright info:

 - btf_encoder.c
 - btf_encoder.h
 - ctf.h
 - libbtf.c
 - libbtf.h
 - libctf.c
 - libctf.h

Though the detailed analysis is not yet complete, it's clear that the
copyright/licensing situation does not satisfy DFSG.

--
3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

Source: dwarves-dfsg
Source-Version: 1.12-2

We believe that the bug you reported is fixed in the latest version of
dwarves-dfsg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Domenico Andreoli <[hidden email]> (supplier of updated dwarves-dfsg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 27 Feb 2019 18:09:08 +0100
Source: dwarves-dfsg
Architecture: source
Version: 1.12-2
Distribution: unstable
Urgency: medium
Maintainer: Thomas Girard <[hidden email]>
Changed-By: Domenico Andreoli <[hidden email]>
Closes: 919356
Changes:
 dwarves-dfsg (1.12-2) unstable; urgency=medium
 .
   * Convert to dh.
   * Fix Homepage and Vcs-Git.
   * Fix depends on debhelper >= 10.
   * Remove trailing spaces from the Debian changelog.
   * Update copyright to copyright-format/1.0. Closes: #919356.
Checksums-Sha1:
 0dd4a5af837c9e7d477936e3e0075ff836f00184 2001 dwarves-dfsg_1.12-2.dsc
 46e5e6106acfe96aab4de3128a59d2a47e8ee840 6108 dwarves-dfsg_1.12-2.debian.tar.xz
 8908efeca75fe568c674d15c05dcdd3f6327333e 6294 dwarves-dfsg_1.12-2_source.buildinfo
Checksums-Sha256:
 67b85bfd55df9018322989dd02aff1eb9eb8bc53b4ac7d6b321e80b8eee192ad 2001 dwarves-dfsg_1.12-2.dsc
 2a14264042956422a24c8b9e0f327c52626ce8d154c8cdde4e0bc14bebb26898 6108 dwarves-dfsg_1.12-2.debian.tar.xz
 368aea312c7d451b4751ba6ab3279d73eab1c1ed17b9b982bc7a2d56b900e5b7 6294 dwarves-dfsg_1.12-2_source.buildinfo
Files:
 45a1a5a2ab7c83d0612a3bd023bbdc70 2001 utils extra dwarves-dfsg_1.12-2.dsc
 320dcb7ba82f9c8e22ea859f9bd7946d 6108 utils extra dwarves-dfsg_1.12-2.debian.tar.xz
 388f21b95ed9665e5d813df9d30c9f46 6294 utils extra dwarves-dfsg_1.12-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAlx26UEACgkQweDZLphv
fH4bqxAAnMAz90FvaCgU19ttkbSVa/FBAXr3jBJ/zbp6UahpUr+JROgBteRPgUy1
caY0jb85QC4Q4masYxsbyj+a/Fd9TVHG48neIRwV9vpmAOUkt9gsy8mbG8W8FQ4N
uXdIuKa/38VxePf+D7kclaeL4EVC22huYH3AVKR9Q4MXQx//UqAaGeW/t4eDPco9
g2uZggvpaJwM6bpsoavIWgtbj9Zl7L6otlqD5ZrBKjK46bd5uWPSOO1l2iDLp1c0
ad0iCOKpdqXgt2Cbi4n87Zk4Ad005nG8Y4jzqMu/PpQoefOwOKhjRTKimX5ves+p
EZg1Wahzz0RtnK1ZFfMdZcJSTLjPkOKOfZNDhcppnpumBXS+nGbxTk/h2TM2F/w8
jUW8VtNaiWquNL3smfZ16OPku+SC0Mw652iNLOFRudyaOjOjsN9pHAbxwDZl8tjO
PtBQ4tP2HGFnHJx9JfHc/jJnLJvhqU0981JXf8O4d51PgxvXMYxkzuFeCdSQcrse
b01mG690GIHdSaR8j+AR9Kd6fA0nggsS7LNOoYp0c5rURVpV8w3A/9RLkyeXjXbp
AsHrXqEQUYBVUuz4SQxOYypvQG+JgWEk+QjKCX9RLUI1n9IDp/fW5u1y/DgK1bDA
5s7nGzoTTXki6zXwRQRczpbpAHiO3Opl3NQ2sDW+e0IMVTEERPE=
=xekJ
-----END PGP SIGNATURE-----

signature.asc (849 bytes) Download Attachment