Bug#921510: qutemol: segfaults at startup when compiled with GCC 8

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#921510: qutemol: segfaults at startup when compiled with GCC 8

Graham Inggs-3
Source: qutemol
Version: 0.4.1~cvs20081111-10
Tags: help

Qutemol terminates at startup with a segmentation fault when compiled
with GCC 8.

Reply | Threaded
Open this post in threaded view
|

Bug#921510: [Debichem-devel] Bug#921510: qutemol: segfaults at startup when compiled with GCC 8

Graham Inggs-3
Commenting out AOgpu2::init() avoids the problem with GCC 8 and so far
I haven't noticed any side-effects.

--- a/src/Common.cpp
+++ b/src/Common.cpp
@@ -1054,7 +1054,7 @@
   if (!shadowmap.init())     res|=ERRGL_NO_FBO_SHADOWMAP;
   if (!shadowmap.initHalo()) res|=ERRGL_NO_FBO_HALO;

-  if (! AOgpu2::init()) res|=ERRGL_NO_FBO_AO;
+//  if (! AOgpu2::init()) res|=ERRGL_NO_FBO_AO;

Reply | Threaded
Open this post in threaded view
|

Bug#921510: [Debichem-devel] Bug#921510: qutemol: segfaults at startup when compiled with GCC 8

Adrian Bunk-3
Control: tags -1 patch

On Wed, Feb 06, 2019 at 08:50:21PM +0200, Graham Inggs wrote:

> Commenting out AOgpu2::init() avoids the problem with GCC 8 and so far
> I haven't noticed any side-effects.
>
> --- a/src/Common.cpp
> +++ b/src/Common.cpp
> @@ -1054,7 +1054,7 @@
>    if (!shadowmap.init())     res|=ERRGL_NO_FBO_SHADOWMAP;
>    if (!shadowmap.initHalo()) res|=ERRGL_NO_FBO_HALO;
>
> -  if (! AOgpu2::init()) res|=ERRGL_NO_FBO_AO;
> +//  if (! AOgpu2::init()) res|=ERRGL_NO_FBO_AO;
With -Wall gcc even tells what the actual bug is:
  src/ShadowMap.cpp: In static member function 'static bool AOgpu2::init()':
  src/ShadowMap.cpp:250:25: warning: control reaches end of non-void function [-Wreturn-type]

Proper fix attached.

cu
Adrian

--

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


debdiff-qutemol (2K) Download Attachment