Bug#921558: marked as done (lsb-base: killproc does not pass name parameter to start-stop-daemon)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#921558: marked as done (lsb-base: killproc does not pass name parameter to start-stop-daemon)

Debian Bug Tracking System
Your message dated Wed, 13 Mar 2019 21:04:19 +0000
with message-id <[hidden email]>
and subject line Bug#921558: fixed in lsb 10.2019031300
has caused the Debian Bug report #921558,
regarding lsb-base: killproc does not pass name parameter to start-stop-daemon
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
921558: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921558
Debian Bug Tracking System
Contact [hidden email] with problems

Package: lsb-base
Version: 10.2018112800
Severity: serious

Hello,

there is a logic error in /lib/lsb/init-functions's killproc:

base=${1##*/}
    if [ ! $pidfile ]; then
        name_param="--name $base --pidfile /var/run/$base.pid"
    else
        name_param="--pidfile $pidfile"
    fi

The if clause checks for nonempty $pidfile instead of nonempty $base to
decide whether --name is used.

Also --pidfile $pidfile is always used, even when $pidfile is empty.

I am reportig this as serious since sid's start-stop-daemon requires a
name parameter in addition to --pidfile when the pidfile is not owned by
root, therefore this bug causes init script failures. (#921205)

cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

Source: lsb
Source-Version: 10.2019031300

We believe that the bug you reported is fixed in the latest version of
lsb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <[hidden email]> (supplier of updated lsb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 13 Mar 2019 21:42:26 +0100
Source: lsb
Architecture: source
Version: 10.2019031300
Distribution: unstable
Urgency: low
Maintainer: Debian LSB Team <[hidden email]>
Changed-By: Didier Raboud <[hidden email]>
Closes: 921558
Changes:
 lsb (10.2019031300) unstable; urgency=low
 .
   [ Dmitry Bogatov ]
   * init-functions: in killproc, pass '--name' to start-stop-daemon
     (Closes: #921558)
Checksums-Sha1:
 ba44df4600d285880f68e50cb271e324c42ce3c7 1695 lsb_10.2019031300.dsc
 1635aec3dc49e88e6f0761bdfbcd1b32946762d0 42132 lsb_10.2019031300.tar.xz
Checksums-Sha256:
 7b71ba5ea22d9d650d4066aeff92f63b2795e02b2b23b8f2ad4328b02a67e646 1695 lsb_10.2019031300.dsc
 a956c45c7e0830b9c9a17407ed91c3373972493cead42b9c4dc53a8619a3898a 42132 lsb_10.2019031300.tar.xz
Files:
 523af3064863251feef1391e2aad0744 1695 misc extra lsb_10.2019031300.dsc
 c19e974983e70abcb128ed03999023b7 42132 misc extra lsb_10.2019031300.tar.xz

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEe+WPIRpjNw1/GSB7i8+nHsoWNFUFAlyJbCUACgkQi8+nHsoW
NFWwaQv/VT0mLI+9BRMz5WL7idk11YSzBQj7msbocPUFF0u9L/wj8lk1FFUgaXeV
SlszkjmT6snzjR1RjvTdlVIe7YosXHu73u3fsq+WsvV3DRU7anx3sL+rRCTmh1Hk
g360mPzwmNvfDgHYuymnESEbV96qSCWhcmiBwKuta3QnBDcBYrJUbeLGDkXsLmuB
r0T6gNSel5Nmwn+yX+e7kR1Vv6o0X31fa0O/HVg2Fi+Nf9Z8VA9NP3GN2QqlXV7L
vYEY0w1gMROy1om88Ixkcszdeew19K2rnSb3beWQ93fYZsErvjv5W1gjGtl68GV6
pg/q/k20ybHhrjsoMS7XgsmiC1IIkcfXmWodcWrqyoaYLOfgfxjxvU8D82X3+Njd
nnp43nTjy4JijoYikKqMT+diFzTan3OxiurMq6vQ0CQ5oo3PbHS6eafW8m3fbENs
MibXktv3S9nkqiLCUcV+/n+Q5zEM3WmhAd6Gt6kTFrvP4pGm5bDhI47RgY3U1EX5
F1IPmL4L
=xeQT
-----END PGP SIGNATURE-----