Bug#921598: No METAR available since noaa.gov switched to https

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#921598: No METAR available since noaa.gov switched to https

Gabriel F. T. Gomes-2
Package: flightgear
Version: 1:2018.3.2+dfsg-2

Dear maintainers,

Very recently, noaa.gov switched to https, which makes flightgear unable
to download METAR data, thus unable to provide 'live' weather conditions
for the simulation.

I have created a merge request on salsa [1] with a possible, albeit not
ideal, solution to the problem.  Since this is about a hardcoded URL in
the source, which might potentially require rebuilds, and since we are
close to the freeze for buster, I decided to share this with you sooner
than later, so that you have more time to evaluate.

(as noted in the merge request, the flightgear forum has suggestions of
fixes that do not require a rebuild, but I haven't checked that they
actually work.  I did check that the merge request fixes the problem)

[1] https://salsa.debian.org/debian/flightgear/merge_requests/1

Reply | Threaded
Open this post in threaded view
|

Bug#921598: No METAR available since noaa.gov switched to https

Gabriel F. T. Gomes-4
I updated the merge request.

When I first wrote the merge request, upstream did not have a fix for
the METAR problem.  Now they do [1].  So, I removed the simple patch I
wrote, and replaced it with this upstream fix.

Would you consider this for buster?
(otherwise, live weather won't work)

[1] https://sourceforge.net/p/flightgear/flightgear/ci/2fdc24c1097955c5d2c88a9cc0be66069b22eebe/

Reply | Threaded
Open this post in threaded view
|

Bug#921598: No METAR available since noaa.gov switched to https

Florent Rougon
Hello,

"Gabriel F. T. Gomes" <[hidden email]> wrote:

> I updated the merge request.
>
> When I first wrote the merge request, upstream did not have a fix for
> the METAR problem.  Now they do [1].  So, I removed the simple patch I
> wrote, and replaced it with this upstream fix.

(...)

> [1]
> https://sourceforge.net/p/flightgear/flightgear/ci/2fdc24c1097955c5d2c88a9cc0be66069b22eebe/

As has been discussed on flightgear-devel and despite the commit
message, commit [1] is not a proper fix and will probably be reverted (I
mean, the "if( responseCode() >= 400 )" part, not the http to https URL
change which is okay though unnecessary now that redirection is fixed in
SimGear's HTTP::Client).

The correct fix is [a]. [b] is also a bug fix in this area, but doesn't
solve the particular METAR fetching problem.

[a] https://sourceforge.net/p/flightgear/simgear/ci/34b3c52a288d62779073fc7694344d0658755645/
[b] https://sourceforge.net/p/flightgear/simgear/ci/6197098541eceecdb0dcfe8a58b15f0d0773c391/

--
Florent

Reply | Threaded
Open this post in threaded view
|

Bug#921598: No METAR available since noaa.gov switched to https

Gabriel F. T. Gomes-2
On Sat, Feb 16 2019, Florent Rougon wrote:
>
> As has been discussed on flightgear-devel and despite the commit
> message, commit [1] is not a proper fix and will probably be reverted (I
> mean, the "if( responseCode() >= 400 )" part, not the http to https URL
> change which is okay though unnecessary now that redirection is fixed in
> SimGear's HTTP::Client).

OK, thanks for the clarification.

> The correct fix is [a]. [b] is also a bug fix in this area, but doesn't
> solve the particular METAR fetching problem.
>
> [a] https://sourceforge.net/p/flightgear/simgear/ci/34b3c52a288d62779073fc7694344d0658755645/
> [b] https://sourceforge.net/p/flightgear/simgear/ci/6197098541eceecdb0dcfe8a58b15f0d0773c391/

I'll close the merge request.

Thanks,
Gabriel

Reply | Threaded
Open this post in threaded view
|

Bug#921598: No METAR available since noaa.gov switched to https

Dr. Tobias Quathamer
Am 16.02.2019 um 17:18 schrieb Gabriel F. T. Gomes:

> On Sat, Feb 16 2019, Florent Rougon wrote:
>>
>> As has been discussed on flightgear-devel and despite the commit
>> message, commit [1] is not a proper fix and will probably be reverted (I
>> mean, the "if( responseCode() >= 400 )" part, not the http to https URL
>> change which is okay though unnecessary now that redirection is fixed in
>> SimGear's HTTP::Client).
>
> OK, thanks for the clarification.
>
>> The correct fix is [a]. [b] is also a bug fix in this area, but doesn't
>> solve the particular METAR fetching problem.
>>
>> [a] https://sourceforge.net/p/flightgear/simgear/ci/34b3c52a288d62779073fc7694344d0658755645/
>> [b] https://sourceforge.net/p/flightgear/simgear/ci/6197098541eceecdb0dcfe8a58b15f0d0773c391/
>
> I'll close the merge request.
Hi Gabriel and Florent,

thanks for reporting this bug and pointing to the commits! I'm currently
preparing a new upload of simgear which should still be in time for buster.

Regards,
Tobias


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#921598: No METAR available since noaa.gov switched to https

Florent Rougon
Hi again Gabriel, hi Tobias,

"Dr. Tobias Quathamer" <[hidden email]> wrote:

> Hi Gabriel and Florent,
>
> thanks for reporting this bug and pointing to the commits! I'm currently
> preparing a new upload of simgear which should still be in time for buster.

The partial revert I foresaw has happened. :)

  https://sourceforge.net/p/flightgear/flightgear/ci/c2fb01ccb7df6fc893ab79850654cb39153cea3d/

Regards

--
Florent

Reply | Threaded
Open this post in threaded view
|

Bug#921598: fixed in simgear 1:2018.3.2+dfsg-5

Gabriel F. T. Gomes-4
In reply to this post by Gabriel F. T. Gomes-2
On Sun, 17 Feb 2019 20:54:34 +0000 [hidden email] (Dr. Tobias Quathamer) wrote:
> Source: simgear
> Source-Version: 1:2018.3.2+dfsg-5
>
> We believe that the bug you reported is fixed in the latest version of
> simgear, which is due to be installed in the Debian FTP archive.

Thanks for this simgear fix.

I tested that rebuilding flightgear with this dependency updated solves
the METAR problem.  Do you plan to upload a new binary version of
flightgear, too?  (I'm asking because the flightgear package currently
on the archives still has the problem (probably because it needs to be
rebuilt - should a rebuild happen automatically?)).

Reply | Threaded
Open this post in threaded view
|

Bug#921598: fixed in simgear 1:2018.3.2+dfsg-5

Gabriel F. T. Gomes-4
In reply to this post by Gabriel F. T. Gomes-2
On Wed, 20 Feb 2019 00:53:18 -0300 "Gabriel F. T. Gomes" <[hidden email]> wrote:
>
> I tested that rebuilding flightgear with this dependency updated solves
> the METAR problem.  Do you plan to upload a new binary version of
> flightgear, too?  (I'm asking because the flightgear package currently
> on the archives still has the problem (probably because it needs to be
> rebuilt - should a rebuild happen automatically?)).

I learned about binNMUs (thanks tarpman@OFTC) and I learned that such
rebuilds are not automatically triggered, but must be manually request
via a bug report against the release.debian.org package.

I have created such request as https://bugs.debian.org/923005

I think I got it right, but I'll check once the build is done and if
you could also check that it fixes the problem for yourselves, that
would be good.

Thanks,
Gabriel