Bug#921962: Please remove obsolete 'xm' completion file

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Hans van Kranenburg-3
Package: bash-completion
Version: 1:2.8-5

Hi bash completion maintainer,

Please remove the 'xm' file from the bash-completion package. This
command does not exist in Xen any more (last time it was relevant was in
Jessie, where it was already deprecated).

Also, I just hijacked another of your bugs, 768005 , about the xl
command completion. Hope that's fine, we can maintain this in the Xen
packaging and upstream improvements.

Thanks a lot for taking care of it up until now!

Hans van Kranenburg

Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Gabriel F. T. Gomes-2
On Sun, Feb 10 2019, Hans van Kranenburg wrote:
>
> Please remove the 'xm' file from the bash-completion package. This
> command does not exist in Xen any more (last time it was relevant was in
> Jessie, where it was already deprecated).

That should be easy to do for Debian.  On the other hand, I wonder if I
should work first with upstream to get it removed from there.  Do you
know if the deprecation of xm is debian-specific?  Or has it been
deprecated and removed by the xen project?

> Also, I just hijacked another of your bugs, 768005 , about the xl
> command completion. Hope that's fine, we can maintain this in the Xen
> packaging and upstream improvements.

Thanks for doing this.  That's the ideal situation (from an upstream
bash-completion point-of-view, anyway [1]).

[1] https://github.com/scop/bash-completion/pull/276#issuecomment-456558772

Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Hans van Kranenburg-3
On 2/12/19 1:35 AM, Gabriel F. T. Gomes wrote:

> On Sun, Feb 10 2019, Hans van Kranenburg wrote:
>>
>> Please remove the 'xm' file from the bash-completion package. This
>> command does not exist in Xen any more (last time it was relevant was in
>> Jessie, where it was already deprecated).
>
> That should be easy to do for Debian.  On the other hand, I wonder if I
> should work first with upstream to get it removed from there.  Do you
> know if the deprecation of xm is debian-specific?  Or has it been
> deprecated and removed by the xen project?

There is no xm bash completion upstream any more.

Also, quoting upstream wiki about this:

https://wiki.xen.org/wiki/Choice_of_Toolstacks

"Deprecated in Xen 4.1; Removed in 4.5"

Stretch has Xen 4.8, Buster will have at least Xen 4.11.

So, there's really no reason to just throw this xm file into the
wastebin asap. :)

>> Also, I just hijacked another of your bugs, 768005 , about the xl
>> command completion. Hope that's fine, we can maintain this in the Xen
>> packaging and upstream improvements.
>
> Thanks for doing this.  That's the ideal situation (from an upstream
> bash-completion point-of-view, anyway [1]).

HTH (as.. Happy To Help!),

K

>
> [1] https://github.com/scop/bash-completion/pull/276#issuecomment-456558772

Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Hans van Kranenburg-3
On 2/12/19 1:59 AM, Hans van Kranenburg wrote:

> On 2/12/19 1:35 AM, Gabriel F. T. Gomes wrote:
>> On Sun, Feb 10 2019, Hans van Kranenburg wrote:
>>>
>>> Please remove the 'xm' file from the bash-completion package. This
>>> command does not exist in Xen any more (last time it was relevant was in
>>> Jessie, where it was already deprecated).
>>
>> That should be easy to do for Debian.  On the other hand, I wonder if I
>> should work first with upstream to get it removed from there.  Do you
>> know if the deprecation of xm is debian-specific?  Or has it been
>> deprecated and removed by the xen project?
>
> There is no xm bash completion upstream any more.
>
> Also, quoting upstream wiki about this:
>
> https://wiki.xen.org/wiki/Choice_of_Toolstacks
>
> "Deprecated in Xen 4.1; Removed in 4.5"
>
> Stretch has Xen 4.8, Buster will have at least Xen 4.11.
>
> So, there's really no reason to just throw this xm file into the
> wastebin asap. :)

*cough* .. to not do that...

>
>>> Also, I just hijacked another of your bugs, 768005 , about the xl
>>> command completion. Hope that's fine, we can maintain this in the Xen
>>> packaging and upstream improvements.
>>
>> Thanks for doing this.  That's the ideal situation (from an upstream
>> bash-completion point-of-view, anyway [1]).
>
> HTH (as.. Happy To Help!),
>
> K
>
>>
>> [1] https://github.com/scop/bash-completion/pull/276#issuecomment-456558772
>

Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Gabriel F. T. Gomes-2
In reply to this post by Hans van Kranenburg-3
On Tue, Feb 12 2019, Hans van Kranenburg wrote:

> On 2/12/19 1:35 AM, Gabriel F. T. Gomes wrote:
> >
> > That should be easy to do for Debian.  On the other hand, I wonder if I
> > should work first with upstream to get it removed from there.  Do you
> > know if the deprecation of xm is debian-specific?  Or has it been
> > deprecated and removed by the xen project?
>
> There is no xm bash completion upstream any more.
>
> Also, quoting upstream wiki about this:
>
> https://wiki.xen.org/wiki/Choice_of_Toolstacks
>
> "Deprecated in Xen 4.1; Removed in 4.5"

Thanks for the information.  I have forwarded this upstream as
https://github.com/scop/bash-completion/pull/284

> Stretch has Xen 4.8, Buster will have at least Xen 4.11.
>
> So, there's really no reason to just throw this xm file into the
> wastebin asap. :)

I see.  It would be easier, from a maintenance perspective, to wait for
the upstream patch to be accepted, then released in bash-completion 2.9,
then updated in Debian, instead of backporting this specific fix.

It is my understanding that having the completion for the unavailable
command is not so harmful, and that we could ship it with buster, even
though it is useless.  Not ideal, but easier for maintenance.  Would
that be OK for you, or is it causing more trouble than I can actually
see (I don't use Xen, so I don't know).

Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Hans van Kranenburg-3
Hi Gabriel,

On 2/23/19 2:52 PM, Gabriel F. T. Gomes wrote:

> On Tue, Feb 12 2019, Hans van Kranenburg wrote:
>> On 2/12/19 1:35 AM, Gabriel F. T. Gomes wrote:
>>>
>>> That should be easy to do for Debian.  On the other hand, I wonder if I
>>> should work first with upstream to get it removed from there.  Do you
>>> know if the deprecation of xm is debian-specific?  Or has it been
>>> deprecated and removed by the xen project?
>>
>> There is no xm bash completion upstream any more.
>>
>> Also, quoting upstream wiki about this:
>>
>> https://wiki.xen.org/wiki/Choice_of_Toolstacks
>>
>> "Deprecated in Xen 4.1; Removed in 4.5"
>
> Thanks for the information.  I have forwarded this upstream as
> https://github.com/scop/bash-completion/pull/284

Aha, thanks.

>> Stretch has Xen 4.8, Buster will have at least Xen 4.11.
>>
>> So, there's really no reason to just throw this xm file into the
>> wastebin asap. :)
>
> I see.  It would be easier, from a maintenance perspective, to wait for
> the upstream patch to be accepted, then released in bash-completion 2.9,
> then updated in Debian, instead of backporting this specific fix.
>
> It is my understanding that having the completion for the unavailable
> command is not so harmful, and that we could ship it with buster, even
> though it is useless.  Not ideal, but easier for maintenance.  Would
> that be OK for you, or is it causing more trouble than I can actually
> see (I don't use Xen, so I don't know).

Yes, it will just be sitting there, doing nothing. I can't think of any
way it would be causing trouble.

So if you prefer that, I think that's totally fine.

Hans

Reply | Threaded
Open this post in threaded view
|

Bug#921962: Please remove obsolete 'xm' completion file

Gabriel F. T. Gomes-4
In reply to this post by Hans van Kranenburg-3
On Sat, 23 Feb 2019 10:52:43 -0300 "Gabriel F. T. Gomes" <[hidden email]> wrote:
>
> Thanks for the information.  I have forwarded this upstream as
> https://github.com/scop/bash-completion/pull/284

This has been integrated into bash-completion 2.9, which is now
available in Debian unstable as 1:2.9-1 (not migrating to Debian
testing because I still need to do a source-only upload... I'll do it
when I have more fixes to upload, as suggested in the Q&A in the
announcement of Debian Buster release [1])

[1] https://lists.debian.org/debian-devel-announce/2019/07/msg00002.html