Bug#923871: acpid: support for runit init system

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#923871: acpid: support for runit init system

Dmitry Bogatov-3

Package: acpid
Version: 1:2.0.31-1
Severity: wishlist
Tags: patch
User: [hidden email]
Usertags: runscript

Dear Maintainer,

please consider including support for Runit initialization system. Patch
attached. This patch is /not/ to be included into Buster, it introduces
build dependency on version of `dh-runit' that is in experimental.

Also, I modelled runscript after systemd unit file. Init.d script in
addition loads kernel modules. What is the reason for such mismatch?
Is systemd unit file is incomplete or modules loading is no longer
needed in init script?

From 2d7140fca54f2d54edeacf4dce6ce10d49d501e7 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <[hidden email]>
Date: Sun, 24 Feb 2019 21:33:40 +0000
Subject: [PATCH] Add native runit script

---
 debian/acpid.runit     | 1 +
 debian/acpid.runscript | 5 +++++
 debian/control         | 3 ++-
 debian/rules           | 2 +-
 4 files changed, 9 insertions(+), 2 deletions(-)
 create mode 100644 debian/acpid.runit
 create mode 100644 debian/acpid.runscript

diff --git a/debian/acpid.runit b/debian/acpid.runit
new file mode 100644
index 0000000..d9c6b54
--- /dev/null
+++ b/debian/acpid.runit
@@ -0,0 +1 @@
+debian/acpid.runscript logscript,name=acpid,since=1:2.0.31-2
diff --git a/debian/acpid.runscript b/debian/acpid.runscript
new file mode 100644
index 0000000..d74e0db
--- /dev/null
+++ b/debian/acpid.runscript
@@ -0,0 +1,5 @@
+#!/usr/bin/env /lib/runit/invoke-run
+exec 2>&1
+exec /usr/bin/env -i /usr/sbin/acpid --foreground ${OPTIONS:-}
+
+# vim: ft=sh
diff --git a/debian/control b/debian/control
index 8201366..d45a33a 100644
--- a/debian/control
+++ b/debian/control
@@ -5,13 +5,14 @@ Maintainer: Debian Acpi Team <[hidden email]>
 Uploaders: Michael Meskes <[hidden email]>,
            Loic Minier <[hidden email]>
 Standards-Version: 4.2.1
-Build-Depends: debhelper (>= 11), dpkg-dev (>= 1.15.7)
+Build-Depends: debhelper (>= 11), dpkg-dev (>= 1.15.7), dh-runit (>= 2.8.8)
 Vcs-Git: https://salsa.debian.org/debian/acpid.git
 Vcs-Browser: https://salsa.debian.org/debian/acpid
 Homepage: http://sourceforge.net/projects/acpid2/
 
 Package: acpid
 Architecture: linux-any
+Breaks: ${runit:Breaks}
 Depends: ${shlibs:Depends},
          ${misc:Depends},
          lsb-base (>= 3.2-14),
diff --git a/debian/rules b/debian/rules
index 7df4ff4..cbff7af 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,7 +6,7 @@ export DEB_CFLAGS_MAINT_PREPEND = -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURC
 export DEB_CFLAGS_MAINT_APPEND = -fno-strict-aliasing
 
 %:
- dh ${@}
+ dh ${@} --with runit
 
 override_dh_installsystemd:
  dh_installsystemd --no-enable --name=acpid

attachment0 (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#923871: acpid: please provide runscript file

Dmitry Bogatov-3

control: retitle -1 acpid: please provide runscript file -- second call

Hello, dear maintainer.

This bug, requesting addition of runscript file into package was filed
some time ago, and got no response. It is quite unfortunate, since
your review of could have provided valuable advice how to improve
proposed patch.

But, after all, we all volonteers here. So hereby I inform you,
following advice in Developer reference, section 5.11, that I plan to
do non-maintainer upload in two weeks or so.

Upload will be into DELAYED/15, so you still have plenty of time
to make comments and take action.

Thank you for your work on Debian.

Best regards.

Reply | Threaded
Open this post in threaded view
|

Bug#923871: [Pkg-acpi-devel] Bug#923871: acpid: please provide runscript file

Dmitry Bogatov-3
In reply to this post by Dmitry Bogatov-3

[ You replied in private, I took liberty to put BTS back into CC ]

[2019-06-17 11:03] Michael Meskes <[hidden email]>

> Dmitry,
>
> > But, after all, we all volonteers here. So hereby I inform you,
> > following advice in Developer reference, section 5.11, that I plan to
> > do non-maintainer upload in two weeks or so.
> >
> > Upload will be into DELAYED/15, so you still have plenty of time
> > to make comments and take action.
>
> Feel free to upload directly, or if you want, fully take over the
> package. As it stands the package is essentially orphaned as I have
> neither the time not the usage for it anymore. I was thinking of
> officially orphaning it after the release.

Thank you for your response.

If you are positive on orphaning package, probably filing Orphan bug
right now would simplify some things: my upload would additionally
reassign maintenance to QA group.

I think it is very important for orphaned packages have QA group as
maintainer, otherwise it could scare away prospective new maintainer.
--
Note, that I send and fetch email in batch, once in a few days.

Reply | Threaded
Open this post in threaded view
|

Bug#923871: [Pkg-acpi-devel] Bug#923871: acpid: please provide runscript file

Michael Meskes
In reply to this post by Dmitry Bogatov-3
On Fri, 2019-06-21 at 10:17 +0000, Dmitry Bogatov wrote:
> [ You replied in private, I took liberty to put BTS back into CC ]

And what or who gave you the right to put my private comments into the
public BTS? At the very least this is very rude, especially given that
you did it on purpose.

> > Feel free to upload directly, or if you want, fully take over the
> > package. As it stands the package is essentially orphaned as I have
> > neither the time not the usage for it anymore. I was thinking of
> > officially orphaning it after the release.
>
> Thank you for your response.
>
> If you are positive on orphaning package, probably filing Orphan bug
> right now would simplify some things: my upload would additionally
> reassign maintenance to QA group.

Please read what I wrote. There is a reason why I want to do this
*after* the release.

> I think it is very important for orphaned packages have QA group as
> maintainer, otherwise it could scare away prospective new maintainer.

Thanks for the lecture.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL

Reply | Threaded
Open this post in threaded view
|

Bug#923871: [Pkg-acpi-devel] Bug#923871: acpid: please provide runscript file

Dmitry Bogatov-3

[2019-06-21 20:02] Michael Meskes <[hidden email]>
> On Fri, 2019-06-21 at 10:17 +0000, Dmitry Bogatov wrote:
> > [ You replied in private, I took liberty to put BTS back into CC ]
>
> And what or who gave you the right to put my private comments into the
> public BTS? At the very least this is very rude, especially given that
> you did it on purpose.

I apologize. I thought it wasn't deliberate decision to drop BTS.

Sometimes I forget to put bug into thread, and it causes troubles, but I
have never had problems with my Debian-related messages being public --
they all are intended to. Sure, I should have erred on side of your
privacy. Sorry.
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.