Bug#924290: [rfc] information about EFI partitions

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Vincent McIntyre-4
Package: installation-guide
Version: 20180930
Severity: wishlist
Tags: patch

Hi

recently I was learning about presseding UEFI installs and
I think the install guide could use a small addition to make
that journey easier. I also sent a patch to partman-auto-recipe.txt
but I am sure the readership of that is much less than the d-i manual.

Kind regards
Vince

0001-Add-some-information-about-preseeding-EFI-partitions.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Holger Wansing-4
Hi,

<[hidden email]> wrote:

> Package: installation-guide
> Version: 20180930
> Severity: wishlist
> Tags: patch
>
> Hi
>
> recently I was learning about presseding UEFI installs and
> I think the install guide could use a small addition to make
> that journey easier. I also sent a patch to partman-auto-recipe.txt
> but I am sure the readership of that is much less than the d-i manual.

I am unable to proof the patch correct or not, could anyone comment on that?



From 4697c54b3f61bc145980f52206bb20e2280c0a63 Mon Sep 17 00:00:00 2001
From: Vincent McIntyre <[hidden email]>
Date: Mon, 11 Mar 2019 15:38:19 +1100
Subject: [RFC PATCH] Add some information about preseeding EFI partitions

---
 en/appendix/preseed.xml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/en/appendix/preseed.xml b/en/appendix/preseed.xml
index c55860e34..9e334738a 100644
--- a/en/appendix/preseed.xml
+++ b/en/appendix/preseed.xml
@@ -1211,6 +1211,20 @@ d-i partman-auto/choose_recipe select atomic
 # system labels, volume group names and which physical devices to include
 # in a volume group.
 
+## Partitioning for EFI
+# If your system needs an EFI partition you could add something like
+# this to the recipe above, as the first element in the recipe:
+#               538 538 1075 free                              \
+#                      $iflabel{ gpt }                         \
+#                      $reusemethod{ }                         \
+#                      method{ efi }                           \
+#                      format{ }                               \
+#               .                                              \
+#
+# The fragment above is for the amd64 architecture; the details may be
+# different on other architectures. The 'partman-auto' package in the
+# D-I source repository may have an example you can follow.
+
 # This makes partman automatically partition without confirmation, provided
 # that you told it what to do using one of the methods above.
 d-i partman-partitioning/confirm_write_new_label boolean true
@@ -1218,6 +1232,9 @@ d-i partman/choose_partition select finish
 d-i partman/confirm boolean true
 d-i partman/confirm_nooverwrite boolean true
 
+# Force UEFI booting ('BIOS compatibility' will be lost). Default: false.
+#d-i partman-efi/non_efi_system boolean true
+
 # When disk encryption is enabled, skip wiping the partitions beforehand.
 #d-i partman-auto-crypto/erase_disks boolean false
 </screen></informalexample>
--
2.11.0



--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Vincent McIntyre-4
On Sun, May 17, 2020 at 02:34:47PM +0200, Holger Wansing wrote:

>Hi,
>
><[hidden email]> wrote:
>> Package: installation-guide
>> Version: 20180930
>> Severity: wishlist
>> Tags: patch
>>
>> Hi
>>
>> recently I was learning about presseding UEFI installs and
>> I think the install guide could use a small addition to make
>> that journey easier. I also sent a patch to partman-auto-recipe.txt
>> but I am sure the readership of that is much less than the d-i manual.
>
>I am unable to proof the patch correct or not, could anyone comment on that?

All I can say is It Works For Us, on plenty of amd64 installs
over the last year. The patch has evolved a little since then,
inline below. Please let me know if you'd rather a MR.

Vince


diff --git a/en/appendix/preseed.xml b/en/appendix/preseed.xml
index d7570d6b3..817749bb9 100644
--- a/en/appendix/preseed.xml
+++ b/en/appendix/preseed.xml
@@ -1206,6 +1211,20 @@ d-i partman-auto/choose_recipe select atomic
 # system labels, volume group names and which physical devices to include
 # in a volume group.

+## Partitioning for EFI
+# If your system needs an EFI partition you could add something like
+# this to the recipe above, as the first element in the recipe:
+#               538 538 1075 free                              \
+#                      $iflabel{ gpt }                         \
+#                      $reusemethod{ }                         \
+#                      method{ efi }                           \
+#                      format{ }                               \
+#               .                                              \
+#
+# The fragment above is for the amd64 architecture; the details may be
+# different on other architectures. The 'partman-auto' package in the
+# D-I source repository may have an example you can follow.
+
 # This makes partman automatically partition without confirmation, provided
 # that you told it what to do using one of the methods above.
 d-i partman-partitioning/confirm_write_new_label boolean true
@@ -1213,6 +1232,16 @@ d-i partman/choose_partition select finish
 d-i partman/confirm boolean true
 d-i partman/confirm_nooverwrite boolean true

+# Force UEFI booting ('BIOS compatibility' will be lost). Default: false.
+#d-i partman-efi/non_efi_system boolean true
+# Ensure the partition table is GPT - this is required for EFI
+#d-i partman-basicfilesystems/choose_label string gpt
+#d-i partman-basicfilesystems/default_label string gpt
+#d-i partman-partitioning/choose_label string gpt
+#d-i partman-partitioning/default_label string gpt
+#d-i partman/choose_label string gpt
+#d-i partman/default_label string gpt
+
 # When disk encryption is enabled, skip wiping the partitions beforehand.
 #d-i partman-auto-crypto/erase_disks boolean false
 </screen></informalexample>
Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Holger Wansing-4
Hi,

"McIntyre, Vincent (CASS, Marsfield)" <[hidden email]> wrote:

> diff --git a/en/appendix/preseed.xml b/en/appendix/preseed.xml
> index d7570d6b3..817749bb9 100644
> --- a/en/appendix/preseed.xml
> +++ b/en/appendix/preseed.xml
> @@ -1206,6 +1211,20 @@ d-i partman-auto/choose_recipe select atomic
>  # system labels, volume group names and which physical devices to include
>  # in a volume group.
>
> +## Partitioning for EFI
> +# If your system needs an EFI partition you could add something like
> +# this to the recipe above, as the first element in the recipe:
> +#               538 538 1075 free                              \
> +#                      $iflabel{ gpt }                         \
> +#                      $reusemethod{ }                         \
> +#                      method{ efi }                           \
> +#                      format{ }                               \
> +#               .                                              \
> +#
> +# The fragment above is for the amd64 architecture; the details may be
> +# different on other architectures. The 'partman-auto' package in the
> +# D-I source repository may have an example you can follow.
> +
>  # This makes partman automatically partition without confirmation, provided
>  # that you told it what to do using one of the methods above.
>  d-i partman-partitioning/confirm_write_new_label boolean true
> @@ -1213,6 +1232,16 @@ d-i partman/choose_partition select finish
>  d-i partman/confirm boolean true
>  d-i partman/confirm_nooverwrite boolean true
>
> +# Force UEFI booting ('BIOS compatibility' will be lost). Default: false.
> +#d-i partman-efi/non_efi_system boolean true
> +# Ensure the partition table is GPT - this is required for EFI
> +#d-i partman-basicfilesystems/choose_label string gpt
> +#d-i partman-basicfilesystems/default_label string gpt
> +#d-i partman-partitioning/choose_label string gpt
> +#d-i partman-partitioning/default_label string gpt
> +#d-i partman/choose_label string gpt
> +#d-i partman/default_label string gpt

I might wonder why this is needed: to set the same setting in three different
packages...
However there seem to be a reason for this?

If noone objects, I will apply this patch soon...


Holger


> +
>  # When disk encryption is enabled, skip wiping the partitions beforehand.
>  #d-i partman-auto-crypto/erase_disks boolean false
>  </screen></informalexample>


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Vincent McIntyre-4
On Fri, May 29, 2020 at 11:29:17PM +0200, Holger Wansing wrote:

>Hi,
>
>"McIntyre, Vincent (CASS, Marsfield)" <[hidden email]> wrote:
>> diff --git a/en/appendix/preseed.xml b/en/appendix/preseed.xml
>> index d7570d6b3..817749bb9 100644
>> --- a/en/appendix/preseed.xml
>> +++ b/en/appendix/preseed.xml
>> @@ -1206,6 +1211,20 @@ d-i partman-auto/choose_recipe select atomic
>>  # system labels, volume group names and which physical devices to include
>>  # in a volume group.
>>
>> +## Partitioning for EFI
>> +# If your system needs an EFI partition you could add something like
>> +# this to the recipe above, as the first element in the recipe:
>> +#               538 538 1075 free                              \
>> +#                      $iflabel{ gpt }                         \
>> +#                      $reusemethod{ }                         \
>> +#                      method{ efi }                           \
>> +#                      format{ }                               \
>> +#               .                                              \
>> +#
>> +# The fragment above is for the amd64 architecture; the details may be
>> +# different on other architectures. The 'partman-auto' package in the
>> +# D-I source repository may have an example you can follow.
>> +
>>  # This makes partman automatically partition without confirmation, provided
>>  # that you told it what to do using one of the methods above.
>>  d-i partman-partitioning/confirm_write_new_label boolean true
>> @@ -1213,6 +1232,16 @@ d-i partman/choose_partition select finish
>>  d-i partman/confirm boolean true
>>  d-i partman/confirm_nooverwrite boolean true
>>
>> +# Force UEFI booting ('BIOS compatibility' will be lost). Default: false.
>> +#d-i partman-efi/non_efi_system boolean true
>> +# Ensure the partition table is GPT - this is required for EFI
>> +#d-i partman-basicfilesystems/choose_label string gpt
>> +#d-i partman-basicfilesystems/default_label string gpt
>> +#d-i partman-partitioning/choose_label string gpt
>> +#d-i partman-partitioning/default_label string gpt
>> +#d-i partman/choose_label string gpt
>> +#d-i partman/default_label string gpt
>
>I might wonder why this is needed: to set the same setting in three different
>packages...
>However there seem to be a reason for this?
>

I went back and double-checked (this _was_ marked RFC...).
The partman/ questions don't appear to exist, doh! Sorry about that.

partman-basicfilesystems/{choose,default}_label
  refer to a +filesystem+ label, tsk. So shouldn't be needed either.

partman-partitioning/default_label
  has a platform-specific default that also depends on the disk size
  (packages/partman-partitioning/lib/disk-label.sh)

Revised patch below. I'll test it on amd64 and let you know
if it works.

Regards
Vince

diff --git a/en/appendix/preseed.xml b/en/appendix/preseed.xml
index d7570d6b3..9757883b3 100644
--- a/en/appendix/preseed.xml
+++ b/en/appendix/preseed.xml
@@ -1206,6 +1211,20 @@ d-i partman-auto/choose_recipe select atomic
 # system labels, volume group names and which physical devices to include
 # in a volume group.
 
+## Partitioning for EFI
+# If your system needs an EFI partition you could add something like
+# this to the recipe above, as the first element in the recipe:
+#               538 538 1075 free                              \
+#                      $iflabel{ gpt }                         \
+#                      $reusemethod{ }                         \
+#                      method{ efi }                           \
+#                      format{ }                               \
+#               .                                              \
+#
+# The fragment above is for the amd64 architecture; the details may be
+# different on other architectures. The 'partman-auto' package in the
+# D-I source repository may have an example you can follow.
+
 # This makes partman automatically partition without confirmation, provided
 # that you told it what to do using one of the methods above.
 d-i partman-partitioning/confirm_write_new_label boolean true
@@ -1213,6 +1232,12 @@ d-i partman/choose_partition select finish
 d-i partman/confirm boolean true
 d-i partman/confirm_nooverwrite boolean true
 
+# Force UEFI booting ('BIOS compatibility' will be lost). Default: false.
+#d-i partman-efi/non_efi_system boolean true
+# Ensure the partition table is GPT - this is required for EFI
+#d-i partman-partitioning/choose_label string gpt
+#d-i partman-partitioning/default_label string gpt
+
 # When disk encryption is enabled, skip wiping the partitions beforehand.
 #d-i partman-auto-crypto/erase_disks boolean false
 </screen></informalexample>
Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Vincent McIntyre-4
On Mon, Jun 01, 2020 at 02:34:40PM +1000, Vincent McIntyre wrote:
>
>Revised patch below. I'll test it on amd64 and let you know
>if it works.

This has now been tested on a number of installs and works ok.
I think it's good to go now.

The partman-efi/non_efi_system question is somewhat confusing,
but setting it to 'true' is what one wants if you want to be sure
the system boots in EFI mode.

Regards
Vince

>diff --git a/en/appendix/preseed.xml b/en/appendix/preseed.xml
>index d7570d6b3..9757883b3 100644
>--- a/en/appendix/preseed.xml
>+++ b/en/appendix/preseed.xml
>@@ -1206,6 +1211,20 @@ d-i partman-auto/choose_recipe select atomic
># system labels, volume group names and which physical devices to include
># in a volume group.
>
>+## Partitioning for EFI
>+# If your system needs an EFI partition you could add something like
>+# this to the recipe above, as the first element in the recipe:
>+#               538 538 1075 free                              \
>+#                      $iflabel{ gpt }                         \
>+#                      $reusemethod{ }                         \
>+#                      method{ efi }                           \
>+#                      format{ }                               \
>+#               .                                              \
>+#
>+# The fragment above is for the amd64 architecture; the details may be
>+# different on other architectures. The 'partman-auto' package in the
>+# D-I source repository may have an example you can follow.
>+
># This makes partman automatically partition without confirmation, provided
># that you told it what to do using one of the methods above.
>d-i partman-partitioning/confirm_write_new_label boolean true
>@@ -1213,6 +1232,12 @@ d-i partman/choose_partition select finish
>d-i partman/confirm boolean true
>d-i partman/confirm_nooverwrite boolean true
>
>+# Force UEFI booting ('BIOS compatibility' will be lost). Default: false.
>+#d-i partman-efi/non_efi_system boolean true
>+# Ensure the partition table is GPT - this is required for EFI
>+#d-i partman-partitioning/choose_label string gpt
>+#d-i partman-partitioning/default_label string gpt
>+
># When disk encryption is enabled, skip wiping the partitions beforehand.
>#d-i partman-auto-crypto/erase_disks boolean false
></screen></informalexample>
>

--
Reply | Threaded
Open this post in threaded view
|

Bug#924290: [rfc] information about EFI partitions

Holger Wansing-4
Control: tags -1 + pending


"McIntyre, Vincent (CASS, Marsfield)" <[hidden email]> wrote:
> On Mon, Jun 01, 2020 at 02:34:40PM +1000, Vincent McIntyre wrote:
> >
> >Revised patch below. I'll test it on amd64 and let you know
> >if it works.
>
> This has now been tested on a number of installs and works ok.
> I think it's good to go now.

Just applied.

Tagging this bug as pending.
Thanks


Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076