Bug#924410: 'manage.py' uses '/usr/bin/env python' instead of '/usr/bin/python3'

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#924410: 'manage.py' uses '/usr/bin/env python' instead of '/usr/bin/python3'

Louis-Philippe Véronneau-3
Package: python3-django-hyperkitty
Severity: normal

Dear maintainers,

On systems running both python2 and python3 and where python2 is the
default, running 'example_project/manage.py' fails, since this is a
python3 package. (i.e. hyperkitty can't be imported by python2 since it
is not installed in the python2 path).

This is important since the files in 'example_project' are a very good
way to bootstrap an hyperkitty instance without having to create a
Django project manually.

I'll send a patch today.

Thanks for packaging this!

--
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   [hidden email] / veronneau.org
  ⠈⠳⣄


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#924410: Patch available

Louis-Philippe Véronneau-3
Control: tag -1 patch

Dear maintainers,

I've create a Merge Request on Salsa [1] with a patch for this bug.

Don't hesitate to communicate with me if there is anything wrong with it.

[1] https://salsa.debian.org/mailman-team/hyperkitty/merge_requests/1

--
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   [hidden email] / veronneau.org
  ⠈⠳⣄


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#924410: 'manage.py' uses '/usr/bin/env python' instead of '/usr/bin/python3'

Pierre-Elliott Bécue-3
In reply to this post by Louis-Philippe Véronneau-3
Le mardi 12 mars 2019 à 13:45:59-0400, Louis-Philippe Véronneau a écrit :

> Package: python3-django-hyperkitty
> Severity: normal
>
> Dear maintainers,
>
> On systems running both python2 and python3 and where python2 is the
> default, running 'example_project/manage.py' fails, since this is a
> python3 package. (i.e. hyperkitty can't be imported by python2 since it
> is not installed in the python2 path).
>
> This is important since the files in 'example_project' are a very good
> way to bootstrap an hyperkitty instance without having to create a
> Django project manually.
>
> I'll send a patch today.
>
> Thanks for packaging this!
Hi,

While I agree that it'd be better to use /usr/bin/python3 or
/usr/bin/env python3, mind that hyperkitty was initially designed to be
both python2 and python3 compatible, hence it's hard to have a
definitive solution.

On the other hand, one should not rely on './manage.py' to manage a
production environment. The appropriate way of handling a django
instance is via django-admin and its Python3 alter-ego.

We'll discuss regarding whether we try or not to merge your fix and have
it in buster.

Best regards,

--
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.

signature.asc (849 bytes) Download Attachment