Bug#924948: unblock: onedrive/2.2.6-2

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#924948: unblock: onedrive/2.2.6-2

Norbert Preining-5
Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock

Dear RM,

I am asking to unblock onedrive 2.2.6-2 for buster. This is a new
upstream release that fixes a considerable amount of (critical) bugs,
most of which not reported in Debian, but still present. Here are the
release notes from the CHANGELOG.md file:

## 2.2.6 - 2019-03-12
### Fixed
*   Resolve application crash when unable to delete remote folders when business retention policies are enabled
*   Resolve deprecation warning: loop index implicitly converted from size_t to int
*   Resolve warnings regarding 'bashisms'
*   Resolve handling of notification failure is dbus server has not started or available
*   Resolve handling of response JSON to ensure that 'id' key element is always checked for
*   Resolve excessive & needless logging in monitor mode
*   Resolve compiling with LDC on Alpine as musl lacks some standard interfaces
*   Resolve notification issues when offline and cannot act on changes
*   Resolve Docker entrypoint.sh to accept command line arguments
*   Resolve to create a new upload session on reinit
*   Resolve where on OneDrive query failure, default root and drive id is used if a response is not returned
*   Resolve Key not found: nextExpectedRanges when attempting session uploads and incorrect response is returned
*   Resolve application crash when re-using an authentication URI twice after previous --logout
*   Resolve creating a folder on a shared personal folder appears successful but returns a JSON error
*   Resolve to treat mv of new file as upload of mv target
*   Update Debian i386 build dependencies
*   Update handling of --get-O365-drive-id to print out all 'site names' that match the explicit search entry rather than just the last match
*   Update Docker readme & documentation
*   Update handling of validating local file permissions for new file uploads
### Added
*   Add support for install & uninstall on RHEL / CentOS 6.x
*   Add support for when notifications are enabled, display the number of OneDrive changes to process if any are found
*   Add 'config' option 'min_notif_changes' for minimum number of changes to notify on, default = 5
*   Add additional Docker container builds utilising a smaller OS footprint
*   Add configurable interval of logging in monitor mode
*   Implement new CLI option --skip-dot-files to skip .files and .folders if option is used
*   Implement new CLI option --check-for-nosync to ignore folder when special file (.nosync) present
*   Implement new CLI option --dry-run


The Debian related diffs are trivial, see attached debdiff, where I
excluded the actual code changes in the onedrive sources.

Having 2.2.5 with all the hitherto found bugs in buster would be
unfortunate.

Thanks for your consideration

Norbert

unblock onedrive/2.2.6-2

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.2 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

onedrive.debdiff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#924948: unblock: onedrive/2.2.6-2

Paul Gevers-4
Control: tags -1 moreinfo

Hi Norbert,

On Tue, 19 Mar 2019 07:50:10 +0900 Norbert Preining
<[hidden email]> wrote:

> I am asking to unblock onedrive 2.2.6-2 for buster. This is a new
> upstream release that fixes a considerable amount of (critical) bugs,
> most of which not reported in Debian, but still present. Here are the
> release notes from the CHANGELOG.md file:
>
> ## 2.2.6 - 2019-03-12
> ### Fixed
> *   Resolve application crash when unable to delete remote folders when business retention policies are enabled
> *   Resolve deprecation warning: loop index implicitly converted from size_t to int
> *   Resolve warnings regarding 'bashisms'
> *   Resolve handling of notification failure is dbus server has not started or available
> *   Resolve handling of response JSON to ensure that 'id' key element is always checked for
> *   Resolve excessive & needless logging in monitor mode
> *   Resolve compiling with LDC on Alpine as musl lacks some standard interfaces
> *   Resolve notification issues when offline and cannot act on changes
> *   Resolve Docker entrypoint.sh to accept command line arguments
> *   Resolve to create a new upload session on reinit
> *   Resolve where on OneDrive query failure, default root and drive id is used if a response is not returned
> *   Resolve Key not found: nextExpectedRanges when attempting session uploads and incorrect response is returned
> *   Resolve application crash when re-using an authentication URI twice after previous --logout
> *   Resolve creating a folder on a shared personal folder appears successful but returns a JSON error
> *   Resolve to treat mv of new file as upload of mv target
> *   Update Debian i386 build dependencies
> *   Update handling of --get-O365-drive-id to print out all 'site names' that match the explicit search entry rather than just the last match
> *   Update Docker readme & documentation
> *   Update handling of validating local file permissions for new file uploads
> ### Added
> *   Add support for install & uninstall on RHEL / CentOS 6.x
> *   Add support for when notifications are enabled, display the number of OneDrive changes to process if any are found
> *   Add 'config' option 'min_notif_changes' for minimum number of changes to notify on, default = 5
> *   Add additional Docker container builds utilising a smaller OS footprint
> *   Add configurable interval of logging in monitor mode
> *   Implement new CLI option --skip-dot-files to skip .files and .folders if option is used
> *   Implement new CLI option --check-for-nosync to ignore folder when special file (.nosync) present
> *   Implement new CLI option --dry-run
>
>
> The Debian related diffs are trivial, see attached debdiff, where I
> excluded the actual code changes in the onedrive sources.
>
> Having 2.2.5 with all the hitherto found bugs in buster would be
> unfortunate.
I fear this request hasn't received a response because it is very
daunting to review (35 files changed, 1565 insertions(+), 747
deletions(-)) and it doesn't comply with the freeze policy (targeted
fixes). Hence the I am seriously wondering if it wouldn't be better to
remove onedrive from buster and make sure the package is in better shape
during the bullseye cycle. What do you think?

Paul


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#924948: unblock: onedrive/2.2.6-2

Norbert Preining-5
Hi Paul,

On Thu, 30 May 2019, Paul Gevers wrote:
> On Tue, 19 Mar 2019 07:50:10 +0900 Norbert Preining

What a time lag for a release related bug, impressive.

> I fear this request hasn't received a response because it is very
> daunting to review (35 files changed, 1565 insertions(+), 747

As far as I remember, there have been other full version upgrades after
that date, but anyway.

> fixes). Hence the I am seriously wondering if it wouldn't be better to
> remove onedrive from buster and make sure the package is in better shape
> during the bullseye cycle. What do you think?

Feel free to do whatever you think is good. I have no particular
opinion. The version that is in buster now is usable, but does not catch
errors in a good way but crashes. Manual syncing should be fine in most
cases, while background sync / monitor mode might be sub-optimal or
crash rather soon.

Best

Norbert

--
PREINING Norbert                               http://www.preining.info
Accelia Inc.     +    JAIST     +    TeX Live     +    Debian Developer
GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13

Reply | Threaded
Open this post in threaded view
|

Bug#924948: unblock: onedrive/2.2.6-2

Niels Thykier
Norbert Preining:
> Hi Paul,
>
> On Thu, 30 May 2019, Paul Gevers wrote:
>> On Tue, 19 Mar 2019 07:50:10 +0900 Norbert Preining
>
> What a time lag for a release related bug, impressive.
>

Hi Nobert,

I can understand that the delay in the reply is unsatisfying to you  -
personally, I am not happy about such delays either.

However, I find remarks like the above unhelpful and uncalled for at
best - not to mention draining energy- and motivation-wise.  Please keep
future communication professional.

A much better approach would have been to ask us an update (in a
friendly/professional manner) in case we had forgotten about the
request.  This might have gotten you a reply much earlier.

Thanks,
~Niels

Reply | Threaded
Open this post in threaded view
|

Bug#924948: unblock: onedrive/2.2.6-2

Norbert Preining-5
Dear Niels,

Please remove onedrive from buster.

Thanks

Norbert

--
PREINING Norbert http://www.preining.info
Accelia Inc. + JAIST + TeX Live + Debian Developer
GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13