Bug#925540: qhull: add libqhullcpp to installed libraries

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

D Haley-2
Source: qhull
Version: 2015.2-4
Severity: normal
Tags: patch

Dear Maintainer,

The Qhull package does not install the libqhullcpp shared libraries. The
headers are installed, but the library is built statically, and does
not get installed.

I have attached a patch against ea54d22bba5fb2cedf106a58bd11904370bfeb4f,
which changes the library to shared and adds it to the relevant .install
files.

If the patch or similar is not suitable, and it is not desired to
distribute the C++ library,  perhaps the C++ qhull headers should
be removed?


-- System Information:
Debian Release: 9.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

commit-c60f19c (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

D Haley-2
Hi,

Just re-pinging this bug. I can try to arrange for an NMU if this is
acceptable.

Thanks.

On 26/03/2019 15:21, D Haley wrote:

> Source: qhull
> Version: 2015.2-4
> Severity: normal
> Tags: patch
>
> Dear Maintainer,
>
> The Qhull package does not install the libqhullcpp shared libraries. The
> headers are installed, but the library is built statically, and does
> not get installed.
>
> I have attached a patch against ea54d22bba5fb2cedf106a58bd11904370bfeb4f,
> which changes the library to shared and adds it to the relevant .install
> files.
>
> If the patch or similar is not suitable, and it is not desired to
> distribute the C++ library,  perhaps the C++ qhull headers should
> be removed?
>
>
> -- System Information:
> Debian Release: 9.8
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
> Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=de_DE.utf8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>

Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

David Bremner
In reply to this post by D Haley-2
D Haley <[hidden email]> writes:

>
> The Qhull package does not install the libqhullcpp shared libraries. The
> headers are installed, but the library is built statically, and does
> not get installed.
>
> I have attached a patch against ea54d22bba5fb2cedf106a58bd11904370bfeb4f,
> which changes the library to shared and adds it to the relevant .install
> files.

Normally we don't install static libraries in Debian. Shared libraries
need to have SONAMES, and hopefully fairly stable ABIs. Do you know if
those conditions are met? If so, it would need to be in a seperate
package named after the SONAME.

d

Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

D Haley-2
Hi and thanks for the quick feedback,

> Normally we don't install static libraries in Debian. Shared libraries
> need to have SONAMES, and hopefully fairly stable ABIs. Do you know if
> those conditions are met? If so, it would need to be in a seperate
> package named after the SONAME.

Upstream's comment in their release notes are:
"Qhull's C++ interface is likely to change.  Stay current with GitHub.".
  [1] So, no there is no upstream SONAME, and the ABI is declared
unstable. However, updates to qhull are historically at most yearly.

As a downstream consumer of the library, this is unfortunate for me.

However, Policy (8.3) [2] is that the static may be installed,
particularly if the ABI is unstable, but doesn't really say anything
about not installing the static at all?

The current behaviour is - no static nor shared for the C++ interface,
but both for the C interface...

$ apt-file show libqhull-dev | grep 'lib/'
libqhull-dev: /usr/lib/x86_64-linux-gnu/libqhull.a
libqhull-dev: /usr/lib/x86_64-linux-gnu/libqhull.so
libqhull-dev: /usr/lib/x86_64-linux-gnu/libqhull_r.so
libqhull-dev: /usr/lib/x86_64-linux-gnu/libqhullstatic_r.a

So we could take out libqhull*.a, or add libqhullcpp*.a? Maybe I'm
missing something, and omitting libqhullcpp is a deliberate choice?

Thanks.

[1] http://www.qhull.org/README.txt
[2] https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

On 10/10/2019 18:39, David Bremner wrote:

> D Haley <[hidden email]> writes:
>
>>
>> The Qhull package does not install the libqhullcpp shared libraries. The
>> headers are installed, but the library is built statically, and does
>> not get installed.
>>
>> I have attached a patch against ea54d22bba5fb2cedf106a58bd11904370bfeb4f,
>> which changes the library to shared and adds it to the relevant .install
>> files.
>
>
>
> d
>

Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

Timo Röhling-2
Hi everyone,

I'm also affected by this bug.

On Thu, 10 Oct 2019 19:08:23 +0100 D Haley <[hidden email]> wrote:

> However, Policy (8.3) [2] is that the static may be installed,
> particularly if the ABI is unstable, but doesn't really say anything
> about not installing the static at all?
> [...]
> So we could take out libqhull*.a, or add libqhullcpp*.a? Maybe I'm
> missing something, and omitting libqhullcpp is a deliberate choice?

I would also welcome that libqhullcpp be included in the package. I
noticed that there is some packaging in progress for the latest 2019
release:

https://salsa.debian.org/science-team/qhull

If there's anything I can do to help, I'll gladly lend my support.

-Timo




signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

Timo Röhling-2
On Mon, 9 Mar 2020 12:26:51 +0100 Timo Röhling <[hidden email]> wrote:
> https://salsa.debian.org/science-team/qhull

I took the liberty and prepared a Merge Request that will fix this bug:

https://salsa.debian.org/science-team/qhull/-/merge_requests/2

I hope it is useful.

-Timo

Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

Jochen Sprickerhof-5
Hi Barak,

did you see the merge request by Timo in qhull?

https://salsa.debian.org/science-team/qhull/-/merge_requests/2

I think this is ready to be merged and uploaded to experimental/NEW. Do
you agree?

If you don't have time, I'm happe to take care of it and of the
transition to unstable as well.

If you don't answer by next week Tuesday, I will assume that you are
busy and go ahead. Please write if I should not.

Cheers Jochen

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

Barak A. Pearlmutter-4
Had not noticed that, thanks!

Next time, do feel free to 0-day NMU, pushing to the shared repo.

But, now that I've seen it, looks great. I'm going to just upload to
unstable. (Hence the term, right?)

Cheers,

--Barak.

Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

Jochen Sprickerhof-5
Hi Barak,

* Barak A. Pearlmutter <[hidden email]> [2020-04-07 23:07]:
>But, now that I've seen it, looks great. I'm going to just upload to
>unstable. (Hence the term, right?)

No, it has a differen Soname due to a different ABI. We need to go
through experimental and request a transition with the release team,
see:

https://wiki.debian.org/Teams/ReleaseTeam/Transitions

Cheers Jochen

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#925540: qhull: add libqhullcpp to installed libraries

Barak A. Pearlmutter-4
Ah right, transition, experimental, oops.
Just uploaded to experimental.

Please feel free to upload yourselves next time; certainly anyone on
the science team, etc. Jochen, do you want to officially co-maintain
or whatever? The repo is under science-team for a reason, but I'm
happy to give additional access rights if necessary.

Cheers,

--Barak.