Bug#926575: libgps changed API of gps_read lists/Debian x

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#926575: libgps changed API of gps_read lists/Debian x

Christian Ehrhardt
Package: foxtrotgps
Version: 1.2.1-1

Hi,
libgps changed the gps_read implementation in [0].
To be clear the change in gpsd is currently only in experimental. This
is a heads up for the post buster transition that will come sooner or
later.

Uptream foxtrotgps has already fixed that in [1] The change isn't too
hard and will be compatible with older versions. That fix is
unfortunately
not yet in the version 1.2.1 that I found in Debian.
I found no VCS and didn't see it on salsa, so I'll provide a debdiff
to help. Since it is transparent (can be applied before the GPSD
transition) I'd appreciate if you could include this change in
when-/whatever the next upload to foxtrotgps will happen. I'll let the
gpsd maintainer know about the bug, so that we can consider it when
kicking off the transition.

[0]: https://git.savannah.gnu.org/cgit/gpsd.git/commit/?id=6bba8b329
[1]: https://bazaar.launchpad.net/~foxtrotgps-team/foxtrotgps/trunk/revision/316

--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

Reply | Threaded
Open this post in threaded view
|

Bug#926575: Debidiff as a suggestion

Christian Ehrhardt
Hi,
as I mentioned I found no VCS, therefore here a Debdiff for you
The fail would look like:
gps_functions.c: In function ‘cb_gpsd_data’:
gps_functions.c:741:8: error: too few arguments to function ‘gps_read’
 ret = gps_read(&libgps_gpsdata);
       ^~~~~~~~
In file included from gps_functions.c:17:
/usr/include/gps.h:2122:12: note: declared here
extern int gps_read(struct gps_data_t *, char *message, int message_len);
           ^~~~~~~~

This debdiff was test built against gpsd in experimental and works fine with it.

--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

fix-foxtrotgps-libgps-API.debdiff (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#926575: Debidiff as a suggestion

Paul Wise via nm
On Sun, 2019-04-07 at 11:52 +0200, Christian Ehrhardt wrote:

> This debdiff was test built against gpsd in experimental and works
> fine with it.

I expect I'll just make a new upstream release after buster.

--
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc (849 bytes) Download Attachment