Bug#926883: php7.3 breaks symfony autopkgtest

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#926883: php7.3 breaks symfony autopkgtest

Paul Gevers-4
Source: php7.3, symfony
Control: found -1 php7.3/7.3.4-1
Control: found -1 symfony/3.4.22+dfsg-1
Severity: important
X-Debbugs-CC: [hidden email]
User: [hidden email]
Usertags: breaks needs-update

Dear maintainers,

With a recent upload of php7.3 the autopkgtest of symfony fails in
testing when that autopkgtest is run with the binary packages of php7.3
from unstable. It passes when run with only packages from testing. In
tabular form:
                       pass            fail
php7.3                 from testing    7.3.4-1
symfony                from testing    3.4.22+dfsg-1
versioned deps [0]     from testing    from unstable
all others             from testing    from testing

I normally copy some of the output to the bottom of this report, but the
output is long and littered with shell makeup code and I was unable to
spot where the error was. All I see is "exit 1" and multiple "OK, but
incomplete, skipped, or risky tests!"

Currently this regression is blocking the migration of php7.3 to testing
[1]. Due to the nature of this issue, I filed this bug report against
both packages. Can you please investigate the situation and reassign the
bug to the right package? If needed, please change the bug's severity.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[0] You can see what packages were added from the second line of the log
file quoted below. The migration software adds source package from
unstable to the list if they are needed to install packages from
php7.3/7.3.4-1. I.e. due to versioned dependencies or breaks/conflicts.
[1] https://qa.debian.org/excuses.php?package=php7.3

https://ci.debian.net/data/autopkgtest/testing/amd64/s/symfony/2231104/log.gz


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#926883: php7.3 breaks symfony autopkgtest

Ondřej Surý-4
I am actually not sure this is related to PHP update, see the error:

+ rm -rf ./vendor
+ patch -Rp1
patching file src/Symfony/Component/Form/Tests/Console/Descriptor/AbstractDescriptorTest.php
+ exit 1

which comes from debian/tests/phpunit:

rm -rf ./vendor
patch -Rp1 < debian/patches/DEP-8/Form-drop-test-failing-on-CI.patch

which also fails if you test it manually.

There’s one WARNING, and it’s the exactly the one warning that has been previously patched out:

— cut here —
1) Warning
The data provider specified for Symfony\Component\Form\Tests\Extension\Core\Type\DateIntervalTypeTest::testSubmitNullUsesDateEmptyData is invalid.
DateInterval::createFromDateString(): Unknown or bad format (6 years and 4 months) at position 8 (a): The timezone could not be found in the database

WARNINGS!
Tests: 3512, Assertions: 7977, Warnings: 1, Skipped: 2, Incomplete: 8.
— cut here —

I can probably do NMU if David doesn’t have time to fix this, but it’s definitely unrelated to 7.3.3 to 7.3.4 update looking from where I stand.

Ondrej
--
Ondřej Surý
[hidden email]



> On 11 Apr 2019, at 21:14, Paul Gevers <[hidden email]> wrote:
>
> Source: php7.3, symfony
> Control: found -1 php7.3/7.3.4-1
> Control: found -1 symfony/3.4.22+dfsg-1
> Severity: important
> X-Debbugs-CC: [hidden email]
> User: [hidden email]
> Usertags: breaks needs-update
>
> Dear maintainers,
>
> With a recent upload of php7.3 the autopkgtest of symfony fails in
> testing when that autopkgtest is run with the binary packages of php7.3
> from unstable. It passes when run with only packages from testing. In
> tabular form:
>                       pass            fail
> php7.3                 from testing    7.3.4-1
> symfony                from testing    3.4.22+dfsg-1
> versioned deps [0]     from testing    from unstable
> all others             from testing    from testing
>
> I normally copy some of the output to the bottom of this report, but the
> output is long and littered with shell makeup code and I was unable to
> spot where the error was. All I see is "exit 1" and multiple "OK, but
> incomplete, skipped, or risky tests!"
>
> Currently this regression is blocking the migration of php7.3 to testing
> [1]. Due to the nature of this issue, I filed this bug report against
> both packages. Can you please investigate the situation and reassign the
> bug to the right package? If needed, please change the bug's severity.
>
> More information about this bug and the reason for filing it can be found on
> https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation
>
> Paul
>
> [0] You can see what packages were added from the second line of the log
> file quoted below. The migration software adds source package from
> unstable to the list if they are needed to install packages from
> php7.3/7.3.4-1. I.e. due to versioned dependencies or breaks/conflicts.
> [1] https://qa.debian.org/excuses.php?package=php7.3
>
> https://ci.debian.net/data/autopkgtest/testing/amd64/s/symfony/2231104/log.gz
>

Reply | Threaded
Open this post in threaded view
|

Bug#926883: php7.3 breaks symfony autopkgtest

David Prévot-4
Hi,

Le 14/04/2019 à 04:27, Ondřej Surý a écrit :
> I am actually not sure this is related to PHP update, see the error:
>
> + rm -rf ./vendor
> + patch -Rp1
> patching file src/Symfony/Component/Form/Tests/Console/Descriptor/AbstractDescriptorTest.php
> + exit 1

No, the error comes from way before, but you already noticed it:

> There’s one WARNING, and it’s the exactly the one warning that has been previously patched out:
>
> — cut here —
> 1) Warning
> The data provider specified for Symfony\Component\Form\Tests\Extension\Core\Type\DateIntervalTypeTest::testSubmitNullUsesDateEmptyData is invalid.
> DateInterval::createFromDateString(): Unknown or bad format (6 years and 4 months) at position 8 (a): The timezone could not be found in the database
>
> WARNINGS!
> Tests: 3512, Assertions: 7977, Warnings: 1, Skipped: 2, Incomplete: 8.
> — cut here —
This one is new, comes with the new PHP version, and makes the package
FTBFS. Since it needs to build in order to provide security fixes, it
will be fixed soon…

Regards

David


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#926883: php7.3 breaks symfony autopkgtest

David Prévot-4
Hi,

Le 18/04/2019 à 21:33, David Prévot a écrit :
> Le 14/04/2019 à 04:27, Ondřej Surý a écrit :
>> I am actually not sure this is related to PHP update

FWIW, upstream already provided a [workaround], and the root issue is
discussed in [#77896].

workaround: https://github.com/symfony/symfony/pull/31115
#77896: https://bugs.php.net/77896

Regards

David


signature.asc (499 bytes) Download Attachment