Bug#927344: marked as done (unblock: calamares-settings-debian/10.0.20-1)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#927344: marked as done (unblock: calamares-settings-debian/10.0.20-1)

Debian Bug Tracking System
Your message dated Thu, 18 Apr 2019 09:49:00 +0000
with message-id <[hidden email]>
and subject line Re: Bug#927344: unblock: calamares-settings-debian/10.0.20-1
has caused the Debian Bug report #927344,
regarding unblock: calamares-settings-debian/10.0.20-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
927344: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927344
Debian Bug Tracking System
Contact [hidden email] with problems

Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock

Please consider unblocking package calamares-settings-debian

Recently, I put out a call for testing for debian-live, and my #1
feedback from random users and Debian Developers alike was that
we really should have desktop icons for the calamares installer
on the live media desktop instead of only in the menus.

I didn't have time to implement that by the time the freeze hit,
but spent some time looking into it and now have a very simple
but effective implementation that's tested on gnome, lxde, xfce,
lxqt, kde, cinnamon and mate (all our live variants) and it works.

I can understand if release team declines this because it is a new
feature that technically goes against the release policy, but it's
also very highly requested, has near-zero risk of affecting anything
else, and it would be a shame if users would have to wait another
two years for this.

Here follows the debdiff:

"""
diff -Nru calamares-settings-debian-10.0.19/add-calamares-desktop-icon calamares-settings-debian-10.0.20/add-calamares-desktop-icon
--- calamares-settings-debian-10.0.19/add-calamares-desktop-icon 1970-01-01 00:00:00.000000000 +0000
+++ calamares-settings-debian-10.0.20/add-calamares-desktop-icon 2019-04-18 08:14:00.000000000 +0000
@@ -0,0 +1,25 @@
+#!/bin/sh
+# Creates an "Install Debian" icon on the live session tested with:
+# Xfce, LXDE, LXqt, Gnome, KDE, Mate, Cinnamon
+
+
+# Create ~/Desktop just in case this runs before the xdg folder
+# creation script.
+mkdir -p ~/Desktop
+
+
+# Among the Debian desktop environments, LXDE is the only one
+# that behaves completely different.
+if [ -f /usr/bin/lxsession ]; then
+    echo "[Desktop Entry]" > ~/Desktop/install-debian.desktop
+    echo "Type=Link" >> ~/Desktop/install-debian.desktop
+    echo "Name=Install Debian" >> ~/Desktop/install-debian.desktop
+    echo "Icon=install-debian" >> ~/Desktop/install-debian.desktop
+    echo "URL=/usr/share/applications/install-debian.desktop" \
+          >> ~/Desktop/install-debian.desktop
+else
+    cp /usr/share/applications/install-debian.desktop ~/Desktop
+    # Xfce needs this executable otherwise it complains, everything
+    # else doesn't seem to care either way.
+    chmod +x ~/Desktop/install-debian.desktop
+fi
diff -Nru calamares-settings-debian-10.0.19/conf/calamares-desktop-icon.desktop calamares-settings-debian-10.0.20/conf/calamares-desktop-icon.desktop
--- calamares-settings-debian-10.0.19/conf/calamares-desktop-icon.desktop 1970-01-01 00:00:00.000000000 +0000
+++ calamares-settings-debian-10.0.20/conf/calamares-desktop-icon.desktop 2019-04-18 08:14:00.000000000 +0000
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Type=Application
+Name=Add Calamares Desktop Icon
+Exec=add-calamares-desktop-icon
+StartupNotify=false
+NoDisplay=true
+
+X-GNOME-Autostart-Phase=Initialization
+X-KDE-autostart-phase=1
diff -Nru calamares-settings-debian-10.0.19/debian/changelog calamares-settings-debian-10.0.20/debian/changelog
--- calamares-settings-debian-10.0.19/debian/changelog 2019-04-15 13:32:36.000000000 +0000
+++ calamares-settings-debian-10.0.20/debian/changelog 2019-04-18 08:18:37.000000000 +0000
@@ -1,3 +1,10 @@
+calamares-settings-debian (10.0.20-1) unstable; urgency=medium
+
+  * New upstream release
+    - Configure Desktop icon for calamares
+
+ -- Jonathan Carter <[hidden email]>  Thu, 18 Apr 2019 08:18:37 +0000
+
 calamares-settings-debian (10.0.19-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru calamares-settings-debian-10.0.19/debian/install calamares-settings-debian-10.0.20/debian/install
--- calamares-settings-debian-10.0.19/debian/install 2019-04-15 13:32:05.000000000 +0000
+++ calamares-settings-debian-10.0.20/debian/install 2019-04-18 08:18:37.000000000 +0000
@@ -5,3 +5,5 @@
 install-debian usr/bin
 artwork/install-debian.png usr/share/pixmaps
 conf/96_calamares-settings-debian.gschema.override usr/share/glib-2.0/schemas
+conf/calamares-desktop-icon.desktop etc/xdg/autostart
+add-calamares-desktop-icon usr/bin
"""

If approved, it would also be tremendously helpful if it had a short migration time, to aid us in doing a quick turnaround for a public RC for wider testing.

Thanks for your time!

-Jonathan

Jonathan Carter:

> Package: release.debian.org
> Severity: normal
> User: [hidden email]
> Usertags: unblock
>
> Please consider unblocking package calamares-settings-debian
>
> Recently, I put out a call for testing for debian-live, and my #1
> feedback from random users and Debian Developers alike was that
> we really should have desktop icons for the calamares installer
> on the live media desktop instead of only in the menus.
>
> I didn't have time to implement that by the time the freeze hit,
> but spent some time looking into it and now have a very simple
> but effective implementation that's tested on gnome, lxde, xfce,
> lxqt, kde, cinnamon and mate (all our live variants) and it works.
>
> I can understand if release team declines this because it is a new
> feature that technically goes against the release policy, but it's
> also very highly requested, has near-zero risk of affecting anything
> else, and it would be a shame if users would have to wait another
> two years for this.
>
> Here follows the debdiff:
>
> [...]
>
> If approved, it would also be tremendously helpful if it had a short migration time, to aid us in doing a quick turnaround for a public RC for wider testing.
>
> Thanks for your time!
>
> -Jonathan
>
Done and done.  On the flip side, I expect prompt fixes if regressions
appear in testing because of the accelerated migration (NB: it also
affects the 10.0.19-1 changes).

For future reference, it is often easier for us to let the previous
upload migrate first before doing a second upload for non-critical
(RC/migration blocking) issues.

Thanks,
~Niels