Bug#927346: marked as done (unblock: voctomix-outcasts/0.8.0-1)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#927346: marked as done (unblock: voctomix-outcasts/0.8.0-1)

Debian Bug Tracking System
Your message dated Thu, 18 Apr 2019 10:45:00 +0000
with message-id <[hidden email]>
and subject line Re: Bug#927346: unblock: voctomix-outcasts/0.8.0-1
has caused the Debian Bug report #927346,
regarding unblock: voctomix-outcasts/0.8.0-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
927346: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927346
Debian Bug Tracking System
Contact [hidden email] with problems

Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock

Please unblock package voctomix-outcasts, it's a fringe package only
used by some conference video setups, which requested fixes for these
bugs:

voctomix-outcasts (0.8.0-1) unstable; urgency=medium

  * New upstream release, which does not exit with error on EOS.
    Closes: #926828.
  * Recommend gstreamer1.0-alsa for USB microphones. Closes: #926829.

Sadly the debdiff is a bit of noisy because the new upstream release
included a few silly whitespace changes. I still think it's trivial to
review though. The tests are tests.

$ debdiff voctomix-outcasts_0.7.0-1.dsc voctomix-outcasts_0.8.0-1.dsc |diffstat
 configs/test1.ini      |    4 ----
 debian/changelog       |    8 ++++++++
 debian/control         |    5 ++++-
 ingest.py              |    9 +++++----
 record-mixed-av.sh     |   10 ++++++++--
 tests/mock-stack.sh    |   11 ++++++-----
 tests/show_hdmi2usb.sh |   13 ++++++++++---
 7 files changed, 41 insertions(+), 19 deletions(-)

As usual the full debdiff is attached.


--
thanks,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

Holger Levsen:

> Package: release.debian.org
> Severity: normal
> User: [hidden email]
> Usertags: unblock
>
> Please unblock package voctomix-outcasts, it's a fringe package only
> used by some conference video setups, which requested fixes for these
> bugs:
>
> voctomix-outcasts (0.8.0-1) unstable; urgency=medium
>
>   * New upstream release, which does not exit with error on EOS.
>     Closes: #926828.
>   * Recommend gstreamer1.0-alsa for USB microphones. Closes: #926829.
>
> Sadly the debdiff is a bit of noisy because the new upstream release
> included a few silly whitespace changes. I still think it's trivial to
> review though. The tests are tests.
>
> $ debdiff voctomix-outcasts_0.7.0-1.dsc voctomix-outcasts_0.8.0-1.dsc |diffstat
>  configs/test1.ini      |    4 ----
>  debian/changelog       |    8 ++++++++
>  debian/control         |    5 ++++-
>  ingest.py              |    9 +++++----
>  record-mixed-av.sh     |   10 ++++++++--
>  tests/mock-stack.sh    |   11 ++++++-----
>  tests/show_hdmi2usb.sh |   13 ++++++++++---
>  7 files changed, 41 insertions(+), 19 deletions(-)
>
> As usual the full debdiff is attached.
>
>
Unblocked.

I noted that the tests hardcodes a /tmp/test.ts file (not a regression
though).  Could you talk to upstream about avoiding hard-coding file
names in /tmp - even in test suites?

Thanks,
~Niels

voctomix-outcasts_0.8.0-1.diff (6K) Download Attachment
signature.asc (849 bytes) Download Attachment