Bug#927347: voctomix-outcasts: don't use hardcoded filenames in /tmp - even for testing

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#927347: voctomix-outcasts: don't use hardcoded filenames in /tmp - even for testing

Holger Levsen-2
package: voctomix-outcasts
severity: important
x-debbugs-cc: [hidden email], [hidden email]

Hi Carl,

On Thu, Apr 18, 2019 at 10:45:00AM +0000, Niels Thykier wrote:
> > voctomix-outcasts (0.8.0-1) unstable; urgency=medium
> Unblocked.

this is quite yay! (=it will make it into Buster)

> I noted that the tests hardcodes a /tmp/test.ts file (not a regression
> though).

eeks, this is not so yay. Please use mktemp instead.

I see /tmp/test.ts is used by tests/server-file.sh and tests/mock-stack.sh
- do they both need to refer to the same file? If not the fix is
trivial...

> Could you talk to upstream about avoiding hard-coding file
> names in /tmp - even in test suites?

done :)


--
tschau,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

signature.asc (849 bytes) Download Attachment