Bug#928746: unblock: zfs-linux/0.7.13-1

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#928746: unblock: zfs-linux/0.7.13-1

Mo Zhou
Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock
X-Debbugs-CC: [hidden email]

Please unblock package zfs-linux

zfs-linux (= 0.7.13-1) is 66 days in unstable and there is no new bug
for it.
Compared to (0.7.12-2), the (0.7.13-1) version in unstable only
introduces
bug fixes. Aron has already applied for an unblock but it was rejected.
Here I'm requesting for unblock again.

The difference between upstream 0.7.12 and 0.7.13 includes
linux 5.0 compat fixes, and a series of bug fixes. I can revert
the linux 5.0 compat fixes if you think that's irrelated to
the Buster release with the 0.7.13-2 upload. I can also revert
some enhancement patches if release team doesn't like them. Even
if we reverted the linux 5.0 compat and some enhancements, it
is still better than letting 0.7.12-2 stay in Buster, because
in that way we still have bug fixes.

On the debian packaging side, the difference between 0.7.12-2
(testing) and 0.7.13-1 (unstable) includes manually cherry-picked
patches (by Colin Ian King(ubuntu diff), Aron Xu, and Me), fixes
for the problematic autopkgtest script I wrote, and a small update
for the Debian+OpenRC support patch. Most of the newly added patches
were already shipped by the ubuntu package more than 3 months ago.

zfs (0.7.12-5) was uploaded to unstable before (hardfreeze - 12 days).
zfs (0.7.13-1) was uploaded to unstable on (hardfreeze - 8 days).
I should have waited for some time for the 0.7.12-5 migration...

Anyway let's see the diffstat and I'll comment every bit of change in
detail.  Please at least accept some bug fixes for Buster. And tell
me which of the enhancements (incl. linux 5.0 compat) are
not acceptible so that I can revert them.

(explain the reason for the unblock here)

```
~/D/z/zfs ❯❯❯ git diff debian/0.7.12-2 debian/0.7.13-1 --stat | cat
 META                                               |   2 +-
 Makefile.in                                        |   2 +
 aclocal.m4                                         |   2 +
 cmd/Makefile.in                                    |   2 +
 cmd/arc_summary/Makefile.in                        |   2 +
 cmd/arcstat/Makefile.in                            |   2 +
 cmd/dbufstat/Makefile.in                           |   2 +
 cmd/fsck_zfs/Makefile.in                           |   2 +
 cmd/mount_zfs/Makefile.am                          |   2 +
 cmd/mount_zfs/Makefile.in                          |   4 +
 cmd/raidz_test/Makefile.in                         |   2 +
 cmd/vdev_id/Makefile.in                            |   2 +

    [linux 5.0 compat]
    *.am and *.in was updated for linux 5.0

 cmd/vdev_id/vdev_id                                | 209 ++++-

    [enhancements]

    2b8c3cb0c83681d7425fa5bf567e726b7ba975e9
    vdev_id: extension for new scsi topology

    41f7723e9cb260f313f99d667142e37617812fca
    vdev_id: new slot type ses

    c32c2f17d06cea5dc298b404fad7696921e490e0
    Add enclosure_symlinks option to vdev_id

 cmd/zdb/Makefile.in                                |   2 +
 cmd/zed/Makefile.in                                |   2 +
 cmd/zfs/Makefile.in                                |   2 +
 cmd/zgenhostid/Makefile.in                         |   2 +
 cmd/zhack/Makefile.in                              |   2 +
 cmd/zinject/Makefile.in                            |   2 +
 cmd/zpios/Makefile.in                              |   2 +
 cmd/zpool/Makefile.in                              |   2 +
 cmd/zstreamdump/Makefile.in                        |   2 +
 cmd/ztest/Makefile.in                              |   2 +

    [linux 5.0 compat]
    all the *.in files above

 cmd/ztest/ztest.c                                  |   4 +-

    [trivial C code change]
    -   .zo_pool = { 'z', 't', 'e', 's', 't', '\0' },
    -   .zo_dir = { '/', 't', 'm', 'p', '\0' },
    +   .zo_pool = "ztest",
    +   .zo_dir = "/tmp",

 cmd/zvol_id/Makefile.in                            |   2 +
 config/kernel-access-ok-type.m4                    |  21 +
 config/kernel-bio_set_dev.m4                       |  35 +-
 config/kernel-fpu.m4                               |  41 +-
 config/kernel-misc-minor.m4                        |  26 +
 config/kernel.m4                                   |   4 +-

    [linux 5.0 compat]
    the above several files were changed due to linux compat fix

 configure                                          | 599
++++++++++++++-

    Mostly due to newly added kernel feature checks.
    Deleted lines are due to version number bump.

 configure.ac                                       |   3 +
 contrib/Makefile.in                                |   2 +
 contrib/bash_completion.d/Makefile.in              |   2 +
 contrib/dracut/02zfsexpandknowledge/Makefile.in    |   2 +
 contrib/dracut/90zfs/Makefile.am                   |   1 +
 contrib/dracut/90zfs/Makefile.in                   |   3 +
 contrib/dracut/90zfs/module-setup.sh.in            |   4 +-
 contrib/dracut/Makefile.in                         |   2 +
 contrib/initramfs/Makefile.am                      |   5 +-
 contrib/initramfs/Makefile.in                      | 282 ++++++-
 contrib/initramfs/hooks/Makefile.am                |  21 +
 contrib/initramfs/hooks/Makefile.in                | 655
++++++++++++++++
 contrib/initramfs/hooks/{zfs => zfs.in}            |  14 +-
 contrib/initramfs/scripts/Makefile.am              |  20 +
 contrib/initramfs/scripts/Makefile.in              | 855
+++++++++++++++++++++
 contrib/initramfs/scripts/local-top/Makefile.am    |   3 +
 contrib/initramfs/scripts/local-top/Makefile.in    | 573 ++++++++++++++
 contrib/initramfs/scripts/{zfs => zfs.in}          |   8 +-

    2428fbbfcf7f1b2298e1e4ee054430ca155144cc
    Use automake to build initramfs scripts and hooks.

    Most of the additions are auto-generated by the gnu
    auto???? tools.

 debian/changelog                                   |  91 +++
 debian/control                                     |   5 +-
 debian/control.in                                  |   3 +-

    Linux compat bump. Remove duplicated field.
    Bump stdver.

 debian/gitlab-ci.yml                               |  19 +-
 debian/linux_compat                                |   2 +-
 debian/not-installed                               |   1 +
 ...-for-META-and-DCH-consistency-in-autoconf.patch |  10 +-
 ...cut-make-module-setup.sh-shebang-explicit.patch |  16 +-
 .../0010-fix-install-path-of-zpool.d-scripts.patch |  10 +-
 debian/patches/1001-cmd-python-exec-path.patch     |  18 +-
 debian/patches/1004-zed-service-bindir.patch       |  17 +-

    Patch content not changed. Quilt did something like this for fun
    ---- a/etc/systemd/system/zfs-zed.service.in
    -+++ b/etc/systemd/system/zfs-zed.service.in
    +Index: zfs/etc/systemd/system/zfs-zed.service.in
    +===================================================================
    +--- zfs.orig/etc/systemd/system/zfs-zed.service.in
    ++++ zfs/etc/systemd/system/zfs-zed.service.in

 ...-promote-rename-.-recv-should-be-an-error.patch | 229 ++++++

    [bug fix] zfs promote|rename .../%recv should be an error
    (avoiding an confusing and weird usage)

 ...2-Fix-parsable-zfs-get-for-compressratios.patch |  41 +

    [bug fix] Fix parsable 'zfs get' for compressratios
    (making output more parsible to tools)

 ...-zpool-events-scripted-mode-tab-separator.patch |  52 ++

    [bug fix] Fix zpool events scripted mode tab separator
    (more parsible outputs)

 .../2305-Allow-longer-SPA-names-in-stats.patch     | 205 +++++

    [enhancement] Allow longer SPA names in stats
    (allows longer zpool names)

 ...FS-8375-Kernel-memory-leak-in-nvpair-code.patch |  50 ++

    [bug fix] OpenZFS 8375 - Kernel memory leak in nvpair code
    (memory leak, hmmm...)

 ...1-nvlist-code-should-enforce-name-length-.patch |  37 +

    [bug fix] OpenZFS 7261 - nvlist code should enforce name length
limit

 ...8-nvpair_type_is_array-does-not-recognize.patch |  36 +

    [bug fix] OpenZFS 5778 - nvpair_type_is_array() does not recognize
DATA_TYPE_INT8_ARRAY

 .../2313-Fix-printk-calls-missing-log-level.patch  |  29 +

    [bug fix] Fix printk() calls missing log level

 ...2314-Fix-abdstats-kstat-on-32-bit-systems.patch |  39 +

    [bug fix] Fix abdstats kstat on 32-bit systems

 .../2316-Fix-coverity-defects-147480-147584.patch  |  67 ++

    [bug fix] Fix coverity defects: 147480, 147584
    (fixes logically dead code and out-of-bound access)

 .../2317-Fix-coverity-defects-CID-161388.patch     |  43 ++

    [bug fix] Fix coverity defects: CID 161388
    (fixes resource leak for zpool utility)

 ...-ashift-12-by-default-on-SSDSC2BW48-disks.patch |  30 +

    [enhancement] Use ashift=12 by default on SSDSC2BW48 disks
    (one-line patch for another Intel SSD model)

 ...enZFS-8558-8602-lwp_create-returns-EAGAIN.patch | 274 +++++++

    [bug fix] OpenZFS 8558, 8602 - lwp_create() returns EAGAIN
    (this fixes failure on systems with more than 80,000 ZFS file
systems.)

 ...-fails-to-dump-objects-larger-than-128PiB.patch | 258 +++++++

    [bug fix] ZFS send fails to dump objects larger than 128PiB

 ...egfault-in-zpool-iostat-when-adding-VDEVs.patch |  66 ++

    [bug fix] Fix segfault in zpool iostat when adding VDEVs

 .../2328-Fix-fsanitize-address-memory-leak.patch   |  40 +

    [bug fix] Fix -fsanitize=address memory leak

 ...7-zpool-online-e-fails-assertion-when-run.patch |  46 ++

    [bug fix] OpenZFS 8897 - zpool online -e fails assertion when run on
non-leaf vdevs

 ...8-creating-fs-with-checksum-skein-on-the-.patch |  60 ++

    [bug fix] OpenZFS 8898 - creating fs with checksum=skein on the boot
pools fails ungracefully

 ...1-zpool-clear-and-zinject-don-t-work-on-s.patch |  65 ++

    [bug fix] OpenZFS 8641 - "zpool clear" and "zinject" don't work on
"spare" or "replacing" vdevs

 ...2-zfs-holds-In-scripted-mode-do-not-pad-c.patch |  50 ++

    [bug fix] OpenZFS 8972 - zfs holds: In scripted mode, do not pad
columns with spaces
    (more parsible outputs)

 ...rt-Remove-wrong-ASSERT-in-annotate_ecksum.patch |  40 +

    [bug fix] Revert "Remove wrong ASSERT in annotate_ecksum"
    (required by the next patch)

 ...1-ASSERT3U-nui64s-UINT16_MAX-fails-for-la.patch |  69 ++

    [bug fix] OpenZFS 8731 - ASSERT3U(nui64s, <=, UINT16_MAX) fails for
large blocks

 ...nt-zdb-8-from-occasionally-hanging-on-I-O.patch |  53 ++

    [bug fix] Prevent zdb(8) from occasionally hanging on I/O

 ...41-Change-movaps-to-movups-in-AES-NI-code.patch | 279 +++++++

    [bug fix] Change movaps to movups in AES-NI code
    (assembly fix)

 .../patches/3203-Fix-zpool-create-t-tempname.patch | 166 ++++

    [bug fix] Fix 'zpool create -t <tempname>'

 .../allow-rename-of-in-use-zvol-dataset.patch      |  66 ++

    [enhancement] zvol: allow rename of in use ZVOL dataset

 ...clarify-zpool-iostat-statistics-reporting.patch |  40 +

    [doc] Clarify zpool iostat statistics reporting

 ...njection-can-cause-indefinitely-hung-zios.patch |  28 +

    [bug fix] Delay injection can cause indefinitely hung zios

 ...-zvols-rangelock-for-read-bio-with-size-0.patch |  59 ++

    [bug fix] Don't enter zvol's rangelock for read bio with size 0

 debian/patches/enable-zed.patch                    |   6 +-

    Quilt had some fun in changing trivial things.

 debian/patches/fix-zdb-crash.patch                 |  36 +

    [bug fix] Fix zdb crash

 debian/patches/init-debian-openrc-workaround.patch | 110 +--

    This update better supports Debian+OpenRC setup.
    Upstream reviewed this patch but they think this patch
    is too Debian specific and didn't merge.

 debian/patches/series                              |  32 +
 ...-manpage-should-document-legacy-behaviour.patch |  49 ++

    [doc] zfs mount man page should document legacy behaviour

 ...s-mounted-nfsv3-shares-fail-lock-reclaims.patch |  27 +

    [systemd unit] ZFS mounted NFSv3 shares fail lock reclaims

 debian/tests/control                               |  13 +-

    Architecture specific test depenedencies.

 debian/tests/dkms-zfs-test                         |  17 +-

    Fixed my buggy test script which soemtimes yields useless
    negative results.

 debian/zfsutils-linux.examples                     |   1 +

    One new example.

 etc/Makefile.in                                    |   2 +
 etc/init.d/Makefile.in                             |   2 +
 etc/modules-load.d/Makefile.in                     |   2 +
 etc/modules-load.d/zfs.conf.in                     |   4 +-
 etc/sudoers.d/Makefile.in                          |   2 +
 etc/systemd/Makefile.in                            |   2 +
 etc/systemd/system/Makefile.in                     |   2 +

    trivial updates due to linux 5.0 compat

 etc/systemd/system/zfs-import-cache.service.in     |   1 -
 etc/systemd/system/zfs-import-scan.service.in      |   1 -

    Deletion due to "Add kernel module auto-loading".

 etc/zfs/Makefile.am                                |   3 +-
 etc/zfs/Makefile.in                                |   5 +-
 etc/zfs/vdev_id.conf.sas_direct.example            |   3 +
 etc/zfs/vdev_id.conf.scsi.example                  |   9 +
 include/Makefile.in                                |   2 +
 include/linux/Makefile.in                          |   2 +

    2 new examples and linux 5.0 compat.

 include/linux/kmap_compat.h                        |   8 +

    linux 5.0 compat

 include/linux/simd_x86.h                           | 127 ++-

    Linux 5.0 compat: Disable vector instructions on 5.0+ kernels
    The 5.0 kernel no longer exports the functions we need to do vector
instructions.

 include/sys/Makefile.in                            |   2 +
 include/sys/crypto/Makefile.in                     |   2 +

    linux 5.0 compat

 include/sys/dbuf.h                                 |   4 +-
 include/sys/dnode.h                                |   4 +-

    [enhancement] OpenZFS 9577 - remove zfs_dbuf_evict_key tsd

 include/sys/fm/Makefile.in                         |   2 +
 include/sys/fm/fs/Makefile.in                      |   2 +
 include/sys/fs/Makefile.in                         |   2 +
 include/sys/sysevent/Makefile.in                   |   2 +

    linux 5.0 compat

 include/sys/uio_impl.h                             |   2 +-

    [bug fix] deadlock between mm_sem and tx assign in zfs_write() and
page fault

 lib/Makefile.in                                    |   2 +
 lib/libavl/Makefile.in                             |   2 +
 lib/libefi/Makefile.in                             |   2 +
 lib/libicp/Makefile.in                             |   2 +
 lib/libnvpair/Makefile.in                          |   2 +
 lib/libshare/Makefile.in                           |   2 +
 lib/libspl/Makefile.in                             |   2 +
 lib/libspl/asm-generic/Makefile.in                 |   2 +
 lib/libspl/asm-i386/Makefile.in                    |   2 +
 lib/libspl/asm-x86_64/Makefile.in                  |   2 +
 lib/libspl/include/Makefile.in                     |   2 +
 lib/libspl/include/ia32/Makefile.in                |   2 +
 lib/libspl/include/ia32/sys/Makefile.in            |   2 +
 lib/libspl/include/rpc/Makefile.in                 |   2 +
 lib/libspl/include/sys/Makefile.in                 |   2 +
 lib/libspl/include/sys/dktp/Makefile.in            |   2 +
 lib/libspl/include/util/Makefile.in                |   2 +
 lib/libunicode/Makefile.in                         |   2 +
 lib/libuutil/Makefile.in                           |   2 +
 lib/libzfs/Makefile.in                             |   2 +

    linux 5.0 compat: *.in above

 lib/libzfs/libzfs.pc                               |   2 +-
 lib/libzfs/libzfs_core.pc                          |   2 +-

    version bumps

 lib/libzfs/libzfs_util.c                           |  13 +-

    [bug fix] Add kernel module auto-loading

 lib/libzfs_core/Makefile.in                        |   2 +
 lib/libzpool/Makefile.in                           |   2 +
 man/Makefile.in                                    |   2 +
 man/man1/Makefile.in                               |   2 +
 man/man5/Makefile.in                               |   2 +

    linux 5.0 compat

 man/man5/vdev_id.conf.5                            |  42 +-

    doc

 man/man8/Makefile.in                               |   2 +

    5.0

 man/man8/zfs.8                                     |   8 +-

    doc

 module/Makefile.in                                 |   6 +-

   variable rename

 module/zcommon/zfs_uio.c                           |  30 +-

   deadlock between mm_sem and tx assign in zfs_write() and page fault
   plus linux 5.0 compat

 module/zfs/arc.c                                   |   4 +-

   5.0

 module/zfs/dbuf.c                                  |  69 +-
 module/zfs/dnode.c                                 |   7 +-
 module/zfs/dnode_sync.c                            |  17 +-

   *.c above: OpenZFS 9577 - remove zfs_dbuf_evict_key tsd

 module/zfs/vdev_disk.c                             |  32 +-

   5.0

 module/zfs/zfs_ioctl.c                             |  25 +-

   [bug fix] Add kernel module auto-loading

 module/zfs/zfs_vfsops.c                            |  21 +-

   5.0

 module/zfs/zfs_vnops.c                             |  24 +-

   [bug fix] deadlock between mm_sem and tx assign in zfs_write() and
page fault

 rpm/Makefile.in                                    |   2 +
 rpm/generic/Makefile.in                            |   2 +
 rpm/generic/zfs-kmod.spec.in                       |   3 +

   5.0

 rpm/generic/zfs.spec.in                            |  12 +
 rpm/redhat/Makefile.in                             |   2 +
 rpm/redhat/zfs.spec.in                             |  12 +

   redhat stuff. not our business.

 scripts/Makefile.in                                |   2 +
 scripts/dkms.mkconf                                |   4 +
 scripts/zpios-profile/Makefile.in                  |   2 +
 scripts/zpios-test/Makefile.in                     |   2 +
 scripts/zpool-config/Makefile.in                   |   2 +

   5.0

 tests/Makefile.in                                  |   2 +
 tests/runfiles/Makefile.in                         |   2 +
 tests/test-runner/Makefile.in                      |   2 +
 tests/test-runner/cmd/Makefile.in                  |   2 +
 tests/test-runner/cmd/test-runner.py               | 237 +++---

    [enhancement] python3 support

 tests/test-runner/include/Makefile.in              |   2 +
 tests/test-runner/man/Makefile.in                  |   2 +
 tests/zfs-tests/Makefile.in                        |   2 +
 tests/zfs-tests/callbacks/Makefile.in              |   2 +
 tests/zfs-tests/cmd/Makefile.in                    |   2 +
 tests/zfs-tests/cmd/chg_usr_exec/Makefile.in       |   2 +
 tests/zfs-tests/cmd/devname2devid/Makefile.in      |   2 +
 tests/zfs-tests/cmd/dir_rd_update/Makefile.in      |   2 +
 tests/zfs-tests/cmd/file_check/Makefile.in         |   2 +
 tests/zfs-tests/cmd/file_trunc/Makefile.in         |   2 +
 tests/zfs-tests/cmd/file_write/Makefile.in         |   2 +
 tests/zfs-tests/cmd/largest_file/Makefile.in       |   2 +
 tests/zfs-tests/cmd/mkbusy/Makefile.in             |   2 +
 tests/zfs-tests/cmd/mkfile/Makefile.in             |   2 +
 tests/zfs-tests/cmd/mkfiles/Makefile.in            |   2 +
 tests/zfs-tests/cmd/mktree/Makefile.in             |   2 +
 tests/zfs-tests/cmd/mmap_exec/Makefile.in          |   2 +
 tests/zfs-tests/cmd/mmap_libaio/Makefile.in        |   2 +
 tests/zfs-tests/cmd/mmapwrite/Makefile.in          |   2 +

    linux 5.0, all above

 tests/zfs-tests/cmd/mmapwrite/mmapwrite.c          | 140 +++-

    [bug fix] deadlock between mm_sem and tx assign in zfs_write() and
page fault

 tests/zfs-tests/cmd/randfree_file/Makefile.in      |   2 +
 tests/zfs-tests/cmd/readmmap/Makefile.in           |   2 +
 tests/zfs-tests/cmd/rename_dir/Makefile.in         |   2 +
 .../zfs-tests/cmd/rm_lnkcnt_zero_file/Makefile.in  |   2 +
 tests/zfs-tests/cmd/threadsappend/Makefile.in      |   2 +
 tests/zfs-tests/cmd/user_ns_exec/Makefile.in       |   2 +
 tests/zfs-tests/cmd/xattrtest/Makefile.in          |   2 +
 tests/zfs-tests/include/Makefile.in                |   2 +
 tests/zfs-tests/tests/Makefile.in                  |   2 +
 tests/zfs-tests/tests/functional/Makefile.in       |   2 +
 tests/zfs-tests/tests/functional/acl/Makefile.in   |   2 +
 .../tests/functional/acl/posix/Makefile.in         |   2 +
 tests/zfs-tests/tests/functional/atime/Makefile.in |   2 +
 .../zfs-tests/tests/functional/bootfs/Makefile.in  |   2 +
 tests/zfs-tests/tests/functional/cache/Makefile.in |   2 +
 .../tests/functional/cachefile/Makefile.in         |   2 +
 .../tests/functional/casenorm/Makefile.in          |   2 +
 .../zfs-tests/tests/functional/chattr/Makefile.in  |   2 +
 .../tests/functional/checksum/Makefile.in          |   2 +
 .../tests/functional/clean_mirror/Makefile.in      |   2 +
 .../tests/functional/cli_root/Makefile.in          |   2 +
 .../tests/functional/cli_root/zdb/Makefile.in      |   2 +
 .../tests/functional/cli_root/zfs/Makefile.in      |   2 +
 .../functional/cli_root/zfs_clone/Makefile.in      |   2 +
 .../functional/cli_root/zfs_copies/Makefile.in     |   2 +
 .../functional/cli_root/zfs_create/Makefile.in     |   2 +
 .../functional/cli_root/zfs_destroy/Makefile.in    |   2 +
 .../tests/functional/cli_root/zfs_get/Makefile.in  |   2 +
 .../functional/cli_root/zfs_inherit/Makefile.in    |   2 +
 .../functional/cli_root/zfs_mount/Makefile.in      |   2 +
 .../functional/cli_root/zfs_promote/Makefile.in    |   2 +
 .../functional/cli_root/zfs_property/Makefile.in   |   2 +
 .../functional/cli_root/zfs_receive/Makefile.in    |   2 +
 .../functional/cli_root/zfs_rename/Makefile.in     |   2 +
 .../cli_root/zfs_reservation/Makefile.in           |   2 +
 .../functional/cli_root/zfs_rollback/Makefile.in   |   2 +
 .../tests/functional/cli_root/zfs_send/Makefile.in |   2 +
 .../tests/functional/cli_root/zfs_set/Makefile.in  |   2 +
 .../functional/cli_root/zfs_share/Makefile.in      |   2 +
 .../functional/cli_root/zfs_snapshot/Makefile.in   |   2 +
 .../functional/cli_root/zfs_unmount/Makefile.in    |   2 +
 .../functional/cli_root/zfs_unshare/Makefile.in    |   2 +
 .../functional/cli_root/zfs_upgrade/Makefile.in    |   2 +
 .../tests/functional/cli_root/zpool/Makefile.in    |   2 +
 .../functional/cli_root/zpool_add/Makefile.in      |   2 +
 .../functional/cli_root/zpool_attach/Makefile.in   |   2 +
 .../functional/cli_root/zpool_clear/Makefile.in    |   2 +
 .../functional/cli_root/zpool_create/Makefile.in   |   2 +
 .../functional/cli_root/zpool_destroy/Makefile.in  |   2 +
 .../functional/cli_root/zpool_detach/Makefile.in   |   2 +
 .../functional/cli_root/zpool_expand/Makefile.in   |   2 +
 .../functional/cli_root/zpool_export/Makefile.in   |   2 +
 .../functional/cli_root/zpool_get/Makefile.in      |   2 +
 .../functional/cli_root/zpool_history/Makefile.in  |   2 +
 .../functional/cli_root/zpool_import/Makefile.in   |   2 +
 .../cli_root/zpool_labelclear/Makefile.in          |   2 +
 .../functional/cli_root/zpool_offline/Makefile.in  |   2 +
 .../functional/cli_root/zpool_online/Makefile.in   |   2 +
 .../functional/cli_root/zpool_remove/Makefile.in   |   2 +
 .../functional/cli_root/zpool_replace/Makefile.in  |   2 +
 .../functional/cli_root/zpool_scrub/Makefile.in    |   2 +
 .../functional/cli_root/zpool_set/Makefile.in      |   2 +
 .../functional/cli_root/zpool_status/Makefile.in   |   2 +
 .../functional/cli_root/zpool_sync/Makefile.in     |   2 +
 .../functional/cli_root/zpool_upgrade/Makefile.in  |   2 +
 .../tests/functional/cli_user/Makefile.in          |   2 +
 .../tests/functional/cli_user/misc/Makefile.in     |   2 +
 .../tests/functional/cli_user/zfs_list/Makefile.in |   2 +
 .../functional/cli_user/zpool_iostat/Makefile.in   |   2 +
 .../functional/cli_user/zpool_list/Makefile.in     |   2 +
 .../tests/functional/compression/Makefile.in       |   2 +
 .../tests/functional/cp_files/Makefile.in          |   2 +
 tests/zfs-tests/tests/functional/ctime/Makefile.in |   2 +
 .../tests/functional/delegate/Makefile.in          |   2 +
 .../zfs-tests/tests/functional/devices/Makefile.in |   2 +
 .../zfs-tests/tests/functional/events/Makefile.in  |   2 +
 tests/zfs-tests/tests/functional/exec/Makefile.in  |   2 +
 tests/zfs-tests/tests/functional/fault/Makefile.in |   2 +
 .../tests/functional/features/Makefile.in          |   2 +
 .../functional/features/async_destroy/Makefile.in  |   2 +
 .../functional/features/large_dnode/Makefile.in    |   2 +
 .../tests/functional/grow_pool/Makefile.in         |   2 +
 .../tests/functional/grow_replicas/Makefile.in     |   2 +
 .../zfs-tests/tests/functional/history/Makefile.in |   2 +
 .../tests/functional/inheritance/Makefile.in       |   2 +
 tests/zfs-tests/tests/functional/inuse/Makefile.in |   2 +
 tests/zfs-tests/tests/functional/kstat/Makefile.in |   2 +
 .../tests/functional/large_files/Makefile.in       |   2 +
 .../tests/functional/largest_pool/Makefile.in      |   2 +
 .../zfs-tests/tests/functional/libzfs/Makefile.in  |   2 +
 .../tests/functional/link_count/Makefile.in        |   2 +
 .../tests/functional/migration/Makefile.in         |   2 +
 tests/zfs-tests/tests/functional/mmap/Makefile.in  |   2 +

    all above: linux 5.0

 .../tests/functional/mmap/mmap_write_001_pos.ksh   |   8 +-

    deadlock between mm_sem and tx assign in zfs_write() and page fault

 tests/zfs-tests/tests/functional/mmp/Makefile.in   |   2 +
 tests/zfs-tests/tests/functional/mount/Makefile.in |   2 +
 .../tests/functional/mv_files/Makefile.in          |   2 +
 .../tests/functional/nestedfs/Makefile.in          |   2 +
 .../tests/functional/no_space/Makefile.in          |   2 +
 .../tests/functional/nopwrite/Makefile.in          |   2 +
 .../tests/functional/online_offline/Makefile.in    |   2 +
 .../tests/functional/pool_names/Makefile.in        |   2 +
 .../tests/functional/poolversion/Makefile.in       |   2 +
 .../tests/functional/privilege/Makefile.in         |   2 +
 tests/zfs-tests/tests/functional/quota/Makefile.in |   2 +
 tests/zfs-tests/tests/functional/raidz/Makefile.in |   2 +
 .../tests/functional/redundancy/Makefile.in        |   2 +
 .../tests/functional/refquota/Makefile.in          |   2 +
 .../tests/functional/refreserv/Makefile.in         |   2 +
 .../tests/functional/rename_dirs/Makefile.in       |   2 +
 .../tests/functional/replacement/Makefile.in       |   2 +
 .../tests/functional/reservation/Makefile.in       |   2 +
 .../tests/functional/rootpool/Makefile.in          |   2 +
 tests/zfs-tests/tests/functional/rsend/Makefile.in |   2 +
 .../tests/functional/scrub_mirror/Makefile.in      |   2 +
 tests/zfs-tests/tests/functional/slog/Makefile.in  |   2 +
 .../tests/functional/snapshot/Makefile.in          |   2 +
 .../tests/functional/snapused/Makefile.in          |   2 +
 .../zfs-tests/tests/functional/sparse/Makefile.in  |   2 +
 .../tests/functional/threadsappend/Makefile.in     |   2 +
 .../zfs-tests/tests/functional/tmpfile/Makefile.in |   2 +
 .../tests/functional/truncate/Makefile.in          |   2 +
 .../zfs-tests/tests/functional/upgrade/Makefile.in |   2 +
 .../tests/functional/user_namespace/Makefile.in    |   2 +
 .../tests/functional/userquota/Makefile.in         |   2 +
 .../tests/functional/vdev_zaps/Makefile.in         |   2 +
 .../tests/functional/write_dirs/Makefile.in        |   2 +
 tests/zfs-tests/tests/functional/xattr/Makefile.in |   2 +
 tests/zfs-tests/tests/functional/zvol/Makefile.in  |   2 +
 .../tests/functional/zvol/zvol_ENOSPC/Makefile.in  |   2 +
 .../tests/functional/zvol/zvol_cli/Makefile.in     |   2 +
 .../tests/functional/zvol/zvol_misc/Makefile.in    |   2 +
 .../tests/functional/zvol/zvol_swap/Makefile.in    |   2 +
 tests/zfs-tests/tests/perf/Makefile.in             |   2 +
 tests/zfs-tests/tests/perf/fio/Makefile.in         |   2 +
 tests/zfs-tests/tests/perf/regression/Makefile.in  |   2 +
 tests/zfs-tests/tests/perf/scripts/Makefile.in     |   2 +
 tests/zfs-tests/tests/stress/Makefile.in           |   2 +
 udev/Makefile.in                                   |   2 +

    all above: linux 5.0

 udev/rules.d/69-vdev.rules.in                      |   4 +

    Add enclosure_symlinks option to vdev_id

 udev/rules.d/90-zfs.rules.in                       |   2 +-

    [bug fix] Add kernel module auto-loading

 udev/rules.d/Makefile.in                           |   2 +

    5.0

 zfs_config.h.in                                    |  21 +-

    auto generated

 344 files changed, 7224 insertions(+), 552 deletions(-)
```

Upstream git changelog between 0.7.12 and 0.7.13:
```
* a8c2b7ebc (HEAD, tag: zfs-0.7.13) Tag zfs-0.7.13
* 2af898ee2 test-runner: python3 support
* c32c2f17d Fix flake 8 style warnings
* 2254b2bbb GCC 9.0: Fix ztest "directive argument is not a
nul-terminated string"
* 5c4ec382a Linux 5.0 compat: Fix bio_set_dev()
* e22bfd814 Linux 5.0 compat: Disable vector instructions on 5.0+
kernels
* f45ad7bff Linux 5.0 compat: Fix SUBDIRs
* 0a3a4d067 Linux 5.0 compat: Convert MS_* macros to SB_*
* ba8024a28 Linux 5.0 compat: Use totalram_pages()
* edc2675ae Linux 5.0 compat: access_ok() drops 'type' parameter
* 98bb45e27 deadlock between mm_sem and tx assign in zfs_write() and
page fault
* 44f463824 dkms: Enable debuginfo option to be set with zfs sysconfig
file
* b0d579bc5 Bump commit subject length to 72 characters
* 7e5def8ae zfs.8 uses wrong snapshot names in Example 15
* 89019a846 Add enclosure_symlinks option to vdev_id
* 41f7723e9 vdev_id: new slot type ses
* 2b8c3cb0c vdev_id: extension for new scsi topology
* f325d76e9 Rename macro ZFS_MINOR due to Lustre conflict
* e3fb781c5 Add kernel module auto-loading
* 14a5e48fb Use autoconf variable for C preprocessor
* 01937958c OpenZFS 9577 - remove zfs_dbuf_evict_key tsd
* edb504f9d Honor --with-mounthelperdir where applicable
* 2428fbbfc contrib/initramfs: switch to automake
* 16d298188 (tag: zfs-0.7.12) Tag zfs-0.7.12
```


(include/attach the debdiff against the package in testing)

unblock zfs-linux/0.7.13-1

-- System Information:
Debian Release: 10.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

zfs-0.7.12-2..0.7.13-1.diff.zst (114K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#928746: unblock: zfs-linux/0.7.13-1

Paul Gevers-4
Control: tags -1 moreinfo

Hi Mo,

On Thu, 09 May 2019 22:09:18 -0700 Mo Zhou <[hidden email]> wrote:
> zfs-linux (= 0.7.13-1) is 66 days in unstable and there is no new bug
> for it.
> Compared to (0.7.12-2), the (0.7.13-1) version in unstable only
> introduces
> bug fixes. Aron has already applied for an unblock but it was rejected.
> Here I'm requesting for unblock again.

I checked bug #923770 again (it was filed by you by the way). As I said
in that bug, I didn't spot anything that was at the level of important
or more severe in Debian BTS terms. I may have been wrong, but then
please point me to the changes so important that you want them in
buster. Please also be prepared to undo the new upstream release and
just fix the bugs that are so important to you.

Be aware that requests like this one are draining energy from the
release team. It isn't nice to turn a maintainer down on a request,
repeating the process is worse. Your changes are huge (your explanation
is appreciated), we get several unblock requests per day and we have a
freeze policy in place to manage it. Please don't push your pet project
so hard if it doesn't meet the policy that you are driving the
volunteers in the release team away. Thanks for also considering our time.

Paul


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#928746: unblock: zfs-linux/0.7.13-1

Christian Marillat
On 30 mai 2019 21:51, Paul Gevers <[hidden email]> wrote:

> Control: tags -1 moreinfo
>
> Hi Mo,
>
> On Thu, 09 May 2019 22:09:18 -0700 Mo Zhou <[hidden email]> wrote:
>> zfs-linux (= 0.7.13-1) is 66 days in unstable and there is no new bug
>> for it.
>> Compared to (0.7.12-2), the (0.7.13-1) version in unstable only
>> introduces
>> bug fixes. Aron has already applied for an unblock but it was rejected.
>> Here I'm requesting for unblock again.
>
> I checked bug #923770 again (it was filed by you by the way). As I said
> in that bug, I didn't spot anything that was at the level of important
> or more severe in Debian BTS terms. I may have been wrong, but then
> please point me to the changes so important that you want them in
> buster. Please also be prepared to undo the new upstream release and
> just fix the bugs that are so important to you.

I see a problem with longterm kernel is Buster (4.19).
4.19.38 doesn't build with zfs 0.7.12

OK, 4.19.37 will be the Buster kernel, but has we upgrade recent kernel
from longterm branch for stable release the next stable release will
probably break zfs.

So zfs 0.7.13 is probably a good choice for Buster.

This is because kernel 5.0 "drops export of __kernel_fpu_begin/end" has
been back-ported to 4.19.38 (and also 4.14.120) kernel and fixed in zfs 0.7.13

https://github.com/NixOS/nixpkgs/issues/60907
https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.19.38
https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.14.120

Christian

Reply | Threaded
Open this post in threaded view
|

Bug#928746: unblock: zfs-linux/0.7.13-1

Mo Zhou
In reply to this post by Paul Gevers-4
Hi Paul,

On 2019-05-30 19:51, Paul Gevers wrote:
> or more severe in Debian BTS terms. I may have been wrong, but then
> please point me to the changes so important that you want them in
> buster. Please also be prepared to undo the new upstream release and
> just fix the bugs that are so important to you.

I've already forgotten them and I'm tired to review the diff.
Let's forget all the important stuff and only focus on the grave one:

Due to a stable kernel change (4.19.37->4.19.38) that makes me sad,
we got a grave RC for ZFS 0.7.12-2 (testing) which makes it not suitable
for the Buster release:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929929

We have two solutions for this stable RC:

1. just unblock 0.7.13-1 .
2. revert debdiff(0.7.12-2,0.7.12-5), then cherry-pick
   the commits[1] that fix the build issue, then go
   through t-p-u for 0.7.12-6 .

Patching the kernel is impossible because kernel maintainers
refused to do that. So that's an invalid solution.

> Be aware that requests like this one are draining energy from the
> release team. It isn't nice to turn a maintainer down on a request,
> repeating the process is worse. Your changes are huge (your explanation
> is appreciated), we get several unblock requests per day and we have a
> freeze policy in place to manage it. Please don't push your pet project
> so hard if it doesn't meet the policy that you are driving the
> volunteers in the release team away. Thanks for also considering our time.

Sorry for that. My motivation is just that 0.7.13-1 is really
expected to reduce the number of problems compared to 0.7.12-2...

Please make a choice between the two proposed solution above.
If release team doesn't trust every line of code, please just
choose 2. I'll never argue about ZFS unblock again for Buster.

[1] Patch:
https://github.com/zfsonlinux/zfs/commit/e22bfd814960295029ca41c8e116e8d516d3e730

Reply | Threaded
Open this post in threaded view
|

Bug#928746: unblock: zfs-linux/0.7.13-1

Mo Zhou
control: retitle -1 unblock: zfs-linux/0.7.12-6 (or 0.7.13-1)
control: close -1

Hi Release Team,

On 2019-06-03 15:05, Mo Zhou wrote:
> Patching the kernel is impossible because kernel maintainers
> refused to do that. So that's an invalid solution.

After a short discussion with Aron Xu, I realized that I made
a mistake about the kernel SIMD problem.

It's the ***LTS KERNEL UPDATE*** that breaks ZFS 0.7.12-2.
It's not a bug of 0.7.12-2 at all. An LTS KERNEL UPDATE
that BREAKS stuff indicates a grave RC.

> I'll never argue about ZFS unblock again for Buster.

Sorry and I decided to give up the unblock request.
We[2] Debian ZoL maintainers decided to do nothing about
the kernel SIMD issue and we'll file an RC bug against
the kernel immediately after the 10.1 point release
because it breaks stuff.

[1]
https://github.com/zfsonlinux/zfs/commit/e22bfd814960295029ca41c8e116e8d516d3e730
[2] Aron and Me.

Reply | Threaded
Open this post in threaded view
|

Bug#928746: unblock: zfs-linux/0.7.13-1

Sam Hartman-3
Please start talking to the kernel team now, and let them know your
position.

If you strongly suspect you're going to file an RC bug in the future,
you should be talking now, not just holding back.

I'm available to mediate if that ends up being useful.