Bug#929405: ITP: pveclib -- power vector library

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Gabriel F. T. Gomes-2
Package: wnpp
Severity: normal

I will start working on the packaging for pveclib
(https://github.com/open-power-sdk/pveclib).

Cheers,
Gabriel

Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Gabriel F. T. Gomes-4
Hi, Steve,

After creating a initial version of the packaging [1], I got two
packages: one that contains the headers and the static library
(libpvec-dev_1.0.0-1_ppc64el.deb), and another that contains the shared
library (libpvec0_1.0.0-1_ppc64el.deb).

My first question would be: is that expected?  The shared library
contains a couple of symbols (e.g. tipowof10 and decpowof2) and it has
a valid soname, but README.md says that pveclib is "header files...".

Maybe the text is just out-of-date (maybe the wiki has newer content?).


[1] https://salsa.debian.org/gabrielftg-guest/pveclib/commit/3aeaa970f1f78b239bd26bb1e7ff52d77e2ec452

Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Gabriel F. T. Gomes-4
In reply to this post by Gabriel F. T. Gomes-2
On Fri, May 24 2019, Steven Munroe wrote:
> In the current state, these libraries are only required for unit tests, but
> could be used for applications that need those constant values.

OK, if it can be useful for applications, than it's probably better to
distribute it, right away.

> [...] So the current build is looking ahead to a configuration
> that provides a space vs performance trade-off.
>
> Fro example muludq <
> https://munroesj52.github.io/vec__int128__ppc_8h.html#aee5c5b2998ef105b4c6f39739748ffa8>
> where the POWER8 implementation runs 132 bytes. It is even bigger for
> POWER7 and only 80 bytes for POWER9.
>
> The threshold for in-lining is a matter of some debate.
>
> So I expect that eventually pveclib will need the option to move some
> operations for some -mcpu= values to use library calls. And some
> performance oriented applications will want to inline every thing
> regardless.

OK.  All good points to ship the shared library.

> For now I want to make pveclib available as-is to users. Then if someone
> complains about code size we can add the controls/configuration to adjust.

As-is sounds good to me. :)

With this information, I think the package is ready to be submitted to
the Debian Archive.  However, since we are under the freeze, that might
take a while, but I'll get the process started.

Thanks, Steve!

Cheers,
Gabriel.

Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Gabriel F. T. Gomes-4
In reply to this post by Gabriel F. T. Gomes-2
On Sat, 25 May 2019 15:31:47 -0300 "Gabriel F. T. Gomes" <[hidden email]> wrote:
>
> As-is sounds good to me. :)

On second thought, I have an usability question for you, which would
also be relevant for other distros that might ship pveclib...

The headers are currently installed under /usr/include/pveclib/ (this
is based on what 'make install' does).  Then, users will have to use
'-I/usr/include/pveclib/' on their compilation commands, similarly to
what is suggested in the README page [1] for pveclib.

Wouldn't it be more appropriate to ask users to use:

  #include <pveclib/some_header.h>

instead?  (and forget about '-I').

But if we do that, all header files in pveclib would have to be patched
so that the files they include also contain 'pveclib/', for instance,
in src/vec_bcd_ppc.h:

  -#include <vec_common_ppc.h>
  -#include <vec_char_ppc.h>
  -#include <vec_int128_ppc.h>
  +#include <pveclib/vec_common_ppc.h>
  +#include <pveclib/vec_char_ppc.h>
  +#include <pveclib/vec_int128_ppc.h>

I submitted a pull request [2] upstream to foster this discussion.

[1] https://github.com/open-power-sdk/pveclib#usage

[2] https://github.com/open-power-sdk/pveclib/pull/71

Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Gabriel F. T. Gomes-4
On Wed, 29 May 2019, Gabriel F. T. Gomes wrote:
>
>I submitted a pull request [2] upstream to foster this discussion.
>
>[...]
>
>[2] https://github.com/open-power-sdk/pveclib/pull/71

For the record: this pull request was superseded by pull request #73 [1],
which has been integrated.

Steve,

You mentioned you had plans to tag pveclib again (as v1.0.1, iirc)?  If
you still have them, I'll wait for it then sync the source code in Debian.
Otherwise, I'll add debian/patches for pull requests #73 (and #74).

Please, let me know of your current plans.

Thanks,
Gabriel

[1] https://github.com/open-power-sdk/pveclib/pull/73

Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Steven Munroe
yes but distracted by the bug I found with GCC9 (Fedora 30).

I need s work around for that, Then I will update/tag.

On Thu, Jun 13, 2019 at 9:07 AM Gabriel F. T. Gomes <[hidden email]> wrote:
On Wed, 29 May 2019, Gabriel F. T. Gomes wrote:
>
>I submitted a pull request [2] upstream to foster this discussion.
>
>[...]
>
>[2] https://github.com/open-power-sdk/pveclib/pull/71

For the record: this pull request was superseded by pull request #73 [1],
which has been integrated.

Steve,

You mentioned you had plans to tag pveclib again (as v1.0.1, iirc)?  If
you still have them, I'll wait for it then sync the source code in Debian.
Otherwise, I'll add debian/patches for pull requests #73 (and #74).

Please, let me know of your current plans.

Thanks,
Gabriel

[1] https://github.com/open-power-sdk/pveclib/pull/73
Reply | Threaded
Open this post in threaded view
|

Bug#929405: ITP: pveclib -- power vector library

Gabriel F. T. Gomes-4
On 13 Jun 2019, Steven Munroe wrote:

>I need s work around for that, Then I will update/tag.

Thanks for the fixes and for the tagging.

With that, I was able to finish the package and send it for review
(see https://bugs.debian.org/930709).