Bug#929750: debhelper: dh_installdocs errs out on non-matching pattern in v10 mode

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#929750: debhelper: dh_installdocs errs out on non-matching pattern in v10 mode

Andreas Metzler-2
Source: debhelper
Version: 12.1.1
Severity: normal

Hello,

one of the *changes* in v11 mode is the following:
| The helpers dh_installdocs, dh_installexamples, dh_installinfo, and
| dh_installman now error out if their config has a pattern that does
| not match anything or reference a path that does not exist.

However I see this behavior for dh_installdocs in v10 mode, too:
-------------
(sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.6.8$ cat debian/compat
10
(sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.6.8$ cat debian/gnutls-doc.docs
doc/gnutls.pdf
(sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.6.8$ dh_installdocs -O--builddirectory=b4deb --no-act --verbose -pgnutls-doc ; echo $?
dh_installdocs: Cannot find (any matches for) "doc/gnutls.pdf" (tried in .)

2
-------------

I cannot say when this bug was introduced, it might be long-standing.

cu Andreas

-- System Information:
Debian Release: 10.0
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_AT.UTF-8, LC_CTYPE=de_AT.UTF-8 (charmap=UTF-8), LANGUAGE=de_AT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Reply | Threaded
Open this post in threaded view
|

Bug#929750: debhelper: dh_installdocs errs out on non-matching pattern in v10 mode

Niels Thykier
Control: tags -1 moreinfo

On Thu, 30 May 2019 13:44:27 +0200 Andreas Metzler <[hidden email]> wrote:

> Source: debhelper
> Version: 12.1.1
> Severity: normal
>
> Hello,
>
> one of the *changes* in v11 mode is the following:
> | The helpers dh_installdocs, dh_installexamples, dh_installinfo, and
> | dh_installman now error out if their config has a pattern that does
> | not match anything or reference a path that does not exist.
>
> However I see this behavior for dh_installdocs in v10 mode, too:
> -------------
> (sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.6.8$ cat debian/compat
> 10
> (sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.6.8$ cat debian/gnutls-doc.docs
> doc/gnutls.pdf
> (sid)ametzler@argenau:/tmp/GNUTLS/gnutls-3.6.8$ dh_installdocs -O--builddirectory=b4deb --no-act --verbose -pgnutls-doc ; echo $?
> dh_installdocs: Cannot find (any matches for) "doc/gnutls.pdf" (tried in .)
>
> 2
> -------------
>
> I cannot say when this bug was introduced, it might be long-standing.
>
> cu Andreas
>
> [...]
>

Hi Andreas,

The code is working as intended, but I think you have found the
documentation confusing.

 * Suggestions for improving the docs are welcome.

The root issue here is that "doc/gnutls.pdf" is not a pattern (in the
compat 11 sense).  A pattern would be something like "doc/*.pdf".

The "non-pattern" case has been an error since compat 5[1].  Compat 11
extends that to patterns as well (to match dh_install, where this has
been an error since compat 5 as well).


Thanks,
~Niels

[1] Note: debhelper did have a regression at some point for an extended
period of time where non-patterns did not trigger errors as intended -
though the fix for that regression is not recent (fixed during
debhelper/11 AFAIR), so I doubt it is related to this bug.