Bug#929912: unblock: ltsp/5.18.12-3

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#929912: unblock: ltsp/5.18.12-3

Vagrant Cascadian-4
Package: release.debian.org
Severity: normal
User: [hidden email]
Usertags: unblock
X-Debbugs-Cc: [hidden email], [hidden email]

Please unblock package ltsp

This fixes two release-critical bugs, an important bug, and updates
the debconf translation for Dutch.

Builds from unsigned CDs failed due to changes in apt being more
strict regarding unsigned repositories. This is fixed by passing the
--trust-file-mirror option introduced in ltsp-build-client upstream,
but not added to the default arguments for the ltsp-client-builder
.udeb. This .udeb is not used in the default debian-installer images,
and thus should have no impact on them.

The tool to build an LTSP chroot environment failed to detect the
codename in buster now that /etc/debian_version contains a version,
instead passing the version of Debian "10" to debootstrap, resulting
in a failure to build. The upstream fix was to switch back to using
lsb_release, and the patch applied to this version.

An important issue in the arguments for mounting loopback images was
discovered and fixed upstream, ensuring read-only mounts which might
otherwise lead to filesystem inconsistancies with ext4 or other
writeable filesystems, and fixing a typo in the loop argument passed
to mount. The upstream patch is included in this version.

Additionally, the Dutch debconf message translation was included in
this version.

diff -Nru ltsp-5.18.12/debian/changelog ltsp-5.18.12/debian/changelog
--- ltsp-5.18.12/debian/changelog 2018-12-24 17:30:09.000000000 -0800
+++ ltsp-5.18.12/debian/changelog 2019-05-29 13:02:07.000000000 -0700
@@ -1,3 +1,23 @@
+ltsp (5.18.12-3) unstable; urgency=medium
+
+  * ltsp-client-builder: Add --trust-file-mirror to ltsp-build-client
+    options to fix builds from unsigned CDs (Closes: #929735).
+
+ -- Vagrant Cascadian <[hidden email]>  Wed, 29 May 2019 13:02:07 -0700
+
+ltsp (5.18.12-2) unstable; urgency=medium
+
+  [ Frans Spiesschaert ]
+  * [INTL:nl] Dutch translation of debconf messages (Closes: #924103).
+
+  [ Vagrant Cascadian ]
+  * Add patch to fix loop mounting and ensure mount is read-only. Thanks
+    to Alkis Georgopoulos.
+  * Add patch to fix codename detection (Closes: #925173). Thanks to
+    Wolfgang Schweer.
+
+ -- Vagrant Cascadian <[hidden email]>  Mon, 27 May 2019 04:58:46 -0700
+
 ltsp (5.18.12-1) unstable; urgency=medium
 
   * New upstream version.
diff -Nru ltsp-5.18.12/debian/ltsp-client-builder.templates ltsp-5.18.12/debian/ltsp-client-builder.templates
--- ltsp-5.18.12/debian/ltsp-client-builder.templates 2018-12-24 17:15:33.000000000 -0800
+++ ltsp-5.18.12/debian/ltsp-client-builder.templates 2019-05-29 12:23:24.000000000 -0700
@@ -29,7 +29,7 @@
 
 Template: ltsp-client-builder/build-client-opts
 Type: string
-Default: --mirror file:///media/cdrom --security-mirror none --updates-mirror none --accept-unsigned-packages
+Default: --mirror file:///media/cdrom --security-mirror none --updates-mirror none --accept-unsigned-packages --trust-file-mirror
 # Only used for preseeding arguments to ltsp-client-builder.
 Description: for internal use: arguments for ltsp-build-client:
  this option is meant to be used with debconf preseeding.
diff -Nru ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch
--- ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch 1969-12-31 16:00:00.000000000 -0800
+++ ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch 2019-05-27 04:55:58.000000000 -0700
@@ -0,0 +1,24 @@
+From 5dcca1e8dcd864669ffa1cb36d89f832077a7243 Mon Sep 17 00:00:00 2001
+From: Alkis Georgopoulos <[hidden email]>
+Date: Sat, 25 May 2019 09:49:38 +0300
+Subject: Debian: correct typo in ltsploop, avoid ext4 journal
+ playback errors.
+
+---
+ client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop b/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop
+index 595e56ba..12bc4601 100755
+--- a/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop
++++ b/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop
+@@ -45,5 +45,5 @@ if [ -f "${rootmnt}/${ltsploop}" ]; then
+    mount -o move ${rootmnt} /ltsploop
+    mkdir -p ${rootmnt}
+    # TODO filesystem detection
+-   mount -o ltsploop -t ${ltsploopfs} /ltsploop/${ltsploop} ${rootmnt}
++   mount -o loop,ro -t ${ltsploopfs} /ltsploop/${ltsploop} ${rootmnt}
+ fi
+--
+2.20.1
+
diff -Nru ltsp-5.18.12/debian/patches/fix-codename-detection.patch ltsp-5.18.12/debian/patches/fix-codename-detection.patch
--- ltsp-5.18.12/debian/patches/fix-codename-detection.patch 1969-12-31 16:00:00.000000000 -0800
+++ ltsp-5.18.12/debian/patches/fix-codename-detection.patch 2019-05-27 04:54:47.000000000 -0700
@@ -0,0 +1,33 @@
+From e7c0ed4201d06a4d2fe4f686352c4a74a6eb3a47 Mon Sep 17 00:00:00 2001
+From: Wolfgang Schweer <[hidden email]>
+Date: Wed, 20 Mar 2019 19:50:13 +0100
+Subject: ltsp: codename detection code not useful for stable
+ (Closes: #925173).
+
+While it made sense to use /etc/debian_release in testing (the file contains
+text like 'buster/sid') it fails to work in stable (the file content is a plain
+version number like 9.8). 'lsb_release --short --codename' is supposed to work
+in stable also in standalone mode.
+
+(Vagrant Cascadian made minor edit to use longhand options consistent
+with upstream).
+---
+ .../plugins/ltsp-build-client/Debian/000-basic-configuration    | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/server/share/ltsp/plugins/ltsp-build-client/Debian/000-basic-configuration b/server/share/ltsp/plugins/ltsp-build-client/Debian/000-basic-configuration
+index 30d04dcf..d075d9df 100644
+--- a/server/share/ltsp/plugins/ltsp-build-client/Debian/000-basic-configuration
++++ b/server/share/ltsp/plugins/ltsp-build-client/Debian/000-basic-configuration
+@@ -2,7 +2,7 @@ case "$MODE" in
+     configure)
+         ARCH=${ARCH:-"$(dpkg --print-architecture)"}
+         APT_GET_OPTS=${APT_GET_OPTS:-"-y"}
+-        DIST=${DIST:-"$(cat /etc/debian_version | cut -d'/' -f1)"}
++        DIST=${DIST:-"$(lsb_release --short --codename)"}
+         MIRROR=${MIRROR:-"http://deb.debian.org/debian"}
+         COMPONENTS=${COMPONENTS:-"main"}
+         EARLY_PACKAGES=${EARLY_PACKAGES:-"ltsp-client"}
+--
+2.20.1
+
diff -Nru ltsp-5.18.12/debian/patches/series ltsp-5.18.12/debian/patches/series
--- ltsp-5.18.12/debian/patches/series 2018-12-24 17:18:18.000000000 -0800
+++ ltsp-5.18.12/debian/patches/series 2019-05-27 04:54:47.000000000 -0700
@@ -1,3 +1,5 @@
 manpages-use-debian-version
 disable-default-encrypted-swap.patch
 reproducible-mo-files
+correct-typo-in-ltsploop-avoid-ext4-journal-p.patch
+fix-codename-detection.patch
diff -Nru ltsp-5.18.12/debian/po/nl.po ltsp-5.18.12/debian/po/nl.po
--- ltsp-5.18.12/debian/po/nl.po 2018-12-24 17:15:33.000000000 -0800
+++ ltsp-5.18.12/debian/po/nl.po 2019-05-27 04:52:26.000000000 -0700
@@ -1,21 +1,24 @@
-# ltsp debconf templates for LANGUAGE.
+# ltsp debconf templates for Dutch.
 # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
 # This file is distributed under the same license as the ltsp package.
 # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
+# Frans Spiesschaert <[hidden email]>, 2019.
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: ltsp\n"
+"Project-Id-Version: ltsp_5.18.12-1\n"
 "Report-Msgid-Bugs-To: [hidden email]\n"
 "POT-Creation-Date: 2016-01-27 20:02-0800\n"
-"PO-Revision-Date: 2007-10-19 18:30+0100\n"
-"Last-Translator: Bart Cornelis <[hidden email]>\n"
-"Language-Team: debian-l10n-dutch <[hidden email]>\n"
+"PO-Revision-Date: 2019-02-21 16:27+0100\n"
+"Last-Translator: Frans Spiesschaert <[hidden email]>\n"
+"Language-Team: Debian Dutch l10n Team <[hidden email]>\n"
 "Language: \n"
 "MIME-Version: 1.0\n"
-"Content-Type: text/plain; charset=utf-8\n"
+"Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "X-Poedit-Language: Dutch\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Generator: Gtranslator 2.91.7\n"
 
 #. Type: boolean
 #. Description
@@ -30,15 +33,15 @@
 "Please choose whether you want to set up an LTSP chroot environment on this "
 "machine, to act as a thin client server."
 msgstr ""
-"Wilt u de LTSP-chroot-omgeving op deze machine opzetten als een thin-client-"
-"server?"
+"Geef aan of u op deze machine een LTSP-chroot-omgeving wilt opzetten om te "
+"fungeren als een thin-client-server."
 
 #. Type: text
 #. Description
 #. Item in the main menu to select this package
 #: ../ltsp-client-builder.templates:3001
 msgid "Build LTSP chroot"
-msgstr "Bouw de LTSP-chroot"
+msgstr "Bouwen van de LTSP-chroot"
 
 #. Type: text
 #. Description
@@ -83,8 +86,8 @@
 "Please choose which of this system's multiple spare interfaces should be "
 "used for the thin client."
 msgstr ""
-"Dit systeem heeft meerdere (netwerk)interfaces. Welke hiervan wilt u "
-"gebruiken voor de thin-client?"
+"Dit systeem heeft meerdere ongebruikte (netwerk)interfaces. Welke hiervan "
+"wilt u gebruiken voor de thin-client?"
 
 #~ msgid "Installation aborted"
 #~ msgstr "Installatie is afgebroken"


unblock ltsp/5.18.12-3


Thanks for all your work on releasing Debian!


live well,
  vagrant

signature.asc (233 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#929912: unblock: ltsp/5.18.12-3

Niels Thykier
Control: tags -1 confirmed d-i

Vagrant Cascadian:

> Package: release.debian.org
> Severity: normal
> User: [hidden email]
> Usertags: unblock
> X-Debbugs-Cc: [hidden email], [hidden email]
>
> Please unblock package ltsp
>
> This fixes two release-critical bugs, an important bug, and updates
> the debconf translation for Dutch.
>
> Builds from unsigned CDs failed due to changes in apt being more
> strict regarding unsigned repositories. This is fixed by passing the
> --trust-file-mirror option introduced in ltsp-build-client upstream,
> but not added to the default arguments for the ltsp-client-builder
> .udeb. This .udeb is not used in the default debian-installer images,
> and thus should have no impact on them.
>
> The tool to build an LTSP chroot environment failed to detect the
> codename in buster now that /etc/debian_version contains a version,
> instead passing the version of Debian "10" to debootstrap, resulting
> in a failure to build. The upstream fix was to switch back to using
> lsb_release, and the patch applied to this version.
>
> An important issue in the arguments for mounting loopback images was
> discovered and fixed upstream, ensuring read-only mounts which might
> otherwise lead to filesystem inconsistancies with ext4 or other
> writeable filesystems, and fixing a typo in the loop argument passed
> to mount. The upstream patch is included in this version.
>
> Additionally, the Dutch debconf message translation was included in
> this version.
>
> [...]
>
> unblock ltsp/5.18.12-3
>
>
> Thanks for all your work on releasing Debian!
>
>
> live well,
>   vagrant
>

Looks good to me, CC'ing KiBi for a d-i ack before completing the unblock.

Thanks,
~Niels

Reply | Threaded
Open this post in threaded view
|

Bug#929912: unblock: ltsp/5.18.12-3

Cyril Brulebois-4
Niels Thykier <[hidden email]> (2019-06-04):
> Control: tags -1 confirmed d-i
>
> Vagrant Cascadian:
> > Please unblock package ltsp
> >
> > unblock ltsp/5.18.12-3
>
> Looks good to me, CC'ing KiBi for a d-i ack before completing the unblock.

No objections, thanks.


Cheers,
--
Cyril Brulebois ([hidden email])            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

signature.asc (849 bytes) Download Attachment