Bug#930487: lintian: speed up test suite CI

classic Classic list List threaded Threaded
29 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

Felix Lechner-4
Hi

On Sun, Jul 21, 2019 at 6:28 AM Chris Lamb <[hidden email]> wrote:
>
> I am very much disposed towards simple and braindead obvious in things
> like this, especially when they hit 90% of the use-case. And then we
> can get back to other stuff...

I realized we are talking about related but different things. Please
look out for a merge request on the topics that go beyond the scope of
this bug.

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

Georg Faerber-4
In reply to this post by Chris Lamb -2
Hi,

I'm not sure if the following is of help, as I didn't saw the involved
code, but:

On 19-07-20 17:28:56, Chris Lamb wrote:

> I have something working except that I am running into a blocker
> whereby the GitLab cache is not seen in subsequent runs.
>
> For example, the cache is being stored at the end of the test package
> build stage:
>
>     Creating cache default-2...
>     .cache/: found 2 matching files                    
>     No URL provided, cache will be not uploaded to shared cache server. Cache will be stored only locally.
>     Created cache
>
> … but it is not seen when you re-run that same pipeline:
>
>     Checking cache for default-2...
>     No URL provided, cache will not be downloaded from shared cache server. Instead a local version of cache will be extracted.
>     Successfully extracted cache
>    
>     $ ls -l .cache || true
>     ls: cannot access '.cache': No such file or directory
>
> I will try and hunt down a Salsa admin during DebConf. This might be
> due to the use of shared runners and us not using a centralised cache.
An alternative might be to use artifacts [1], which work as expected on
Salsa.

Cheers,
Georg


[1] https://docs.gitlab.com/ee/user/project/pipelines/job_artifacts.html

signature.asc (235 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

Chris Lamb -2
Hi Georg,

> An alternative might be to use artifacts [1], which work as expected on
> Salsa.

Thanks. Unfortunately, I did investigate using artifacts at first and
whilst they do indeed work on Salsa they are for a different use-case
that does not fit our "re-use from a previous build" requirement (they
re-use files between *parts* of a build).


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] 🍥 chris-lamb.co.uk
       `-

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

Felix Lechner-4
In reply to this post by Chris Lamb -2
Hi Chris,

On Sat, Jul 20, 2019 at 1:33 PM Chris Lamb <[hidden email]> wrote:
>
> I've been hacking on this on a Salsa-local fork of Lintian that splits
> the generation of the test packages and the testing itself, crucially
> caching the result of the former if the tests and some other key files
> have not changed.

Will it also force an update of the test packages when the build chain
has changed? It may expose Lintian bugs like #932339.

Kind regards,
Felix

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

Chris Lamb -2
Felix Lechner wrote:

> > caching the result of the former if the tests and some other key files
> > have not changed.
>
> Will it also force an update of the test packages when the build chain
> has changed? It may expose Lintian bugs like #932339.

Whilst my *current* implementation does not rebuild if a build-depends
version changes, we would only need to include these package version
in the hash key. It would then (correctly) cache miss in that instance
and rebuild the test packages. It's a shame we would not have
a .buildinfo file at this point...

I'm not going to implement this bit just yet until I solve the more
deeper problem of it, well, not actually caching anything at the
moment. See previous messages for more background.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] 🍥 chris-lamb.co.uk
       `-

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

Georg Faerber-4
Hi again,

On 19-07-30 21:39:00, Chris Lamb wrote:
> I'm not going to implement this bit just yet until I solve the more
> deeper problem of it, well, not actually caching anything at the
> moment. See previous messages for more background.

As far as I can tell, the cache problem was caused by a breaking
upstream change. This got fixed [1]. Probably, didn't test, this "should
work" again.

Cheers,
Georg


[1] https://salsa.debian.org/salsa/salsa-ansible/commit/c6404e6b31267a8f9c46a2eb7838b829e08a451d

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: speed up test suite CI

Felix Lechner-4
In reply to this post by Dmitry Bogatov-3
Hi,

On Thu, Jun 13, 2019 at 8:51 AM Dmitry Bogatov <[hidden email]> wrote:
>
> Gitlab CI jobs take very long to complete: around 1.5 hours.

We are still working on this bug for you. Meanwhile, the running time
was reduced by about 20 minutes. The change is described here:

    https://lists.debian.org/debian-lint-maint/2019/08/msg00280.html

Kind regards

Felix Lechner

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: speed up test suite CI

Chris Lamb -2
Felix Lechner wrote:

> We are still working on this bug for you. Meanwhile, the running time
> was reduced by about 20 minutes.

FYI I hope to finish/refine my CI caching stuff over the next week or
so and get that onto master.


Best wishes,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [hidden email] 🍥 chris-lamb.co.uk
       `-

Reply | Threaded
Open this post in threaded view
|

Bug#930487: lintian: speed up test suite CI

Dmitry Bogatov-4

[2019-08-22 11:14] "Chris Lamb" <[hidden email]>
> Felix Lechner wrote:
>
> > We are still working on this bug for you. Meanwhile, the running time
> > was reduced by about 20 minutes.
>
> FYI I hope to finish/refine my CI caching stuff over the next week or
> so and get that onto master.

Almost 1/3. Impressive. Thank you for you work.
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.

12