Bug#930689: dh_missing --fail-missing should be smarter about -A and -B

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#930689: dh_missing --fail-missing should be smarter about -A and -B

Daniel Kahn Gillmor-3
Package: debhelper
Version: 12.1.1

dh_missing(1) says:

       Remember to test different kinds of builds (dpkg-buildpackage
       -A/-B/...) as you may experience varying results when only a subset of
       the packages are built.

And i've seen those different results (e.g., #930042, where .info files
that typically go in the arch-indep packages get flagged as an error by
dh_missing --fail-missing).  I'd still like the reassurance of
dh_missing --fail-missing, but it's not clear to me how to resolve the
situation, since upstream builds and installs the .info file no matter
what, but the binary-only builds ignore them.

It seems to me that dh_missing should be smarter about this, at least
for files that are listed in a package that dh in general knows about
but aren't being installed in this particular run of dpkg-buildpackage.

as it stands, i'm likely to drop --fail-missing from the gnupg2 source
package, because i don't see any other way to fix this, but i feel
pretty sad doing so.

sorry to not have a clear suggestion for how to do this, but i figure
the dh developers (or others reading the dh bug reports) might have
better suggestions about how to make it safer/easier to use
--fail-missing.

    --dkg

signature.asc (233 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#930689: dh_missing --fail-missing should be smarter about -A and -B

Niels Thykier
On Tue, 18 Jun 2019 12:54:32 -0400 Daniel Kahn Gillmor
<[hidden email]> wrote:

> Package: debhelper
> Version: 12.1.1
>
> dh_missing(1) says:
>
>        Remember to test different kinds of builds (dpkg-buildpackage
>        -A/-B/...) as you may experience varying results when only a subset of
>        the packages are built.
>
> And i've seen those different results (e.g., #930042, where .info files
> that typically go in the arch-indep packages get flagged as an error by
> dh_missing --fail-missing).  I'd still like the reassurance of
> dh_missing --fail-missing, but it's not clear to me how to resolve the
> situation, since upstream builds and installs the .info file no matter
> what, but the binary-only builds ignore them.
>
> It seems to me that dh_missing should be smarter about this, at least
> for files that are listed in a package that dh in general knows about
> but aren't being installed in this particular run of dpkg-buildpackage.
>
> as it stands, i'm likely to drop --fail-missing from the gnupg2 source
> package, because i don't see any other way to fix this, but i feel
> pretty sad doing so.
>
> sorry to not have a clear suggestion for how to do this, but i figure
> the dh developers (or others reading the dh bug reports) might have
> better suggestions about how to make it safer/easier to use
> --fail-missing.
>
>     --dkg

Hi,

Thanks for reporting the issue.

It was cased by dh_installinfo having an obsolete/invalid optimization
hint for dh (when used with dh_missing).  This has now been fixed in git
(master) will be part of the next release.

If you are curious, you can see the changes in the following link/URL:
https://salsa.debian.org/debian/debhelper/commit/4de9f81f589aa6aa17a68cea45af15ad2b245c98


Thanks,
~Niels

Reply | Threaded
Open this post in threaded view
|

Bug#930689: dh_missing --fail-missing should be smarter about -A and -B

Daniel Kahn Gillmor-3
On Tue 2019-06-18 18:00:00 +0000, Niels Thykier wrote:
> It was cased by dh_installinfo having an obsolete/invalid optimization
> hint for dh (when used with dh_missing).  This has now been fixed in git
> (master) will be part of the next release.
>
> If you are curious, you can see the changes in the following link/URL:
> https://salsa.debian.org/debian/debhelper/commit/4de9f81f589aa6aa17a68cea45af15ad2b245c98

thanks for this fix, Niels!  i would not have known how to do that.
i've lost count of how many beers i owe you now.

        --dkg