Bug#931709: marked as done (diffoscope: testsuite failure on all archs)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug#931709: marked as done (diffoscope: testsuite failure on all archs)

Debian Bug Tracking System
Your message dated Tue, 09 Jul 2019 13:34:16 +0000
with message-id <[hidden email]>
and subject line Bug#931709: fixed in diffoscope 117
has caused the Debian Bug report #931709,
regarding diffoscope: testsuite failure on all archs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
931709: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931709
Debian Bug Tracking System
Contact [hidden email] with problems

Source: diffoscope
Version: 116
Severity: serious
Justification: autopkgtests failures are RC since bullseye
Tags: patch

Hello, you have an autopkgtest failure on sid for version 116, due to missing tools at runtime.

While we are at it, there are a few tools that aren't available everywhere, due to different architectures, so I crafted a patch
that should make hopefully testsuite pass everywhere.

diff -Nru diffoscope-116/debian/tests/pytest diffoscope-116ubuntu1/debian/tests/pytest
--- diffoscope-116/debian/tests/pytest  2019-07-07 16:54:29.000000000 +0200
+++ diffoscope-116ubuntu1/debian/tests/pytest   2019-07-09 08:46:17.000000000 +0200
@@ -10,7 +10,7 @@
 export LIBGUESTFS_MEMSIZE=128
 if [ "$(basename "$0")" = "pytest-with-recommends" ]; then
     export DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS=1
-    export DIFFOSCOPE_TESTS_MISSING_TOOLS="cbfstool otool lipo wasm2wat"
+    export DIFFOSCOPE_TESTS_MISSING_TOOLS="apktool zipinfo pedump oggDump ppudump cbfstool otool lipo wasm2wat"
 fi

 cp -r tests "$ADTTMP"

--- diffoscope-116/debian/tests/control.in      2019-07-07 16:54:29.000000000 +0200
+++ diffoscope-116ubuntu1/debian/tests/control.in       2019-07-09 08:46:17.000000000 +0200
@@ -7,7 +7,7 @@
 Depends: diffoscope, black, python3-pytest, file, linux-image-amd64 [amd64] | linux-image-generic [amd64], %RECOMMENDS%, %PYRECOMMENDS%

 Tests: pytest
-Depends: diffoscope, python3-pytest, file
+Depends: diffoscope, python3-pytest, file, python3-tlsh

 Tests: basic-command-line
 Depends: diffoscope


please accept if possible this patch.

NB some tools such as pedump should be available everywhere, but mono is explictly disabling it on arm64...
I'm doing a test build enabling it to see what happens

https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+build/17243705

thanks

Gianfranco

Source: diffoscope
Source-Version: 117

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <[hidden email]> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 09 Jul 2019 10:24:54 -0300
Source: diffoscope
Binary: diffoscope
Built-For-Profiles: nocheck
Architecture: source all
Version: 117
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <[hidden email]>
Changed-By: Chris Lamb <[hidden email]>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 931709
Changes:
 diffoscope (117) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Add support for file 5.37. Thanks again to Christoph Biedl for the heads-up
     in advance. (Closes: reproducible-builds/diffoscope/#57)
   * Apply patch from Gianfranco Costamagna to fix autopkgtest failures in
     Debian. (Closes: #931709)
 .
   [ Holger Levsen ]
   * debian/control: Bump Standards-Version to 4.4.0.
Checksums-Sha1:
 2b83b7656404f43ed003d4210454c8cd15276097 4660 diffoscope_117.dsc
 d388a8d6b53910a281147269c10133d04e19e82c 1118640 diffoscope_117.tar.xz
 a9fc0c8429c5a46a4e2520eeb0498b06f317bd5c 131232 diffoscope_117_all.deb
 473fecc54bb55a61fe72027a21541108129d04c3 6764 diffoscope_117_amd64.buildinfo
Checksums-Sha256:
 b66e54cfd7a330f7930bd6aaa8ce6dd75583ed10da2d11acd88768e307fdf0e5 4660 diffoscope_117.dsc
 dbac3c0f96ee61da72ef31310ff5611eab405b7c199ff13e657b0025c756a90c 1118640 diffoscope_117.tar.xz
 e306a0962d1807724550f0f5c7e8b3e76c4a5d931c104a10d0985d9323eea86e 131232 diffoscope_117_all.deb
 26f81df01ab965b6d051af2783c9c64cd523f667d9dc377fd6e71eabe995900a 6764 diffoscope_117_amd64.buildinfo
Files:
 c0186f09dcba0daca521ae37c18f8b46 4660 devel optional diffoscope_117.dsc
 7d7e31063cba3075663d329975979e3e 1118640 devel optional diffoscope_117.tar.xz
 af565f3b71fee194c9998c0149646fd1 131232 devel optional diffoscope_117_all.deb
 37872f9c9d8d892e5efcfbb7ee23a546 6764 devel optional diffoscope_117_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl0klfgACgkQHpU+J9Qx
HljXew/9F+u6cKH4SKYfDY2iiyipocLmYoDhn6W+Ncnt0vhx3rcpw7LXIbw0wp/A
B+XamrvBWq8mk7XATB1zyzEpAWjS27+gnWeS3h/affInlvGZtMaOttQ7aCxoh+XF
XyqGawna5+1Tj6pqsz/zAjFDuidI49iWKXpqfMveLO4xxN0k7YwHIiMasE8V3lO6
hPNddzo1WGNFWVfW7DvhNdQkbM+udcCfGH6LmqHTOtftknaAZHE0jdPcMj29IECW
asziPFJI/5Iw5Adq8sAh1IYjclDzk0TcvNkJ85IhSNxKGu6yIsWA2qu2wNdp8IeR
PiYkxWSgqSm7O71HNa9pqyjLI6oI4KeEEc9a7fp0piYNu5JhCHZTrbykZQr33Q6l
Ob8TDmux0W6Vxl0TgufNxve4cASX0gVrwODqmvcMrLPh+kX9uaqXPx1nN5Uwg8oV
NlPdpAzJ6CfiJDDL222mhhhDf55SujQch/dnSIrjT4GMsP8Zb6J+n2gVl9/7D1Bs
I2xI6F4bvr73kc4POdHn2YMI4ZQnOhIo9kp8zt3ybvZlqsq0idETs7CdcNoZFcbD
jja5SZwznyf6NUF5qtUC8I6cfsQ8F+gNYepyeFKrS7iGwPftHxcWlGnPjvzojnwP
AVcwG8TsCuDgvqJNEIV2h1TA8/4CA7qrkpCXDHQwNQhS8P08yUA=
=+9QF
-----END PGP SIGNATURE-----