Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Alexandre Rossi-4
Package: uwsgi-plugin-php
Version: 2.0.17.1+8+0.0.3+b3
Severity: normal
Tags: patch

Dear Maintainer,

I've noticed that an interesting fix for the uwsgi PHP plugin is not included
in the upstream releases[1].

This fix[2] solves failures to initialize PHP sessions using session_start()
for PHP apps that use the feature. I was hit by this with phpmyadmin,
adminer.

[1] https://github.com/unbit/uwsgi/issues/2048
[2] https://github.com/unbit/uwsgi/commit/7cf140aab8ed1f161c93f4c255964898560f2515

I rebuilt the uwsgi-src package with that patch included and then proceeded
to rebuilt uwsgi-plugin-php. This fixed thoses errors, for instance:

    PHP Warning:  session_start(): Failed to read session data: uwsgi (path: dbadmsessions) in /usr/share/adminer/adminer.php on line 71

I think that this is a nice candidate for stable-updates, I can help preparing
an upload if appropriate.

Thanks,

Alex

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages uwsgi-plugin-php depends on:
ii  libc6                                                    2.28-10
pn  libphp-embed                                             <none>
ii  php7.3-cli [phpapi-20180731]                             7.3.6-1
ii  uwsgi-core [uwsgi-abi-a411bb8664cd85ae0fd852d2f665558a]  2.0.18-3

uwsgi-plugin-php recommends no packages.

uwsgi-plugin-php suggests no packages.

7cf140aab8ed1f161c93f4c255964898560f2515.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Jonas Smedegaard-2
Hi Alexandre,

Quoting Alexandre Rossi (2019-08-02 14:03:42)

> I've noticed that an interesting fix for the uwsgi PHP plugin is not
> included in the upstream releases[1].
>
> This fix[2] solves failures to initialize PHP sessions using
> session_start() for PHP apps that use the feature. I was hit by this
> with phpmyadmin, adminer.
>
> [1] https://github.com/unbit/uwsgi/issues/2048
> [2] https://github.com/unbit/uwsgi/commit/7cf140aab8ed1f161c93f4c255964898560f2515
>
> I rebuilt the uwsgi-src package with that patch included and then
> proceeded to rebuilt uwsgi-plugin-php. This fixed thoses errors, for
> instance:
>
>     PHP Warning:  session_start(): Failed to read session data: uwsgi (path: dbadmsessions) in /usr/share/adminer/adminer.php on line 71
>
> I think that this is a nice candidate for stable-updates, I can help
> preparing an upload if appropriate.

I do not personally use PHP at all, and it sounds like you do: Would you
perhaps be interested in joining our little packaging team and help care
for PHP-related issues in general?


 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Alexandre Rossi-4
Hi,

> I do not personally use PHP at all, and it sounds like you do: Would you
> perhaps be interested in joining our little packaging team and help care
> for PHP-related issues in general?

I'd be more than happy to join.

Alex

Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Jonas Smedegaard-2
Quoting Alexandre Rossi (2019-08-03 07:01:46)
> Hi,
>
> > I do not personally use PHP at all, and it sounds like you do: Would you
> > perhaps be interested in joining our little packaging team and help care
> > for PHP-related issues in general?
>
> I'd be more than happy to join.

Great!

Please join at https://salsa.debian.org/uwsgi-team and subscribe at
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-uwsgi-devel 
and let's continue general discussion at that mailinglist, leaving this
for the concrete issue you raised :-)


 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Alexandre Rossi-4
In reply to this post by Alexandre Rossi-4
Hi,

> Should I push directly to master, send a patcht o the mailing list or propose
> a pull request in salsa, or other?

The fix has been pushed to master.

Any upload planned? Or should I prepare an upload on mentors.d.o?

Also, I'm pondering raising the severity of this bug. uwsgi-plugin-php
cannot run PHP applications that are using PHP sessions, basically most
applications that use some kind of login/password process. This fits
"a bug which has a major effect on the usability of a package, without
rendering it completely unusable to everyone". This would open the door
to a stable update. What do people think?

Thanks,

Alex

Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Jonas Smedegaard-2
Hi Alexandre (cc bugreport),

[ but dropping mailinglist indirectly covered via bugreport ]

Quoting Alexandre Rossi (2019-08-14 13:08:15)
> > Should I push directly to master, send a patcht o the mailing list
> > or propose a pull request in salsa, or other?
>
> The fix has been pushed to master.

Good.  But where is that, exactly?  URL?


> Any upload planned? Or should I prepare an upload on mentors.d.o?

mentors.d.o is a service for "lonely riders" to find sponsors for their
otherwise self-maintained packages.  Since this is team-maintained (and
we have Debian Developers with upload rights in the team) we don't need
that.

As soon as I understand where you pushed the code, I will have a look at
it, and assuming it looks sensible I will make a release.


> Also, I'm pondering raising the severity of this bug. uwsgi-plugin-php
> cannot run PHP applications that are using PHP sessions, basically
> most applications that use some kind of login/password process. This
> fits "a bug which has a major effect on the usability of a package,
> without rendering it completely unusable to everyone". This would open
> the door to a stable update. What do people think?

Makes good sense.


 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Alexandre Rossi-4
> > > Should I push directly to master, send a patcht o the mailing list
> > > or propose a pull request in salsa, or other?
> >
> > The fix has been pushed to master.
>
> Good.  But where is that, exactly?  URL?

https://salsa.debian.org/uwsgi-team/uwsgi/commit/78c4ab534609f01b30ebcc2560e269bd78af6c0d

Alex

Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Jonas Smedegaard-2
Quoting Alexandre Rossi (2019-08-14 15:10:58)
> > > > Should I push directly to master, send a patcht o the mailing list
> > > > or propose a pull request in salsa, or other?
> > >
> > > The fix has been pushed to master.
> >
> > Good.  But where is that, exactly?  URL?
>
> https://salsa.debian.org/uwsgi-team/uwsgi/commit/78c4ab534609f01b30ebcc2560e269bd78af6c0d

Ah, silly me - I was looking at the -php project which contains zero
upstream code.

Looks good - I just prefer having patches more tight so will tidy up the
ones recently added by others than myself, then release.

Nice!

 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Alexandre Rossi-4
Hi,

> Looks good - I just prefer having patches more tight so will tidy up the
> ones recently added by others than myself, then release.

Now that the fix is in the source, there needs to be a binNMU of
uwsgi-plugin-php or a new upload with some basic fixes[1] I had for the package.

[1] https://salsa.debian.org/uwsgi-team/uwsgi-plugin-php/commits/master

Thanks,

Alex

Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: Bug#933736: Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Jonas Smedegaard-2
Quoting Alexandre Rossi (2019-08-26 10:46:45)
> > Looks good - I just prefer having patches more tight so will tidy up
> > the ones recently added by others than myself, then release.
>
> Now that the fix is in the source, there needs to be a binNMU of
> uwsgi-plugin-php or a new upload with some basic fixes[1] I had for
> the package.
>
> [1]
> https://salsa.debian.org/uwsgi-team/uwsgi-plugin-php/commits/master

Indeed.  BinNMU won't work when dependency is arch-independent, so we
need a sourceful upload as you've already prepared.  Great!

...and thanks for reminding me - I had totally forgotten this again.

I disagreed with you on the wording of those changes, but that's
nitpicking.  Uploaded now.


 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#933736: [pkg-uWSGI-devel] Bug#933736: Bug#933736: Bug#933736: uwsgi-plugin-php: Please include "for php7 return failures only on failure"

Jonas Smedegaard-2
Quoting Jonas Smedegaard (2019-08-26 11:01:47)

> Quoting Alexandre Rossi (2019-08-26 10:46:45)
> > > Looks good - I just prefer having patches more tight so will tidy
> > > up the ones recently added by others than myself, then release.
> >
> > Now that the fix is in the source, there needs to be a binNMU of
> > uwsgi-plugin-php or a new upload with some basic fixes[1] I had for
> > the package.
> >
> > [1]
> > https://salsa.debian.org/uwsgi-team/uwsgi-plugin-php/commits/master
>
> Indeed.  BinNMU won't work when dependency is arch-independent, so we
> need a sourceful upload as you've already prepared.  Great!
Please ignore my bogus first remark above about arch-independency.

 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc (849 bytes) Download Attachment