Bug#940185: src:pywps: Debian/copyright needs update

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#940185: src:pywps: Debian/copyright needs update

Scott Kitterman-5
Package: src:pywps
Version: 4.2.1-1
Severity: serious
Justification: Policy 2.3

One of our ftp-trainees reviewed your package and made the following
observations.  They exist in the current version of the package, so I'm
not rejecting as a result, but they should be fixed in the next upload:

Compiled works are present in tests/ and it does not appear this data can be rebuilt
from the source package provided.  Please remove and repack the tarball
to remove any such artifacts.

Data in pywps/schemas/geojson/ has no licensing information.

Who holds an actual copyright is confusing:
- LICENSE.txt claims copyright by "PyWPS Development Team"
- All source claims copyright by "Open Source Geospatial Foundation"
- Source also (incorrectly) uses "and others" as a copyright holder
- d/copyright claims "PyWPS Project Steering Committee" is a copyright holder, but is
  not represented in source

Files provided in d/patches have a copyright holder that is not present in d/copyright
This appears to be the new maintainer, they should be included in the debian/* paragraph.

Scott K

Reply | Threaded
Open this post in threaded view
|

Bug#940185: src:pywps: Debian/copyright needs update

Scott Kitterman-5
On Friday, September 13, 2019 11:56:30 AM EDT Sebastiaan Couwenberg wrote:

> Hi Scott,
>
> Thanks for finally reviewing pywps.
>
> On 9/13/19 5:23 PM, Scott Kitterman wrote:
> > One of our ftp-trainees reviewed your package and made the following
> > observations.
>
> It seems that the process is broken.
>
> This is far from the first time where an anonymous ftp-trainee commented
> on a package in NEW, but no ftp-master acted on this.
>
> What process does ftp-master use to review ftp-trainee comments?

The delay this time was caused by it being in an incorrectly locked state, not
because there was a pending trainee comment.  The stale lock problem happens
rarely enough that it took me some time to remember how to resolve it.

> > Compiled works are present in tests/ and it does not appear this data can
> > be rebuilt from the source package provided.  Please remove and repack
> > the tarball to remove any such artifacts.
>
> Can you or or the anonymous ftp-trainee clarify which files they
> consider to be "Compiled works"?

I'll ask, but unfortunately the note didn't include it.  If you don't see
anything there, then I wouldn't worry about it.

> There are data files under tests/data & tests/requests used in various
> tests. Why should these need to be rebuilt if those are the files in
> question?

There's no need to actually rebuild them.  We do generally require that it be
possible to rebuild them from tools in Debian.  Of course the best way to know
that you actually can rebuild them is to do so during the package build, but
it's not required.

> > Data in pywps/schemas/geojson/ has no licensing information.
>
> Its upstream states: "[...] either of the AFL or BSD license", but not
> which version. I've contacted the author to request clarification.

Thanks.  I took a look and those files seem to be based on https://geojson.org/
geojson-spec.html which is CC BY 3.0 US, so I have doubts.  

> > Who holds an actual copyright is confusing:
> > - LICENSE.txt claims copyright by "PyWPS Development Team"
> > - All source claims copyright by "Open Source Geospatial Foundation"
>
> Why does this matter?
>
> debian/copyright includes the holders as listed in LICENSE.txt and the
> sources. Are you saying that's wrong?
>
> > - Source also (incorrectly) uses "and others" as a copyright holder
>
> Why is this incorrect?
>
> The sources have copyright statements like this:

>  Copyright 2018 Open Source Geospatial Foundation and others
>  licensed under MIT, Please consult LICENSE.txt for details
>
> That's what's reflected in debian/copyright.

I've reviewed it more carefully now and I agree with you that it's fine as is.

> > - d/copyright claims "PyWPS Project Steering Committee" is a copyright
> > holder, but is>
> >   not represented in source
>
> It used to be a copyright holder, see:
>
>  debian/share/pywps/processes/sayhello.py
>
> > Files provided in d/patches have a copyright holder that is not present in
> > d/copyright This appears to be the new maintainer, they should be
> > included in the debian/* paragraph.
> The patches are trivial and cannot be copyrighted in my understanding. I
> wave any copyright claims on them if they can.

I think that's fine.

> Depending on how strict ftp-master is on the data files issue, it may be
> better to just remove this package from Debian as I don't use it myself
> and just co-maintain it because it's also included in OSGeoLive.

I should have checked more carefully before passing on all the note as it's
not all correct.  The missing license for the schema is correctly serious and
should be resolved.  I can't tell you if it's worth keeping in Debian or not,
but I don't think (now that I've looked harder) there's a lot of work to do to
resolve this.

Scott K

Reply | Threaded
Open this post in threaded view
|

Bug#940185: marked as done (src:pywps: Debian/copyright needs update)

Debian Bug Tracking System
In reply to this post by Scott Kitterman-5
Your message dated Sat, 21 Sep 2019 16:05:33 +0000
with message-id <[hidden email]>
and subject line Bug#940185: fixed in pywps 4.2.1-4
has caused the Debian Bug report #940185,
regarding src:pywps: Debian/copyright needs update
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
940185: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940185
Debian Bug Tracking System
Contact [hidden email] with problems

Package: src:pywps
Version: 4.2.1-1
Severity: serious
Justification: Policy 2.3

One of our ftp-trainees reviewed your package and made the following
observations.  They exist in the current version of the package, so I'm
not rejecting as a result, but they should be fixed in the next upload:

Compiled works are present in tests/ and it does not appear this data can be rebuilt
from the source package provided.  Please remove and repack the tarball
to remove any such artifacts.

Data in pywps/schemas/geojson/ has no licensing information.

Who holds an actual copyright is confusing:
- LICENSE.txt claims copyright by "PyWPS Development Team"
- All source claims copyright by "Open Source Geospatial Foundation"
- Source also (incorrectly) uses "and others" as a copyright holder
- d/copyright claims "PyWPS Project Steering Committee" is a copyright holder, but is
  not represented in source

Files provided in d/patches have a copyright holder that is not present in d/copyright
This appears to be the new maintainer, they should be included in the debian/* paragraph.

Scott K

Source: pywps
Source-Version: 4.2.1-4

We believe that the bug you reported is fixed in the latest version of
pywps, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bas Couwenberg <[hidden email]> (supplier of updated pywps package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 21 Sep 2019 17:34:45 +0200
Source: pywps
Architecture: source
Version: 4.2.1-4
Distribution: unstable
Urgency: medium
Maintainer: Debian GIS Project <[hidden email]>
Changed-By: Bas Couwenberg <[hidden email]>
Closes: 940185
Changes:
 pywps (4.2.1-4) unstable; urgency=medium
 .
   * Add license & copyright for geojson schemas.
     (closes: #940185)
Checksums-Sha1:
 f073e314c7a42cc9992b12aa457f7ae1d243c0be 2356 pywps_4.2.1-4.dsc
 5ccbe51861b9e134c05bf2d268af666f3d220b1f 12268 pywps_4.2.1-4.debian.tar.xz
 2debaad8b224fe542e121f346d3ddb54a6e23c11 11692 pywps_4.2.1-4_amd64.buildinfo
Checksums-Sha256:
 22c3ae2db9dbe27ac22fcbb5a07c8c4f977a5cab25c062d6a6dfaa737b02de99 2356 pywps_4.2.1-4.dsc
 0df47e4a8879cf68d9b6b2bc7bb4b018b2070673e2d97b258a1c0ede66c44547 12268 pywps_4.2.1-4.debian.tar.xz
 fcf90591e2bace1c27ef3db531f63a33b995cd05c8799629a61bffff5275e5a1 11692 pywps_4.2.1-4_amd64.buildinfo
Files:
 6051c6037fa702db6b12dd0f92f7e44b 2356 python optional pywps_4.2.1-4.dsc
 e581971c18972aa9b4f1fec3e7feeece 12268 python optional pywps_4.2.1-4.debian.tar.xz
 f7381bf8cba4fc9e6a0af655e9a92f6e 11692 python optional pywps_4.2.1-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEgYLeQXBWQI1hRlDRZ1DxCuiNSvEFAl2GR3QACgkQZ1DxCuiN
SvHY9g/+LVMuyjIOQ7j4DU4AMB8MakvhgbC9TrTatYdBTgSMFxqPoK7MccNhxEXU
Gn5nhnokrQbBgPGerFpznWsoN7IFi8IQas0Vw6D1zUN/npyC/hHom9oJ9iUIWC1O
1fqsAZiSVp84wP+UabG/N9IBjWzdYCIj0JGAvHHfpeF6d00/gJRPwG1emJCnqbAg
1OCDdvkzHRrBCAtd4hr74JqshoQf7RXr+KDR8pby+Cx9/PLzANGfEBN39UaC69MC
JP4qMlWyGm4UEEV7ei0ZM33pikp1v4ynpBBSgV6PByTBIdTuiQuiIJwSyz7evfq6
WVoEQCvkIHUl4zDaIZrKv33SemEExHajj7hQz3OZSTzIIZ0xDc0tY5Ba26umFiBj
FClpTcJQJeP1YQUR6ln/ZD+9atJgYeYoIM832MP4cDpOqMyVlV+AUOruqSgRDXzQ
hqf5B94/629d10+bN09ah3OrA6kBJh5uvJyKCYfv92lH3bLH8Ztm74x7wUXiyQy3
hmuheerDGfLC8lwDFeio7L22SwysJJBzITqFvQGGZ+FnmINSRsW1d6vMvYIX6tjp
T3z+jnEFlA6rlqBIHeVCY9Elbfl+0BffdvuCXIJ2PFsorl2pIv0fhOsF2Rd/CPrk
7HVYloWXksCcxwr/xQYSkoWgRWWwwRVIe0SC+psgwTjqWt9xhbc=
=vpx+
-----END PGP SIGNATURE-----