Bug#940902: doesn't read the data

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#940902: doesn't read the data

Andreas Tille-2
Control: tags -1 help

Dear Ana,

On Sat, Sep 21, 2019 at 05:41:27PM +0200, Ana Guerrero Lopez wrote:
> This new version of cycle, ported to python3, doesn't read the data file
> ( under .cycle) and prompts to create a new user.
>
> Not creating a new user and downgrading to the version in buster (-14), allows
> to continue using the application with the previous data.

thanks a lot for thorough testing the package!

The situation is as follows:  Upstream is dead so we probably become
upstream in Debian.  I has done my best to port it to Python3 with the
help of Debian Python team.  I personally can not do more.  I can just
hope that someone who is using the program will try to fix it.  If you
feel able to do this it would be great.  If you know somebody who could
do it great as well.  I'd be really happy if we could keep the package
inside Debian and if someone could fix it.

Kind regards

      Andreas.

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Processed: Re: Bug#940902: doesn't read the data

Debian Bug Tracking System
Processing control commands:

> tags -1 help
Bug #940902 [cycle] doesn't read the data
Added tag(s) help.

--
940902: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940902
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#940902: doesn't read the data

ana (Bugzilla)
In reply to this post by Andreas Tille-2
Hi Andreas,

On Sat, Sep 21, 2019 at 06:39:51PM +0200, Andreas Tille wrote:

> Control: tags -1 help
>
> Dear Ana,
>
> On Sat, Sep 21, 2019 at 05:41:27PM +0200, Ana Guerrero Lopez wrote:
> > This new version of cycle, ported to python3, doesn't read the data file
> > ( under .cycle) and prompts to create a new user.
> >
> > Not creating a new user and downgrading to the version in buster (-14), allows
> > to continue using the application with the previous data.
>
> thanks a lot for thorough testing the package!
>
> The situation is as follows:  Upstream is dead so we probably become
> upstream in Debian.  I has done my best to port it to Python3 with the
> help of Debian Python team.  I personally can not do more.  I can just
> hope that someone who is using the program will try to fix it.  If you
> feel able to do this it would be great.  If you know somebody who could
> do it great as well.  I'd be really happy if we could keep the package
> inside Debian and if someone could fix it.

I used to maintain this package, so I'm well aware of the problems, check
the changelog ;)

The package should be removed from the archive, the base code is very poor to
start with, and the patching for python3 isn't going to fix this, just add
more problems...
Your current python3 porting is not helping here since many people will start
the application, will be prompted for a new user, will create it and erase
all their data. So please, revert your changes and if that means the package
will be removed from the archive, let it be. At least people will be able to
continue using it while they move to something else (or not), but won't lose
their data as it'll happen now.

Thanks for caring.

cheers,
Ana

Reply | Threaded
Open this post in threaded view
|

Bug#940902: doesn't read the data

Andreas Tille-2
Hi Ana,

On Sun, Sep 22, 2019 at 11:11:47PM +0200, Ana Guerrero Lopez wrote:

> > thanks a lot for thorough testing the package!
> >
> > The situation is as follows:  Upstream is dead so we probably become
> > upstream in Debian.  I has done my best to port it to Python3 with the
> > help of Debian Python team.  I personally can not do more.  I can just
> > hope that someone who is using the program will try to fix it.  If you
> > feel able to do this it would be great.  If you know somebody who could
> > do it great as well.  I'd be really happy if we could keep the package
> > inside Debian and if someone could fix it.
>
> I used to maintain this package, so I'm well aware of the problems, check
> the changelog ;)

I'm aware of this. ;-)
 
> The package should be removed from the archive, the base code is very poor to
> start with, and the patching for python3 isn't going to fix this, just add
> more problems...

OK, sorry for causing problems - and good to know that some qualified
user of unstable is spotting these in an early stage to (hopefully) not harm
the majority of users.

> Your current python3 porting is not helping here since many people will start
> the application, will be prompted for a new user, will create it and erase
> all their data. So please, revert your changes and if that means the package
> will be removed from the archive, let it be. At least people will be able to
> continue using it while they move to something else (or not), but won't lose
> their data as it'll happen now.

I've now pushed a change to salsa[1] where I deactivated the whole 2to3
port and replaced the warning about the port by some other warning that
a port will be needed or the package will vanish.  Hopefully this might
attract some coders.  BTW, I fully agree with you that the code quality
might not be a good start.

I tried to start the build here but I get:

$ cycle
Traceback (most recent call last):
  File "/usr/bin/cycle", line 213, in <module>
    app = MyApp(0)
  File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk3/wx/_core.py", line 8628, in __init__
    self._BootstrapApp()
  File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk3/wx/_core.py", line 8196, in _BootstrapApp
    return _core_.PyApp__BootstrapApp(*args, **kwargs)
  File "/usr/bin/cycle", line 193, in OnInit
    ret=first_login()
  File "/usr/share/cycle/dialogs.py", line 304, in first_login
    users = get_users()
  File "/usr/share/cycle/dialogs.py", line 192, in get_users
    users.append((cPickle.loads(tmp[:n]), f))
ValueError: unsupported pickle protocol: 3


So I reverted to the Python2 version 0.3.1-14 (from testing) but I get
absolutely the same error.  I wonder whether my package is fine in terms
of "works as broken as before" or whether I messed up something else.

> Thanks for caring.

Thanks to you.  I'd be happy if you could check master[1] and confirm
that it is OK.  I can even give you commit permissions so you can change
anything you feel sensible and do the team upload yourself.

See you (hopefully some time - missed you at last DebConfs)

     Andreas.

[1] https://salsa.debian.org/med-team/cycle 

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#940902: doesn't read the data

Ana Guerrero Lopez
On Tue, Oct 01, 2019 at 06:12:56AM +0200, Andreas Tille wrote:
> On Mon, Sep 30, 2019 at 11:47:14PM +0200, Ana Guerrero Lopez wrote:
> > > Thanks to you.  I'd be happy if you could check master[1] and confirm
> > > that it is OK.  I can even give you commit permissions so you can change
> > > anything you feel sensible and do the team upload yourself.
> >
> > Please, add me to the group, I'll take care of the testing and upload.
>
> Welcome to the team, Andreas.

Thanks!
Good news, I've tested and it works fine. I'm doing a team upload right now.

I think we shouldn't give up in getting this ported to python3, but I think a
re-write keeping the possibility to read the all data is the best way to go.

Cheers,
Ana

Reply | Threaded
Open this post in threaded view
|

Bug#940902: doesn't read the data

Andreas Tille-2
On Sun, Nov 10, 2019 at 05:32:48PM +0100, Ana Guerrero Lopez wrote:
> >
> > Welcome to the team, Andreas.
>
> Thanks!
> Good news, I've tested and it works fine. I'm doing a team upload right now.
>
> I think we shouldn't give up in getting this ported to python3, but I think a
> re-write keeping the possibility to read the all data is the best way to go.

Thanks a lot for caring

    Andreas.

--
http://fam-tille.de