Bug#944232: /lib/systemd/system/virtlogd.service: Please add needrestart overrides

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#944232: /lib/systemd/system/virtlogd.service: Please add needrestart overrides

Sam Morris
Package: libvirt-daemon-system
Version: 5.6.0-2
Severity: normal
File: /lib/systemd/system/virtlogd.service

needrestart currently defaults to restarting virtlogd when it detects
that the service needs a restart.

According to the man page and systemd unit, a reload operation will
re-exec the virtlogd executable without losing virtual machine logs.

Please ship /etc/needrestart/restart.d/virtlogd.service and
/etc/needrestart/restart.d/virtlog scripts which should call 'systemctl
reload virtlogd.service' and '/etc/init.d/virtlogd reload',
respectively, so that needrestart doesn't just restart the service on
its own.

See /etc/needrestart/restart.d/README.needrestart for more information.

-- System Information:
Debian Release: 10.1
  APT prefers stable-updates
  APT policy: (570, 'stable-updates'), (570, 'stable-debug'), (570, 'stable'), (550, 'testing-debug'), (550, 'testing'), (540, 'unstable-debug'), (540, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.2.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libvirt-daemon-system depends on:
ii  adduser                3.118
ii  debconf [debconf-2.0]  1.5.71
ii  firewalld              0.7.2-1
ii  gettext-base           0.19.8.1-9
ii  init-system-helpers    1.56+nmu1
ii  iptables               1.8.3-2~bpo10+1
ii  libc6                  2.29-2
ii  libvirt-clients        5.6.0-2
ii  libvirt-daemon         5.6.0-2
ii  libvirt0               5.6.0-2
ii  libxml2                2.9.4+dfsg1-7+b3
ii  logrotate              3.14.0-4
ii  lsb-base               10.2019051400
ii  policykit-1            0.105-25

Versions of packages libvirt-daemon-system recommends:
ii  dmidecode                    3.2-1
ii  dnsmasq-base [dnsmasq-base]  2.80-1
ii  iproute2                     4.20.0-2
ii  parted                       3.2-25

Versions of packages libvirt-daemon-system suggests:
ii  apparmor    2.13.3-6
ii  auditd      1:2.8.4-3
pn  nfs-common  <none>
pn  open-iscsi  <none>
pn  pm-utils    <none>
pn  radvd       <none>
ii  systemd     242-7
ii  systemtap   4.0-1
pn  zfsutils    <none>

-- Configuration Files:
/etc/libvirt/nwfilter/allow-arp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-arp.xml'
/etc/libvirt/nwfilter/allow-dhcp-server.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-dhcp-server.xml'
/etc/libvirt/nwfilter/allow-dhcp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-dhcp.xml'
/etc/libvirt/nwfilter/allow-incoming-ipv4.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-incoming-ipv4.xml'
/etc/libvirt/nwfilter/allow-ipv4.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-ipv4.xml'
/etc/libvirt/nwfilter/clean-traffic-gateway.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/clean-traffic-gateway.xml'
/etc/libvirt/nwfilter/clean-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/clean-traffic.xml'
/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml'
/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml'
/etc/libvirt/nwfilter/no-arp-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-spoofing.xml'
/etc/libvirt/nwfilter/no-ip-multicast.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-ip-multicast.xml'
/etc/libvirt/nwfilter/no-ip-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-ip-spoofing.xml'
/etc/libvirt/nwfilter/no-mac-broadcast.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-mac-broadcast.xml'
/etc/libvirt/nwfilter/no-mac-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-mac-spoofing.xml'
/etc/libvirt/nwfilter/no-other-l2-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-other-l2-traffic.xml'
/etc/libvirt/nwfilter/no-other-rarp-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-other-rarp-traffic.xml'
/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml'
/etc/libvirt/nwfilter/qemu-announce-self.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/qemu-announce-self.xml'
/etc/libvirt/qemu.conf [Errno 13] Permission denied: '/etc/libvirt/qemu.conf'
/etc/libvirt/qemu/networks/default.xml [Errno 13] Permission denied: '/etc/libvirt/qemu/networks/default.xml'

-- debconf information excluded

Reply | Threaded
Open this post in threaded view
|

Bug#944232: [Pkg-libvirt-maintainers] Bug#944232: /lib/systemd/system/virtlogd.service: Please add needrestart overrides

Guido Günther
Hi,
On Wed, Nov 06, 2019 at 12:33:52PM +0000, Sam Morris wrote:

> Package: libvirt-daemon-system
> Version: 5.6.0-2
> Severity: normal
> File: /lib/systemd/system/virtlogd.service
>
> needrestart currently defaults to restarting virtlogd when it detects
> that the service needs a restart.
>
> According to the man page and systemd unit, a reload operation will
> re-exec the virtlogd executable without losing virtual machine logs.
>
> Please ship /etc/needrestart/restart.d/virtlogd.service and
> /etc/needrestart/restart.d/virtlog scripts which should call 'systemctl
> reload virtlogd.service' and '/etc/init.d/virtlogd reload',
> respectively, so that needrestart doesn't just restart the service on
> its own.
>
> See /etc/needrestart/restart.d/README.needrestart for more
> information.

can you provide a tested merge request on salsa for that please?
 -- Guido

>
> -- System Information:
> Debian Release: 10.1
>   APT prefers stable-updates
>   APT policy: (570, 'stable-updates'), (570, 'stable-debug'), (570, 'stable'), (550, 'testing-debug'), (550, 'testing'), (540, 'unstable-debug'), (540, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 5.2.0-3-amd64 (SMP w/8 CPU cores)
> Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
> Versions of packages libvirt-daemon-system depends on:
> ii  adduser                3.118
> ii  debconf [debconf-2.0]  1.5.71
> ii  firewalld              0.7.2-1
> ii  gettext-base           0.19.8.1-9
> ii  init-system-helpers    1.56+nmu1
> ii  iptables               1.8.3-2~bpo10+1
> ii  libc6                  2.29-2
> ii  libvirt-clients        5.6.0-2
> ii  libvirt-daemon         5.6.0-2
> ii  libvirt0               5.6.0-2
> ii  libxml2                2.9.4+dfsg1-7+b3
> ii  logrotate              3.14.0-4
> ii  lsb-base               10.2019051400
> ii  policykit-1            0.105-25
>
> Versions of packages libvirt-daemon-system recommends:
> ii  dmidecode                    3.2-1
> ii  dnsmasq-base [dnsmasq-base]  2.80-1
> ii  iproute2                     4.20.0-2
> ii  parted                       3.2-25
>
> Versions of packages libvirt-daemon-system suggests:
> ii  apparmor    2.13.3-6
> ii  auditd      1:2.8.4-3
> pn  nfs-common  <none>
> pn  open-iscsi  <none>
> pn  pm-utils    <none>
> pn  radvd       <none>
> ii  systemd     242-7
> ii  systemtap   4.0-1
> pn  zfsutils    <none>
>
> -- Configuration Files:
> /etc/libvirt/nwfilter/allow-arp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-arp.xml'
> /etc/libvirt/nwfilter/allow-dhcp-server.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-dhcp-server.xml'
> /etc/libvirt/nwfilter/allow-dhcp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-dhcp.xml'
> /etc/libvirt/nwfilter/allow-incoming-ipv4.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-incoming-ipv4.xml'
> /etc/libvirt/nwfilter/allow-ipv4.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/allow-ipv4.xml'
> /etc/libvirt/nwfilter/clean-traffic-gateway.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/clean-traffic-gateway.xml'
> /etc/libvirt/nwfilter/clean-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/clean-traffic.xml'
> /etc/libvirt/nwfilter/no-arp-ip-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-ip-spoofing.xml'
> /etc/libvirt/nwfilter/no-arp-mac-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-mac-spoofing.xml'
> /etc/libvirt/nwfilter/no-arp-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-arp-spoofing.xml'
> /etc/libvirt/nwfilter/no-ip-multicast.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-ip-multicast.xml'
> /etc/libvirt/nwfilter/no-ip-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-ip-spoofing.xml'
> /etc/libvirt/nwfilter/no-mac-broadcast.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-mac-broadcast.xml'
> /etc/libvirt/nwfilter/no-mac-spoofing.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-mac-spoofing.xml'
> /etc/libvirt/nwfilter/no-other-l2-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-other-l2-traffic.xml'
> /etc/libvirt/nwfilter/no-other-rarp-traffic.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/no-other-rarp-traffic.xml'
> /etc/libvirt/nwfilter/qemu-announce-self-rarp.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/qemu-announce-self-rarp.xml'
> /etc/libvirt/nwfilter/qemu-announce-self.xml [Errno 13] Permission denied: '/etc/libvirt/nwfilter/qemu-announce-self.xml'
> /etc/libvirt/qemu.conf [Errno 13] Permission denied: '/etc/libvirt/qemu.conf'
> /etc/libvirt/qemu/networks/default.xml [Errno 13] Permission denied: '/etc/libvirt/qemu/networks/default.xml'
>
> -- debconf information excluded
>
> _______________________________________________
> Pkg-libvirt-maintainers mailing list
> [hidden email]
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-libvirt-maintainers