Bug#952060: libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#952060: libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]

Lucas Nussbaum-4
Source: libsignon-glib
Version: 1.12-2
Severity: serious
Justification: FTBFS on amd64
Tags: buster sid
Usertags: ftbfs-20200222 ftbfs-buster

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):

> /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H   -I.. -I. -I.. -I. -pthread -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/signond -Wall -Werror -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o libsignon_glib_la-signon-auth-service.lo `test -f 'signon-auth-service.c' || echo './'`signon-auth-service.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I.. -I. -I.. -I. -pthread -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/signond -Wall -Werror -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c signon-auth-service.c  -fPIC -DPIC -o .libs/libsignon_glib_la-signon-auth-service.o
> signon-auth-service.c: In function ‘signon_auth_service_init’:
> signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]
>    72 |                                         SignonAuthServicePrivate);
>       |             ^              
> signon-auth-service.c: In function ‘signon_auth_service_class_init’:
> signon-auth-service.c:112:5: warning: ‘g_type_class_add_private’ is deprecated [-Wdeprecated-declarations]
>   112 |     g_type_class_add_private (object_class, sizeof (SignonAuthServicePrivate));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:29,
>                  from /usr/include/glib-2.0/glib-object.h:23,
>                  from signon-auth-service.h:28,
>                  from signon-auth-service.c:34:
> /usr/include/glib-2.0/gobject/gtype.h:1308:10: note: declared here
>  1308 | void     g_type_class_add_private       (gpointer                    g_class,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[4]: *** [Makefile:654: libsignon_glib_la-signon-auth-service.lo] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/02/22/libsignon-glib_1.12-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

Reply | Threaded
Open this post in threaded view
|

Bug#952060: libsignon-glib FTBFS: a few non-trivial ways to fix

John Scott-3
This is caused by GLib => 2.58 which was uploaded in September 2018 long ago.

Likewise, libsignon-glib 1.12 lags behind upstream substantially.
It's 2.1 and the disparity causes the patch to not apply.

A cheap workaround might be to add a -Wno-error like is already done for
some other deprecated functions. (That has since been fixed upstream proper.)

But in version 1.13, the NEWS file says
* Build: don't emit a build error on deprecations
so perhaps to fix this "cleanly" without such a leap, this avenue may be
most suitable (perhaps 1.15).

signature.asc (235 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#952060: libsignon-glib: diff for NMU version 1.12-2.1

Adrian Bunk-3
In reply to this post by Lucas Nussbaum-4
Control: tags 952060 + patch
Control: tags 952060 + pending

Dear maintainer,

I've prepared an NMU for libsignon-glib (versioned as 1.12-2.1) and
uploaded it to DELAYED/15. Please feel free to tell me if I should
cancel it.

cu
Adrian

libsignon-glib-1.12-2.1-nmu.diff (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Processed: libsignon-glib: diff for NMU version 1.12-2.1

Debian Bug Tracking System
In reply to this post by Lucas Nussbaum-4
Processing control commands:

> tags 952060 + patch
Bug #952060 [src:libsignon-glib] libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]
Added tag(s) patch.
> tags 952060 + pending
Bug #952060 [src:libsignon-glib] libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]
Added tag(s) pending.

--
952060: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952060
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#952060: marked as pending in libsignon-glib

Aurélien COUDERC-4
In reply to this post by Lucas Nussbaum-4
Control: tag -1 pending

Hello,

Bug #952060 in libsignon-glib reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/qt-kde-team/3rdparty/libsignon-glib/-/commit/4b03ce137b10f1663e944e758ff7e6ec8986d7f3

------------------------------------------------------------------------
NMU: Don't build with -Werror. (Closes: #952060) Thanks Adrian Bunk
------------------------------------------------------------------------

(this message was generated automatically)
--
Greetings

https://bugs.debian.org/952060

Reply | Threaded
Open this post in threaded view
|

Processed: Bug#952060 marked as pending in libsignon-glib

Debian Bug Tracking System
In reply to this post by Lucas Nussbaum-4
Processing control commands:

> tag -1 pending
Bug #952060 [src:libsignon-glib] libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]
Ignoring request to alter tags of bug #952060 to the same tags previously set

--
952060: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952060
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#952060: marked as done (libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror])

Debian Bug Tracking System
In reply to this post by Lucas Nussbaum-4
Your message dated Tue, 14 Apr 2020 16:48:56 +0000
with message-id <[hidden email]>
and subject line Bug#952060: fixed in libsignon-glib 1.12-2.1
has caused the Debian Bug report #952060,
regarding libsignon-glib: FTBFS: signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
952060: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952060
Debian Bug Tracking System
Contact [hidden email] with problems

Source: libsignon-glib
Version: 1.12-2
Severity: serious
Justification: FTBFS on amd64
Tags: buster sid
Usertags: ftbfs-20200222 ftbfs-buster

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):

> /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H   -I.. -I. -I.. -I. -pthread -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/signond -Wall -Werror -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o libsignon_glib_la-signon-auth-service.lo `test -f 'signon-auth-service.c' || echo './'`signon-auth-service.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I.. -I. -I.. -I. -pthread -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/signond -Wall -Werror -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c signon-auth-service.c  -fPIC -DPIC -o .libs/libsignon_glib_la-signon-auth-service.o
> signon-auth-service.c: In function ‘signon_auth_service_init’:
> signon-auth-service.c:72:13: error: G_ADD_PRIVATE [-Werror]
>    72 |                                         SignonAuthServicePrivate);
>       |             ^              
> signon-auth-service.c: In function ‘signon_auth_service_class_init’:
> signon-auth-service.c:112:5: warning: ‘g_type_class_add_private’ is deprecated [-Wdeprecated-declarations]
>   112 |     g_type_class_add_private (object_class, sizeof (SignonAuthServicePrivate));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:29,
>                  from /usr/include/glib-2.0/glib-object.h:23,
>                  from signon-auth-service.h:28,
>                  from signon-auth-service.c:34:
> /usr/include/glib-2.0/gobject/gtype.h:1308:10: note: declared here
>  1308 | void     g_type_class_add_private       (gpointer                    g_class,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[4]: *** [Makefile:654: libsignon_glib_la-signon-auth-service.lo] Error 1
The full build log is available from:
   http://qa-logs.debian.net/2020/02/22/libsignon-glib_1.12-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

Source: libsignon-glib
Source-Version: 1.12-2.1
Done: Adrian Bunk <[hidden email]>

We believe that the bug you reported is fixed in the latest version of
libsignon-glib, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adrian Bunk <[hidden email]> (supplier of updated libsignon-glib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 07 Apr 2020 10:42:59 +0300
Source: libsignon-glib
Architecture: source
Version: 1.12-2.1
Distribution: unstable
Urgency: low
Maintainer: Debian/Kubuntu Qt/KDE Maintainers <[hidden email]>
Changed-By: Adrian Bunk <[hidden email]>
Closes: 952060
Changes:
 libsignon-glib (1.12-2.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Don't build with -Werror. (Closes: #952060)
Checksums-Sha1:
 f108c8fd6c7704df2b4d430317e48f187a1770ab 2350 libsignon-glib_1.12-2.1.dsc
 78ec1dc6fea537eddbc2ea434c48864bb3c80363 3420 libsignon-glib_1.12-2.1.debian.tar.xz
Checksums-Sha256:
 02ebbc3becc4c654df0cca032ce52e4529d7f5551703cc6ffde11909b2ee01c5 2350 libsignon-glib_1.12-2.1.dsc
 07c42e1b6b19383304c5e9fc041861efb34544af2948960c479b329fc2acb34a 3420 libsignon-glib_1.12-2.1.debian.tar.xz
Files:
 8eaf83e6955d0de6b702ac2adc298725 2350 libs optional libsignon-glib_1.12-2.1.dsc
 03c73cb20632a16c49a0e2e97387a33e 3420 libs optional libsignon-glib_1.12-2.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAl6ML5cACgkQiNJCh6LY
mLGfIg/+M4Jepmzp1yZsp68X3e4d1NV7i2xaMgVSBGN7OVE8Sa6uZBrvZBgcHryR
kIuuSGH7LZBZNKQpAPYo9/w8+scv121Ts7E4sFLzX3Zage5gLP70p3yMHUdO5yGq
OK/MShulk5BIeZ8z6SfL4+rlb1GrHjbnlXl9n8eKLZetNgkmx75by425X8DApEjH
VeSRTqysffzmGzhu2VkcSpgG7EjsaY6IMZMwboSI3JljGvBb1451HJ3IqqTeIW8j
SqrW0m6B1LiATixT7+7r8z6DdcnIxMVKumMhl0IWo5nHn8JxIXaxy+2Xdg1Xrksa
ENWB5fYBIRRL1DcOmV/8M0tkZyxtdr5WRRppxGtLEqJy6zAYWTxM2sDxUZAc5NWi
8ZRZdQgrwtfmLUACkFeLREumbenuIfeHWpiDxhVfdHpkqDsuJjIeSRkXn3/kuywl
8/J42RmC/nG5hSWOC0PcQi6B8VUL24S1oo+zap710ac4TasUIxTP9ZQmCmYcwydz
hp8Ch8xenyAN9adfhkSkAmpdIJ86umEeOAyGVAKahe/s3ndMCUDD1iDZUvgZlYZJ
dLjnlwThzAGJ4rtspqCcsxaJAB3s12uBBkXk46qsOzx5dSV7ocwujrw7SA92q2eo
6fkVJiVdZKA173Zrp/yDo0J6A1vWNgKUa+kf2HAYpVeVZ5YYybM=
=p0Me
-----END PGP SIGNATURE-----