Bug#953487: runescape: binaries for non-free not auto-built

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#953487: runescape: binaries for non-free not auto-built

Ivo De Decker-3
package: src:runescape
version: 0.6-2
severity: serious
tags: ftbfs

Hi,

The latest upload of runescape to unstable has no binaries.
The buildds are not building it, because it is in non-free.

If the binaries can be auto-built, the package should be whitelisted, as
described in
https://www.debian.org/doc/manuals/developers-reference/pkgs.html#non-free-buildd

If not, a binary upload must be done (note that binary maintainer uploads for
sources in contrib and non-free are allowed to migrate to testing).

Cheers,

Ivo

Reply | Threaded
Open this post in threaded view
|

Bug#953487: marked as pending in runescape

Markus Koschany-4
Control: tag -1 pending

Hello,

Bug #953487 in runescape reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/games-team/runescape/-/commit/9b3d6ff837e1f2cdb9be62e4bc220c1dcdca075a

------------------------------------------------------------------------
Import Debian changes 0.7-1

runescape (0.7-1) unstable; urgency=medium

  * New upstream release. (Closes: #953487, #953714)
  * debian/control:
    + Bumped Standards-Version to 4.5.0.
    + Added in Build-Depends: default-jdk-headless | default-jdk.
    + Added in Depends: default-jre-headless.
  * Added autopkgtest.
  * debian/copyright:
    + Copyright information organized for contacts.
    + Copyright updated for current years (2020).
  * Update debian/upstream/metadata years (2020).
------------------------------------------------------------------------

(this message was generated automatically)
--
Greetings

https://bugs.debian.org/953487

Reply | Threaded
Open this post in threaded view
|

Processed: Bug#953487 marked as pending in runescape

Debian Bug Tracking System
In reply to this post by Ivo De Decker-3
Processing control commands:

> tag -1 pending
Bug #953487 [src:runescape] runescape: binaries for non-free not auto-built
Added tag(s) pending.

--
953487: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953487
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#953487: Bug#954055: RFS: runescape/0.7-1 [RC] -- Multiplayer online game set in a fantasy world

Juhani Numminen
In reply to this post by Ivo De Decker-3
Hi,

Carlos Donizete Froes kirjoitti 16.3.2020 klo 4.59:
> Changes since the last upload:
>
>    * New upstream release. (Closes: #953487, #953714)

Please confirm how you are fixing #953487. debian/control already
contains XS-Autobuild: yes. Have you followed through with the process
https://www.debian.org/doc/manuals/developers-reference/pkgs.html#non-free-buildd
and sent to [hidden email]? Have they responded?

Regards,
Juhani

Reply | Threaded
Open this post in threaded view
|

Bug#953487: Runescape package: Autobuilding

Carlos Donizete Froes
In reply to this post by Ivo De Decker-3
Hi,

I come to warn that the runescape package can be built automatically and there
is "XS-Autobuild: yes" added to debian/control[1] and notified to
debian/copyright[2].

---
Disclaimer:
 The contents of this package can not be distributed as part of the Debian
 distribution. It is provided in the non-free file area for the convenience
 of Debian users.
 .
 Autobuilding: According the license there are no problems to build
 this software on several architectures automatically and distributing it.
---

[1]
https://salsa.debian.org/games-team/runescape/-/blob/debian/master/debian/control

[2]
https://salsa.debian.org/games-team/runescape/-/blob/debian/master/debian/copyright

See you!

--
⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀  2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#953487: marked as done (runescape: binaries for non-free not auto-built)

Debian Bug Tracking System
In reply to this post by Ivo De Decker-3
Your message dated Wed, 08 Apr 2020 22:20:28 +0000
with message-id <[hidden email]>
and subject line Bug#953487: fixed in runescape 0.7-1
has caused the Debian Bug report #953487,
regarding runescape: binaries for non-free not auto-built
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
953487: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953487
Debian Bug Tracking System
Contact [hidden email] with problems

package: src:runescape
version: 0.6-2
severity: serious
tags: ftbfs

Hi,

The latest upload of runescape to unstable has no binaries.
The buildds are not building it, because it is in non-free.

If the binaries can be auto-built, the package should be whitelisted, as
described in
https://www.debian.org/doc/manuals/developers-reference/pkgs.html#non-free-buildd

If not, a binary upload must be done (note that binary maintainer uploads for
sources in contrib and non-free are allowed to migrate to testing).

Cheers,

Ivo

Source: runescape
Source-Version: 0.7-1
Done: Carlos Donizete Froes <[hidden email]>

We believe that the bug you reported is fixed in the latest version of
runescape, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Carlos Donizete Froes <[hidden email]> (supplier of updated runescape package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 15 Mar 2020 16:52:37 -0300
Source: runescape
Architecture: source
Version: 0.7-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[hidden email]>
Changed-By: Carlos Donizete Froes <[hidden email]>
Closes: 953487 953714
Changes:
 runescape (0.7-1) unstable; urgency=medium
 .
   * New upstream release. (Closes: #953487, #953714)
   * debian/control:
     + Bumped Standards-Version to 4.5.0.
     + Added in Build-Depends: default-jdk-headless | default-jdk.
     + Added in Depends: default-jre-headless.
   * Added autopkgtest.
   * debian/copyright:
     + Copyright information organized for contacts.
     + Copyright updated for current years (2020).
   * Update debian/upstream/metadata years (2020).
Checksums-Sha1:
 410dce3fee4bf2a94317770718dc080c910a5f13 2205 runescape_0.7-1.dsc
 eb71e63c73a739783a91a599d2f42db9e6210380 627878 runescape_0.7.orig.tar.bz2
 4e492e9569c007bb2d27315dd71bfc468406a47d 12836 runescape_0.7-1.debian.tar.xz
 3b2fc474816330c45a0ee1962a6cd17bfe8fb1d3 7241 runescape_0.7-1_amd64.buildinfo
Checksums-Sha256:
 d8e829c51dd1e1cc7b6c656ba2ce27ab9a7d1f5ecc3407ae432c5634b39d638f 2205 runescape_0.7-1.dsc
 db2cf90335dae027486e3d93cf81e88c27b121eaf37988dfc99a543e0de1f0e3 627878 runescape_0.7.orig.tar.bz2
 caf36feee7711e830783e40ed79a66a36092a31715983130c9edeec501e9f2fc 12836 runescape_0.7-1.debian.tar.xz
 f7ed225e9d1bbf050142221da1c3105cf82673c177dbae67f7e07f2a1244c113 7241 runescape_0.7-1_amd64.buildinfo
Files:
 71a3fa70eb996cf05e97ba17e34ae5c9 2205 non-free/games optional runescape_0.7-1.dsc
 4e412f344cb9e21966ab1abfedb9bb95 627878 non-free/games optional runescape_0.7.orig.tar.bz2
 362f45db6a41951ae9aaf603f58ef554 12836 non-free/games optional runescape_0.7-1.debian.tar.xz
 2f7c55721f64856171038a658cf5bcca 7241 non-free/games optional runescape_0.7-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAl6OSoJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1Hk7ysP+wdFH+SG+oD20jAzHa8uYCxLf/uH8ZjjkykL
9jwbYzHrDFLFI8WhFdw2x3QpJeWZyiZIDMeeJwP4Qt0ijDpPyZlxzgfaOH1mz5KB
AMJS10t8P1teVbBskNx5DExLDL5Z5AehMrBkW13pIFiXU6MELBM7qDecdJ55k08F
R9yRiQkBBBIijX7uIzKqGwt5bubzpS6UUldShOxfSJaTqmYq3AmtW0gkNJm5LGq6
t8hEB3l2u3CCL2ViogNb1vyezILNpDmszkxu7H00rzOSEDlhnUJCdH1Ind6kFWsD
qlYnHl0GF7AOkGdAnmBTs8zAc748qQek5Eyum2mm1W2u05OX3lKbgGY/HH6JkLBp
MR1nksbbRKeiVmgZifFRrc7DEpJnpbdaDI+6cikAehljd1NMi3eU8XQWG31Njnw1
EC/J8cgLuYBlgXPBC8RItOq5RJWGXjcL0fEMQRBuqP1/HVRlK2esIWWvK7yJLGWP
McHMrw30SV9NkRJD4u1mt/clugiIZONpzAabaHssxvklz2pVWjlNN+2Z2YUWaQ8r
K7LcPu7/bDlZybeFQoNo/mqgg45QBxw2HmeJ57ee7XLI8VttMoqXE4rcxmI1xG8q
z3/gKGuCQI4j4XcgXSWBTSwbu5ZY2hibO+wG5MP5M982xDfxutrnf/cQ7T502BYu
D6kTYwXF
=5qbF
-----END PGP SIGNATURE-----
Reply | Threaded
Open this post in threaded view
|

Processed: Re: Bug#953487: fixed in runescape 0.7-1

Debian Bug Tracking System
In reply to this post by Ivo De Decker-3
Processing control commands:

> reopen -1
Bug #953487 {Done: Carlos Donizete Froes <[hidden email]>} [src:runescape] runescape: binaries for non-free not auto-built
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions runescape/0.7-1.

--
953487: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953487
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#953487: fixed in runescape 0.7-1

Carlos Donizete Froes
In reply to this post by Ivo De Decker-3
Hi Ivo,

> This new version doesn't fix the autobuilding issue:
>
> https://buildd.debian.org/status/package.php?p=runescape

I don't understand how the package still has the autobuilding problem. I did
several construction tests via pbuilder and sbuild and there were no problems,
as shown in the attached file. :/

> Looking at the package, I also discovered some other issues, which I will file
> as separate bugs.

Ok, if you can help me with the solution of these problems that you encountered,
I would be very grateful. And I will fix it as soon as possible.

Thanks!

--
⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀  2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

runescape_0.7-1_amd64-2020-04-10T04:55:06Z.build (128K) Download Attachment
signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#953487: fixed in runescape 0.7-1

Markus Koschany-2
I suggest we wait a little for a response from
[hidden email] before we make another upload. However if
there is no response in two weeks, we can just proceed by making a
binary upload of runescape.

Bug #956275 can be resolved by replacing the runescape.png icon. The
license is most likely not BSD-2-clause. You should either document the
correct license, the image must be distributable at least, or you can
create or find your own icon. For instance you could create an image the
same size with a black, red or blue background and then you add the R S
initials in white. Simple icon, easily done.

Bug #956276 is about an additional verification step, e.g. to verify the
integrity of the launcher with a hashsum. You could store the value in a
text file in our Git repository and then fetch the value and compare it
with the hashsum of the binary before you run the java command. By
storing the value in Git we can adjust the value whenever there is a new
runescape update without having to make another Debian upload. This
could be especially useful for stable releases. In any case I would try
to avoid to hardcode the value.

I don't consider bug #956276 release critical because there is no Debian
Policy justification for it and there is no more risk involved than
downloading the file with a web browser normally poses, so it should be
treated as a normal or important bug. What you can and should do is to
improve the package description. It should be clear that src:runescape
is a mere script that downloads and runs the runescape launcher and that
Debian cannot guarantee the integrity of this binary file because it is
non-free and it is closed source. So simply warn about that in the
package description and when your script is executed. The warning
message could be displayed in a text terminal or you could use zenity to
make it more user friendly and obvious.

Regards,

Markus


signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#953487: fixed in runescape 0.7-1

Carlos Donizete Froes
In reply to this post by Ivo De Decker-3
Hi Markus,

I hope everything is fine with you and your family.

> I had uploaded the new version of runescape to fix bug 953487 because
> you stated in
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953487#25
>
> that the package has been whitelisted. Apparently this is not the case
> hence I am writing to [hidden email] again and I kindly ask
> that runescape is whitelisted for autobuilding. The package is basically
> a script and the license allows autobuilding.

I am grateful that you uploaded this latest version of runescape, but I didn't
quite understand what happened in those discussions in the posted messages.

I will create a new icon and add a warning when starting the script, as
mentioned in the message https://bugs.debian.org/953487#54

I want to thank Stephen for offering help in solving the problem of validating
the downloaded JAR file, where I don't know how I do it at the moment.

Thanks!

--
⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀  2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#953487: fixed in runescape 0.7-1

Carlos Donizete Froes
In reply to this post by Markus Koschany-2
Hi Markus,

> I suggest we wait a little for a response from
> [hidden email] before we make another upload. However if
> there is no response in two weeks, we can just proceed by making a
> binary upload of runescape.

Perfect, I will be waiting and I hope it is a positive answer. ;)

> Bug #956275 can be resolved by replacing the runescape.png icon. The
> license is most likely not BSD-2-clause. You should either document the
> correct license, the image must be distributable at least, or you can
> create or find your own icon. For instance you could create an image the
> same size with a black, red or blue background and then you add the R S
> initials in white. Simple icon, easily done.

Removed icon that does not belong to the BSD-2-clause license and created the
icon itself in SVG and PNG formats using the Inkscape software.[1]

[1] https://gitlab.com/coringao/runescape/-/blob/master/src/runescape.png

> Bug #956276 is about an additional verification step, e.g. to verify the
> integrity of the launcher with a hashsum. You could store the value in a
> text file in our Git repository and then fetch the value and compare it
> with the hashsum of the binary before you run the java command. By
> storing the value in Git we can adjust the value whenever there is a new
> runescape update without having to make another Debian upload. This
> could be especially useful for stable releases. In any case I would try
> to avoid to hardcode the value.
>
> I don't consider bug #956276 release critical because there is no Debian
> Policy justification for it and there is no more risk involved than
> downloading the file with a web browser normally poses, so it should be
> treated as a normal or important bug. What you can and should do is to
> improve the package description. It should be clear that src:runescape
> is a mere script that downloads and runs the runescape launcher and that
> Debian cannot guarantee the integrity of this binary file because it is
> non-free and it is closed source. So simply warn about that in the
> package description and when your script is executed. The warning
> message could be displayed in a text terminal or you could use zenity to
> make it more user friendly and obvious.
Added verification of the downloaded file against a hash in good condition. I
thank Stephen Kitt for helping me. :D

I added a friendly warning when running the launcher via kdialog or zenity.[2]

[2] https://gitlab.com/coringao/runescape/-/blob/master/src/runescape.sh

Once approved by [hidden email], I will update the package to
version 0.8, where I will add this warning to the long description of
"debian/control" and depends: kdialog | zenity.

See you later!

--
⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀  2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#953487: Bugs fixed in runescape/0.8-1

Carlos Donizete Froes
In reply to this post by Ivo De Decker-3
Hi,

Improvements were made to the Runescape launcher, as reported.

BUG #953487:
- This bug contains "XS-Autobuild: yes" in d/control and also a warning about
"Autobuilding" in d/copyright since the runescape/0.5-2 package which has not
been changed since recent versions.

BUG #956275:
- Own icon created in SVG and PNG formats for this runescape launcher.

BUG #956276:
- Added in the script (runescape.sh) the integrity check with the hashsum of the
downloaded file.
- Added warning message via kdialog or zenity when executing the script,
explaining what it does.

Thanks see you soon!

--
⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀  2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

signature.asc (849 bytes) Download Attachment